[device] Remove device__init module startup function

There's not really a need to track all devices in a linked
list.  So now the module is purely library.

diff --git a/src/include/device.h b/src/include/device.h
index e42a87c..bd5e324 100644 (file)
--- a/src/include/device.h
+++ b/src/include/device.h
@@ -77,13 +77,6 @@ typedef void STDCALL device__free_func(IN struct device__type *);
 
 extern winvblock__lib_func device__free_func device__free;
 
-/**
- * Initialize the global, device-common environment.
- *
- * @ret ntstatus        STATUS_SUCCESS or the NTSTATUS for a failure.
- */
-extern STDCALL NTSTATUS device__init(void);
-
 extern winvblock__lib_func struct device__type * device__create(void);
 
 winvblock__def_struct(device__ops) {

diff --git a/src/winvblock/device.c b/src/winvblock/device.c
index b9ee9de..2805f6e 100644 (file)
--- a/src/winvblock/device.c
+++ b/src/winvblock/device.c
@@ -35,25 +35,10 @@
 #include "device.h"
 #include "debug.h"
 
-static LIST_ENTRY dev_list;
-static KSPIN_LOCK dev_list_lock;
 /* Forward declarations. */
 static device__free_func free_dev;
 static device__create_pdo_func make_dev_pdo;
 
-/**
- * Initialize the global, device-common environment.
- *
- * @ret ntstatus        STATUS_SUCCESS or the NTSTATUS for a failure.
- */
-STDCALL NTSTATUS device__init(void) {
-    /* Initialize the global list of devices. */
-    InitializeListHead(&dev_list);
-    KeInitializeSpinLock(&dev_list_lock);
-
-    return STATUS_SUCCESS;
-  }
-
 /**
  * Create a new device.
  *
@@ -74,12 +59,6 @@ winvblock__lib_func struct device__type * device__create(void) {
     dev = wv_mallocz(sizeof *dev);
     if (dev == NULL)
       return NULL;
-    /* Track the new device in our global list. */
-    ExInterlockedInsertTailList(
-        &dev_list,
-        &dev->tracking,
-                       &dev_list_lock
-      );
     /* Populate non-zero device defaults. */
     dev->dispatch = driver__default_dispatch;
     dev->DriverObject = driver__obj_ptr;
@@ -143,13 +122,6 @@ winvblock__lib_func void STDCALL device__free(IN struct device__type * dev) {
  * @v dev               Points to the device to delete.
  */
 static void STDCALL free_dev(IN struct device__type * dev) {
-    /*
-     * Track the device deletion in our global list.  Unfortunately,
-     * for now we have faith that a device won't be deleted twice and
-     * result in a race condition.  Something to keep in mind...
-     */
-    ExInterlockedRemoveHeadList(dev->tracking.Blink, &dev_list_lock);
-  
     wv_free(dev);
   }
 

diff --git a/src/winvblock/driver.c b/src/winvblock/driver.c
index 754aa1b..352d28c 100644 (file)
--- a/src/winvblock/driver.c
+++ b/src/winvblock/driver.c
@@ -315,7 +315,6 @@ NTSTATUS STDCALL DriverEntry(
     /* Set the driver AddDevice callback. */
     DriverObject->DriverExtension->AddDevice = driver__attach_fdo_;
     /* Initialize various modules. */
-    device__init();             /* TODO: Check for error. */
     disk__init();               /* TODO: Check for error. */
     filedisk__init();           /* TODO: Check for error. */
     ramdisk__init();            /* TODO: Check for error. */