http://git.etherboot.org
/
people
/
sha0
/
gpxe.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
0958726
)
Avoid double free on I/O buffer when rtl_transmit() returns failure.
author
Michael Brown
<mcb30@etherboot.org>
Tue, 3 Jul 2007 13:44:33 +0000
(14:44 +0100)
committer
Michael Brown
<mcb30@etherboot.org>
Tue, 3 Jul 2007 13:44:33 +0000
(14:44 +0100)
Convert printf() to DBG(); printf() is not allowed in drivers.
src/drivers/net/rtl8139.c
patch
|
blob
|
history
diff --git
a/src/drivers/net/rtl8139.c
b/src/drivers/net/rtl8139.c
index
6acffd9
..
06d40aa
100644
(file)
--- a/
src/drivers/net/rtl8139.c
+++ b/
src/drivers/net/rtl8139.c
@@
-380,8
+380,7
@@
static int rtl_transmit ( struct net_device *netdev, struct io_buffer *iobuf ) {
/* Check for space in TX ring */
if ( rtl->tx.iobuf[rtl->tx.next] != NULL ) {
/* Check for space in TX ring */
if ( rtl->tx.iobuf[rtl->tx.next] != NULL ) {
- printf ( "TX overflow\n" );
- free_iob ( iobuf );
+ DBG ( "TX overflow\n" );
return -ENOBUFS;
}
return -ENOBUFS;
}