people/mcb30/busybox.git
17 years agoWoops, the previous commit was an accident, its supplied in the patch,
bug1 [Sat, 5 Jun 2004 07:58:18 +0000 (07:58 +0000)]
Woops, the previous commit was an accident, its supplied in the patch,
dont commit yet as we are in feature freeze

git-svn-id: svn://busybox.net/trunk/busybox@8886 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoDevice table support for makedevs, the previous behaviour can been
bug1 [Sat, 5 Jun 2004 07:54:52 +0000 (07:54 +0000)]
Device table support for makedevs, the previous behaviour can been
selected at configure time.

git-svn-id: svn://busybox.net/trunk/busybox@8885 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAhem. ("I'm just tweaking a documentation string, I don't need to compile
landley [Wed, 26 May 2004 22:09:37 +0000 (22:09 +0000)]
Ahem.  ("I'm just tweaking a documentation string, I don't need to compile
test it before checking in..."  New entry for famous last words list.)

Add the missing backslash at the end of the new sed doc string line.

(This one actually compiled with "show verbose applet usage messages"...)

git-svn-id: svn://busybox.net/trunk/busybox@8883 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUpdate sed help. (Add -r option to long help, add -i option to brief help,
landley [Wed, 26 May 2004 21:59:31 +0000 (21:59 +0000)]
Update sed help.  (Add -r option to long help, add -i option to brief help,
and alphabetizie the option list.)

git-svn-id: svn://busybox.net/trunk/busybox@8882 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoKevin P. Fleming writes:
andersen [Wed, 26 May 2004 21:26:07 +0000 (21:26 +0000)]
Kevin P. Fleming writes:

Yes, I know busybox is in feature freeze. If this two-liner is too much
that's fine, but it's handy.

This patch allows busybox mount to support "-o move" just like it
supports "-o bind", which is the equivalent of util-linux "mount --move".

Usage is:

mount -o move /mnt/point/1 /mnt/point/2

where /mnt/point/1 is an already mounted filesystem; it will be moved to
/mnt/point/2.

git-svn-id: svn://busybox.net/trunk/busybox@8881 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUpdate U.S. Robotics and Actiontec entries
andersen [Wed, 26 May 2004 17:17:39 +0000 (17:17 +0000)]
Update U.S. Robotics and Actiontec entries

git-svn-id: svn://busybox.net/trunk/busybox@8880 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoIf read were to return with an error, bad things would happen. Fix it.
mjn3 [Wed, 26 May 2004 15:21:19 +0000 (15:21 +0000)]
If read were to return with an error, bad things would happen.  Fix it.
Also, make sure read errors are reflected in the applet exit code.

git-svn-id: svn://busybox.net/trunk/busybox@8879 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agooops
andersen [Wed, 26 May 2004 12:06:38 +0000 (12:06 +0000)]
oops

git-svn-id: svn://busybox.net/trunk/busybox@8878 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPer suggestion from Bastian Blank, be less evil when we force fdisk to
andersen [Wed, 26 May 2004 11:59:19 +0000 (11:59 +0000)]
Per suggestion from Bastian Blank, be less evil when we force fdisk to
transparently remap 32-bit interfaces to actually use 64 bit interfaces.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@8877 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUse tab not space
andersen [Wed, 26 May 2004 11:50:37 +0000 (11:50 +0000)]
Use tab not space

git-svn-id: svn://busybox.net/trunk/busybox@8876 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoMake the grep option values a bit less horrible
andersen [Wed, 26 May 2004 11:48:29 +0000 (11:48 +0000)]
Make the grep option values a bit less horrible

git-svn-id: svn://busybox.net/trunk/busybox@8875 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoRick Richardson writes:
andersen [Wed, 26 May 2004 11:47:55 +0000 (11:47 +0000)]
Rick Richardson writes:

Here is a patch that adds egrep -L support (the opposite of egrep -l).

I realize this is probably too late for 1.0.  But I offer it for your
future consideration.

egrep -L is used in some networking startup scripts I inherited.

-Rick

git-svn-id: svn://busybox.net/trunk/busybox@8874 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Yoshinori Sato:
andersen [Wed, 26 May 2004 11:38:46 +0000 (11:38 +0000)]
Patch from Yoshinori Sato:

This patch is uClinux-2.4.x for H8/300 module support.
please apply.

--
Yoshinori Sato

git-svn-id: svn://busybox.net/trunk/busybox@8873 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAs discussed, drop minit, which was not being supported in busybox.
andersen [Wed, 26 May 2004 10:28:32 +0000 (10:28 +0000)]
As discussed, drop minit, which was not being supported in busybox.
People wishing to use minit can obtain it and obtain support from
http://www.fefe.de/minit/

git-svn-id: svn://busybox.net/trunk/busybox@8872 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUse STDIN_FILENO rather than '0'
andersen [Wed, 26 May 2004 10:26:10 +0000 (10:26 +0000)]
Use STDIN_FILENO rather than '0'

git-svn-id: svn://busybox.net/trunk/busybox@8871 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoRob Landley writes:
andersen [Wed, 26 May 2004 10:03:33 +0000 (10:03 +0000)]
Rob Landley writes:

add sed -r support.

I bumped into a couple of things that want to use extended regular expressions
in sed, and it really isn't that hard to add.  Can't say I've extensively
tested it, but it's small and isn't going to break anything that doesn't use
it, so...

Rob

git-svn-id: svn://busybox.net/trunk/busybox@8870 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoRob Landley writes:
andersen [Wed, 26 May 2004 09:54:36 +0000 (09:54 +0000)]
Rob Landley writes:

Run this test, against both busybox and a non-busybox version of "tee".

while true; do i=$[$i+1]; echo "hello $i"; sleep 1; done | ./busybox tee

Now run the busybox one again with the following small patch applied:

git-svn-id: svn://busybox.net/trunk/busybox@8869 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from vodz to correct 'grep -e pattern1 -e pattern2' logic
andersen [Wed, 26 May 2004 09:46:41 +0000 (09:46 +0000)]
Patch from vodz to correct 'grep -e pattern1 -e pattern2' logic

git-svn-id: svn://busybox.net/trunk/busybox@8868 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoDo not prompt about FDISK large disk support when LFS is enabled.
andersen [Tue, 25 May 2004 11:30:22 +0000 (11:30 +0000)]
Do not prompt about FDISK large disk support when LFS is enabled.
Resolve a dependancy problem with the various malloc debug libs
and make them mutually exclusive.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@8867 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoDo not select LFS
andersen [Wed, 19 May 2004 11:06:20 +0000 (11:06 +0000)]
Do not select LFS

git-svn-id: svn://busybox.net/trunk/busybox@8864 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoErik,
andersen [Wed, 19 May 2004 10:49:17 +0000 (10:49 +0000)]
Erik,

>http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/fdisk.c?r1=1.22&r2=1.23&diff_format=u

Its hack for "force" ;-)

If to return the previous version of a Config.in
http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/Config.in?r1=1.12&r2=1.13
and to apply last patch, then I shall calm down. ;-)

(OOPS, last patch have autocorrected from my editor begins spaces to tabs and
removed spaces from empty lines too).

--w
vodz

git-svn-id: svn://busybox.net/trunk/busybox@8863 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agouse busybox sysinfo struct
russ [Wed, 19 May 2004 09:18:04 +0000 (09:18 +0000)]
use busybox sysinfo struct

git-svn-id: svn://busybox.net/trunk/busybox@8860 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMake vodz happy and make fdisk always use large file support if
andersen [Wed, 19 May 2004 09:00:00 +0000 (09:00 +0000)]
Make vodz happy and make fdisk always use large file support if
possible, even if LFS is not enabled for the rest of busybox.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@8859 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix a compile problem
andersen [Wed, 19 May 2004 08:54:28 +0000 (08:54 +0000)]
Fix a compile problem

git-svn-id: svn://busybox.net/trunk/busybox@8858 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agofix timewarp in client (server fix later)
russ [Wed, 19 May 2004 08:29:05 +0000 (08:29 +0000)]
fix timewarp in client (server fix later)

git-svn-id: svn://busybox.net/trunk/busybox@8857 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoremove uneccessary check (already done in pidfile.c)
russ [Wed, 19 May 2004 07:46:23 +0000 (07:46 +0000)]
remove uneccessary check (already done in pidfile.c)

git-svn-id: svn://busybox.net/trunk/busybox@8854 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agofix memory leak caused by switch to vfork
russ [Wed, 19 May 2004 07:45:47 +0000 (07:45 +0000)]
fix memory leak caused by switch to vfork

git-svn-id: svn://busybox.net/trunk/busybox@8853 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUse int instead of char for return type, in theory avoiding a cast
bug1 [Sun, 16 May 2004 02:35:49 +0000 (02:35 +0000)]
Use int instead of char for return type, in theory avoiding a cast

git-svn-id: svn://busybox.net/trunk/busybox@8845 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix for debian bug #248106, should use int for returned getopt value.
bug1 [Mon, 10 May 2004 08:59:17 +0000 (08:59 +0000)]
Fix for debian bug #248106, should use int for returned getopt value.

git-svn-id: svn://busybox.net/trunk/busybox@8819 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSteve Grubb writes:
andersen [Wed, 5 May 2004 19:39:21 +0000 (19:39 +0000)]
Steve Grubb writes:

Hi,

I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in
dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop
increments by 2. That's why it should be BUFSIZ-3.

Best Regards,
Steve Grubb

git-svn-id: svn://busybox.net/trunk/busybox@8805 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSteve Grubb writes:
andersen [Wed, 5 May 2004 10:37:49 +0000 (10:37 +0000)]
Steve Grubb writes:

Hello,

I found and patched 2 more bugs. The first is a misplaced semi-colon. The second
one is a buffer overflow. I doubt the buffer overflow is triggered in real life.
But you never know what those wily hackers are up to.

Thanks,
Steve Grubb

git-svn-id: svn://busybox.net/trunk/busybox@8804 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSteve Grubb writes:
andersen [Wed, 5 May 2004 07:05:32 +0000 (07:05 +0000)]
Steve Grubb writes:

Hello,

Last November a bug was found in iproute. CAN-2003-0856 has more information.
Basically, netlink packets can come from any user. If a program performs action
based on netlink packets, they must be examined to make sure they came from the
place they are expected (the kernel).

Attached is a patch against pre8. Please apply this before releasing 1.00 final.
All users of busy box may be vulnerable to local attacks without it.

Best Regards,
Steve Grubb

git-svn-id: svn://busybox.net/trunk/busybox@8803 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix size command, safe_strtoul gives and error if the \r is left in, the
bug1 [Tue, 4 May 2004 10:43:34 +0000 (10:43 +0000)]
Fix size command, safe_strtoul gives and error if the \r is left in, the
RFC spec says the \r should be there.
This fix is the same as a recent wget fix

git-svn-id: svn://busybox.net/trunk/busybox@8799 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd part of a patch from Vernon Sauder that i missed a while back
bug1 [Sun, 2 May 2004 08:38:53 +0000 (08:38 +0000)]
Add part of a patch from Vernon Sauder that i missed a while back

git-svn-id: svn://busybox.net/trunk/busybox@8797 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate dpkg-deb usage to match current practices
bug1 [Sun, 2 May 2004 03:01:08 +0000 (03:01 +0000)]
Update dpkg-deb usage to match current practices

git-svn-id: svn://busybox.net/trunk/busybox@8796 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoThis patch makes the id command SuS3 compliant and provides a groups
bug1 [Sat, 1 May 2004 11:47:24 +0000 (11:47 +0000)]
This patch makes the id command SuS3 compliant and provides a groups
applet via an alias to id.
 - Add G option
 - Pedantic option checking
 - If effective group and user differs from the real one show both.
id.
 - Alias id -Gn to groups applet

git-svn-id: svn://busybox.net/trunk/busybox@8795 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoDo not use getpass(3)
andersen [Sat, 1 May 2004 01:27:30 +0000 (01:27 +0000)]
Do not use getpass(3)

git-svn-id: svn://busybox.net/trunk/busybox@8793 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoRe-add the TODO list, mention tr
bug1 [Sat, 1 May 2004 00:49:49 +0000 (00:49 +0000)]
Re-add the TODO list, mention tr

git-svn-id: svn://busybox.net/trunk/busybox@8792 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoBugfixes
bug1 [Fri, 30 Apr 2004 23:09:39 +0000 (23:09 +0000)]
Bugfixes
1) a non NULL terminated buffer that can mess up output, spotted by Ian
Latter
2) in miscutils/strings.c: get rid of useless pointer dereference in
third part of for(;;), spotted by Larry Doolittle
3) bug when reading from a pipe and being invoked as strings
"cat Readme | strings" is broken
"cat Readme | busybox strings" works
spotted by Ian Latter and fixed by Tito.

git-svn-id: svn://busybox.net/trunk/busybox@8791 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix symlink handling and small memory leak
bug1 [Thu, 29 Apr 2004 09:24:19 +0000 (09:24 +0000)]
Fix symlink handling and small memory leak

git-svn-id: svn://busybox.net/trunk/busybox@8785 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoThomas Koeller writes:
andersen [Mon, 26 Apr 2004 19:32:49 +0000 (19:32 +0000)]
Thomas Koeller writes:

    Hi,

    the following output is from BusyBox 1.0.0-pre10:

    ~ # ip link help
    ip: Command "help" is unknown, try "ip link help".

    tk

This patch fixes it by removing the advertisements for
the "ip blah help" stuff that is not implemented.

git-svn-id: svn://busybox.net/trunk/busybox@8784 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSync my tasks with AUTHORS file
bug1 [Sun, 25 Apr 2004 06:05:14 +0000 (06:05 +0000)]
Sync my tasks with AUTHORS file

git-svn-id: svn://busybox.net/trunk/busybox@8783 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate my email address, document some of my tasks in the AUTHORS file
bug1 [Sun, 25 Apr 2004 05:11:19 +0000 (05:11 +0000)]
Update my email address, document some of my tasks in the AUTHORS file

git-svn-id: svn://busybox.net/trunk/busybox@8782 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoThis sed patch can only be described as "duh". Stat the source file, chmod
andersen [Wed, 21 Apr 2004 00:57:14 +0000 (00:57 +0000)]
This sed patch can only be described as "duh".  Stat the source file, chmod
the _destination_ file.  (Ah hah!  That works _much_ better...)  I
implemented the behavior, I just forgot to test this corner of it.  My fault,
sorry...

No, gnu sed -i doesn't preverve ownership information.  I checked.
Permissions, yes, ownership info, no.

Rob

git-svn-id: svn://busybox.net/trunk/busybox@8776 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSo I'm building a linux from scratch system, using a working script to do this
andersen [Wed, 21 Apr 2004 00:56:22 +0000 (00:56 +0000)]
So I'm building a linux from scratch system, using a working script to do this
that the _only_ change to is that gnu sed has been replaced with busybox sed.
And ncurses' install phase hangs.  I trace it down, and it's trying to run
gawk.  (Insert obligatory doubletake, but this is FSF code we're talking
about, so...)

It turns out gawk shells out to sed, ala "sed -f /tmp/blah file.h".  The
/tmp/blah file is basically empty (it contains one character, a newline).  So
basically, gawk is using sed as "cat".  With gnu sed, it works like cat,
anyway.

With busybox sed, it tests if its command list is empty after parsing the
command line, and if the list is empty it takes the first file argument as a
sed command string, and if that leaves the file list empty it tries to read
the data to operate on from stdin.  (Hence the hang, since nothing's coming
in on stdin...)

It _should_ be testing whether there were any instances of -f or -e, not
whether it actually got any commands.  Using sed as cat may be kind of
stupid, but it's valid and gawk relies on this behavior.

Here's a patch to fix it, turning a couple of ints into chars in hopes of
saving a bit of the space this adds.  Comments?

Rob

git-svn-id: svn://busybox.net/trunk/busybox@8775 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoDont try and preserve hard links to directories.
bug1 [Mon, 19 Apr 2004 12:28:02 +0000 (12:28 +0000)]
Dont try and preserve hard links to directories.
The linux kernel doesnt allow hard links to directories, SUS says its
implementation specific.
cramfs gives empty directories and 0 length files the same node it
makies it difficult to distinguish from hard links.

git-svn-id: svn://busybox.net/trunk/busybox@8767 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd two fundamental tests for copying directories
bug1 [Sun, 18 Apr 2004 13:35:56 +0000 (13:35 +0000)]
Add two fundamental tests for copying directories

git-svn-id: svn://busybox.net/trunk/busybox@8766 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoThats odd. I guess this was cut-n-paste error, but vodz
andersen [Fri, 16 Apr 2004 15:02:10 +0000 (15:02 +0000)]
Thats odd.  I guess this was cut-n-paste error, but vodz
email address was wrong!

git-svn-id: svn://busybox.net/trunk/busybox@8765 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate Acronis and Belkin
andersen [Thu, 15 Apr 2004 19:16:28 +0000 (19:16 +0000)]
Update Acronis and Belkin

git-svn-id: svn://busybox.net/trunk/busybox@8762 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSteven Scholz writes:
andersen [Wed, 14 Apr 2004 17:59:21 +0000 (17:59 +0000)]
Steven Scholz writes:

Hi there,

the "-h" option of httpd is not described in the usage text.

Please find the attached patch.

Thanks.

Steven

git-svn-id: svn://busybox.net/trunk/busybox@8761 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoremove a warning
andersen [Wed, 14 Apr 2004 17:57:11 +0000 (17:57 +0000)]
remove a warning

git-svn-id: svn://busybox.net/trunk/busybox@8760 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoLarry Doolittle writes:
andersen [Wed, 14 Apr 2004 17:51:38 +0000 (17:51 +0000)]
Larry Doolittle writes:

This is a bulk spelling fix patch against busybox-1.00-pre10.
If anyone gets a corrupted copy (and cares), let me know and
I will make alternate arrangements.

Erik - please apply.

Authors - please check that I didn't corrupt any meaning.

Package importers - see if any of these changes should be
passed to the upstream authors.

I glossed over lots of sloppy capitalizations, missing apostrophes,
mixed American/British spellings, and German-style compound words.

What is "pretect redefined for test" in cmdedit.c?

Good luck on the 1.00 release!

      - Larry

git-svn-id: svn://busybox.net/trunk/busybox@8759 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agobump version, prepare for -pre10
andersen [Tue, 13 Apr 2004 19:38:17 +0000 (19:38 +0000)]
bump version, prepare for -pre10

git-svn-id: svn://busybox.net/trunk/busybox@8754 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix incorrect ipcalc usage text
andersen [Tue, 13 Apr 2004 19:27:20 +0000 (19:27 +0000)]
Fix incorrect ipcalc usage text

git-svn-id: svn://busybox.net/trunk/busybox@8753 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoslightly clean the whacked out formatting
andersen [Tue, 13 Apr 2004 19:25:57 +0000 (19:25 +0000)]
slightly clean the whacked out formatting

git-svn-id: svn://busybox.net/trunk/busybox@8752 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix several problems with start-stop-daemon, add -m support
andersen [Tue, 13 Apr 2004 18:28:46 +0000 (18:28 +0000)]
Fix several problems with start-stop-daemon, add -m support

git-svn-id: svn://busybox.net/trunk/busybox@8751 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoPut the glibc nss junk back at the end
andersen [Tue, 13 Apr 2004 16:31:41 +0000 (16:31 +0000)]
Put the glibc nss junk back at the end

git-svn-id: svn://busybox.net/trunk/busybox@8750 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSigh. The patch from David Anders (prpplague) broke standard
andersen [Mon, 12 Apr 2004 22:49:06 +0000 (22:49 +0000)]
Sigh.  The patch from David Anders (prpplague) broke standard
securetty files since the /dev was not stripped.

git-svn-id: svn://busybox.net/trunk/busybox@8749 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoWolfgang Denk writes:
andersen [Mon, 12 Apr 2004 21:41:29 +0000 (21:41 +0000)]
Wolfgang Denk writes:

He,

there is a bug in HUSH's handling of "if" / "elif" commands:

        $  if true
        > then
        > echo 1
        > elif
        > true
        > then
        > echo 2
        > elif
        > true
        > then
        > echo 3
        > else
        > echo 4
        > fi
        1
        2
        3
        $

The same bug exists in all versions of HUSH from BB v0.60.x up to and
including v1.00-pre9. The attached patch fixes this:

        $ if true
        > then
        > echo 1
        > elif
        > true
        > then
        > echo 2
        > elif
        > true
        > then
        > echo 3
        > else
        > echo 4
        > fi
        1
        $

Best regards,

Wolfgang Denk

git-svn-id: svn://busybox.net/trunk/busybox@8747 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoEric Spakman noticed that ifdown' will attempt to run 'ifconfig'
andersen [Mon, 12 Apr 2004 20:57:17 +0000 (20:57 +0000)]
Eric Spakman noticed that ifdown' will attempt to run 'ifconfig'
even if built with CONFIG_FEATURE_IFUPDOWN_IP when shutting down
a dhcp connection.

git-svn-id: svn://busybox.net/trunk/busybox@8743 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSilly me
andersen [Mon, 12 Apr 2004 19:21:54 +0000 (19:21 +0000)]
Silly me

git-svn-id: svn://busybox.net/trunk/busybox@8741 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAs reported by Quy Tonthat, init has problems with inittab's that
andersen [Mon, 12 Apr 2004 19:17:13 +0000 (19:17 +0000)]
As reported by Quy Tonthat, init has problems with inittab's that
contain only actions sysinit/wait/once. It does not clean up zombies
in that case.

git-svn-id: svn://busybox.net/trunk/busybox@8740 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoPeter Milne writes:
andersen [Mon, 12 Apr 2004 19:12:13 +0000 (19:12 +0000)]
Peter Milne writes:

Just upgraded from 0.6 to 1.00-pre8

Dot command handling handled args correctly (same as bash) in 0.60,
but failed in 1.00:

I fixed this by reverting the dotcmd function back to previous 0.60
instantiation,
please consider using the older version.

Thanks

Peter

git-svn-id: svn://busybox.net/trunk/busybox@8739 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoJamie Guinan writes:
andersen [Mon, 12 Apr 2004 17:59:24 +0000 (17:59 +0000)]
Jamie Guinan writes:

It looks like latest uClibc defines ARCH_HAS_MMU, but a few busybox files
test UCLIBC_HAS_MMU, resulting in vfork() getting called instead of
fork(), etc.

Patch below.   Only tested for lash.

Cheers,
-Jamie

git-svn-id: svn://busybox.net/trunk/busybox@8738 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd an extra link
andersen [Mon, 12 Apr 2004 15:23:19 +0000 (15:23 +0000)]
Add an extra link

git-svn-id: svn://busybox.net/trunk/busybox@8737 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoPatch from Rob Landley to fix sed documentation.
andersen [Mon, 12 Apr 2004 15:12:06 +0000 (15:12 +0000)]
Patch from Rob Landley to fix sed documentation.
The -i option was not documented, and in genereal
the formatting was a bit ugly.

git-svn-id: svn://busybox.net/trunk/busybox@8736 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years ago"Mac OS X" is how it is written on the Apple website
andersen [Mon, 12 Apr 2004 15:05:10 +0000 (15:05 +0000)]
"Mac OS X" is how it is written on the Apple website

git-svn-id: svn://busybox.net/trunk/busybox@8735 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix spelling. "sort of" is two words.
andersen [Mon, 12 Apr 2004 15:03:51 +0000 (15:03 +0000)]
Fix spelling.  "sort of" is two words.

git-svn-id: svn://busybox.net/trunk/busybox@8734 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agomake mount ignore -n when CONFIG_FEATURE_MTAB_SUPPORT is disabled
andersen [Mon, 12 Apr 2004 15:02:53 +0000 (15:02 +0000)]
make mount ignore -n when CONFIG_FEATURE_MTAB_SUPPORT is disabled

git-svn-id: svn://busybox.net/trunk/busybox@8733 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix compile error if CONFIG_FEATURE_IP_ADDR isnt enabled
bug1 [Mon, 12 Apr 2004 02:35:44 +0000 (02:35 +0000)]
Fix compile error if CONFIG_FEATURE_IP_ADDR isnt enabled

git-svn-id: svn://busybox.net/trunk/busybox@8732 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix up conditional compile of files needed by ip applets
bug1 [Mon, 12 Apr 2004 02:22:39 +0000 (02:22 +0000)]
Fix up conditional compile of files needed by ip applets

git-svn-id: svn://busybox.net/trunk/busybox@8731 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd a comment explaining why we have to check for an extra \n
bug1 [Fri, 9 Apr 2004 06:59:05 +0000 (06:59 +0000)]
Add a comment explaining why we have to check for an extra \n

git-svn-id: svn://busybox.net/trunk/busybox@8727 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix ftp resume
bug1 [Thu, 8 Apr 2004 10:27:11 +0000 (10:27 +0000)]
Fix ftp resume
Terminate returned message at <CRLF> so strtoul returns without error

git-svn-id: svn://busybox.net/trunk/busybox@8726 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoVladimir N. Oleynik writes:
andersen [Wed, 7 Apr 2004 17:59:04 +0000 (17:59 +0000)]
Vladimir N. Oleynik writes:

Hi.

Last changes (rev 1.12) to recursive_actions() by Christian Grigis
have problem.
Test for demonstrate:

$ mkdir aaa bbb ccc
$ su
# chown root bbb
# chmod 700 bbb
# exit
$ busybox chmod 777 -R .
./bbb: Permision denied

But "./ccc" mode not changed. Previous variant works fine,
errors skiped and continued recursion.

--w
vodz

git-svn-id: svn://busybox.net/trunk/busybox@8725 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd the Tritton Technologies NAS120
andersen [Wed, 7 Apr 2004 16:59:59 +0000 (16:59 +0000)]
Add the Tritton Technologies NAS120

git-svn-id: svn://busybox.net/trunk/busybox@8724 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoDocument insmod -o
andersen [Wed, 7 Apr 2004 15:07:55 +0000 (15:07 +0000)]
Document insmod -o

git-svn-id: svn://busybox.net/trunk/busybox@8723 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate for release
andersen [Wed, 7 Apr 2004 14:19:41 +0000 (14:19 +0000)]
Update for release

git-svn-id: svn://busybox.net/trunk/busybox@8721 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate changelog for release
andersen [Wed, 7 Apr 2004 14:19:26 +0000 (14:19 +0000)]
Update changelog for release

git-svn-id: svn://busybox.net/trunk/busybox@8720 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix url
andersen [Wed, 7 Apr 2004 14:07:27 +0000 (14:07 +0000)]
Fix url

git-svn-id: svn://busybox.net/trunk/busybox@8719 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMinor update
andersen [Wed, 7 Apr 2004 14:02:40 +0000 (14:02 +0000)]
Minor update

git-svn-id: svn://busybox.net/trunk/busybox@8718 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMention Acronis PartitionExpert
andersen [Wed, 7 Apr 2004 12:57:15 +0000 (12:57 +0000)]
Mention Acronis PartitionExpert

git-svn-id: svn://busybox.net/trunk/busybox@8717 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMore doc updates
andersen [Wed, 7 Apr 2004 12:26:57 +0000 (12:26 +0000)]
More doc updates

git-svn-id: svn://busybox.net/trunk/busybox@8716 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoAdd an example inetd.conf file
andersen [Wed, 7 Apr 2004 10:34:16 +0000 (10:34 +0000)]
Add an example inetd.conf file

git-svn-id: svn://busybox.net/trunk/busybox@8715 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoRemove the CONFIG_FEATURE_SH_APPLETS_ALWAYS_WIN option. It was sortof
andersen [Wed, 7 Apr 2004 09:34:27 +0000 (09:34 +0000)]
Remove the CONFIG_FEATURE_SH_APPLETS_ALWAYS_WIN option.  It was sortof
stupid and didn't work properly anyways.

git-svn-id: svn://busybox.net/trunk/busybox@8714 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoUpdate the default config
andersen [Wed, 7 Apr 2004 09:17:14 +0000 (09:17 +0000)]
Update the default config

git-svn-id: svn://busybox.net/trunk/busybox@8713 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoBump version to -pre9
andersen [Tue, 6 Apr 2004 17:58:37 +0000 (17:58 +0000)]
Bump version to -pre9

git-svn-id: svn://busybox.net/trunk/busybox@8712 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix buffalo url
andersen [Tue, 6 Apr 2004 17:53:09 +0000 (17:53 +0000)]
Fix buffalo url

git-svn-id: svn://busybox.net/trunk/busybox@8711 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoYet more doc updates
andersen [Tue, 6 Apr 2004 17:52:02 +0000 (17:52 +0000)]
Yet more doc updates

git-svn-id: svn://busybox.net/trunk/busybox@8710 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoYet more doc cleanups. Many thanks to Robert P. J. Day for
andersen [Tue, 6 Apr 2004 17:16:36 +0000 (17:16 +0000)]
Yet more doc cleanups.  Many thanks to Robert P. J. Day for
kindly reviewing the existing docs and providing helpful feedback.

git-svn-id: svn://busybox.net/trunk/busybox@8709 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoSeem not many people are using 'ipaddr' since it has
andersen [Tue, 6 Apr 2004 16:59:43 +0000 (16:59 +0000)]
Seem not many people are using 'ipaddr' since it has
never worked....  Most people use 'ip addr foo' I suppose.

git-svn-id: svn://busybox.net/trunk/busybox@8708 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix indenting
andersen [Tue, 6 Apr 2004 16:56:00 +0000 (16:56 +0000)]
Fix indenting

git-svn-id: svn://busybox.net/trunk/busybox@8707 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoyet-more doc updates and cleanups
andersen [Tue, 6 Apr 2004 16:36:20 +0000 (16:36 +0000)]
yet-more doc updates and cleanups

git-svn-id: svn://busybox.net/trunk/busybox@8706 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoYet more doc updates
andersen [Tue, 6 Apr 2004 15:39:20 +0000 (15:39 +0000)]
Yet more doc updates

git-svn-id: svn://busybox.net/trunk/busybox@8705 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoEliminate all trace of the sgml based docs. It was a noble effort,
andersen [Tue, 6 Apr 2004 15:26:25 +0000 (15:26 +0000)]
Eliminate all trace of the sgml based docs.  It was a noble effort,
but it just never worked out...

git-svn-id: svn://busybox.net/trunk/busybox@8704 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix it so build dependancies actually work and do something useful
andersen [Tue, 6 Apr 2004 15:19:52 +0000 (15:19 +0000)]
Fix it so build dependancies actually work and do something useful

git-svn-id: svn://busybox.net/trunk/busybox@8703 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoFix it so usage is _always_ in sync with applets.c. Previously,
andersen [Tue, 6 Apr 2004 14:28:35 +0000 (14:28 +0000)]
Fix it so usage is _always_ in sync with applets.c.  Previously,
broken depends allowed these to get out of sync.

git-svn-id: svn://busybox.net/trunk/busybox@8702 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMichael Tokarev, mjt at tls dot msk dot ru writes:
andersen [Tue, 6 Apr 2004 12:06:03 +0000 (12:06 +0000)]
Michael Tokarev, mjt at tls dot msk dot ru writes:

Fix parsing of all tag-value pairs (in modules.conf in particular).
Without this fix, code chokes badly on lines where either value or
both tag+value are missing, like bare
 alias
line, or alias w/o the value like
 alias some-module
(syntactically incorrect, but no need for coredumps either).

git-svn-id: svn://busybox.net/trunk/busybox@8700 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMichael Tokarev, mjt at tls dot msk dot ru writes:
andersen [Tue, 6 Apr 2004 12:05:04 +0000 (12:05 +0000)]
Michael Tokarev, mjt at tls dot msk dot ru writes:

alias 'off' parsing fix.
It is not
 alias off module
it is
 alias module off

git-svn-id: svn://busybox.net/trunk/busybox@8699 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoMichael Tokarev, mjt at tls dot msk dot ru writes:
andersen [Tue, 6 Apr 2004 12:04:14 +0000 (12:04 +0000)]
Michael Tokarev, mjt at tls dot msk dot ru writes:

Initialize all fields of struct dep_t.
Without that, e.g. `busybox modprobe -v char-major-10-144' *sometimes*
fails this way (strace):

 write(1, "insmod    nvram `\213\f\10\n", 21) = 21

Note the garbage after module name which is taken from the m_options field,
which is not initialized in the alias reading/parsing part.
(Shell properly complains to this command, telling it can't find the
closing backtick)

git-svn-id: svn://busybox.net/trunk/busybox@8698 69ca8d6d-28ef-0310-b511-8ec308f3f277

18 years agoChristian Grigis, christian.grigis at smartdata dot ch writes:
andersen [Tue, 6 Apr 2004 11:56:26 +0000 (11:56 +0000)]
Christian Grigis, christian.grigis at smartdata dot ch writes:

Hello everyone,

Busybox's insmod fails to locate a module when that module is the only one
existing in the /lib/modules directory (with a unique name).

Example:

# find /lib/modules/ -type f
/lib/modules/kernel/drivers/char/bios.o
# insmod bios
insmod: bios.o: no module by that name found
# touch /lib/modules/dummy
# find /lib/modules/ -type f
/lib/modules/kernel/drivers/char/bios.o
/lib/modules/dummy
# insmod bios
Using /lib/modules/kernel/drivers/char/bios.o

As long as there is another file in the /lib/modules directory, insmod
finds it OK.

I tracked the problem down to 'check_module_name_match()' in insmod.c:

It returns TRUE when a match is found, and FALSE otherwise. In the case
where there is only one module in the /lib/modules directory (or more that
one module, but all with the same name), 'recursive_action()' will return
TRUE and we end up on line 4196 in 'insmod.c' which returns an error.
[The reason it works with more than one module with different
names is that in this case there will always be one not matching,
'recursive_action()' will return FALSE and we end up in line 4189.]

Now, from the implementation of 'recursive_action()' and from other
usages of it (tar.c, etc.), it seems to me that FALSE should be returned
to indicate that we want to stop the recursion, so TRUE and FALSE should
be inverted in 'check_module_name_match()'.

At the same time, 'recursive_action()' continues to recurse even after
the recursive call has returned FALSE; again in my understanding and
other usages of it, we can safely stop recursing at this point.

Here is my patch against 1.00-pre8:

git-svn-id: svn://busybox.net/trunk/busybox@8697 69ca8d6d-28ef-0310-b511-8ec308f3f277