people/mcb30/busybox.git
17 years agoNo longer needed
andersen [Thu, 2 Sep 2004 23:11:53 +0000 (23:11 +0000)]
No longer needed

git-svn-id: svn://busybox.net/trunk/busybox@9198 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoBased on patches from Mike Frysinger, add insmod support for
andersen [Thu, 2 Sep 2004 23:03:25 +0000 (23:03 +0000)]
Based on patches from Mike Frysinger, add insmod support for
sparc and ia64 (itanium).

Also, reorganize the insmod architecture support code to be
alphasorted and less messy.

Update the readme to list current insmod arch support.

git-svn-id: svn://busybox.net/trunk/busybox@9197 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTito writes:
andersen [Thu, 2 Sep 2004 22:22:17 +0000 (22:22 +0000)]
Tito writes:

The second patch contains:
1) a size optimization for adduser.c
2) removes a warning about an unused variable in syslogd.c if CONFIG_FEATURE_REMOTE_LOG is not set
3)cosmetic fixes for addgroup_full_usage and adduser_full_usage

Ciao,
Tito

git-svn-id: svn://busybox.net/trunk/busybox@9195 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTito writes:
andersen [Thu, 2 Sep 2004 22:21:41 +0000 (22:21 +0000)]
Tito writes:

Hi Erik,
Hi to all,
This is part five of the my_get*id story.
I've tweaked a bit this two functions to make them more flexible,
but this changes will not affect existing code.
Now they work so:
1) my_getpwuid( char *user, uid_t uid, int bufsize)

   if bufsize is > 0 char *user cannot be set to NULL
                     on success username is written on static allocated buffer
                     on failure uid as string is written to buffer and NULL is returned
   if bufsize is = 0 char *user can be set to NULL
                     on success username is returned
                     on failure NULL is returned
   if bufsize is < 0 char *user can be set to NULL
                     on success username is returned
                     on failure an error message is printed and the program exits

  2) 1) my_getgrgid( char *group, uid_t uid, int bufsize)

   if bufsize is > 0 char *group cannot be set to NULL
                     on success groupname is written on static allocated buffer
                     on failure gid as string is written to buffer and NULL is returned
   if bufsize is = 0 char *group can be set to NULL
                     on success groupname is returned
                     on failure NULL is returned
   if bufsize is < 0 char *group can be set to nULL
                     on success groupname is returned
                     on failure an error message is printed and the program exits

This changes were needed mainly for my new id applet.
It is somewhat bigger then the previous but matches the behaviour of GNU id
and is capable to handle usernames of whatever length.
BTW: at a first look it seems to me that it will integrate well (with just a few changes)
with the pending patch  in patches/id_groups_alias.patch.
The increase in size is balanced by the removal of my_getpwnamegid.c
from libbb as this was used only in previous id applet and by size optimizations
made possible in whoami.c and in passwd.c.
I know that we are in feature freeze but I think that i've tested it enough
(at least I hope so.......).

git-svn-id: svn://busybox.net/trunk/busybox@9194 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFixup some warnings
andersen [Sat, 28 Aug 2004 00:43:07 +0000 (00:43 +0000)]
Fixup some warnings

git-svn-id: svn://busybox.net/trunk/busybox@9180 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoQuiet a few warnings
andersen [Fri, 27 Aug 2004 19:55:28 +0000 (19:55 +0000)]
Quiet a few warnings

git-svn-id: svn://busybox.net/trunk/busybox@9179 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTogg writes:
andersen [Thu, 26 Aug 2004 23:15:29 +0000 (23:15 +0000)]
Togg writes:

Syslogd wont start if remote-logging is enabled and the connection to the
remote-log server is not possible on syslogd startup.

I found a patch somewhere which works like a charm. It uses sendto() which
seems more reliable for this issue.

Please see attached patch. Many people will be more happy with this included
I think.

Regards,
Togg

git-svn-id: svn://busybox.net/trunk/busybox@9171 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoImprove the setuid situation a bit, and make it more apparent
andersen [Thu, 26 Aug 2004 23:13:00 +0000 (23:13 +0000)]
Improve the setuid situation a bit, and make it more apparent
when people really ought to make busybox setuid root.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9170 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoThe login applet should always be setuid root
andersen [Thu, 26 Aug 2004 23:01:34 +0000 (23:01 +0000)]
The login applet should always be setuid root

git-svn-id: svn://busybox.net/trunk/busybox@9169 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTito writes:
andersen [Thu, 26 Aug 2004 22:36:02 +0000 (22:36 +0000)]
Tito writes:

Hi,
I've fixed also the issue of whoami cutting down usernames.
This time I cannot send a diff because i don't know if my previous patches will be applied
or not, so I send in the whole file.
The changes I've made don't affect size but ensure that usernames of whatever lenght
are correctly displayed.
root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o
   text    data     bss     dec     hex filename
    102       0       0     102      66 whoami_orig.o
root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o
   text    data     bss     dec     hex filename
     93       0       0      93      5d whoami.o

This should be applied even if the other patches aren't as this matches the behaviour of the  GNU whoami.

Thanks in advance,
Ciao,
Tito

git-svn-id: svn://busybox.net/trunk/busybox@9168 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoSave a line or two
andersen [Thu, 26 Aug 2004 22:26:26 +0000 (22:26 +0000)]
Save a line or two

git-svn-id: svn://busybox.net/trunk/busybox@9167 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoVladimir N. Oleynik writes:
andersen [Thu, 26 Aug 2004 22:22:50 +0000 (22:22 +0000)]
Vladimir N. Oleynik writes:

Ming-Ching,

>>No. Here there are no mistakes.
>>You using POST metod.
>>For get data you should read from stdin CONTENT_LENGTH bytes.

>Hower as I posted a little while ago, there is indeed a bug
>in POST method if the CONTENT_LENGTH is bigger
>than sizeof(wbuf[128]). So if your CGI script is expecting to
>read the full CONTENT_LENGTH, it might block forever,
>because it will only transfer sizeof(wbuf) to the CGI.

Ok, Ok. I should find time to understand with a problem.
Try attached patch.

--w
vodz

git-svn-id: svn://busybox.net/trunk/busybox@9166 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTito writes:
andersen [Thu, 26 Aug 2004 22:18:59 +0000 (22:18 +0000)]
Tito writes:

Hi,
I've spent the half night staring at the devilish  my_getpwuid and my_getgrgid functions
trying to find out a way to avoid actual and future potential buffer overflow problems
without breaking existing code.
Finally I've  found a not intrusive way to do this that surely doesn't break existing code
and fixes a couple of problems too.
The attached patch:
1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows
2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h.
3) The behaviour of tar, ls and  logger is unchanged.
4) The behavior of ps with somewhat longer usernames messing up output is fixed.
5) The only bigger change was the increasing of size of the buffers in id.c to avoid
     false negatives (unknown user: xxxxxx) with usernames longer than 8 chars.
     The value i used ( 32 chars ) was taken from the tar header ( see gname and uname).
     Maybe this buffers can be reduced a bit  ( to 16 or whatever ), this is up to you.
6) The increase of size of the binary is not so dramatic:
     size busybox
       text    data     bss     dec     hex filename
     239568    2300   36816  278684   4409c busybox
    size busybox_fixed
       text    data     bss     dec     hex filename
     239616    2300   36816  278732   440cc busybox
7) The behaviour of whoami changed:
    actually it  prints out an username cut down to the size of the buffer.
    This could be fixed by increasing the size of the buffer as in id.c or
    avoid the use of my_getpwuid and use getpwuid directly instead.
    Maybe this colud be also remain unchanged......

Please apply if you think it is ok to do so.
The diff applies on today's cvs tarball (2004-08-25).
Thanks in advance,
Ciao,
Tito

git-svn-id: svn://busybox.net/trunk/busybox@9165 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFelipe Kellermann writes:
andersen [Thu, 26 Aug 2004 21:45:21 +0000 (21:45 +0000)]
Felipe Kellermann writes:

Unfortunatelly I've not followed the last two or three weeks commits (new
semester started and so now I rarely have time to fix my personal bridge)
but tonight I synched my tree and immediately noticed a rather nasty bug!

[Using libbb/interface.c:1.24]
# grep eth0 /proc/net/dev | xargs
eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0

# ifconfig eth0
eth0      Link encap:Ethernet  HWaddr 00:20:AF:7C:EA:B7
          inet addr:10.0.0.1  Bcast:10.0.0.127  Mask:255.255.255.128
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
          Interrupt:5 Base address:0x320

All values `ifconfig' is showing are `zeroed' -- I quickly looked at the
last commits I missed and noticed that there were a commit relating to
ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338).

I've reversed the patch and now everything is working again.  I compared
the get_name's return values from the 1.23 and 1.24 and quickly noticed
that the new revision is leaving `p' right on the sep while the rev 1.23
was leaving it right on the starting of the values...

1-line, 1/3-minute patch attached  :-)

git-svn-id: svn://busybox.net/trunk/busybox@9162 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Manousaridis Angelos to cleanup stale file descriptors, it was preventing...
bug1 [Wed, 25 Aug 2004 02:02:19 +0000 (02:02 +0000)]
Patch from Manousaridis Angelos to cleanup stale file descriptors, it was preventing unmounting an initial filesystem.

git-svn-id: svn://busybox.net/trunk/busybox@9147 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Rodney Radford adding x86_64 support.
andersen [Thu, 19 Aug 2004 19:17:30 +0000 (19:17 +0000)]
Patch from Rodney Radford adding x86_64 support.

git-svn-id: svn://busybox.net/trunk/busybox@9132 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoregularly update the status line display
andersen [Thu, 19 Aug 2004 19:15:06 +0000 (19:15 +0000)]
regularly update the status line display
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9131 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Castle to cleanup some modutils issues, in
andersen [Thu, 19 Aug 2004 18:30:31 +0000 (18:30 +0000)]
Patch from Mike Castle to cleanup some modutils issues, in
particular making alias support work better.

git-svn-id: svn://busybox.net/trunk/busybox@9130 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Tito adding support for '-q'
andersen [Thu, 19 Aug 2004 18:26:26 +0000 (18:26 +0000)]
Patch from Tito adding support for '-q'

git-svn-id: svn://busybox.net/trunk/busybox@9129 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Tito documenting the '-q' option
andersen [Thu, 19 Aug 2004 18:25:02 +0000 (18:25 +0000)]
Patch from Tito documenting the '-q' option

git-svn-id: svn://busybox.net/trunk/busybox@9128 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Vladimir N. Oleynik:
andersen [Thu, 19 Aug 2004 18:22:13 +0000 (18:22 +0000)]
Patch from Vladimir N. Oleynik:

On Wed Aug 18, 2004 at 06:52:57PM +0800, Matt Johnston wrote:
> I've come across some strange-seeming behaviour when running programs
> under Busybox (1.0.0-rc3) ash. If the child process sets stdin to be
> non-blocking and then exits, the parent ash will also exit. A quick strace
> shows that a subsequent read() from stdin returns EAGAIN (as would be
> expected):

Thanks!
Patch attached.

--w
vodz

git-svn-id: svn://busybox.net/trunk/busybox@9127 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFixup 'dc' usage
andersen [Wed, 18 Aug 2004 17:57:16 +0000 (17:57 +0000)]
Fixup 'dc' usage

git-svn-id: svn://busybox.net/trunk/busybox@9118 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPrepare for release
andersen [Mon, 16 Aug 2004 10:29:29 +0000 (10:29 +0000)]
Prepare for release

git-svn-id: svn://busybox.net/trunk/busybox@9105 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoBump version
andersen [Mon, 16 Aug 2004 10:23:33 +0000 (10:23 +0000)]
Bump version

git-svn-id: svn://busybox.net/trunk/busybox@9104 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoOnly pass modprobe module params with 2.6.x kernel support.
andersen [Mon, 16 Aug 2004 10:22:34 +0000 (10:22 +0000)]
Only pass modprobe module params with 2.6.x kernel support.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9103 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoDo not use vfork, as init is not vfork safe. Do not allow
andersen [Mon, 16 Aug 2004 09:29:42 +0000 (09:29 +0000)]
Do not use vfork, as init is not vfork safe.  Do not allow
askfirst when mmuless.

git-svn-id: svn://busybox.net/trunk/busybox@9102 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoBertrand Baudet writes:
andersen [Mon, 16 Aug 2004 09:07:39 +0000 (09:07 +0000)]
Bertrand Baudet writes:

Looks like the -D and -H options of the adduser applet aren't handle
properly in BusyBox.

This patch fixes the masks definition for those options according to
there position in the optstring.

Patch against RC2 but should also apply cleanly against CVS.

Bertrand

git-svn-id: svn://busybox.net/trunk/busybox@9101 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoJoe.C writes:
andersen [Mon, 16 Aug 2004 08:38:34 +0000 (08:38 +0000)]
Joe.C writes:

 This bug is in busybox 1.0.0-rc2. When using lash exec
builtin with redirection, the opened file fd keep increasing.
For example, please try the following command with lash.

ls -al /proc/<lash pid>/fd
exec /bin/sh 2>/dev/null
ls -al /proc/<lash pid>/fd

  The last 'ls' command output will look like this. The fd
number 4 shouldn't exist.

lrwx------    1 501      100         64 Aug 13 13:56 4 -> /dev/pts/5
l-wx------    1 501      100         64 Aug 13 13:56 2 -> /dev/null
lrwx------    1 501      100         64 Aug 13 13:56 1 -> /dev/pts/5
lrwx------    1 501      100         64 Aug 13 13:56 0 -> /dev/pts/5
dr-xr-xr-x    3 501      100          0 Aug 13 13:56 ..
dr-x------    2 501      100          0 Aug 13 13:56 .

  This one-line patch fix this problem by setting CLOEXEC flag for
squirrel fd. Please apply.

Joe.C

git-svn-id: svn://busybox.net/trunk/busybox@9100 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUse __kernel_old_dev_t for 2.6.x kernels
andersen [Mon, 16 Aug 2004 08:36:28 +0000 (08:36 +0000)]
Use __kernel_old_dev_t for 2.6.x kernels

git-svn-id: svn://busybox.net/trunk/busybox@9099 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAurelien Jacobs writes:
andersen [Mon, 16 Aug 2004 08:29:44 +0000 (08:29 +0000)]
Aurelien Jacobs writes:

with a quick conversion you will see that 132608 == 0x20600
so noticed that the elif will never be matched !
Apparently there was already a try to modify this in CVS which
was reverted (it was plain wrong).

I don't know when __kernel_old_dev_t is needed, but with a 2.6.7
or a 2.6.8 this is __kernel_dev_t wich is needed.

I corrected this with the following patch but maybe older 2.6
still need __kernel_old_dev_t ?

I think this should be corrected before 1.0.

Thanks
Aurel

git-svn-id: svn://busybox.net/trunk/busybox@9098 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoChristian Ostheimer writes:
andersen [Sat, 14 Aug 2004 20:57:33 +0000 (20:57 +0000)]
Christian Ostheimer writes:

Hello,

function build_dep in modprobe.c assumes that dependencies of one module
have not more than 255 chars;
that is not sufficient in kernel 2.6.7 (alsa sound modules). - Below is
a diff that solves the problem for me.

With regards, Christian Ostheimer

git-svn-id: svn://busybox.net/trunk/busybox@9093 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from solar to fix problems with get_name()
andersen [Thu, 12 Aug 2004 16:52:00 +0000 (16:52 +0000)]
Patch from solar to fix problems with get_name()

git-svn-id: svn://busybox.net/trunk/busybox@9088 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoSet default command to list rather than get, its default behaviour now
bug1 [Wed, 11 Aug 2004 08:10:58 +0000 (08:10 +0000)]
Set default command to list rather than get, its default behaviour now
coincides with upstream. Patch from debian diff.

git-svn-id: svn://busybox.net/trunk/busybox@9087 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Castle, dont print an empty line (patch modified by me to
bug1 [Wed, 11 Aug 2004 05:56:30 +0000 (05:56 +0000)]
Patch from Mike Castle, dont print an empty line (patch modified by me to
change formatting).

git-svn-id: svn://busybox.net/trunk/busybox@9086 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Tito to fix memory leak upon error.
bug1 [Wed, 11 Aug 2004 03:50:30 +0000 (03:50 +0000)]
Patch from Tito to fix memory leak upon error.

git-svn-id: svn://busybox.net/trunk/busybox@9085 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Bastian Blank to add 64 bit support to the test command.
bug1 [Wed, 11 Aug 2004 02:45:47 +0000 (02:45 +0000)]
Patch from Bastian Blank to add 64 bit support to the test command.
Example of broken usage: ./busybox test 2147483648 -gt 2147483648

git-svn-id: svn://busybox.net/trunk/busybox@9084 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Phil Blundellto improve substring match
bug1 [Wed, 11 Aug 2004 02:32:18 +0000 (02:32 +0000)]
Patch from Phil Blundellto improve substring match

git-svn-id: svn://busybox.net/trunk/busybox@9083 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoWillian Barsse wrote
bug1 [Wed, 11 Aug 2004 02:30:30 +0000 (02:30 +0000)]
Willian Barsse wrote
"There seems to be a slight problem with the "mod_strcmp" function in
modprobe.c, it scans for the first occurence of the module name in the
"mod_path" variable and expects it to be the last path element. ie
/lib/modules/2.4.22-debug/kernel/fs/vfat in my example. The comparison
will always fail if mod_path contains another substring matching the
module name."

Robert McQueen wrote
"Although William Barsse's patch fixed mod_strcmp for 2.4 kernels, there
was a remaining problem which prevented it from working for me. I've
just tracked it down - when you enable kernel 2.6 module support it
hard-wired the extension to .ko instead of checking at runtime like the
other places where 2.4 differs from 2.6. The attached patch fixes this
for me."

git-svn-id: svn://busybox.net/trunk/busybox@9082 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Tito to fix warnings about redifined functionions barrier and likely.
bug1 [Fri, 6 Aug 2004 01:49:04 +0000 (01:49 +0000)]
Patch from Tito to fix warnings about redifined functionions barrier and likely.

git-svn-id: svn://busybox.net/trunk/busybox@9064 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPart of patch from William Barsse, fixes a problem with unescaped %.
bug1 [Fri, 6 Aug 2004 00:58:53 +0000 (00:58 +0000)]
Part of patch from William Barsse, fixes a problem with unescaped %.

git-svn-id: svn://busybox.net/trunk/busybox@9063 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoMichael Leibow, MichaelLe at belkin.com writes:
andersen [Wed, 4 Aug 2004 19:19:10 +0000 (19:19 +0000)]
Michael Leibow, MichaelLe at belkin.com writes:

A question was posted a month ago by Mark Alamo to see if others had
problems with sourcing subscripts within msh.  We asked his firm to fix the
msh.c bug he described because we didn't have enough time to do it
ourselves.

When msh.c is executing a compound statement and there is a . command to
source another script file, msh.c will not execute the subscript until it's
completed executing the rest of the compound statement.

His example was this:

Echo "Start" ; . ./subA; echo "mid" ; . ./subB ; echo "end"

subA and subB execute AFTER end is printed in reverse order.  The same is
true if the sourced files are inside an if else fi, case esac, or any
compound statement.

Attached is a patch to msh.c.  It fixes the problem.  Cd to the root of your
busybox tree and execute "patch -p1 < msh.c.patch"

Unfortunately, I won't have more time to work on this so I hope that there
aren't any problems!

Michael Leibow
Senior Software Engineer

Belkin Corporation

git-svn-id: svn://busybox.net/trunk/busybox@9062 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoRun msh through indent
andersen [Wed, 4 Aug 2004 19:16:54 +0000 (19:16 +0000)]
Run msh through indent

git-svn-id: svn://busybox.net/trunk/busybox@9061 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoWilliam Barsse writes:
andersen [Tue, 3 Aug 2004 08:23:33 +0000 (08:23 +0000)]
William Barsse writes:

fixes two other issues (plus the previous as well) with a 2.4 kernel :

- should be able to modprobe an already loaded module and get 0 return
code :
# modprobe <something> && modprobe <something> && echo "ok" || echo "failed"
....
failed

Well, hope this helps and that I didn't screw up again,
- William

git-svn-id: svn://busybox.net/trunk/busybox@9057 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoTito, farmatito at tiscali dot it writes:
andersen [Tue, 3 Aug 2004 00:14:02 +0000 (00:14 +0000)]
Tito, farmatito at tiscali dot it writes:

Hi to all,
This patch is useful for:
1) remove an unused var from extern char *find_real_root_device_name(const char* name)
    changing it to extern char *find_real_root_device_name(void).
2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and  util-linux/umount.c accordingly.
3) fixes a bug, really a false positive,  in find_real_root_device_name() that happens if
    in the /dev directory exists a link named root (/dev/root) that should be skipped but
    is not. This affects applets like df that display wrong results

git-svn-id: svn://busybox.net/trunk/busybox@9056 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agofixup cut-n-paste problem
andersen [Sun, 1 Aug 2004 18:54:45 +0000 (18:54 +0000)]
fixup cut-n-paste problem

git-svn-id: svn://busybox.net/trunk/busybox@9055 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoSimon Poole reports that awk segfaults when environment variables
andersen [Fri, 30 Jul 2004 23:52:08 +0000 (23:52 +0000)]
Simon Poole reports that awk segfaults when environment variables
with no value exist, i.e.

$ export BOB=''
% ./busybox awk
Segmentation fault

This patch teaches awk to not blow chunks on empty env variables.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9054 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFix incorrect arguments being passed to mknod
andersen [Fri, 30 Jul 2004 17:48:21 +0000 (17:48 +0000)]
Fix incorrect arguments being passed to mknod

git-svn-id: svn://busybox.net/trunk/busybox@9049 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUmm. Not guilty by reason of insanity.
andersen [Fri, 30 Jul 2004 17:39:08 +0000 (17:39 +0000)]
Umm.  Not guilty by reason of insanity.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9048 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFixup getty, login, etc so the utmp and wtmp are updated, allowing
andersen [Fri, 30 Jul 2004 17:24:47 +0000 (17:24 +0000)]
Fixup getty, login, etc so the utmp and wtmp are updated, allowing
the 'who' and 'last' applets among other things to work as expected.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9047 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agouse SIGTERM to kill off udhcpd, not SIGKILL
andersen [Fri, 30 Jul 2004 14:45:08 +0000 (14:45 +0000)]
use SIGTERM to kill off udhcpd, not SIGKILL

git-svn-id: svn://busybox.net/trunk/busybox@9046 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFix up brain damage with the way major and minor are used to
andersen [Fri, 30 Jul 2004 14:36:37 +0000 (14:36 +0000)]
Fix up brain damage with the way major and minor are used to
create a dev_t

git-svn-id: svn://busybox.net/trunk/busybox@9045 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAs noted by Eric Spakman, calling static_down() and then calling
andersen [Fri, 30 Jul 2004 14:31:01 +0000 (14:31 +0000)]
As noted by Eric Spakman, calling static_down() and then calling
bootp_down() seems redundant, esp since bootp_down was a subset
of static_down, so just use that...

git-svn-id: svn://busybox.net/trunk/busybox@9044 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoClean up hex escape support.
mjn3 [Thu, 29 Jul 2004 23:15:16 +0000 (23:15 +0000)]
Clean up hex escape support.

git-svn-id: svn://busybox.net/trunk/busybox@9038 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoThanks to Ken Roberts, fix the slackware url
andersen [Wed, 28 Jul 2004 19:15:04 +0000 (19:15 +0000)]
Thanks to Ken Roberts, fix the slackware url

git-svn-id: svn://busybox.net/trunk/busybox@9036 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFelipe Kellermann noticed a missing `break'.
andersen [Tue, 27 Jul 2004 16:45:46 +0000 (16:45 +0000)]
Felipe Kellermann noticed a missing `break'.

git-svn-id: svn://busybox.net/trunk/busybox@9030 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agodocument stuff I have done
sandman [Mon, 26 Jul 2004 18:57:49 +0000 (18:57 +0000)]
document stuff I have done

git-svn-id: svn://busybox.net/trunk/busybox@9029 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoadd missing ;
andersen [Mon, 26 Jul 2004 12:22:33 +0000 (12:22 +0000)]
add missing ;

git-svn-id: svn://busybox.net/trunk/busybox@9026 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agobump version to -rc2
andersen [Mon, 26 Jul 2004 12:12:06 +0000 (12:12 +0000)]
bump version to -rc2

git-svn-id: svn://busybox.net/trunk/busybox@9025 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agobother. unrevert my fix.
andersen [Mon, 26 Jul 2004 12:11:32 +0000 (12:11 +0000)]
bother.  unrevert my fix.

git-svn-id: svn://busybox.net/trunk/busybox@9024 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPrepare for release
andersen [Mon, 26 Jul 2004 12:07:01 +0000 (12:07 +0000)]
Prepare for release

git-svn-id: svn://busybox.net/trunk/busybox@9023 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAllow hex escape sequences
andersen [Mon, 26 Jul 2004 12:06:19 +0000 (12:06 +0000)]
Allow hex escape sequences

git-svn-id: svn://busybox.net/trunk/busybox@9022 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoMake certain that udhcp shuts down the interface
andersen [Mon, 26 Jul 2004 12:05:44 +0000 (12:05 +0000)]
Make certain that udhcp shuts down the interface

git-svn-id: svn://busybox.net/trunk/busybox@9021 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoYAEGASHI Takeshi writes:
andersen [Mon, 26 Jul 2004 12:05:12 +0000 (12:05 +0000)]
YAEGASHI Takeshi writes:

Hi,

With the following /etc/fstab (any two or more lines of nfs), mount -a
-t nfs causes a segmentation faults.

server:/exports/aaa /mnt/aaa nfs defaults 0 0
server:/exprots/bbb /mnt/bbb nfs defaults 0 0

In util-linux/nfsmount.c, it overwrites malloc'ed pointer *mount_opts
with a static pointer.  With this patch it does proper memory realloc
and data copy instead.

git-svn-id: svn://busybox.net/trunk/busybox@9020 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agooops
andersen [Mon, 26 Jul 2004 11:46:50 +0000 (11:46 +0000)]
oops

git-svn-id: svn://busybox.net/trunk/busybox@9019 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agobump version to -rc2
andersen [Mon, 26 Jul 2004 11:45:47 +0000 (11:45 +0000)]
bump version to -rc2

git-svn-id: svn://busybox.net/trunk/busybox@9018 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoMake certain that udhcp shuts down the interface
andersen [Mon, 26 Jul 2004 11:45:25 +0000 (11:45 +0000)]
Make certain that udhcp shuts down the interface

git-svn-id: svn://busybox.net/trunk/busybox@9017 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAllow hex escape sequences
andersen [Mon, 26 Jul 2004 11:28:47 +0000 (11:28 +0000)]
Allow hex escape sequences

git-svn-id: svn://busybox.net/trunk/busybox@9016 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoBusyBox has no business hard coding the number of major and minor bits for a
andersen [Mon, 26 Jul 2004 09:11:12 +0000 (09:11 +0000)]
BusyBox has no business hard coding the number of major and minor bits for a
dev_t.  This is especially important now that the user space concept of a dev_t
and the kernel concept of a dev_t are divergant.  The only bit of user space
allowed to know the number of major and minor bits is include/sys/sysmacros.h
(i.e. part of libc).  When used with a current C library and a 2.6.x kernel,
this fix should allow BusyBox to support wide device major/minor numbers.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@9015 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPaul Whittaker writes:
andersen [Sat, 24 Jul 2004 12:44:13 +0000 (12:44 +0000)]
Paul Whittaker writes:

With job control enabled, ash fails to tcsetpgrp back to initialpgrp
upon exit.  exitshell() should call setjobctl(0) to do this.

Context: I am using a lightweight menu system (replimenu[.sf.net]) on my
console, which invokes "/bin/sh -i -c /bin/login", where /bin/sh and
/bin/login are busybox applets.   /bin/sh is ash, with
CONFIG_ASH_JOB_CONTROL=y as the sole suboption.  The shell of the user
concerned (nobody) is also /bin/sh (ash).  When the user /bin/sh exits
(and thereby login and its parent sh), replimenu receives EIO when it
tries to read from the terminal.

git-svn-id: svn://busybox.net/trunk/busybox@9013 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch by Paul Whittaker, make busybox dc compatable with GNU dc.
bug1 [Sat, 24 Jul 2004 06:01:52 +0000 (06:01 +0000)]
Patch by Paul Whittaker, make busybox dc compatable with GNU dc.
the following example was broken, echo "1 1 +" | dc

git-svn-id: svn://busybox.net/trunk/busybox@9012 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUpdate Tito's contributions
bug1 [Sat, 24 Jul 2004 01:55:56 +0000 (01:55 +0000)]
Update Tito's contributions

git-svn-id: svn://busybox.net/trunk/busybox@9011 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Felipe Kellermann, fix endless loop when first > last and
bug1 [Fri, 23 Jul 2004 06:43:29 +0000 (06:43 +0000)]
Patch from Felipe Kellermann, fix endless loop when first > last and
increment > 0.

git-svn-id: svn://busybox.net/trunk/busybox@9010 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Felipe Kellermann, fixup usage for pidof, poweroff, remove
bug1 [Fri, 23 Jul 2004 06:06:21 +0000 (06:06 +0000)]
Patch from Felipe Kellermann, fixup usage for pidof, poweroff, remove
some trailing '\n'

git-svn-id: svn://busybox.net/trunk/busybox@9009 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Felipe Kellermann, fixup usage for halt command
bug1 [Fri, 23 Jul 2004 05:16:17 +0000 (05:16 +0000)]
Patch from Felipe Kellermann, fixup usage for halt command

git-svn-id: svn://busybox.net/trunk/busybox@9008 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoiUpdate reboot usage, patch by Felipe Kellermann
bug1 [Fri, 23 Jul 2004 03:33:38 +0000 (03:33 +0000)]
iUpdate reboot usage, patch by  Felipe Kellermann

git-svn-id: svn://busybox.net/trunk/busybox@9007 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Dmitry Zakharov to fix a bug discovered via the freeswap
bug1 [Fri, 23 Jul 2004 02:11:25 +0000 (02:11 +0000)]
Patch from Dmitry Zakharov to fix a bug discovered via the freeswap
script.

git-svn-id: svn://busybox.net/trunk/busybox@9006 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFix for a bug identied by Harald Kuthe, when using many interfaces (29
bug1 [Fri, 23 Jul 2004 01:49:46 +0000 (01:49 +0000)]
Fix for a bug identied by Harald Kuthe, when using many interfaces (29
in this case) the order was incorrect and there were duplicate entries.

git-svn-id: svn://busybox.net/trunk/busybox@9005 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFelipe Kellermann writes,
bug1 [Fri, 23 Jul 2004 01:42:28 +0000 (01:42 +0000)]
Felipe Kellermann writes,

"As noticed today by Steven Scholz, the od's `-v' was broken.
I've fixed that and now both the flags `-v' and `-a' are OK"

Fixes a segfault in
echo "uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu\02bar\4"| ./busybox od -av

git-svn-id: svn://busybox.net/trunk/busybox@9004 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Felipe Kellermann, "There is a call to printf using `*pr-cchar'
bug1 [Fri, 23 Jul 2004 01:35:41 +0000 (01:35 +0000)]
Patch from Felipe Kellermann, "There is a call to printf using `*pr-cchar'
referencing a string and using a single char, when *p <= 0x1f."

git-svn-id: svn://busybox.net/trunk/busybox@9003 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Felipe Kellermann to fix some typo's
bug1 [Fri, 23 Jul 2004 01:27:56 +0000 (01:27 +0000)]
Patch from Felipe Kellermann to fix some typo's

git-svn-id: svn://busybox.net/trunk/busybox@9002 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Adam Slattery to add bzip2 support to rpm2cpio
bug1 [Fri, 23 Jul 2004 01:20:57 +0000 (01:20 +0000)]
Patch from Adam Slattery to add bzip2 support to rpm2cpio

git-svn-id: svn://busybox.net/trunk/busybox@9001 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Manousaridis Angelos to bring dhclient down more elegently
bug1 [Fri, 23 Jul 2004 01:10:22 +0000 (01:10 +0000)]
Patch from Manousaridis Angelos to bring dhclient down more elegently

git-svn-id: svn://busybox.net/trunk/busybox@9000 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoReverse my previous change, "::" is a GNU getopt extension that allows
bug1 [Thu, 22 Jul 2004 04:23:18 +0000 (04:23 +0000)]
Reverse my previous change, "::" is a GNU getopt extension that allows
an optional argument.
Looks like a glibc bug to me

git-svn-id: svn://busybox.net/trunk/busybox@8997 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Snitzer <snitzer@gmail.com>:
sandman [Thu, 22 Jul 2004 00:03:39 +0000 (00:03 +0000)]
Patch from Mike Snitzer <snitzer@gmail.com>:
Support for /etc/modprobe.conf (for 2.6 kernels) should likely be added
to bb's modprobe, see attached patch.

modprobe.conf is just a (even simpler) variant of modules.conf

git-svn-id: svn://busybox.net/trunk/busybox@8996 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Snitzer to fix return codes.
bug1 [Wed, 21 Jul 2004 23:56:31 +0000 (23:56 +0000)]
Patch from Mike Snitzer to fix return codes.

"I have a need to _really_ know if the interface was properly configured
via ifup so I made busybox's ifupdown pass the return codes through rather
than dropping them on the floor."

"All the functions in ifupdown.c return 1 on success and 0 on failure
(which happens to the opposite of standard practices but whatever).
So it is important for all these functions to not blindly return 1."

"The problem with blindly returning ret, even if it is != 1, is the
callers expect a 0 or 1 and accumulate the return codes.  So a function that
makes 3 calls to execute will have a value of 3 accumulated.  That value
of 1 (success) was almost always returned even if 1 of the commands in the
command sequence failed.  The attached patch fixes the lack of checking
to verify thar result == expected_reult."

git-svn-id: svn://busybox.net/trunk/busybox@8995 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFix bug in accepting buffer size argument
bug1 [Wed, 21 Jul 2004 13:06:30 +0000 (13:06 +0000)]
Fix bug in accepting buffer size argument

git-svn-id: svn://busybox.net/trunk/busybox@8994 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Tito, ass usage for strings -a options
bug1 [Wed, 21 Jul 2004 12:25:55 +0000 (12:25 +0000)]
Patch from Tito, ass usage for strings -a options

git-svn-id: svn://busybox.net/trunk/busybox@8993 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Snitzer, bring down dhclient using its correct pid, fix
bug1 [Wed, 21 Jul 2004 12:21:39 +0000 (12:21 +0000)]
Patch from Mike Snitzer, bring down dhclient using its correct pid, fix
a grammatical error.

git-svn-id: svn://busybox.net/trunk/busybox@8992 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Jean Wolter, fixes compiler warning when ASH_ALIAS is
bug1 [Wed, 21 Jul 2004 10:20:19 +0000 (10:20 +0000)]
Patch from Jean Wolter, fixes compiler warning when ASH_ALIAS is
disabled.

git-svn-id: svn://busybox.net/trunk/busybox@8991 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoFixup -T (--files-from) option, works for non-directories now
bug1 [Wed, 21 Jul 2004 09:00:39 +0000 (09:00 +0000)]
Fixup -T (--files-from) option, works for non-directories now

git-svn-id: svn://busybox.net/trunk/busybox@8989 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoAvoid a naming conflict with include/bits/fcntl.h
andersen [Tue, 20 Jul 2004 22:53:59 +0000 (22:53 +0000)]
Avoid a naming conflict with include/bits/fcntl.h

git-svn-id: svn://busybox.net/trunk/busybox@8988 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoPatch from Mike Snitzer <snitzer@gmail.com>:
sandman [Tue, 20 Jul 2004 18:36:51 +0000 (18:36 +0000)]
Patch from Mike Snitzer <snitzer@gmail.com>:
Please see the attached patch for the following crash with busybox'
2.6 rmmod support

git-svn-id: svn://busybox.net/trunk/busybox@8987 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agonew_process_module_arguments returns 0 on error and 1 if everything went ok
sandman [Tue, 20 Jul 2004 15:43:57 +0000 (15:43 +0000)]
new_process_module_arguments returns 0 on error and 1 if everything went ok
somehow the ! got lost..
symptoms: modules could only be loaded _without_ parameters

git-svn-id: svn://busybox.net/trunk/busybox@8986 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agooops
andersen [Tue, 20 Jul 2004 11:41:16 +0000 (11:41 +0000)]
oops

git-svn-id: svn://busybox.net/trunk/busybox@8981 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoYet more doc updates
andersen [Tue, 20 Jul 2004 11:31:52 +0000 (11:31 +0000)]
Yet more doc updates

git-svn-id: svn://busybox.net/trunk/busybox@8980 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agomore doc updates
andersen [Tue, 20 Jul 2004 11:31:08 +0000 (11:31 +0000)]
more doc updates

git-svn-id: svn://busybox.net/trunk/busybox@8979 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agocut-n-paste strikes again
andersen [Tue, 20 Jul 2004 11:23:45 +0000 (11:23 +0000)]
cut-n-paste strikes again

git-svn-id: svn://busybox.net/trunk/busybox@8978 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUpdate for release
andersen [Tue, 20 Jul 2004 11:08:30 +0000 (11:08 +0000)]
Update for release

git-svn-id: svn://busybox.net/trunk/busybox@8976 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoUpdate changelog
andersen [Tue, 20 Jul 2004 10:12:21 +0000 (10:12 +0000)]
Update changelog

git-svn-id: svn://busybox.net/trunk/busybox@8975 69ca8d6d-28ef-0310-b511-8ec308f3f277

17 years agoDeal with the fact that 2.6.x kernels replace any '-'s in the
andersen [Tue, 20 Jul 2004 10:05:13 +0000 (10:05 +0000)]
Deal with the fact that 2.6.x kernels replace any '-'s in the
module name with a '_'.
 -Erik

git-svn-id: svn://busybox.net/trunk/busybox@8974 69ca8d6d-28ef-0310-b511-8ec308f3f277