Kill off job::start() (it was only ever added as part of an aborted

attempt at triggering TCP-related protocols to start).

diff --git a/src/core/downloader.c b/src/core/downloader.c
index eec0c57..40003db 100644 (file)
--- a/src/core/downloader.c
+++ b/src/core/downloader.c
@@ -130,7 +130,6 @@ static void downloader_job_kill ( struct job_interface *job ) {
 
 /** Downloader job control interface operations */
 static struct job_interface_operations downloader_job_operations = {
-       .start          = ignore_job_start,
        .done           = ignore_job_done,
        .kill           = downloader_job_kill,
        .progress       = ignore_job_progress,

diff --git a/src/core/job.c b/src/core/job.c
index 1c589fc..8d76858 100644 (file)
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -43,10 +43,6 @@ void job_done ( struct job_interface *job, int rc ) {
  *
  */
 
-void ignore_job_start ( struct job_interface *job __unused ) {
-       /* Nothing to do */
-}
-
 void ignore_job_done ( struct job_interface *job __unused, int rc __unused ) {
        /* Nothing to do */
 }
@@ -62,7 +58,6 @@ void ignore_job_progress ( struct job_interface *job __unused,
 
 /** Null job control interface operations */
 struct job_interface_operations null_job_ops = {
-       .start          = ignore_job_start,
        .done           = ignore_job_done,
        .kill           = ignore_job_kill,
        .progress       = ignore_job_progress,

diff --git a/src/include/gpxe/job.h b/src/include/gpxe/job.h
index 2888586..3190fa2 100644 (file)
--- a/src/include/gpxe/job.h
+++ b/src/include/gpxe/job.h
@@ -33,11 +33,6 @@ struct job_interface;
 
 /** Job control interface operations */
 struct job_interface_operations {
-       /** Start job
-        *
-        * @v job               Job control interface
-        */
-       void ( * start ) ( struct job_interface *job );
        /** Job completed
         *
         * @v job               Job control interface
@@ -71,7 +66,6 @@ extern struct job_interface_operations null_job_ops;
 
 extern void job_done ( struct job_interface *job, int rc );
 
-extern void ignore_job_start ( struct job_interface *job );
 extern void ignore_job_done ( struct job_interface *job, int rc );
 extern void ignore_job_kill ( struct job_interface *job );
 extern void ignore_job_progress ( struct job_interface *job,

diff --git a/src/net/udp/dhcp.c b/src/net/udp/dhcp.c
index e5a95b3..1778ba7 100644 (file)
--- a/src/net/udp/dhcp.c
+++ b/src/net/udp/dhcp.c
@@ -758,7 +758,6 @@ static void dhcp_job_kill ( struct job_interface *job ) {
 
 /** DHCP job control interface operations */
 static struct job_interface_operations dhcp_job_operations = {
-       .start          = ignore_job_start,
        .done           = ignore_job_done,
        .kill           = dhcp_job_kill,
        .progress       = ignore_job_progress,