Cope with non-newline-terminated scripts.

Print error status using strerror().

diff --git a/src/image/script.c b/src/image/script.c
index 8e511d2..c882152 100644 (file)
--- a/src/image/script.c
+++ b/src/image/script.c
@@ -58,6 +58,7 @@ static int script_exec ( struct image *image ) {
                len = sizeof ( cmdbuf );
                if ( len > remaining )
                        len = remaining;
                len = sizeof ( cmdbuf );
                if ( len > remaining )
                        len = remaining;

+               memset ( cmdbuf, 0, sizeof ( cmdbuf ) );

                copy_from_user ( cmdbuf, image->data, offset, len );
 
                /* Find end of line */
                copy_from_user ( cmdbuf, image->data, offset, len );
 
                /* Find end of line */


@@ -75,8 +76,8 @@ static int script_exec ( struct image *image ) {
                *eol = '\0';
                DBG ( "$ %s\n", cmdbuf );
                if ( ( rc = system ( cmdbuf ) ) != 0 ) {
                *eol = '\0';
                DBG ( "$ %s\n", cmdbuf );
                if ( ( rc = system ( cmdbuf ) ) != 0 ) {

-                       DBG ( "Command \"%s\" exited with status %d\n",
-                             cmdbuf, rc );
+                       DBG ( "Command \"%s\" failed: %s\n",
+                             cmdbuf, strerror ( rc ) );

                        goto done;
                }
                
                        goto done;
                }