mirror/winof/.git
11 years ago[MTHCA] add newline to the last line of mthca32.cdf (MakeCat.exe will fail otherwise)
reuven [Sun, 25 Jan 2009 11:23:54 +0000 (11:23 +0000)]
[MTHCA] add newline to the last line of mthca32.cdf (MakeCat.exe will fail otherwise)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1882 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] added MSI-X support to MLX4 driver.
leonidk [Sun, 25 Jan 2009 09:32:03 +0000 (09:32 +0000)]
[MLX4] added MSI-X support to MLX4 driver.

This patch adds MSI-X support to MLX4 driver.
To remind, current driver creates 2 EQs (for commands/events and completions), which both use 1 legacy interrupt.
With this patch MLX4 requests (in inf file) 18 MSI-X interrupt vectors, spreaded across processors in round-robin way.
If the platform doesn't support MSI-X vectors, the driver uses legacy interrupts.

MSI-X support required some changes in the card reset mechanism, which are also found in the patch.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1881 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[CORE] bugfix in debug prints. [mlnx: 3573]
leonidk [Sun, 25 Jan 2009 09:22:12 +0000 (09:22 +0000)]
[CORE] bugfix in debug prints. [mlnx: 3573]

On x86 platform casting expression like
    (LONG_PTR)p_obj
doesn't increase the size of pointer.
As a result printf() function - driven by %I64 size modifier - takes the next parameter as a second part of the previous one.
It causes a corrupted print at least and a crash at most.

The patch replaces %I64Ix fixed-size format modifier by the  variable-sized %p one.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1880 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agolibrdmacm: provide OFED compatibility library.
shefty [Sat, 24 Jan 2009 19:58:23 +0000 (19:58 +0000)]
librdmacm: provide OFED compatibility library.

Provide a port of librdmacm.

Because of the use of overlapped structures and events, the library
has a scalability limitation of about 60 connections. The scalability limit will be addressed in a subsequent version, once the needs of a real application are determined.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1879 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoThe librdmacm uses the same devices that are usable with the libibverbs library.
shefty [Sat, 24 Jan 2009 19:53:32 +0000 (19:53 +0000)]
The librdmacm uses the same devices that are usable with the libibverbs library.
Provide a method in libibverbs that allows librdmacm to use the same winverbs
provider as libibverbs.

Include fixes discovered testing the librdmacm port:

When a CQ is removed, its position in the completion channel is replaced by
the CQ at the end of the list, but the CQ that moves is not updated to
reflect its new location.

When a QP is created, we need to save the user's initial values before
querying for the QPN.  Otherwise, the query call tries to access invalid data.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1878 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoUpdate the winverbs interface and library to add support for connection
shefty [Sat, 24 Jan 2009 19:49:59 +0000 (19:49 +0000)]
Update the winverbs interface and library to add support for connection
establishment.  The implementation supports XP, 2003, and 2008.  Because
kernel support for IP is lacking in XP and 2003, the winverbs userspace
library performs address and route resolution, rather than relying on the
kernel driver to perform those operations.

The interface for datagram support was updated to match that used for
connections, but datagram support is not implemented at this time.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1877 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoForgot to add wv_ep.c. Add it now!
shefty [Sat, 24 Jan 2009 19:46:05 +0000 (19:46 +0000)]
Forgot to add wv_ep.c.  Add it now!

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1876 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoAdd support for connection establishment over IB through the winverbs kernel
shefty [Sat, 24 Jan 2009 19:30:54 +0000 (19:30 +0000)]
Add support for connection establishment over IB through the winverbs kernel
driver.  This depends on exporting the IB CM interface.  Connections follow
the RDMA CM model.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1875 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoib/cm: export cm only interface
shefty [Sat, 24 Jan 2009 19:15:03 +0000 (19:15 +0000)]
ib/cm: export cm only interface

To support WinVerbs and a future OFED libibcm compatibility library (requires
a new library and driver), export a new IB CM interface.  The interface sits
above the existing communication endpoint (CEP) manager.  This allows the
interface to export only IB CM functionality.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1874 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agobuild: add ib-diags to the build
shefty [Fri, 23 Jan 2009 21:57:05 +0000 (21:57 +0000)]
build: add ib-diags to the build

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1871 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoinfiniband-diags: initial port of linux ib diags
shefty [Fri, 23 Jan 2009 21:56:35 +0000 (21:56 +0000)]
infiniband-diags: initial port of linux ib diags

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1870 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agolibibmad: sync with linux
shefty [Fri, 23 Jan 2009 21:44:19 +0000 (21:44 +0000)]
libibmad: sync with linux

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1869 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agolibibumad: add missing #defines to sync with linux
shefty [Fri, 23 Jan 2009 21:42:19 +0000 (21:42 +0000)]
libibumad: add missing #defines to sync with linux

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1868 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] remove deprecated ib_bus*.* file references.
stansmith [Thu, 22 Jan 2009 22:06:04 +0000 (22:06 +0000)]
[WinOF] remove deprecated ib_bus*.* file references.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1864 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] unified msiexec cmd-line DGB=1 to use the same sDBG global for install &...
stansmith [Thu, 22 Jan 2009 21:58:19 +0000 (21:58 +0000)]
[WinOF] unified msiexec cmd-line DGB=1 to use the same sDBG global for install & uninstall. Reworked dpinst_status() to intelligently output useful status information instead of assuming error only.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1863 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] lastest version of dpinst.exe
stansmith [Thu, 22 Jan 2009 21:54:47 +0000 (21:54 +0000)]
[WinOF] lastest version of dpinst.exe

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1862 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agowinverbs.lib: remove from build
shefty [Tue, 20 Jan 2009 23:07:10 +0000 (23:07 +0000)]
winverbs.lib: remove from build

Removal of the listen.cpp and listen.h source files results in the winverbs library build breaking.  The removal will occur, but it's only part of a patch to winverbs to handle listening.  So, we either need to apply the rest of the patch or back out the changes to fix the build.  Since the rest of the patch will be applied within the next couple of days, remove the library from the build until then.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1861 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agowinverbs.lib: remove deleted file from build
shefty [Tue, 20 Jan 2009 21:39:37 +0000 (21:39 +0000)]
winverbs.lib: remove deleted file from build

wv_listen.cpp is no longer part of the build.  Listen functionality was folded into the endpoint code.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1860 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agomlx4u.dll: initialize qp pointer before use
shefty [Tue, 20 Jan 2009 21:35:44 +0000 (21:35 +0000)]
mlx4u.dll: initialize qp pointer before use

We need to initialize the qp pointer to NULL to avoid accessing some random memory location when polling for completions.  Without this, calls to mlx4_poll_cq_array() can crash in mlx4_poll_one().

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1859 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agomthca/mlx4: add check to validate output data sizes
shefty [Tue, 20 Jan 2009 21:34:40 +0000 (21:34 +0000)]
mthca/mlx4: add check to validate output data sizes

Only the hardware drivers know what size the output data buffer must be for ndi_modify_qp.  Have the drivers verify that the provided data buffer is large enough.

This fixes a crash if (say, a buggy) userspace (library under development) does not provide a response buffer.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1858 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoibal: remove unneeded typedefs
shefty [Tue, 20 Jan 2009 21:32:45 +0000 (21:32 +0000)]
ibal: remove unneeded typedefs

al_qp.h defines typedefs that are only used later in the same file.  Remove the typedefs and just define the functions inline.  This also prevents a duplicate typedef (with different types).

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1857 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agowinverbs: remove used files
shefty [Tue, 20 Jan 2009 08:05:38 +0000 (08:05 +0000)]
winverbs: remove used files

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1855 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agowinverbs.dll: remove unused files
shefty [Tue, 20 Jan 2009 08:05:18 +0000 (08:05 +0000)]
winverbs.dll: remove unused files

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1854 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agomaintainers: update maintainer info for OFED compat libs and diags
shefty [Tue, 20 Jan 2009 08:04:44 +0000 (08:04 +0000)]
maintainers: update maintainer info for OFED compat libs and diags

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1853 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF]
stansmith [Mon, 19 Jan 2009 19:43:35 +0000 (19:43 +0000)]
[WinOF]
CustomActions.vbs
  rewrote/cleanup device uninstall to use 'devman driverfiles' instead of guessing what files are installed for each driver.
  Added msiexec.exe cmd-line arg DBG=1 for install & uninstall - provide debug insights to what's going on.

wof.wxs
  Remove ibinstaller.dll references
  Prep for WinOF 2.1 Release
  Remove erroneous file dup/copy for files installed via driver .inf

README_release.txt & Release_notes.htm
  Prep for WinOF 2.1 release.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1844 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] Soft Reset: (bugfix in error flow) handling a case when MLX4_BUS fails during...
leonidk [Sun, 18 Jan 2009 16:11:56 +0000 (16:11 +0000)]
[MLX4] Soft Reset: (bugfix in error flow) handling a case when MLX4_BUS fails during restart after reset. [mlnx: 3557]

Soft Reset mechanism is used only in Ethernet mode of ConnectX HCA.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1842 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLTHCA] added polling mode support.
leonidk [Sun, 18 Jan 2009 13:47:55 +0000 (13:47 +0000)]
[MLTHCA] added polling mode support.

This patch is a second part of a workaround, added in rev. 1800 for MLX4.
It adds polling mode support for MTHCA.
This is needed for example in the case, when interrupts stop to be conveyed to the driver for some HW problem.
(Xsigo saw such case).
This patch additionally "actualize" the workaround (by off-commenting #if WORKAROUND_POLL_EQ) to enable polling mode without re-building the drivers.

Signed-off-by: James Yang [jyang@xsigo.com]
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1841 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] added resource info to MLX4U.DLL
leonidk [Sun, 18 Jan 2009 13:43:26 +0000 (13:43 +0000)]
[MLX4] added resource info to MLX4U.DLL

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1840 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] This patch adds rc file to mlx4u[d].dll.
leonidk [Sun, 18 Jan 2009 13:42:56 +0000 (13:42 +0000)]
[MLX4] This patch adds rc file to mlx4u[d].dll.

Signed-off-by: Reuven Amitai
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1839 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] This patch loads winverbs and winmad as filter drivers for mlx4_hca and mthca
leonidk [Sun, 18 Jan 2009 12:47:00 +0000 (12:47 +0000)]
[MLX4] This patch loads winverbs and winmad as filter drivers for mlx4_hca and mthca

Signed off by stan.smith@intel.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1838 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MLX4] patches for loading winverbs and winmad as filter drivers for mlx4: 3 of 3
leonidk [Sun, 18 Jan 2009 12:25:05 +0000 (12:25 +0000)]
[MLX4] patches for loading winverbs and winmad as filter drivers for mlx4: 3 of 3

Signed off by stan.smith@intel.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1837 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MTHCA] patches for loading winverbs and winmad as filter drivers for mthca: 2 of...
leonidk [Sun, 18 Jan 2009 12:21:03 +0000 (12:21 +0000)]
[MTHCA] patches for loading winverbs and winmad as filter drivers for mthca: 2 of 3 - file: mthca32.cdf

Signed off by stan.smith@intel.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1836 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agowinmad: add missing mad_osd.h
shefty [Thu, 15 Jan 2009 18:25:44 +0000 (18:25 +0000)]
winmad: add missing mad_osd.h

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1834 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agolibibmad: updated based on merge feedback
shefty [Thu, 15 Jan 2009 07:31:36 +0000 (07:31 +0000)]
libibmad: updated based on merge feedback

Latest set of changes to libibmad to support both Windows and Linux.  Changes have not yet been accepted back into the main git tree.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1833 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[tools] Remove coinstaller
reuven [Wed, 14 Jan 2009 09:14:35 +0000 (09:14 +0000)]
[tools] Remove coinstaller

The coinstaller is not needed anymore as IBAL moved to be a filter driver.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1822 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[UMAD] removed readme.txt file as the Windows libumad implementation is indeed a...
stansmith [Tue, 13 Jan 2009 23:56:51 +0000 (23:56 +0000)]
[UMAD] removed readme.txt file as the Windows libumad implementation is indeed a Windows specific implementation - I was confused when the readme.txt was comitted.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1819 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] added README.txt which explains how to setup the WIX toolset.
stansmith [Tue, 13 Jan 2009 23:24:17 +0000 (23:24 +0000)]
[WinOF] added README.txt which explains how to setup the WIX toolset.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1818 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IBBUS] remove unused files
leonidk [Tue, 13 Jan 2009 11:31:42 +0000 (11:31 +0000)]
[IBBUS] remove unused files

The patch removes ib_bus.cdf, ib_bus32.cdf and ib_bus.inx files.
They are not used anymore since ibbus is now a filter driver.
ib_bus.cdf content moved to mthca.cdf & mlx4_hca.cdf, ib_bus.inx content moved to mthca.inx & mlx4_hca.inx.

Signed-off-by: Reuven Amitai (reuven@mellanox.co.il)
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1816 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[MTHCA] patches for loading winverbs and winmad as filter drivers for mthca: 1 of...
leonidk [Tue, 13 Jan 2009 11:22:43 +0000 (11:22 +0000)]
[MTHCA] patches for loading winverbs and winmad as filter drivers for mthca: 1 of 3 - file: mthca.cdf

Signed off by stan.smith@intel.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1815 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] removed IB_[CHK,FRE]_BLD_[IA64,x64,x86].bat as they are no longer used (repla...
stansmith [Fri, 9 Jan 2009 17:56:32 +0000 (17:56 +0000)]
[WinOF] removed IB_[CHK,FRE]_BLD_[IA64,x64,x86].bat as they are no longer used (replaced by etc\bldwo.bat)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1812 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] When requested, start the local OpenSM service immediately after loading...
stansmith [Thu, 8 Jan 2009 00:36:50 +0000 (00:36 +0000)]
[WinOF] When requested, start the local OpenSM service immediately after loading HCA driver in order for the later IOU driver to correctly load; Server 2003/XP64 problem observed such that IOU driver fails to load if OpenSM has not setup IOU/IOC prior to IOU driver load via devcon; dpinst.exe works find due to driver store.
Removed some unused code in CustomActions.vbs

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1811 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[DOCS] document SRP uninstall issues with lingering SRP driver references and how...
stansmith [Thu, 8 Jan 2009 00:32:20 +0000 (00:32 +0000)]
[DOCS] document SRP uninstall issues with lingering SRP driver references and how to cleanly uninstall via diskpart.exe (WLH only).

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1810 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] document SRP install (OFED 1.4 target) & uninstall items of interest
stansmith [Tue, 6 Jan 2009 20:07:42 +0000 (20:07 +0000)]
[WinOF] document SRP install (OFED 1.4 target) & uninstall items of interest

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1809 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[LIBIBMAD] mirror OFED files in svn to assist Windows developers; see README.txt.
stansmith [Tue, 6 Jan 2009 20:04:43 +0000 (20:04 +0000)]
[LIBIBMAD] mirror OFED files in svn to assist Windows developers; see README.txt.
[LIBUMAD] added README.txt file to explain source mirror policy.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1808 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] Support Winmad.dll, libibverbs.dll, libibumad.dll, ibverbs symbols(.pdb files).
stansmith [Mon, 5 Jan 2009 19:53:57 +0000 (19:53 +0000)]
[WinOF] Support Winmad.dll, libibverbs.dll, libibumad.dll, ibverbs symbols(.pdb files).
winverbs installed by default.
Linux OFED SRP target recognized when SRP installed.
For Server 2008 & Vista - dpinst.exe is used to install IOU, SRP & VNIC. Server 2003/XP use devman.exe.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1807 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF] makebin.bat - include winmad, ibverbs & script Progress output(echo).
stansmith [Mon, 5 Jan 2009 19:42:58 +0000 (19:42 +0000)]
[WinOF] makebin.bat - include winmad, ibverbs & script Progress output(echo).

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1806 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[DOCS] document winverbs tools (ibv_devinfo, ibstat)
stansmith [Mon, 5 Jan 2009 19:33:41 +0000 (19:33 +0000)]
[DOCS] document winverbs tools (ibv_devinfo, ibstat)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1805 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IBMAD] build libibmad
stansmith [Mon, 5 Jan 2009 19:30:00 +0000 (19:30 +0000)]
[IBMAD] build libibmad

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1804 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[ipoib] restore last table until validation.
reuven [Mon, 29 Dec 2008 10:10:12 +0000 (10:10 +0000)]
[ipoib] restore last table until validation.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1803 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[ipoib] add guid2mac table instead of endless if statements.
tzachid [Thu, 25 Dec 2008 16:31:39 +0000 (16:31 +0000)]
[ipoib] add guid2mac table instead of endless if statements.
        Add full guid list of Mellanox HCAs cards.
Signed off by: Reuven@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1802 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IPoIB] Removing dead code.
tzachid [Thu, 25 Dec 2008 16:09:02 +0000 (16:09 +0000)]
[IPoIB] Removing dead code.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1801 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[mlx4] Add code that replaces interrupts with a thread that is polling.
tzachid [Thu, 25 Dec 2008 16:06:46 +0000 (16:06 +0000)]
[mlx4] Add code that replaces interrupts with a thread that is polling.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1800 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[etc] Replace recieve with receive.
tzachid [Thu, 25 Dec 2008 15:52:25 +0000 (15:52 +0000)]
[etc] Replace recieve with receive.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1799 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[ibat] Decrease the time it takes to build the ibat lib.
tzachid [Thu, 25 Dec 2008 15:49:45 +0000 (15:49 +0000)]
[ibat] Decrease the time it takes to build the ibat lib.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1798 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[Winverbs/Winumad] _DEBUG_ --> DBG to enable (DEBUG) in file status
stansmith [Thu, 18 Dec 2008 22:28:28 +0000 (22:28 +0000)]
[Winverbs/Winumad] _DEBUG_ --> DBG to enable (DEBUG) in file status

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1796 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years agoWinMad driver and library.
shefty [Wed, 17 Dec 2008 20:27:48 +0000 (20:27 +0000)]
WinMad driver and library.
libibumad compatibility library.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1795 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IBAL] compare TID based on user contolled area only
leonidk [Wed, 17 Dec 2008 10:10:32 +0000 (10:10 +0000)]
[IBAL] compare TID based on user contolled area only

The current MAD processing code operates as follows when sending a request and trying to match a received response:

1. It saves the user's transaction ID (TID) to client_tid.
2. It clears the upper 32-bits of the TID.
3. It sets the upper 32-bits of the TID to an internal index.
4. It clears the upper 32-bits of a received response.
5. It tries to match the received response against client_tid.

Responses are only matched successfully if the user has already cleared the upper 32-bits of the TID before sending the MAD.  It would be better to only match responses using the lower, user-controlled, 32-bits of the TID.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1794 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IBAL]use default LID of 1 for SA AV
leonidk [Wed, 17 Dec 2008 10:05:49 +0000 (10:05 +0000)]
[IBAL]use default LID of 1 for SA AV

The 'SA request' code creates an AV for the SA.  It wants to use a default LID of 1, but does not byte-swap the value.  Swap the value.

Because the AV is modified later to use the real SM LID, the value used here is irrelevant, but using a non-swapped value looks like a bug to anyone reading it.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1793 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[IPoIB]: Fill in service level in MAC_TO_PATH output.
tzachid [Sun, 14 Dec 2008 02:47:22 +0000 (02:47 +0000)]
[IPoIB]: Fill in service level in MAC_TO_PATH output.
signed off by: Fab Tillier [ftillier@windows.microsoft.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1788 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF]
stansmith [Fri, 12 Dec 2008 00:59:29 +0000 (00:59 +0000)]
[WinOF]
trunk\WinOF\WIX\{wlh,wnet,wxp}\*\wof.wxs
    Enable ia64 ConnectX (mlx4) HCA support in WinOF Installs.
    Setup winverbs.sys filter driver in WinOF\IBcore\
    Winverbs[ibverbs.dll] OFED verbs & OFED test pgms (ibv_read_bs & friends) installed by default.

trunk\WinOF\WIX\CustomActions.vbs
    Enable use of dpinst.exe for WLH variants; skip having to specify InfiniHost or ConnectX driver.
     Server 2003/XP/XP64 still need to specify 'which' HCA driver (see below).

    Support cmd-line msiexec installs:
      start/wait msiexec /I WOF.msi /passive NODRV=1 #install defaults except drivers (WDM support)

      (Server 2003/Xp64/XP ONLY - ignored for WLH)
      start/wait msiexec /I WOF.msi /passive HCA=cx  # Install ConnectX driver instead of InfiniHost.
      start/wait msiexec /I WOF.msi /passive HCA=+cx  # Install ConnectX and InfiniHost HCA drivers.

      start/wait msiexec /I WOF.msi /passive HCA=SRP  # add SRP driver to default install.
      start/wait msiexec /I WOF.msi /passive HCA=VNIC  # add SRP driver to default install.

trunk\winof\buildrelease.bat
    Rearrange varible set(s) so 'clean' can 'rmdir WinOF\WIX\{wlh,wnet,wxp}\bin'.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1787 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinOF,WinVerbs]
stansmith [Fri, 12 Dec 2008 00:57:21 +0000 (00:57 +0000)]
[WinOF,WinVerbs]
  makebin.bat - support winverbs & libibverbs.dll (OFED API) install
  etc\user\getopt.c - return '?' as error instead of EOF for missing option arg and other errors.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1786 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[TOOLS] fix a minor spacing typo.
stansmith [Fri, 12 Dec 2008 00:54:09 +0000 (00:54 +0000)]
[TOOLS] fix a minor spacing typo.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1785 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinVerbs] Added .rc files + mods to SOURCES to use .rc files.
stansmith [Fri, 12 Dec 2008 00:52:06 +0000 (00:52 +0000)]
[WinVerbs] Added .rc files + mods to SOURCES to use .rc files.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1784 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

11 years ago[WinVerbs] added .rc files to perftests; fixed missing hostname of '-h hostname'...
stansmith [Fri, 12 Dec 2008 00:42:33 +0000 (00:42 +0000)]
[WinVerbs] added .rc files to perftests; fixed missing hostname of '-h hostname' parsing.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1783 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] reset upon driver unload. [mlnx: 3546]
leonidk [Thu, 27 Nov 2008 13:38:57 +0000 (13:38 +0000)]
[MLX4] reset upon driver unload. [mlnx: 3546]

The patch improves the behavior of mst (with _pci_conf0, after mst stop & start)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1776 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MTHCA] bugfix in CMD interface: wait for GO bit before issuing command in polling...
leonidk [Thu, 27 Nov 2008 13:38:02 +0000 (13:38 +0000)]
[MTHCA] bugfix in CMD interface: wait for GO bit before issuing command in polling mode. [mlnx: 3313]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1775 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[IBBUS] workaround for some problems with WHQL PnP test over IPoIB. [mlnx: 3535]
leonidk [Thu, 27 Nov 2008 13:37:02 +0000 (13:37 +0000)]
[IBBUS] workaround for some problems with WHQL PnP test over IPoIB. [mlnx: 3535]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1774 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ALL] a fix to support debug print in Windows 2008. [mlnx: 3510]
leonidk [Thu, 27 Nov 2008 13:34:14 +0000 (13:34 +0000)]
[ALL] a fix to support debug print in Windows 2008. [mlnx: 3510]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1773 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] fixed application crash in case of IOCTL failure. [mlnx:3498]
leonidk [Thu, 27 Nov 2008 13:29:24 +0000 (13:29 +0000)]
[MLX4] fixed application crash in case of IOCTL failure. [mlnx:3498]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1772 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] Fixed QP memory leak, inserted in 1288 fix.
leonidk [Thu, 27 Nov 2008 13:25:33 +0000 (13:25 +0000)]
[MLX4] Fixed QP memory leak, inserted in 1288 fix.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1771 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] Fixed QP memory leak, inserted in 1288 fix.
leonidk [Thu, 27 Nov 2008 13:16:32 +0000 (13:16 +0000)]
[MLX4] Fixed QP memory leak, inserted in 1288 fix.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1770 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[opensm] Reduce the time needed to build opensm.
tzachid [Wed, 26 Nov 2008 08:59:38 +0000 (08:59 +0000)]
[opensm] Reduce the time needed to build opensm.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1769 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[WinOF] support dpinst.exe for WLH installs.
stansmith [Fri, 21 Nov 2008 22:15:36 +0000 (22:15 +0000)]
[WinOF] support dpinst.exe for WLH installs.
WLH wix files no longer require HCA type selection - let PNP load the correct driver.
start/wait msiexec /I WOF.msi /quiet  # now works for either InfiniHost or ConnectX only on WLH.
To address dpinst not working well for WNET/XP, HCA device type override now possible via HCA=cx or HCA=+cx
start/wait msiexec /I WOF.msi /quiet HCA=cx  # WNET/XP ConnectX HCA install from a single command line.
Support command line msiexec install for SRP or VNIC via SRP=1 and/or VNIC=1
start/wait msiexec /I WOF.msi /quiet SRP=1
Command line functionality documented in Release_notes.htm
WinOF WLH driver-less installs for HPC. Default WinOF install without .inf file processing, let WDM do driver installation.
start/wait msiexec /I WOF.msi /quiet NODRV=1

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1768 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[WinOF] use trunk\etc\bldwo.bat file instead of clunky etc\IB_*.bat file (will be...
stansmith [Fri, 21 Nov 2008 22:07:14 +0000 (22:07 +0000)]
[WinOF] use trunk\etc\bldwo.bat file instead of clunky etc\IB_*.bat file (will be removed ASAP).

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1767 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ND] match ND binaries used in WinOF 2.0
stansmith [Thu, 20 Nov 2008 23:06:18 +0000 (23:06 +0000)]
[ND] match ND binaries used in WinOF 2.0

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1766 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Don't put multicast entries in the dlid lists.
tzachid [Sun, 16 Nov 2008 13:36:32 +0000 (13:36 +0000)]
[ipoib] Don't put multicast entries in the dlid lists.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1765 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] Make the bus driver to start at boot and as part of the NDIS group.
leonidk [Sun, 16 Nov 2008 12:35:00 +0000 (12:35 +0000)]
[MLX4] Make the bus driver to start at boot and as part of the NDIS group.

It is needed for PXE boot.

Signed-off-by: tzachid@mellanox.co.il
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1764 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MTHCA] 1361 fix added a bug: now all applications, creating QP with zero receive...
leonidk [Thu, 13 Nov 2008 17:41:17 +0000 (17:41 +0000)]
[MTHCA] 1361 fix added a bug: now all applications, creating QP with zero receive QP size, will fail with send completion error.

This patch fixes that.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1761 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] Changed WPP GUID, which was accidentally equal to a MTHCA.
leonidk [Thu, 13 Nov 2008 17:33:02 +0000 (17:33 +0000)]
[MLX4] Changed WPP GUID, which was accidentally equal to a MTHCA.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1759 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ETC] saving getopt.c with DOS End-Of-Line instead of Linux EOL
stansmith [Thu, 13 Nov 2008 01:52:04 +0000 (01:52 +0000)]
[ETC] saving getopt.c with DOS End-Of-Line instead of Linux EOL

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1757 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[DAPL2] minor documentation update for the .bat file.
stansmith [Thu, 13 Nov 2008 00:42:09 +0000 (00:42 +0000)]
[DAPL2] minor documentation update for the .bat file.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1756 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[WinOF] script now understands trunk\WinOF instead of ..\branches\WinOF
stansmith [Thu, 13 Nov 2008 00:40:48 +0000 (00:40 +0000)]
[WinOF] script now understands trunk\WinOF instead of ..\branches\WinOF

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1755 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[WinOF] cleaning house - move trunk\buildrelease.bat --> trunk\WinOF
stansmith [Wed, 12 Nov 2008 23:41:00 +0000 (23:41 +0000)]
[WinOF] cleaning house - move trunk\buildrelease.bat --> trunk\WinOF

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1754 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[WinOF] move branches\WinOF to trunk.
stansmith [Wed, 12 Nov 2008 23:35:17 +0000 (23:35 +0000)]
[WinOF] move branches\WinOF to trunk.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1752 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Change network connection status when pkey added/removed in SM.
tzachid [Mon, 10 Nov 2008 18:04:52 +0000 (18:04 +0000)]
[ipoib] Change network connection status when pkey added/removed in SM.
Signed off by: anatolyg@voltaire.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1747 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Make sure that the dlid is zero if it is not in the list.
tzachid [Mon, 10 Nov 2008 17:12:07 +0000 (17:12 +0000)]
[ipoib] Make sure that the dlid is zero if it is not in the list.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1745 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Usa a DPC when we poll too much on recv DPC.
tzachid [Mon, 10 Nov 2008 16:49:06 +0000 (16:49 +0000)]
[ipoib] Usa a DPC when we poll too much on recv DPC.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1743 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[opensm] ignore and overwrite corrupted guid2lid file.
tzachid [Thu, 6 Nov 2008 20:24:37 +0000 (20:24 +0000)]
[opensm] ignore and overwrite corrupted guid2lid file.
signed off by: kliteyn@dev.mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1738 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Fix a bug on __recv_get_endpts.
tzachid [Thu, 6 Nov 2008 08:06:36 +0000 (08:06 +0000)]
[ipoib] Fix a bug on __recv_get_endpts.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1737 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[QLGCVNIC] fix for [Bug 1317] BSOD during reboot when using large MTU for VNIC.
aestrin [Wed, 5 Nov 2008 21:58:51 +0000 (21:58 +0000)]
[QLGCVNIC] fix for [Bug 1317] BSOD during reboot when using large MTU for VNIC.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1735 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Fix releasing a lock too early.
tzachid [Wed, 5 Nov 2008 17:08:18 +0000 (17:08 +0000)]
[ipoib] Fix releasing a lock too early.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1732 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Changed the guid_mask to GUIDMask (as read from registry).
tzachid [Tue, 4 Nov 2008 13:56:49 +0000 (13:56 +0000)]
[ipoib] Changed the guid_mask to GUIDMask (as read from registry).
        Setting GUIDMask to be non-required parameter.
Signed off by: xalex@mellanox.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1731 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Adding additional set of HP GUIDs.
tzachid [Tue, 4 Nov 2008 13:46:00 +0000 (13:46 +0000)]
[ipoib] Adding additional set of HP GUIDs.
Signed off by: reuven@mellanox.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1728 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Fix UDP checksum problem on windows 2008.
tzachid [Tue, 4 Nov 2008 13:41:55 +0000 (13:41 +0000)]
[ipoib] Fix UDP checksum problem on windows 2008.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1726 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Remove unused functions.
tzachid [Tue, 4 Nov 2008 13:36:11 +0000 (13:36 +0000)]
[ipoib] Remove unused functions.
Signed off by: reuven@mellanox.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1724 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[IBBUS] Fix hibernation mechanism, broken after converting IBBUS into filter driver...
leonidk [Sun, 2 Nov 2008 11:36:53 +0000 (11:36 +0000)]
[IBBUS] Fix hibernation mechanism, broken after converting IBBUS into filter driver. [mlnx:3409]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1721 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[IBAL] add WR_LSO to _ib_wr_type_str array. [mlnx: 3391]
leonidk [Sat, 1 Nov 2008 22:06:40 +0000 (22:06 +0000)]
[IBAL] add WR_LSO to _ib_wr_type_str array. [mlnx: 3391]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1719 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[ipoib] Fix referencing the lists without locks.
tzachid [Sat, 1 Nov 2008 18:03:56 +0000 (18:03 +0000)]
[ipoib] Fix referencing the lists without locks.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1717 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[DOCS] WinOF 2.0 items: IPoIB partition mgmt & Network Direct
stansmith [Thu, 30 Oct 2008 17:35:25 +0000 (17:35 +0000)]
[DOCS] WinOF 2.0 items: IPoIB partition mgmt & Network Direct

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1716 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

12 years ago[MLX4] improved error logging: write command failures to Event Log with error code...
leonidk [Thu, 30 Oct 2008 15:09:53 +0000 (15:09 +0000)]
[MLX4] improved error logging: write command failures to Event Log with error code, returned by HW. [mlnx: 3405]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1714 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86