14 years ago[TOOLS] bugfix in latency tests.
leonidk [Tue, 7 Oct 2008 14:57:45 +0000 (14:57 +0000)]
[TOOLS] bugfix in latency tests.

The tests didn't take into account that the time stamping function (QueryPerformanceCounter) can take a lot of time.
But in Win2008 in takes more than 1.1 usec, which causes printing latency value 1.1 usec more than it really is !

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1635 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] Limit the number of retries to connect to broadcast group. (mlnx: 3287)
tzachid [Tue, 7 Oct 2008 08:07:35 +0000 (08:07 +0000)]
[ipoib] Limit the number of retries to connect to broadcast group. (mlnx: 3287)
Part_man.exe – added check for pkey with partial membership. Such a values is not supported in current version.
signed off by: slavas@voltaire.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1633 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL] revert 1574, returning check_av_port. it will work after implementing query_qp...
leonidk [Sun, 5 Oct 2008 19:37:53 +0000 (19:37 +0000)]
[IBAL] revert 1574, returning check_av_port. it will work after implementing query_qp in MTHCA. [mlnx: 3136]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1631 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] add query_qp support. [mlnx: 3138, 3150]
leonidk [Sun, 5 Oct 2008 19:29:40 +0000 (19:29 +0000)]
[MTHCA] add query_qp support. [mlnx: 3138, 3150]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1630 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fix in calculating of the number of HCA physical ports. [mlnx: 3277,3279]
leonidk [Sun, 5 Oct 2008 19:17:22 +0000 (19:17 +0000)]
[MLX4] fix in calculating of the number of HCA physical ports. [mlnx: 3277,3279]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1629 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] more clean allocation of WRID array (replaces 1624-1625).
leonidk [Thu, 2 Oct 2008 09:25:20 +0000 (09:25 +0000)]
[MLX4] more clean allocation of WRID array (replaces 1624-1625).

Signed-off_by: Alex Estrin

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1627 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fail QP creation when both SQ & RQ are of zero size (fix to 1625)
leonidk [Thu, 2 Oct 2008 08:27:14 +0000 (08:27 +0000)]
[MLX4] fail QP creation when both SQ & RQ are of zero size (fix to 1625)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1626 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] skip allocation of WRID array for zero-size RQ or SQ.
leonidk [Sun, 28 Sep 2008 15:11:13 +0000 (15:11 +0000)]
[MLX4] skip allocation of WRID array for zero-size RQ or SQ.

Suggested by: Alex Estrin

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1625 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] fixed error code. [mlnx: 3250]
leonidk [Sun, 28 Sep 2008 14:23:42 +0000 (14:23 +0000)]
[MTHCA] fixed error code. [mlnx: 3250]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1624 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] Enable Event Log writing on DISPATCH_LEVEL
leonidk [Thu, 25 Sep 2008 14:01:31 +0000 (14:01 +0000)]
[MLX4] Enable Event Log writing on DISPATCH_LEVEL

The patch replaces a standard buffer conversion function, requiring PASSIVE_LEVEL, by a home-made one, which doesn't.
It prevents reported crash upon fatal error handling.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1619 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] This patch reuses ipoib_mac_from_general_guid and contains important bugfix...
leonidk [Wed, 24 Sep 2008 18:03:19 +0000 (18:03 +0000)]
[IPoIB] This patch reuses ipoib_mac_from_general_guid and contains important bugfix. [mlnx: 3222, 3226, 3228]

Signed-off by: Alexander Naslednikov

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1608 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] This patch adds support for user-define mask for generic mac generation....
leonidk [Wed, 24 Sep 2008 17:48:31 +0000 (17:48 +0000)]
[IPoIB] This patch adds support for user-define mask for generic mac generation. [mlnx: 3215]

Signed-off by: Alexander Naslednikov

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1606 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] This patch adds support for new GUID type. [mlnx: 3213-3214]
leonidk [Wed, 24 Sep 2008 17:40:50 +0000 (17:40 +0000)]
[IPoIB] This patch adds support for new GUID type. [mlnx: 3213-3214]

Signed-off by: Alexander Naslednikov

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1604 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] fix ref counter indexes enumeration.
leonidk [Thu, 18 Sep 2008 16:09:10 +0000 (16:09 +0000)]
[IPoIB] fix ref counter indexes enumeration.

Signed-off-by: Alex Estrin
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1602 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBBUS] remove overzealous and redundant use of __FUNCTION__ in debug prints; get...
stansmith [Mon, 15 Sep 2008 17:54:03 +0000 (17:54 +0000)]
[IBBUS] remove overzealous and redundant use of __FUNCTION__ in debug prints; get with the BUS_ENTER/EXIT program.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1601 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBBUS] Add back invalidation of Device Removal Relations as they were incorrectly...
stansmith [Mon, 15 Sep 2008 16:50:37 +0000 (16:50 +0000)]
[IBBUS] Add back invalidation of Device Removal Relations as they were incorrectly removed in the transition to a filter driver; both trunk and WOF2-0.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1598 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] release allocated buffer.
tzachid [Thu, 11 Sep 2008 21:43:34 +0000 (21:43 +0000)]
[ipoib] release allocated buffer.
Signed off by: alex.estrin@qlogic.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1596 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ND] ND binaries rev from Mellanox internal tree (Reuven)
stansmith [Wed, 10 Sep 2008 22:12:49 +0000 (22:12 +0000)]
[ND] ND binaries rev from Mellanox internal tree (Reuven)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1593 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[TESTS] removed incorrect setting of remote_ops in send WR. [mlnx: 3156]
leonidk [Wed, 10 Sep 2008 17:11:02 +0000 (17:11 +0000)]
[TESTS] removed incorrect setting of remote_ops in send WR. [mlnx: 3156]

After changing of send WR format remote_ops share the place with UD parameters and they cannot be set simultaneously with them.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1588 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoImproved partion manager prints.
tzachid [Wed, 10 Sep 2008 16:09:29 +0000 (16:09 +0000)]
Improved partion manager prints.
signed off by: Slava Strebkov [slavas@voltaire.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1587 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4, MTHCA, IPoIB] Reuse of receive options for checksum value.
tzachid [Wed, 10 Sep 2008 16:00:16 +0000 (16:00 +0000)]
[MLX4, MTHCA, IPoIB] Reuse of receive options for checksum value.
Signed off by: xalex@mellanox.co.il & alex.estrin@qlogic.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1583 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA, MLX4, IPoIB] Checksum (Csum) offload bugfix.
tzachid [Wed, 10 Sep 2008 15:57:16 +0000 (15:57 +0000)]
[MTHCA, MLX4, IPoIB] Checksum (Csum) offload bugfix.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1582 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL, MTHCA] fix the work with av with valid grh. [mlnx: 3077]
leonidk [Wed, 10 Sep 2008 12:44:47 +0000 (12:44 +0000)]
[IBAL, MTHCA] fix the work with av with valid grh. [mlnx: 3077]

The patch fix the behavior of av verbs in case that sgid isn't found at the gid_table.
Instead of exit with IB_INVALID_GID it sets the index to 0. Please note IB spec regarding av verbs definition.

The patch also used grh.resv2 (rather than resv1) to avoid C4328 warning (improper member alignment).

Signed-off-by: Reuven Amitai reuven@mellanox.co.il
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1581 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB]
stansmith [Tue, 9 Sep 2008 18:43:23 +0000 (18:43 +0000)]
  netipoib.inx - OpenIB --> OpenFabrics name change
  netipoib-xp32.inf - match netipoib.inx (except for 32-bit issues) DriverVer updated.
[WinOF] makebin.bat - updated to include free driver symbol files (.pdb) in std WinOF release.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1578 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[AL] disable check_av_port due to mthca proble. When registering mad svc, port num...
tzachid [Tue, 9 Sep 2008 12:41:57 +0000 (12:41 +0000)]
[AL] disable check_av_port due to mthca proble. When registering mad svc, port num is zero because ibv_query_qp retrun '0' as primary port. (mlnx: 3131)
signed off by: Reuven@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1574 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] Fix a bug in check sum mechanism. (mlnx: 3123)
tzachid [Mon, 8 Sep 2008 07:50:25 +0000 (07:50 +0000)]
[ipoib] Fix a bug in check sum mechanism. (mlnx: 3123)
Signed off by: anatolyg@voltaire.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1573 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoFixing issue no. 1159 in bugzilla (mlnx: 3111)
tzachid [Mon, 8 Sep 2008 07:38:07 +0000 (07:38 +0000)]
Fixing issue no. 1159 in bugzilla (mlnx: 3111)
Signed of by:xalex@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1570 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] Fixing a warning.
tzachid [Mon, 8 Sep 2008 07:36:56 +0000 (07:36 +0000)]
[MTHCA] Fixing a warning.
signed off by:xalex@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1569 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPOIB, MLX4] Improving checksum mechanism (mlnx: 3107)
tzachid [Mon, 8 Sep 2008 07:34:32 +0000 (07:34 +0000)]
[IPOIB, MLX4] Improving checksum mechanism (mlnx: 3107)
Signed off by:xalex

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1566 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] Adding checksum support to mthca driver. (mlnx: 3106)
tzachid [Mon, 8 Sep 2008 07:33:26 +0000 (07:33 +0000)]
[MTHCA] Adding checksum support to mthca driver. (mlnx: 3106)
signed off by: xalex@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1565 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL,IPOIB] (mlnx: 3105)
tzachid [Mon, 8 Sep 2008 07:31:21 +0000 (07:31 +0000)]
[IBAL,IPOIB] (mlnx: 3105)
Restoring vendor_specific field
Signed off by: xalex@mellanox.co.il

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1563 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPOIB] fix IPoIB connectivity when IB switch is configured with lmc > 0.
tzachid [Mon, 8 Sep 2008 06:56:31 +0000 (06:56 +0000)]
[IPOIB] fix IPoIB connectivity when IB switch is configured with lmc > 0.
signed off by: slavas@voltaire.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1561 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[COMPLIB] Removed, happened ASSERT during shutdown sequence. [mlnx: 2955]
leonidk [Sun, 7 Sep 2008 15:08:57 +0000 (15:08 +0000)]
[COMPLIB] Removed, happened ASSERT during shutdown sequence. [mlnx: 2955]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1559 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fixed a bug in "livefish" mode. [mlnx: 3091]
tzachid [Sun, 7 Sep 2008 14:58:00 +0000 (14:58 +0000)]
[MLX4] fixed a bug in "livefish" mode. [mlnx: 3091]

The bug was in returning wrong query_ca results, which caused crashes in some scenarios and incorrect work of applications.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1556 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF]
stansmith [Fri, 5 Sep 2008 17:02:26 +0000 (17:02 +0000)]
  inc/oib_ver.h - VER_LEGALCOPYRIGHT_STR updated for 2008
  inc/openib.def - VER_PROVIDER - OpneIB --> OpenFabrics
[ND] ulp\nd\user\SOURCES place fake binaries correctly in trunk\bin not ulp\bin.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1554 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] reverted changes made by mistake.
aestrin [Fri, 5 Sep 2008 15:26:43 +0000 (15:26 +0000)]
[IPoIB] reverted changes made by mistake.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1551 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoIPoIB CM updated to trunk rev 1499
aestrin [Fri, 5 Sep 2008 14:18:09 +0000 (14:18 +0000)]
IPoIB CM updated to trunk rev 1499

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1549 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoupdated to trunk rev 1341
aestrin [Thu, 4 Sep 2008 22:35:14 +0000 (22:35 +0000)]
updated to trunk rev 1341

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1548 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fixed bug, causing crash in "livefish" mode. [mlnx: 3053]
leonidk [Mon, 1 Sep 2008 17:24:37 +0000 (17:24 +0000)]
[MLX4] fixed bug, causing crash in "livefish" mode. [mlnx: 3053]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1542 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[part_man] Removing unnecessary prints.
tzachid [Mon, 1 Sep 2008 14:06:08 +0000 (14:06 +0000)]
[part_man] Removing unnecessary prints.
signed off by:Slava Strebkov [slavas@voltaire.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1540 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL] fix using of ual_get_gid_index()
leonidk [Mon, 1 Sep 2008 12:47:58 +0000 (12:47 +0000)]
[IBAL] fix using of ual_get_gid_index()

The patch fixes accessing p_user_attr field which lead to access violation, the actual field is p_pnp_attr.
It also moves port checking to the head of the function stack.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1539 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agogit-svn-id: svn://openib.tc.cornell.edu/gen1/branches/trunk@1531 ad392aa1-c5ef-ae45...
stansmith [Wed, 27 Aug 2008 17:01:46 +0000 (17:01 +0000)]
git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/trunk@1531 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL] add sanity check for port_num field in av verbs. [mlnx: 3052]
leonidk [Wed, 27 Aug 2008 16:56:46 +0000 (16:56 +0000)]
[IBAL] add sanity check for port_num field in av verbs. [mlnx: 3052]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1530 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] clean ibv_context (mutex is redundant since p_ca_attr was removed) [mlnx:...
leonidk [Wed, 27 Aug 2008 16:53:54 +0000 (16:53 +0000)]
[MLX4] clean ibv_context (mutex is redundant since p_ca_attr was removed) [mlnx: 3051]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1529 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agogit-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1528 ad392aa1-c5ef-ae45...
stansmith [Wed, 27 Aug 2008 16:41:03 +0000 (16:41 +0000)]
git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1528 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agogit-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1526 ad392aa1-c5ef-ae45...
stansmith [Wed, 27 Aug 2008 16:35:48 +0000 (16:35 +0000)]
git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1526 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agogit-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1525 ad392aa1-c5ef-ae45...
stansmith [Wed, 27 Aug 2008 16:28:20 +0000 (16:28 +0000)]
git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1525 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF] fighting with svn to get a branch of trunk....
stansmith [Wed, 27 Aug 2008 15:44:49 +0000 (15:44 +0000)]
[WinOF] fighting with svn to get a branch of trunk....

git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1522 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[winof] marginal tool
stansmith [Wed, 27 Aug 2008 00:48:24 +0000 (00:48 +0000)]
[winof] marginal tool

git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1521 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF] branching into 2.0 release tree
stansmith [Wed, 27 Aug 2008 00:36:27 +0000 (00:36 +0000)]
[WinOF] branching into 2.0 release tree

git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1520 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WInOF]
stansmith [Wed, 27 Aug 2008 00:34:00 +0000 (00:34 +0000)]

git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1519 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF] 2.0 root
stansmith [Wed, 27 Aug 2008 00:32:54 +0000 (00:32 +0000)]
[WinOF] 2.0 root

git-svn-id: svn://openib.tc.cornell.edu/gen1/branches/WOF2-0@1518 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBBUS] reconstituted omitted commits from 1499.
stansmith [Tue, 26 Aug 2008 19:01:49 +0000 (19:01 +0000)]
[IBBUS] reconstituted omitted commits from 1499.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1516 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] Add support for large send offload in ipoib. (mlnx 3044)
tzachid [Tue, 26 Aug 2008 17:37:19 +0000 (17:37 +0000)]
[ipoib] Add support for large send offload in ipoib. (mlnx 3044)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1515 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[mlx4] Add support for large send offload in mlx4. (mlnx: 3041)
tzachid [Tue, 26 Aug 2008 17:36:39 +0000 (17:36 +0000)]
[mlx4] Add support for large send offload in mlx4. (mlnx: 3041)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1514 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ibal] Add support for large send offload. [mlnx: 3040]
tzachid [Tue, 26 Aug 2008 17:35:52 +0000 (17:35 +0000)]
[ibal] Add support for large send offload. [mlnx: 3040]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1513 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[mlx4] Prepare for support in msi for windows 2008
tzachid [Tue, 26 Aug 2008 13:06:18 +0000 (13:06 +0000)]
[mlx4] Prepare for support in msi for windows 2008

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1512 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[mlx4] Add support for Yatir (more device ids)
tzachid [Tue, 26 Aug 2008 12:32:12 +0000 (12:32 +0000)]
[mlx4] Add support for Yatir (more device ids)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1511 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] erge MR and FMR space on 64-bit systems (mlnx: 2960)
tzachid [Tue, 26 Aug 2008 11:53:56 +0000 (11:53 +0000)]
[MTHCA] erge MR and FMR space on 64-bit systems (mlnx: 2960)
(Linux, 13/02/07, Michael S. Tsirkin, commit: c20e20ab0f3af9a44842ea11287c9ecd034a5d33)

For Tavor, we currently reserve separate MPT and MTT space for FMRs to
avoid abusing the vmalloc space on 32 bit kernels. No such problem
exists on 64 bit kernels so let's not do it there.

This way we have a shared pool for MR and FMR resources, used on
demand.  This will also make it possible to write MTTs for regular
regions directly from driver.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1510 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] Give reserved MTTs a separate cache line (mlnx: 2959)
tzachid [Tue, 26 Aug 2008 11:53:05 +0000 (11:53 +0000)]
[MTHCA] Give reserved MTTs a separate cache line (mlnx: 2959)
(Linux, 13/02/07, Michael S. Tsirkin, commit: 1d1f19cfce7687b557cebdc41bf8a5eeba8a9882)

MTTs are allocated in non-cache-coherent memory, so we must give
reserved MTTs their own cache line, to prevent both device and
CPU from writing into the same cache line at the same time.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1509 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] Fix reserved MTTs calculation on mem-free HCAs (mlnx 2958)
tzachid [Tue, 26 Aug 2008 11:51:37 +0000 (11:51 +0000)]
[MTHCA] Fix reserved MTTs calculation on mem-free HCAs (mlnx 2958)
(Linux, 13/02/07, Michael S. Tsirkin, commit: c7d204e8fdf02f88d91707213f473805bcfb977b)

The reserved_mtts field has different meaning in Tavor and Arbel, so
we are wasting mtt entries on memfree. Fix the Arbel case to match
Tavor semantics.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1508 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] Fix off-by-one in FMR handling on memfree (mlnx: 2957)
tzachid [Tue, 26 Aug 2008 11:50:45 +0000 (11:50 +0000)]
[MTHCA] Fix off-by-one in FMR handling on memfree (mlnx: 2957)
(Linux, 05/01/07, Michael S. Tsirkin, commit: 46707e96b7254663139225ab6c9ab9922cd8c435)

mthca_table_find() will return the wrong address when the table entry
being searched for is exactly at the beginning of a sglist entry
(other than the first), because it uses >= when it should use >.

Example: assume we have 2 entries in scatterlist, 4K each, offset is
4K.  The current code will return first entry + 4K when we really want
the second entry.

In particular this means mapping an FMR on a memfree HCA may end up
writing the page table into the wrong place, leading to memory
corruption and also causing the HCA to use an incorrect address
translation table.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1507 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBBUS] bus_port_mgr.c: resolve mysterious/unannounced port_guid_pkey --> port_guid_p...
stansmith [Tue, 26 Aug 2008 00:20:11 +0000 (00:20 +0000)]
[IBBUS] bus_port_mgr.c: resolve mysterious/unannounced port_guid_pkey --> port_guid_pkey_t typedef change.
bus_driver.c: missing function bus_rem_pkey() - hacked in missing stub routine in order to build.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1506 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[CORE] ibbus as an upper class HCA filter
stansmith [Mon, 25 Aug 2008 22:05:17 +0000 (22:05 +0000)]
[CORE] ibbus as an upper class HCA filter


git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1504 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[tests] add option to run ib_send_bw with events. (mlnx 3032)
tzachid [Mon, 25 Aug 2008 21:11:34 +0000 (21:11 +0000)]
[tests] add option to run ib_send_bw with events. (mlnx 3032)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1503 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinVerbs] set winverbs.cat for driver signing of winverbs.sys
stansmith [Mon, 25 Aug 2008 20:03:45 +0000 (20:03 +0000)]
[WinVerbs] set winverbs.cat for driver signing of winverbs.sys

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1502 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinVerbs] add the catalogue definition file - required for signing the winverbs...
stansmith [Mon, 25 Aug 2008 19:34:52 +0000 (19:34 +0000)]
[WinVerbs] add the catalogue definition file - required for signing the winverbs.sys driver (winverbs.cat)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1501 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinVerbs] sychronize IB class name IfniniBandController with Microsoft's view.
stansmith [Mon, 25 Aug 2008 19:27:03 +0000 (19:27 +0000)]
[WinVerbs] sychronize IB class name IfniniBandController with Microsoft's view.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1500 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib,core] Improve support for partitioning.
tzachid [Mon, 25 Aug 2008 14:00:59 +0000 (14:00 +0000)]
[ipoib,core] Improve support for partitioning.
signed off by: Slava Strebkov [mailto:slavas@voltaire.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1499 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[mlx4] Fixed improper zero-memory allocation.
tzachid [Mon, 25 Aug 2008 12:57:47 +0000 (12:57 +0000)]
[mlx4] Fixed improper zero-memory allocation.
signed-off by: xalex (Alexander Naslednikov)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1498 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] fix for receiving mcast and bcast. (mlnx: 3023)
tzachid [Sun, 24 Aug 2008 08:11:57 +0000 (08:11 +0000)]
[ipoib] fix for receiving mcast and bcast. (mlnx: 3023)
signed off by: Slava Strebkov [slavas@voltaire.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1497 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] misplaced file removed; appears to be a copy of core\bus\kernel\ib_bus32...
stansmith [Thu, 21 Aug 2008 21:17:14 +0000 (21:17 +0000)]
[MTHCA] misplaced file removed; appears to be a copy of core\bus\kernel\ib_bus32.cdf.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1495 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IPoIB] added ndinstall.exe as part of the ipoib install.
stansmith [Thu, 21 Aug 2008 19:42:59 +0000 (19:42 +0000)]
[IPoIB] added ndinstall.exe as part of the ipoib install.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1494 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL] bumps up the CI and AL interface version numbers to account for changes in...
tzachid [Thu, 21 Aug 2008 17:53:29 +0000 (17:53 +0000)]
[IBAL] bumps up the CI and AL interface version numbers to account for changes in structures used in those interfaces made in past revisions.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1492 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF] support ND on all architectures. Setup Winverbs files for WIX install.
stansmith [Thu, 21 Aug 2008 17:48:00 +0000 (17:48 +0000)]
[WinOF] support ND on all architectures. Setup Winverbs files for WIX install.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1491 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WINVERBS] support Winverbs installation - retarget .inf file to be co-resident with...
stansmith [Thu, 21 Aug 2008 17:09:16 +0000 (17:09 +0000)]
[WINVERBS] support Winverbs installation - retarget .inf file to be co-resident with windverbs.sys file.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1490 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[CORE\IOU] add support for ib_iou.cdf & ib_iou.inf files
stansmith [Thu, 21 Aug 2008 16:18:43 +0000 (16:18 +0000)]
[CORE\IOU] add support for ib_iou.cdf & ib_iou.inf files

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1489 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[CORE\IOU] added following files:
stansmith [Thu, 21 Aug 2008 16:08:42 +0000 (16:08 +0000)]
[CORE\IOU] added following files:
  ib_iou.cdf - for driver signing
  ib_iou.inx - for ibiou.sys installation; IOU relevant items
  makefile.inx - for creation of and date/time stamping ib_iou.inf file.
 Added to SOURCES files the rules required to create ib_iou.inf file.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1488 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ND] added fre_svr-03_ia64 binaries, which are really fre_svr-03_x86 binaries.
stansmith [Thu, 21 Aug 2008 15:59:00 +0000 (15:59 +0000)]
[ND] added fre_svr-03_ia64 binaries, which are really fre_svr-03_x86 binaries.
replaced fre_svr-08_ia64 binaries with fre_svr-08_x86 binaries.
Reason for replacement is due to changes in netipoib.inf, now that ndinstall.exe is always installed, so when uninstalling, the installer doesn't know if ND was started or not (ndinstall.exe is always present) so it assumes a need to remove ND ala 'ndinstall -r'. Since ND is yet to be supported on ia64 and I did not want to special case ia64 in the uninstall path, it turns out the x86 ndinstall.exe executes fine on ia64.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1487 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ND] added XP_x86 binaries to fake build env.
stansmith [Fri, 15 Aug 2008 17:25:56 +0000 (17:25 +0000)]
[ND] added XP_x86 binaries to fake build env.
renamed objfre_svr* --> fre_svr* to make it easier to identify ND binary folders from build generated folders.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1483 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] some fixes to support the mixed IB/Eth mode. (mlnx: 2947,2949)
leonidk [Thu, 14 Aug 2008 18:45:08 +0000 (18:45 +0000)]
[MLX4] some fixes to support the mixed IB/Eth mode. (mlnx: 2947,2949)

The only mixed configuration, supported now, is port1-IB, port2-Eth.
To work with it one has to burn FW with parameter 'dpdp_en=true' in INI file, for example MHGH28-XSC_A4-A5.ini.

ib_query_ca returns now the number of IB- and not physical ports. So VSTAT will show only one port and IBBUS will create only one IPoIB adapter.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1482 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoThe mlx4 hca driver should install as an InfiniBandHca class driver,
shefty [Wed, 13 Aug 2008 19:31:04 +0000 (19:31 +0000)]
The mlx4 hca driver should install as an InfiniBandHca class driver,
rather than inventing its own class.  This allows filter drivers to
reside above both the mthca and mlx4 drivers.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1481 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fixed mechanism of mlx4_hca's asynchronous events notification.
leonidk [Tue, 12 Aug 2008 18:34:39 +0000 (18:34 +0000)]
[MLX4] fixed mechanism of mlx4_hca's asynchronous events notification.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1480 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[IBAL] Fix UAL_NDI_NOOP handling
leonidk [Tue, 12 Aug 2008 08:23:29 +0000 (08:23 +0000)]
[IBAL] Fix UAL_NDI_NOOP handling

The NOOP IOCTL allows the ND provider to complete requests asynchronously when a synchronous operation completes in user-land.  This is used for memory registration and deregistration, as well as for connection establishment when ARP resolution is in progress (IBAT returns E_PENDING) in the NetworkDirect provider.  In the latter case, the expectation is that the IOCTL will complete asynchronously with STATUS_TIMEOUT.  However the code processes the IOCTL synchronously, so the IOCTL fails with an immediate error rather than an asynchronous error.

This patch completes the IRP so that it's completion will be reported asynchronously.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1479 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agomlx4: add winverbs support
shefty [Mon, 11 Aug 2008 16:17:04 +0000 (16:17 +0000)]
mlx4: add winverbs support

Export the mlx4 channel interface via PnP query interface calls.  This allows the driver to export its channel interface to multiple drivers, such as WinVerbs.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1477 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agomlx4: fix line endings to windows format
shefty [Mon, 11 Aug 2008 16:12:58 +0000 (16:12 +0000)]
mlx4: fix line endings to windows format

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1476 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] added support for Condor_G2 device
leonidk [Mon, 11 Aug 2008 14:31:22 +0000 (14:31 +0000)]
[MLX4] added support for Condor_G2 device

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1474 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fixed a typo
leonidk [Mon, 11 Aug 2008 13:04:34 +0000 (13:04 +0000)]
[MLX4] fixed a typo

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1473 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MTHCA] removed debug code, which disabled cache update mechanism
leonidk [Mon, 11 Aug 2008 12:54:05 +0000 (12:54 +0000)]
[MTHCA] removed debug code, which disabled cache update mechanism

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1472 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ND] add fake ND build support; to be removed when ND src hits svn.
stansmith [Sat, 9 Aug 2008 00:11:54 +0000 (00:11 +0000)]
[ND] add fake ND build support; to be removed when ND src hits svn.
  Turn down tracing volume
  New Commands: assist in handling large # of WinOF installers.
    msi-label {tag}
       rename .msi files to WOF_os*_arch*tag; frequently svn version #
       delete .msi installers containing this tag
       directory listing of current WinOF .msi installers

    ND installation
    32 versions .cdf files
    Less tracing noise!
    Added comments.

  dirs - added nd to the build

  dirs - added user to the build
  user\ - ugly hack until ND sources show up in svn - pending legal issues with MS
     objfre_svr-03_amd64 - ND binaries from Mellanox
     objfre_svr-08_ia64 - side-steps ia64 ipoib.cdf & ipoib.inx install issues; actually x64 copies.

  ipoib32.cdf - support ND signing for 32 bit systems
  ipoib32-xp.cdf - support XP32 signing
  ipoib.cdf - ND signing
  netipoib.inx - ND install
  netipoib-xp32.inf - XP32 install, no WSD/ND

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1470 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[ipoib] Added receive statistics for ipoib. (mlnx: 2945)
tzachid [Wed, 6 Aug 2008 14:07:28 +0000 (14:07 +0000)]
[ipoib] Added receive statistics for ipoib. (mlnx: 2945)
signed by: Slava Strebkov [slavas@voltaire.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1467 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoadded missing catalogue files
leonidk [Tue, 5 Aug 2008 13:15:15 +0000 (13:15 +0000)]
added missing catalogue files

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1466 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years agoFix winverbs build for XP.
shefty [Mon, 4 Aug 2008 20:51:57 +0000 (20:51 +0000)]
Fix winverbs build for XP.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1464 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] added HCA Soft Reset mechanism (used by Ethernet interface so far)
leonidk [Mon, 4 Aug 2008 16:18:23 +0000 (16:18 +0000)]
[MLX4] added HCA Soft Reset mechanism (used by Ethernet interface so far)

Soft Reset here is HCA re-initialization without bus driver reloading.
A reset can be initiated by clients (mlx4_eth, mlx4_hca) and/or driver (mlx4_bus).
Driver issues reset upon card fatal error, which prevents the following work with the card.
Clients may request the reset at any moment upon their will.

Clients have to register event callback after getting bus interface.

When a reset event comes, the bus driver will:
   - bar the following work with card, returning –EFAULT to all, but destroy_xx, commands;
   - reset the card to stop incoming traffic (only in case of client-initiated reset);
   - notify all registered clients about pending reset.

Getting this notification clients have to:
   - wait for all issued commands to end;
   - reset its own clients, if any, and bar their work;
   - release all the device resources, they were using till now;
   - send “I’m reset-ready” notification to the bus driver;

The driver starts to perform device reset only after receiving the “I’m reset-ready” notifications from all the registered clients. It re-initializes the device and notifies all the clients.

Having received this notification, clients have to:
   - dereference the old bus interface;
   - get the new interface from bus driver;
   - register new event handler;
   - resume/restart itself;
   - wake up its own clients, if any;

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1463 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] added Hibernate/Standby support. (mlnx: 2906)
leonidk [Mon, 4 Aug 2008 12:23:51 +0000 (12:23 +0000)]
[MLX4] added Hibernate/Standby support. (mlnx: 2906)

Mellanox HCA cards do not have Power Management support so far.
So MLX4 driver resets the card on power-down  and starts its back on power-up.
Pay attention, one can go to Standby/Hibernate only when there is no running IB applications (including WSD).
Otherwise he will get an error window with a message like: "Driver mlx4_hca.sys refuses to go Hibernate/Standby".
MTHCA driver behaves upon Hibernate/Standby the same way.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1462 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] bugfix: mlx4_hca was compiled without USE_WDM_INTERRUPTS, which caused it...
leonidk [Mon, 4 Aug 2008 12:00:17 +0000 (12:00 +0000)]
[MLX4] bugfix: mlx4_hca was compiled without USE_WDM_INTERRUPTS, which caused it to see 'struct pci_dev' differently than mlx4_bus.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1461 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[MLX4] fixed a memory leak in mlx4_bus driver. (mlnx: 2886, 2890)
leonidk [Mon, 4 Aug 2008 11:48:05 +0000 (11:48 +0000)]
[MLX4] fixed a memory leak in mlx4_bus driver. (mlnx: 2886, 2890)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1460 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[OPENSM] adjust OPENSM to changed types of the stack.
leonidk [Sun, 3 Aug 2008 08:44:29 +0000 (08:44 +0000)]
[OPENSM] adjust OPENSM to changed types of the stack.

To recall, OPENSM uses it's own pair of files ib_types.h/ib_types_extended.h instead of the stack's ib_types.h.
So all the changes of 'trunk\inc\iba\ib_types.h' should be repeated in the OPENSM's files.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1458 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[HW] fixed a bug in context values handling in new event notification mechanism ...
leonidk [Sun, 3 Aug 2008 08:37:30 +0000 (08:37 +0000)]
[HW] fixed a bug in context values handling in new event notification mechanism (addded in patch 1435).

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1457 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

14 years ago[WinOF] buildrelease.bat usages of 'C:' changed to '%SystemDrive%'.
stansmith [Mon, 28 Jul 2008 18:49:15 +0000 (18:49 +0000)]
[WinOF] buildrelease.bat usages of 'C:' changed to '%SystemDrive%'.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1452 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86