13 years ago[DAPL2] added requirement and code to enforce using delayed env. var expansion. Used...
stansmith [Tue, 8 Jul 2008 18:21:32 +0000 (18:21 +0000)]
[DAPL2] added requirement and code to enforce using delayed env. var expansion. Used to config EP tests: threads & EPs.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1348 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[SRP] added INX -> INF file version stamping.
stansmith [Tue, 8 Jul 2008 18:19:10 +0000 (18:19 +0000)]
[SRP] added INX -> INF file version stamping.
INF file created in ..\..\..\bin\kernel\xxx\
.inf file version now matches .sys file version.
added makefile.inc
ib_srp.inf renamed to ib_srp.inx per MS/WDK convention.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1347 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IPOIB] added INX -> INF file version stamping.
stansmith [Tue, 8 Jul 2008 18:17:07 +0000 (18:17 +0000)]
[IPOIB] added INX -> INF file version stamping.
INF file created in ..\..\..\bin\kernel\xxx
.inf file version now matches .sys file version.
added makefile.inc
netipoib.inf renamed to netipoib.inx per MS/WDK convention.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1346 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBBUS] Removed extra MS example baggage MISCFILES
stansmith [Tue, 8 Jul 2008 18:10:43 +0000 (18:10 +0000)]
[IBBUS] Removed extra MS example baggage MISCFILES

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1345 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[VNIC] Removed extra MS example baggage MISCFILES
stansmith [Tue, 8 Jul 2008 18:09:41 +0000 (18:09 +0000)]
[VNIC] Removed extra MS example baggage MISCFILES

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1344 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[ipoib] Add support for another mlnx series of GUIDs.
tzachid [Tue, 8 Jul 2008 14:51:08 +0000 (14:51 +0000)]
[ipoib] Add support for another mlnx series of GUIDs.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1343 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IPOIB, MLX4] Enabling the use of 4K MTU on ipoib.
tzachid [Tue, 8 Jul 2008 14:36:14 +0000 (14:36 +0000)]
[IPOIB, MLX4] Enabling the use of 4K MTU on ipoib.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1342 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[ipoib] Fix for improper handling of IPoIB params
tzachid [Tue, 8 Jul 2008 14:34:09 +0000 (14:34 +0000)]
[ipoib]  Fix for improper handling of IPoIB params
signed by:xalex

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1341 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[QLGCVNIC] added INX -> INF file stamping. INF file created in ..\..\..\bin\kernel\xxx
stansmith [Mon, 7 Jul 2008 22:05:30 +0000 (22:05 +0000)]
[QLGCVNIC] added INX -> INF file stamping. INF file created in ..\..\..\bin\kernel\xxx
.inf file version now matches .sys file version.
added file makefile.inc
netvnic.inf renamed to netvnic.inx per MS/WDK convention.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1340 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBBUS] added INX -> INF file stamping. INF file created in ..\..\..\bin\kernel\xxx
stansmith [Mon, 7 Jul 2008 18:48:02 +0000 (18:48 +0000)]
[IBBUS] added INX -> INF file stamping. INF file created in ..\..\..\bin\kernel\xxx
.inf file version now matches .sys file version.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1338 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[CORE] openib.def now includes mod_ver.def to retrieve IB_MAJORVERSION & IB_MINORVERS...
stansmith [Mon, 7 Jul 2008 18:45:01 +0000 (18:45 +0000)]
[CORE] openib.def now includes mod_ver.def to retrieve IB_MAJORVERSION & IB_MINORVERSION #'s.  INF file stamping prompted this change.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1337 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WSD] This patch removes the dependency of WSD on DAPL ATS, and reduces connection...
leonidk [Thu, 3 Jul 2008 08:31:57 +0000 (08:31 +0000)]
[WSD] This patch removes the dependency of WSD on DAPL ATS, and reduces connection establishment SA queries from 2 (ATS query + PR query) to 1 (PR query).
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1332 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[CORE, TESTS] This patch adds a library and test utility that performs IP to IB addre...
leonidk [Thu, 3 Jul 2008 08:22:07 +0000 (08:22 +0000)]
[CORE, TESTS] This patch adds a library and test utility that performs IP to IB address translation without going to the SA for DAPL ATS service records.

It's a sequence of operations between the IP helper library and IPoIB.

1. Get the local IPoIB port's IB address information (GID).
2. Lookup the destination MAC address via the IP Helper functions, send ARP if needed 3. Ask IPoIB for the destination IB address information given the destination Ethernet MAC.

As input, the IBAT library takes two IP addresses (v4 or v6).  As output, it returns two GIDs (as IN6_ADDRs), as well as the pkey.

There's a test program, wherebu, that will exercise the IBAT library.

Note that there is special code for Windows Vista/Server 2008 to take advantage of newer functionality in the IP Helper library.  Without this lookups get quite slow as you increase the number of nodes.  On our 256 node cluster the Windows Server 2008 code path performed an order of magnitude better than the Windows Server 2003 code path.

There will be a follow up patch that moves WSD over to using this library.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1331 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] fix to 1326 CID management patch.
leonidk [Wed, 2 Jul 2008 18:10:45 +0000 (18:10 +0000)]
[IBAL] fix to 1326 CID management patch.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1330 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch fixes IBAL object destruction. It does the following:
leonidk [Wed, 2 Jul 2008 18:03:49 +0000 (18:03 +0000)]
[IBAL] This patch fixes IBAL object destruction.  It does the following:

1. Removes forcing synchronous destruction for user-mode exported objects.  This isn't needed, and slows down cleanup of the object hierarchy.

2. Clears the user-mode exported handle from the handle table before invoking the 'destroying' callback of an object, so that all further reference on the object will fail.  Currently, an IOCTL could take a reference on an object after the 'destroying' callback has returned.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1329 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] IBAL currently blows away all CEPs from its 'destroying' callback. This patch...
leonidk [Wed, 2 Jul 2008 17:53:15 +0000 (17:53 +0000)]
[IBAL] IBAL currently blows away all CEPs from its 'destroying' callback.  This patch moves this so that any left over CEPs are cleaned up in the 'cleanup' callback, so that objects that 'own' a CEP have a chance to clean themselves up first.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1328 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch renames 'que' to 'queue'.
leonidk [Wed, 2 Jul 2008 17:17:49 +0000 (17:17 +0000)]
[IBAL] This patch renames 'que' to 'queue'.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1327 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] IBAL has two reserved CID values that it stores in the QPs - AL_INVALID_CID...
leonidk [Wed, 2 Jul 2008 13:32:47 +0000 (13:32 +0000)]
[IBAL] IBAL has two reserved CID values that it stores in the QPs - AL_INVALID_CID, meaning that there is no CEP associated with the QP but that one can be associated, and AL_RESERVED_CID, which means no CEP is associated, and none should be because the QP is being destroyed.

The code uses atomic operations to check for/set AL_INVALID_CID or AL_RESERVED_CID.  Since there are two possible 'special' values, atomics can't be used reliably.

There has been a report of this related to SRP and BSODs.

Additionally, the code would provide the destroy callback when destroying the CEP.  However, the CEP can be destroyed through different paths, and it's important to make sure the destroy callback is invoked always so that reference counts can be properly released.

This patch pushes all assignments and checks for special values into the CEP manager, protected by the CEP manager's lock that it holds when performing the CEP lookup.  It also changes the semantics of creation/destruction of the CEPs to provide the destroy callback when the CEP is created or bound to an object (the binding path is for the passive side of a connection).

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1326 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] The current connection establishment code will return STATUS_HOST_UNREACHABLE...
leonidk [Wed, 2 Jul 2008 12:48:17 +0000 (12:48 +0000)]
[IBAL] The current connection establishment code will return STATUS_HOST_UNREACHABLE when an SA operation times out.  This patch returns STATUS_TIMEOUT if the SA query timed out, which tends to happen in larger clusters quite often.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1325 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] Use the CM protocol to exchange initiator depth and responder resources.
leonidk [Wed, 2 Jul 2008 12:39:02 +0000 (12:39 +0000)]
[IBAL] Use the CM protocol to exchange initiator depth and responder resources.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1324 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] The current ndi_dreq_cm function destroys the CEP after the QP is moved to...
leonidk [Wed, 2 Jul 2008 12:22:39 +0000 (12:22 +0000)]
[IBAL] The current ndi_dreq_cm function destroys the CEP after the QP is moved to the error state.  The CEP should be destroyed first to send the DREQ before changing the QP state.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1323 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] The CEP manager currently keeps a separate field to store the initiator depth...
leonidk [Wed, 2 Jul 2008 12:06:40 +0000 (12:06 +0000)]
[IBAL] The CEP manager currently keeps a separate field to store the initiator depth requested in a REQ.  When the user sends the REP, the CEP stored the responder resources as the minimum of the requested depth or the CA's capabilities.

This change eliminates the separate field, and uses the responder resources to store the received REQ's initiator depth.  This simplifies the code a bit.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1322 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] fix to the previous (1320) patch.
leonidk [Wed, 2 Jul 2008 11:50:44 +0000 (11:50 +0000)]
[IBAL] fix to the previous (1320) patch.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1321 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] Convert ib_api_status_t to NTSTATUS for al_cep_get_pdata to make the IRP handl...
leonidk [Wed, 2 Jul 2008 11:12:53 +0000 (11:12 +0000)]
[IBAL] Convert ib_api_status_t to NTSTATUS for al_cep_get_pdata to make the IRP handling simpler.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1320 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] Add code to allow user-mode code to register memory via the existing IBAL...
leonidk [Wed, 2 Jul 2008 10:34:39 +0000 (10:34 +0000)]
[IBAL] Add code to allow user-mode code to register memory via the existing IBAL IOCTLs, and if that succeeds, issue a no-op IOCTL that completes the user's overlapped request to their IOCP (or whatever mechanism they are using - the I/O manager will take care of it).
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1319 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch changes when the private data is stored to when the CM MAD is recei...
leonidk [Wed, 2 Jul 2008 10:24:10 +0000 (10:24 +0000)]
[IBAL] This patch changes when the private data is stored to when the CM MAD is received and processed.  This makes the code more consistent and simpler.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1318 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch adds a missing reference taken on a QP when delaying the QP modific...
leonidk [Tue, 1 Jul 2008 18:27:55 +0000 (18:27 +0000)]
[IBAL] This patch adds a missing reference taken on a QP when delaying the QP modification for a received DREQ.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1317 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch cancels all outstanding UAL_CEP_GET_REQ_CID IRPs queued in a CEP...
leonidk [Tue, 1 Jul 2008 18:19:33 +0000 (18:19 +0000)]
[IBAL] This patch cancels all outstanding UAL_CEP_GET_REQ_CID IRPs queued in a CEP when the CEP is destroyed.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1316 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] Cleanup dead code in IBAL.
leonidk [Tue, 1 Jul 2008 18:02:59 +0000 (18:02 +0000)]
[IBAL] Cleanup dead code in IBAL.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1315 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBAL.
leonidk [Tue, 1 Jul 2008 17:13:18 +0000 (17:13 +0000)]
[IBAL] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBAL.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1314 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from interface files.
leonidk [Tue, 1 Jul 2008 15:26:01 +0000 (15:26 +0000)]
[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from interface files.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1313 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from \tests.
leonidk [Tue, 1 Jul 2008 12:09:16 +0000 (12:09 +0000)]
[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from \tests.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1312 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[HW] improved memory allocation mechanism. (posix_memalign was implemented by Virtual...
leonidk [Tue, 1 Jul 2008 10:33:46 +0000 (10:33 +0000)]
[HW] improved memory allocation mechanism. (posix_memalign was implemented by VirtualAlloc, which, as it turned out, allocates 64KB instead of 4KB) [MLNX: 2601]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1311 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoRemove XXX_PTR64 and TO_ULONG_PTR from IPoIB
ftillier [Mon, 30 Jun 2008 18:09:25 +0000 (18:09 +0000)]
Remove XXX_PTR64 and TO_ULONG_PTR from IPoIB

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
Acked-by: Tzachi Dar <tzachid@mellanox.co.il>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1310 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoMake build scripts easier to use:
ftillier [Mon, 30 Jun 2008 17:15:54 +0000 (17:15 +0000)]
Make build scripts easier to use:
- bldwo.bat now accepts multiple build parameters, so you can separate them.
  For example, bldwo chk x86 2008 -Ccwg is the same as bldwo chk x86 2008 -C -c -w -g.
- eliminate the need for the WINOF_PATH environment variable so it can be run
  from any directory.
- bldwoall.bat now passes all extra parameters to bldwo.bat
- bldwoall.bat now picks up bldwo.bat from the same directory, rather than
  the directory from which it was launched.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1309 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IOU] This patch removes XXX_PTR64 and TO_ULONG_PTR macro usage in the IOU bus driver...
leonidk [Sun, 29 Jun 2008 17:53:30 +0000 (17:53 +0000)]
[IOU] This patch removes XXX_PTR64 and TO_ULONG_PTR macro usage in the IOU bus driver.  It's a kernel driver and doesn't need any padding as it will always have the same pointer size as other kernel drivers.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1308 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBBUS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBBus.
leonidk [Sun, 29 Jun 2008 16:45:16 +0000 (16:45 +0000)]
[IBBUS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBBus.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1307 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[SRP] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from SRP.
leonidk [Sun, 29 Jun 2008 16:21:53 +0000 (16:21 +0000)]
[SRP] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from SRP.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1306 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[tools] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from vstat.
leonidk [Sun, 29 Jun 2008 16:09:57 +0000 (16:09 +0000)]
[tools] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from vstat.

Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1305 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[tools] remove XXX_PTR64 and TO_ULONG_PTR macro use from perf tests.
tzachid [Sun, 29 Jun 2008 13:52:24 +0000 (13:52 +0000)]
[tools] remove XXX_PTR64 and TO_ULONG_PTR macro use from perf tests.
Signed off: ftillier@windows.microsoft.com

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1304 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mlx4] Stop DPC from running for ever (mlnx: 2642)
tzachid [Sun, 29 Jun 2008 11:38:09 +0000 (11:38 +0000)]
[mlx4] Stop DPC from running for ever (mlnx: 2642)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1303 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[wsd] remove XXX_PTR64 and TO_ULONG_PTR macro use from WSD.
tzachid [Sat, 28 Jun 2008 18:42:34 +0000 (18:42 +0000)]
[wsd] remove XXX_PTR64 and TO_ULONG_PTR macro use from WSD.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1302 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[DAPL2] remove extraneous file
stansmith [Wed, 25 Jun 2008 22:46:50 +0000 (22:46 +0000)]
[DAPL2] remove extraneous file

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1300 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agobldwo: fix usage message to reference correct program name
shefty [Wed, 25 Jun 2008 05:10:30 +0000 (05:10 +0000)]
bldwo: fix usage message to reference correct program name

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1296 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[ibal] Fix an assert. [mlnx: 2610]
tzachid [Mon, 23 Jun 2008 07:52:48 +0000 (07:52 +0000)]
[ibal] Fix an assert. [mlnx: 2610]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1295 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[Core] fixed errant Default Data length when reading registry entry 'PartitionKey...
stansmith [Sat, 21 Jun 2008 00:27:03 +0000 (00:27 +0000)]
[Core] fixed errant Default Data length when reading registry entry 'PartitionKey' and the key did not exist. Showed up as a BSOD crash when loading ibbus.sys on Server 2003 x86.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1294 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[HW, TOOLS] return system_image_guid
leonidk [Thu, 19 Jun 2008 17:52:36 +0000 (17:52 +0000)]
[HW, TOOLS] return system_image_guid

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1289 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mlx4] Add support for Ethernet. (mlnx: 2561)
tzachid [Thu, 19 Jun 2008 15:04:36 +0000 (15:04 +0000)]
[mlx4] Add support for Ethernet. (mlnx: 2561)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1288 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[ipoib] mac generation from hp GUID.
tzachid [Thu, 19 Jun 2008 14:11:17 +0000 (14:11 +0000)]
[ipoib] mac generation from hp GUID.
Signed by: Anatoly Greenblatt

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1287 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF] added common exit path with time stamp info (start & end times); curently...
stansmith [Wed, 18 Jun 2008 21:54:54 +0000 (21:54 +0000)]
[WinOF] added common exit path with time stamp info (start & end times); curently takes about 15 minutes to compile, sign drivers and build installers on a 4P platform.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1285 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MTHCA] Ensure an Rx WQE is in memory before linking
leonidk [Wed, 18 Jun 2008 17:25:21 +0000 (17:25 +0000)]
[MTHCA] Ensure an Rx WQE is in memory before linking

Use a write memory barrier to ensure a WQE is written to memory
before linking it to the previous WQE.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1284 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF]
stansmith [Wed, 18 Jun 2008 00:09:56 +0000 (00:09 +0000)]
  buildrelease.bat - added WIX .msi creation only option; assumes drivers are signed
  etc\makebin.bat - don't copy Mx tools which have been removed from the build/svn
  etc\clean-build.bat - delete build generated files to ensure a clean build.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1279 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MTHCA] Fix possible data corruption for Sinai chip upon fmr_unmap
leonidk [Tue, 17 Jun 2008 18:40:54 +0000 (18:40 +0000)]
[MTHCA] Fix possible data corruption for Sinai chip upon fmr_unmap

(In mthca_arbel_fmr_unmap(), the high bits of the key are masked off.
This gets rid of the effect of adjust_key(), which makes sure that
bits 3 and 23 of the key are equal when the Sinai throughput
optimization is enabled, and so it may happen that an FMR will end up
with bits 3 and 23 in the key being different.  This causes data
corruption, because when enabling the throughput optimization, the
driver promises the HCA firmware that bits 3 and 23 of all memory keys
will always be equal.

Fix by re-applying adjust_key() after masking the key.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1277 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IBAL] fixed a typo in __ib_qp_type_str
leonidk [Tue, 17 Jun 2008 18:39:33 +0000 (18:39 +0000)]
[IBAL] fixed a typo in __ib_qp_type_str

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1276 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] improve the time of handling events like port state change
leonidk [Tue, 17 Jun 2008 18:38:29 +0000 (18:38 +0000)]
[MLX4] improve the time of handling events like port state change

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1275 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF]
stansmith [Tue, 17 Jun 2008 17:09:24 +0000 (17:09 +0000)]
  ib_srp.inf - updated DriverVer so signtool doesn't complain of being too old.
  ib_srp.cdf - driver signing file - defines ibsrp.cat contents for driver package signing.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1274 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF]
stansmith [Tue, 17 Jun 2008 17:02:17 +0000 (17:02 +0000)]
    ipoib.inf - updated DriverVer in order that ipoib.sys could be signed; signtool.exe complained.
    ipoib.cdf - removed extraneous whitespace.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1273 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF]
stansmith [Tue, 17 Jun 2008 17:01:12 +0000 (17:01 +0000)]
    qlgcvnic.inf - added CatalogFile for Windows Server 2008 driver signing.
    netvnic.cdf  - new file for driver signing.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1272 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF] multiple buildrelease options: all, compile, makebin, msi
stansmith [Tue, 17 Jun 2008 16:45:54 +0000 (16:45 +0000)]
[WinOF] multiple buildrelease options: all, compile, makebin, msi

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1271 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[DAPL2] Request extensions didn't allocate a cookie if the completion was suppressed...
stansmith [Fri, 13 Jun 2008 00:00:03 +0000 (00:00 +0000)]
[DAPL2] Request extensions didn't allocate a cookie if the completion was suppressed, which resulted in segfault during provider post call. Provider's expect a *cookie in wr_id, even with surpressed completions, needed to handle events during errors.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1264 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TOOLS] remove Mellanox burning tools. They are to be provided for each kind of HW...
leonidk [Thu, 12 Jun 2008 17:35:37 +0000 (17:35 +0000)]
[TOOLS] remove Mellanox burning tools. They are to be provided for each kind of HW by its vendor.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1262 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TOOLS] remove Mellanox burning tools. They are to be provided for each kind of HW...
leonidk [Wed, 11 Jun 2008 10:25:31 +0000 (10:25 +0000)]
[TOOLS] remove Mellanox burning tools. They are to be provided for each kind of HW by its vendor.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1261 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MTHCA] added returning max_avs for Tavor
leonidk [Tue, 10 Jun 2008 16:21:02 +0000 (16:21 +0000)]
[MTHCA] added returning max_avs for Tavor

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1260 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[ALL] fix drivers to return PKEY in BE order as IBAL requires [MLNX: 2551]
leonidk [Tue, 10 Jun 2008 16:16:44 +0000 (16:16 +0000)]
[ALL] fix drivers to return PKEY in BE order as IBAL requires [MLNX: 2551]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1259 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[HW] remove GPL comments from windows-reimplemented bit macros
leonidk [Tue, 10 Jun 2008 16:10:02 +0000 (16:10 +0000)]
[HW] remove GPL comments from windows-reimplemented bit macros

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1258 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[HW] replace GPL-protected Linux implementation of lists by Windows one
leonidk [Tue, 10 Jun 2008 16:09:13 +0000 (16:09 +0000)]
[HW] replace GPL-protected Linux implementation of lists by Windows one

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1257 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TOOLS] fixed a bug in setting parameters on x64 platform [MLNX: 2558]
leonidk [Tue, 10 Jun 2008 15:09:27 +0000 (15:09 +0000)]
[TOOLS] fixed a bug in setting parameters on x64 platform [MLNX: 2558]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1256 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] return a more specific return code (in the bad flow of create_cq) [MLNX: 2554]
leonidk [Thu, 5 Jun 2008 12:04:45 +0000 (12:04 +0000)]
[MLX4] return a more specific return code (in the bad flow of create_cq) [MLNX: 2554]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1245 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TOOLS] fix license
leonidk [Wed, 4 Jun 2008 15:32:28 +0000 (15:32 +0000)]
[TOOLS] fix license

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1240 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agodocs/dontdiff.txt: add .bin, .rej, and .orig files to the skip list
shefty [Wed, 4 Jun 2008 03:48:05 +0000 (03:48 +0000)]
docs/dontdiff.txt: add .bin, .rej, and .orig files to the skip list

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1237 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF] WDK build env; good to go.
stansmith [Tue, 3 Jun 2008 19:38:02 +0000 (19:38 +0000)]
[WinOF] WDK build env; good to go.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1231 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[DAPL] match winof 1.1
stansmith [Tue, 3 Jun 2008 19:36:03 +0000 (19:36 +0000)]
[DAPL] match winof 1.1

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1230 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] return a more specific return code (in the bad flow of create_cq) [MLNX: 2537]
leonidk [Mon, 2 Jun 2008 16:36:08 +0000 (16:36 +0000)]
[MLX4] return a more specific return code (in the bad flow of create_cq) [MLNX: 2537]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1228 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] bugfix: fill alt_port_num field in qp_modify
leonidk [Sun, 1 Jun 2008 17:29:33 +0000 (17:29 +0000)]
[MLX4] bugfix: fill alt_port_num field in qp_modify

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1227 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed warnings in DBG environment
leonidk [Sun, 1 Jun 2008 17:26:52 +0000 (17:26 +0000)]
[MLX4] fixed warnings in DBG environment

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1226 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed a PREFast warning
leonidk [Sun, 1 Jun 2008 17:24:15 +0000 (17:24 +0000)]
[MLX4] fixed a PREFast warning

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1225 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed bug: send WQE buffer initialization was skipped in case of NDI provider...
leonidk [Sun, 1 Jun 2008 17:10:11 +0000 (17:10 +0000)]
[MLX4] fixed bug: send WQE buffer initialization was skipped in case of NDI provider [MLNX: 2531]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1224 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[SRP] fixes the BSOD when SRPT disconnects.
leonidk [Sun, 1 Jun 2008 14:19:59 +0000 (14:19 +0000)]
[SRP] fixes the BSOD when SRPT disconnects.

Suggested by: Eleanor Witiak [eleanor.witiak@qlogic.com]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1223 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[DAPL2] incorporate WinOF 1.1 DAPL fixes for rnr handling.
stansmith [Tue, 27 May 2008 22:52:49 +0000 (22:52 +0000)]
[DAPL2] incorporate WinOF 1.1 DAPL fixes for rnr handling.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1212 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[WinOF] WDK build env - say goodbye to DDK builds.
stansmith [Tue, 27 May 2008 22:47:16 +0000 (22:47 +0000)]
[WinOF] WDK build env - say goodbye to DDK builds.

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1211 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[TOOLS] support the work on Server 2008, where there are both IPv4 and IPv6. [MLNX...
leonidk [Mon, 26 May 2008 09:46:46 +0000 (09:46 +0000)]
[TOOLS] support the work on Server 2008, where there are both IPv4 and IPv6. [MLNX: 2505]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1209 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed incorrect return code in bad flow, which caused kernel crash. [MLNX...
leonidk [Sun, 25 May 2008 15:56:26 +0000 (15:56 +0000)]
[MLX4] fixed incorrect return code in bad flow, which caused kernel crash. [MLNX: 2500]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1208 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed incorrect return code in bad flow, which caused kernel crash. [MLNX...
leonidk [Wed, 21 May 2008 14:13:22 +0000 (14:13 +0000)]
[MLX4] fixed incorrect return code in bad flow, which caused kernel crash. [MLNX: 2491]

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1198 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[HW] add support for defing max_inline_data size upon QP creation
leonidk [Tue, 20 May 2008 10:17:00 +0000 (10:17 +0000)]
[HW] add support for defing max_inline_data size upon QP creation

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1196 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoChange line endings from UNIX (LF only) to Windows (LF-CR) format. Files are otherwi...
shefty [Tue, 20 May 2008 07:43:32 +0000 (07:43 +0000)]
Change line endings from UNIX (LF only) to Windows (LF-CR) format.  Files are otherwise unchanged.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1195 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mlx4] Fix a build break and allow non-clean builds. (winib 2457/8)
tzachid [Tue, 20 May 2008 07:40:50 +0000 (07:40 +0000)]
[mlx4] Fix a build break and allow non-clean builds. (winib 2457/8)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1194 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mlx4] Create a device for the Ethernet driver if needed. (winib 2456) (3 lost files)
tzachid [Tue, 20 May 2008 07:37:50 +0000 (07:37 +0000)]
[mlx4] Create a device for the Ethernet driver if needed. (winib 2456) (3 lost files)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1193 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoGoofy script to copy .sys, .lib, .dll, .exe, .inf, and .whatever else
shefty [Tue, 20 May 2008 07:28:23 +0000 (07:28 +0000)]
Goofy script to copy .sys, .lib, .dll, .exe, .inf, and .whatever else
into an install directory.  Not sophisticated at all, but I am able to
use it to fairly quickly update drivers when testing.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1192 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoLame build script that can be used to build 2003/2008 winof platforms. Be
shefty [Tue, 20 May 2008 07:27:45 +0000 (07:27 +0000)]
Lame build script that can be used to build 2003/2008 winof platforms.  Be
sure that you have something else to do for the next hour before

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1191 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoThe following build script allows building the winof stack for any
shefty [Tue, 20 May 2008 07:26:48 +0000 (07:26 +0000)]
The following build script allows building the winof stack for any
platform (OS and processor architecture) from a single command prompt
window.  Guaranteed to save your sanity, versus having a dozen build
windows opened to build the various winof flavors.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1190 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoProvide simple build instructions for developers who check out the
shefty [Tue, 20 May 2008 07:25:52 +0000 (07:25 +0000)]
Provide simple build instructions for developers who check out the
source tree and want to try building the drivers.  It's more intuitive
to provide build details with the source code itself, than separately
on a web site.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1189 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoThe SVN diff program cannot handle generating diffs between two different
shefty [Tue, 20 May 2008 07:24:58 +0000 (07:24 +0000)]
The SVN diff program cannot handle generating diffs between two different
directories.  This file describes how to use an external diff program
to generate patches between two directories that can then be applied.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1188 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoWhen using a diff utility to find differences between two subdirectories,
shefty [Tue, 20 May 2008 07:24:21 +0000 (07:24 +0000)]
When using a diff utility to find differences between two subdirectories,
for example, an svn branch and the trunk, you can have the diff program
ignore files.  This is useful to avoid diffs caused by object files,
executables, or svn tracking files.

The following file can be fed into diff to have it ignore files that
match any of the patterns listed.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1187 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years agoProvide an updated list of the various maintainers for the WinOF stack
shefty [Tue, 20 May 2008 07:23:43 +0000 (07:23 +0000)]
Provide an updated list of the various maintainers for the WinOF stack
under the source tree trunk\docs directory.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1186 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mlx4] Create a device for the Ethernet driver if needed. (winib 2456)
tzachid [Tue, 20 May 2008 07:16:08 +0000 (07:16 +0000)]
[mlx4] Create a device for the Ethernet driver if needed. (winib 2456)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1185 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[mthca] Remove dead code. (winib 2455)
tzachid [Mon, 19 May 2008 06:49:00 +0000 (06:49 +0000)]
[mthca] Remove dead code. (winib 2455)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1184 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[IPOIB ]Fix a bugcheck when NdisMResetComplete called without previous reset request...
tzachid [Mon, 19 May 2008 06:46:18 +0000 (06:46 +0000)]
[IPOIB ]Fix a bugcheck when NdisMResetComplete called without previous reset request completed with STATUS_PENDING. (winib 2454)
Signed by: Slava Strebkov

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1183 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] prevent constant comparison to please PREfast (winib 2461)
leonidk [Sun, 18 May 2008 14:27:22 +0000 (14:27 +0000)]
[MLX4] prevent constant comparison to please PREfast (winib 2461)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1182 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] buxfix in WCHAR buffer length in RtlStringCchPrintfW function (winib 2459)
leonidk [Sun, 18 May 2008 14:05:45 +0000 (14:05 +0000)]
[MLX4] buxfix in WCHAR buffer length in RtlStringCchPrintfW function (winib 2459)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1179 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

13 years ago[MLX4] fixed a bug, that caused "Completion event for bogus CQ " message and the...
leonidk [Sun, 18 May 2008 13:44:34 +0000 (13:44 +0000)]
[MLX4] fixed a bug, that caused "Completion event for bogus CQ " message and the miss of CQ completion event after that. (winib 2439)

git-svn-id: svn://openib.tc.cornell.edu/gen1/trunk@1178 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86