13 years ago - Removed artificial limitation on sg_tablesize. It isn't needed, because the regula...
vlnb [Mon, 2 Feb 2009 11:16:38 +0000 (11:16 +0000)]
 - Removed artificial limitation on sg_tablesize. It isn't needed, because the regular iSCSI negotiated MaxRecvDataSegmentLength-related facilities do all the job pretty well.
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@655 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFinal merge with IET (r201-204):
vlnb [Fri, 30 Jan 2009 17:47:31 +0000 (17:47 +0000)]
Final merge with IET (r201-204):

 - 2.6.25 introduced netlink_socket_release(), to be used to clean up netlink sockets correctly (taking care of namespaces).

 - New more scalable proc seq_file implementation

+ minor signess cleanups

+ version updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@654 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r196:
vlnb [Fri, 30 Jan 2009 16:49:01 +0000 (16:49 +0000)]
Merge with IET r196:

 - Allow removal of kernel target objects if the user space object does not exist

Based on a patch by Lars Ellenberg.

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@653 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r195:
vlnb [Fri, 30 Jan 2009 16:41:22 +0000 (16:41 +0000)]
Merge with IET r195:

From: Lars Ellenberg <lars.ellenberg@linbit.com>

Ignore SIGPIPE in ietd

Otherwise we would die in some later write() during the event_loop
instead of getting EPIPE!

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@652 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge of IET r194:
vlnb [Fri, 30 Jan 2009 16:36:39 +0000 (16:36 +0000)]
Merge of IET r194:

 - Add support for Reject PDUs and make use of them in appropriate places.

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@651 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r192-193:
vlnb [Fri, 30 Jan 2009 16:25:52 +0000 (16:25 +0000)]
Merge with IET r192-193:

 - Introduce min*/max*() and more list_* macros

 - Multipart PDU support for discovery sessions

The conn's response buffer is now replaced with a list of buffers and
all users are updated accordingly. Discovery sessions can make use of
this mechanism, if the list of targets + addresses does not fit into a
single text PDU, the initiator may now retrieve subsequent parts.

This also fixes the data segment handling for discovery sessions.

Based on a patch originally provided by Shreyansh Jain <shrey.linux@gmail.com>

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@650 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r170-191:
vlnb [Thu, 29 Jan 2009 19:10:10 +0000 (19:10 +0000)]
Merge with IET r170-191:

 - Update MaxConnections documentation
 - Remove isns config description from man page
 - Check return values of chdir(), ftruncate() and write(), because recent versions of the glibc insist on the return value being checked by
introducing __attribute__((warn_unused_result)) to these functions.
 - Fix snprintf use in isns.c
 - Take \0-termination into account when passing strings to isns_tlv_set() to solve incompatibility with MS iSNS 3.0 as IQN length is multiple of 4
 - Fix list corruption if SCST target registration fails
 - Register the target port actually used instead of the default iSCSI port.
 - Remove unused connection->pad
 - Refactor cmnd_execute()
 - Version changed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@649 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fix for iSCSI RFC violation: TARGET COLD RESET must close all connections/sessions...
vlnb [Thu, 29 Jan 2009 18:25:45 +0000 (18:25 +0000)]
 - Fix for iSCSI RFC violation: TARGET COLD RESET must close all connections/sessions, not only the current one
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@648 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r169:
vlnb [Thu, 29 Jan 2009 12:19:22 +0000 (12:19 +0000)]
Merge with IET r169:

From:  Shreyansh Jain <shrey.linux at gmail.com>
Subject: [Patch 1/1] Segfault in ietd buffer overrun in dump_line

Fix a buffer overrun problem in __dump_line function in log.c file.
It also removes a stray 'return' call in log_pdu function which was
restricting a PDU dump call to complete log_pdu operation.

Also, in log_pdu function, the first check for log_level against
passed parameter for log was incorrect and would have forced a return
even when the caller has set the logging level to acceptable level.

Signed-off-by: Shreyansh Jain <shrey.linux at gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@647 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r160-168: add iscsi-scst-adm support to display list of CHAP accounts...
vlnb [Thu, 29 Jan 2009 12:12:42 +0000 (12:12 +0000)]
Merge ... IET r160-168: add iscsi-scst-adm support to display list of CHAP accounts and their data

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@646 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake USN related stuff completed. Unfortunately, it can break existing cluster setups...
vlnb [Wed, 28 Jan 2009 18:44:59 +0000 (18:44 +0000)]
Make USN related stuff completed. Unfortunately, it can break existing cluster setups, but it's better to make it now, then later.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@645 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSync with IET revisions 156-159: fix for compilation on glibc 2.8
vlnb [Tue, 27 Jan 2009 18:50:33 +0000 (18:50 +0000)]
Sync with IET revisions 156-159: fix for compilation on glibc 2.8

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@644 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Add autogenerated USN
vlnb [Tue, 27 Jan 2009 18:09:24 +0000 (18:09 +0000)]
 - Add autogenerated USN
 - Sync fileio_tgt with scst_vdisk

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@643 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixed race in scst_user, which can lead to usage of already freed command. A misbe...
vlnb [Mon, 26 Jan 2009 18:08:07 +0000 (18:08 +0000)]
 - Fixed race in scst_user, which can lead to usage of already freed command. A misbehaving user space handler can make ucmd to get dead
   immediately after the lock is released and we should catch it.
 - Text in README about barriers usage updated
 - Minor cleanup with aim to have more robust code

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@642 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes most checkpatch and sparse issues that are reported by
vlnb [Mon, 26 Jan 2009 17:32:50 +0000 (17:32 +0000)]
The patch below fixes most checkpatch and sparse issues that are reported by
the most recent versions (checkpatch 2.6.28 / latest sparse git version) and
that were not reported by previous versions (checkpatch 2.6.27 / sparse 0.4.1).
The patch below fixes the following issues:
* Removed trailing space in iscsi-scst/README_in-tree.
* Fixed sparse complaints about functions that were not declared static.
* Fixed sparse complaints about casts between address spaces: such casts are
   now either fixed or explicit (via the __force keyword).

The patch below has been verified by checking the output produced by:
scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@641 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRecently (Subversion revision 633) code was added to scst_vdisk.c that
vlnb [Mon, 26 Jan 2009 17:23:46 +0000 (17:23 +0000)]
Recently (Subversion revision 633) code was added to scst_vdisk.c that
performs a.o. 64-bit division. While gcc supports 64-bit divisions on 32-bit
CPU's, gcc generates a function call for these 64-bit divisions (see also
http://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html for the
entire list). Unfortunately there is no implementation available for these
functions in the Linux kernel. Which means that loading kernel modules
that contain 64-bit divisions on a 32-bit system will fail and that insmod/
modprobe will complain about undefined references to e.g. __umoddi3. AFAIK the
proper approach in the Linux kernel is to use the do_div() macro for
performing 64-bit divisions. This macro is defined in <asm/div64.h>. The patch
below converts the call to div_s64_rem() by a call to do_div().

The patch below has been verified as follows:
- Reran scripts/run-regression-tests -k -k -k -k -k
  on a 64-bit system and verified that the output of the re*/sparse* files did
  not contain any compilation errors.
- Verified that the patched SCST source compiles fine on CentOS 5.2, 32-bit.
- Verified that the scst_vdisk module loads correctly on CentOS 5.2, 32-bit.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@640 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes wrong usage of the last parameter of module_param_named()
vlnb [Mon, 26 Jan 2009 12:57:22 +0000 (12:57 +0000)]
Fixes wrong usage of the last parameter of module_param_named()

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@639 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoModified patch from Bart Van Assche <bart.vanassche@gmail.com>
vlnb [Fri, 23 Jan 2009 19:51:54 +0000 (19:51 +0000)]
Modified patch from Bart Van Assche <bart.vanassche@gmail.com>

It, hopefully, fixes compilation problems on CentOS 5.2 as well as on vanilla kernels <2.6.28

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@638 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Fixed bug in evaluation of expressions containing '&&' or '||'.
bvassche [Mon, 19 Jan 2009 19:07:42 +0000 (19:07 +0000)]
- Fixed bug in evaluation of expressions containing '&&' or '||'.
- Added support for evaluating #ifdef and #ifndef.
- Added support for substituting the macro's RHEL_MAJOR, RHEL_MINOR and RHEL_RELEASE_CODE.
- Added more comments.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@637 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBumped default kernel version to 2.6.28.
bvassche [Sat, 17 Jan 2009 10:34:48 +0000 (10:34 +0000)]
Bumped default kernel version to 2.6.28.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@636 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoA bunch of minor fixes/improvements, cleanups and updates:
vlnb [Fri, 16 Jan 2009 20:56:06 +0000 (20:56 +0000)]
A bunch of minor fixes/improvements, cleanups and updates:

 - In scst_local new experimental compile-time option to force direct processing added
 - Attempt in SCST structures to separate read-mostly from read-write data to decrease cache ping-pong between CPUs
 - In scst_vdisk new module parameter num_threads added to specify a number of threads for each vdisk/vcdrom. Default is 5.
 - Debug logging for failed digests in iSCSI-SCST improved
 - Docs updates/cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@635 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Minor optimization
vlnb [Thu, 15 Jan 2009 18:50:43 +0000 (18:50 +0000)]
 - Minor optimization
 - New member target_name added to struct scst_user_sess
 - Docs updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@634 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor fixes for better Windows compatibility
vlnb [Thu, 15 Jan 2009 16:14:57 +0000 (16:14 +0000)]
Minor fixes for better Windows compatibility

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@633 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Update for 2.6.28
vlnb [Mon, 12 Jan 2009 18:55:08 +0000 (18:55 +0000)]
 - Update for 2.6.28
 - Small doc update in flow control area

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@632 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRemoved trailing whitespace. While the checkpatch script included with the 2.6.27...
bvassche [Sat, 10 Jan 2009 17:21:57 +0000 (17:21 +0000)]
Removed trailing whitespace. While the checkpatch script included with the 2.6.27 kernel did not complain on trailing whitespace in documentation and kbuild files, the checkpatch script included with the 2.6.28 kernel does.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@631 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor performance improvement
vlnb [Sun, 4 Jan 2009 17:53:57 +0000 (17:53 +0000)]
Minor performance improvement

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@630 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Minor improvements
vlnb [Sun, 4 Jan 2009 16:14:33 +0000 (16:14 +0000)]
 - Minor improvements
 - Incorrect BUG_ON removed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@629 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor fixes
vlnb [Sun, 4 Jan 2009 16:12:56 +0000 (16:12 +0000)]
Minor fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@628 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed problem with KERN_CONT absent in some vendor kernels
vlnb [Tue, 30 Dec 2008 10:37:07 +0000 (10:37 +0000)]
Fixed problem with KERN_CONT absent in some vendor kernels

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@627 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoREAD POSITION command's constants cleanup, since LONG_BIT conflicts with constant...
vlnb [Fri, 26 Dec 2008 17:49:27 +0000 (17:49 +0000)]
READ POSITION command's constants cleanup, since LONG_BIT conflicts with constant defined in /usr/include/bits/xopen_lim.h

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@626 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoObsolete TODO removed
vlnb [Fri, 26 Dec 2008 17:42:21 +0000 (17:42 +0000)]
Obsolete TODO removed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@625 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAccess control docs updated
vlnb [Fri, 26 Dec 2008 17:40:30 +0000 (17:40 +0000)]
Access control docs updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@624 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Fixed a removeDevice() case when using -ForceConfig. Spotted by Ondrej Palkovsky.
mgandalf [Thu, 18 Dec 2008 17:30:37 +0000 (17:30 +0000)]
- Fixed a removeDevice() case when using -ForceConfig. Spotted by Ondrej Palkovsky.
- SCST.pm: Cosmetic changes to error messages - include the handler name.
- SCST.pm: Quote handlers, handler IOs, devices, users and groups in error messages.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@623 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSet memory limits according to LOWMEM, not TOTALMEM
vlnb [Thu, 18 Dec 2008 16:50:43 +0000 (16:50 +0000)]
Set memory limits according to LOWMEM, not TOTALMEM

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@622 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup: dev_serialized deleted, because it dublicates dev_double_ua_possible
vlnb [Thu, 18 Dec 2008 16:41:26 +0000 (16:41 +0000)]
Cleanup: dev_serialized deleted, because it dublicates dev_double_ua_possible

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@621 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Cosmetic fixes by Witold Kowolik and increment version.
mgandalf [Thu, 18 Dec 2008 16:11:32 +0000 (16:11 +0000)]
- Cosmetic fixes by Witold Kowolik and increment version.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@620 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Fixed enabling/disabling targets. Spotted by Witold Kowolik.
mgandalf [Thu, 18 Dec 2008 16:05:55 +0000 (16:05 +0000)]
- Fixed enabling/disabling targets. Spotted by Witold Kowolik.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@619 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Fix a check in SCST::removeUser(), spotted by Witold Kowolik.
mgandalf [Thu, 18 Dec 2008 16:00:34 +0000 (16:00 +0000)]
- Fix a check in SCST::removeUser(), spotted by Witold Kowolik.
- Changed a few returns to 1 instead of $TRUE since really they're
  int returns and not boolean.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@618 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago.26 changed to .27 to stop confusing too observant people :)
vlnb [Thu, 11 Dec 2008 14:30:40 +0000 (14:30 +0000)]
.26 changed to .27 to stop confusing too observant people :)

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@617 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCheckpatch fix
vlnb [Wed, 10 Dec 2008 15:55:16 +0000 (15:55 +0000)]
Checkpatch fix

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@616 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoTrailing whitespace fixed
vlnb [Wed, 10 Dec 2008 12:05:17 +0000 (12:05 +0000)]
Trailing whitespace fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@615 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Memory barriers cleanup. Comments for them improved
vlnb [Wed, 10 Dec 2008 10:55:01 +0000 (10:55 +0000)]
 - Memory barriers cleanup. Comments for them improved
 - Small docs update
 - srpt/README_in-tree added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@614 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Added patch my Witold Kowolik to allow enable/disable of qla_isp cards.
mgandalf [Tue, 9 Dec 2008 18:57:32 +0000 (18:57 +0000)]
- Added patch my Witold Kowolik to allow enable/disable of qla_isp cards.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@613 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Applied patch from Witold Kowolik with modifications,
mgandalf [Tue, 9 Dec 2008 18:28:29 +0000 (18:28 +0000)]
- Applied patch from Witold Kowolik with modifications,
  simplifies/fixes option parsing.
- Added new REMOVABLE option.
- Allow options to be specified in lowercase.
- Misc. fixes.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@612 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSplit generated patch files further:
bvassche [Tue, 9 Dec 2008 07:50:44 +0000 (07:50 +0000)]
Split generated patch files further:
- Left out iscsi_scst_itf_ver.h since it is a generated file.
- README.qla2x00t has been put in a separate patch, qla2x00t-doc.diff.
- scst_proc.diff has been scst_core.diff.
- scst_vdisk.diff has been split from scst_dev_handlers.diff.
- scst_dev_handlers.diff has been renamed into scst_passthrough.diff.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@611 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup.
bvassche [Mon, 8 Dec 2008 12:58:09 +0000 (12:58 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@610 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMade "make htmldocs" the last step.
bvassche [Sat, 6 Dec 2008 16:28:05 +0000 (16:28 +0000)]
Made "make htmldocs" the last step.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@609 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoOption -p now generates three extra patches: scst_debug.diff, scst_sgv.diff and scst_...
bvassche [Sat, 6 Dec 2008 16:27:19 +0000 (16:27 +0000)]
Option -p now generates three extra patches: scst_debug.diff, scst_sgv.diff and scst_user.diff.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@608 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed typo.
bvassche [Sat, 6 Dec 2008 14:04:29 +0000 (14:04 +0000)]
Fixed typo.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@607 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded 'make htmldocs'. Changed default kernel version from into
bvassche [Sat, 6 Dec 2008 13:39:16 +0000 (13:39 +0000)]
Added 'make htmldocs'. Changed default kernel version from into

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@606 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoModified the way in which the dummy mpt patch is suppressed, such that the run-regres...
bvassche [Sat, 6 Dec 2008 13:37:43 +0000 (13:37 +0000)]
Modified the way in which the dummy mpt patch is suppressed, such that the run-regression-tests script works again.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@605 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup
vlnb [Fri, 5 Dec 2008 13:56:43 +0000 (13:56 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@604 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup
vlnb [Fri, 5 Dec 2008 13:54:00 +0000 (13:54 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@603 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoVarious changes
vlnb [Fri, 5 Dec 2008 13:48:10 +0000 (13:48 +0000)]
Various changes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@602 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed a sparse warning.
bvassche [Thu, 4 Dec 2008 21:29:24 +0000 (21:29 +0000)]
Fixed a sparse warning.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@601 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Removed command-line option -l -- scst_local is now unconditionally
bvassche [Thu, 4 Dec 2008 21:21:05 +0000 (21:21 +0000)]
- Removed command-line option -l -- scst_local is now unconditionally
  included in the generated patch output.
- Added command-line option -p <patchdir>, which allows to generate a
  set of patches instead of one big patch.
- New feature: by setting the environment variable SIGNED_OFF_BY, the
  Signed-off-by line is filled in.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@600 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoIt was brocken. Fixed.
vlnb [Thu, 4 Dec 2008 19:31:46 +0000 (19:31 +0000)]
It was brocken. Fixed.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@599 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded README for scst_local
vlnb [Thu, 4 Dec 2008 19:13:02 +0000 (19:13 +0000)]
Added README for scst_local

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@598 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanups
vlnb [Thu, 4 Dec 2008 18:20:22 +0000 (18:20 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@597 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUntil now I had been using the latest git version of sparse (August 26, 2008).
vlnb [Thu, 4 Dec 2008 18:00:51 +0000 (18:00 +0000)]
Until now I had been using the latest git version of sparse (August 26, 2008).
Apparently not all messages reported by this version are correct. So I switched
back to the last released sparse version (0.4.1). The patch below fixes all
errors and warnings reported by sparse 0.4.1 on the SCST source code.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@596 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded 'make headers_check', 'make checkstack' and 'make namespacecheck'.
bvassche [Wed, 3 Dec 2008 18:29:50 +0000 (18:29 +0000)]
Added 'make headers_check', 'make checkstack' and 'make namespacecheck'.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@595 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake soft IRQ context default
vlnb [Wed, 3 Dec 2008 18:01:42 +0000 (18:01 +0000)]
Make soft IRQ context default

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@594 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanups after "make namespacecheck"
vlnb [Wed, 3 Dec 2008 11:59:41 +0000 (11:59 +0000)]
Cleanups after "make namespacecheck"

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@593 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Patch from Richard Sharpe <realrichardsharpe@gmail.com> to fix an unterminated...
vlnb [Mon, 1 Dec 2008 18:36:54 +0000 (18:36 +0000)]
 - Patch from Richard Sharpe <realrichardsharpe@gmail.com> to fix an unterminated macro call and add a semicolon to please
the compiler in an ifdef block.

 - Memory leak fixed on error path in scst_local

 - Docs cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@592 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSome minor fixups to the doc to make it more correct.
richardsharpe [Mon, 1 Dec 2008 00:55:56 +0000 (00:55 +0000)]
Some minor fixups to the doc to make it more correct.

My previous commit was tested against 2.6.24 and prior to the commit.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@591 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix a problem on kernels older than 2.6.25 where the symbol SCSI_MAX_SG_SEGMENTS
richardsharpe [Mon, 1 Dec 2008 00:42:02 +0000 (00:42 +0000)]
Fix a problem on kernels older than 2.6.25 where the symbol SCSI_MAX_SG_SEGMENTS
is not available. Define it if it is not already defined.

Also fix a few minor English issues.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@590 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSmall docs update
vlnb [Sat, 29 Nov 2008 17:00:15 +0000 (17:00 +0000)]
Small docs update

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@589 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoalloc_io_context renamed to export_alloc_io_context
vlnb [Fri, 28 Nov 2008 17:19:29 +0000 (17:19 +0000)]
alloc_io_context renamed to export_alloc_io_context

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@588 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Performance increase
vlnb [Fri, 28 Nov 2008 17:15:17 +0000 (17:15 +0000)]
 - Performance increase
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@587 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSigned/unsigned cleanups
vlnb [Fri, 28 Nov 2008 16:11:51 +0000 (16:11 +0000)]
Signed/unsigned cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@586 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixing compilation warning when compiling the code with -Wcast-qual.
vlnb [Wed, 26 Nov 2008 19:03:41 +0000 (19:03 +0000)]
Fixing compilation warning when compiling the code with -Wcast-qual.
The casting from (const uint8_t *) to (uint8_t *) is not really necessary.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@585 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThere are two remaining printk() statements on which checkpatch warns that the
vlnb [Wed, 26 Nov 2008 19:00:23 +0000 (19:00 +0000)]
There are two remaining printk() statements on which checkpatch warns that the
KERN_ facility level is missing. Algthough these warnings are false positives,
I have developed a patch to suppress these warnings.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@584 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Now task_mgmt_fn() callback called for TARGET RESET and NEXUS LOSS only once for...
vlnb [Tue, 25 Nov 2008 16:44:24 +0000 (16:44 +0000)]
 - Now task_mgmt_fn() callback called for TARGET RESET and NEXUS LOSS only once for tgt_dev, which belongs to the session, from which the corresponding request came

 - Cleanup

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@583 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCheckpatch warnings fixed
vlnb [Fri, 21 Nov 2008 12:12:53 +0000 (12:12 +0000)]
Checkpatch warnings fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@582 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoForgotten in r578 initiator version increase
vlnb [Fri, 21 Nov 2008 10:18:28 +0000 (10:18 +0000)]
Forgotten in r578 initiator version increase

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@581 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoDRIVER_ATTR add_host made static
vlnb [Fri, 21 Nov 2008 10:16:34 +0000 (10:16 +0000)]
DRIVER_ATTR add_host made static

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@580 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the sparse warnings on passing a __user pointer where a
vlnb [Fri, 21 Nov 2008 10:15:03 +0000 (10:15 +0000)]
The patch below fixes the sparse warnings on passing a __user pointer where a
kernel pointer is expected and vice versa. Additionally, there are a few fixes
for checkpatch warnings on trailing whitespace and lines that were over 80

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@579 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUpdate to initiator driver from 2.6.27
vlnb [Thu, 20 Nov 2008 18:58:53 +0000 (18:58 +0000)]
Update to initiator driver from 2.6.27

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@578 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - SGV cache related parameters moved from scst.h to scst_sgv.h
vlnb [Thu, 20 Nov 2008 17:05:08 +0000 (17:05 +0000)]
 - SGV cache related parameters moved from scst.h to scst_sgv.h

 - Minor updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@577 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPrevent memory leaks in error paths by deferring
vlnb [Wed, 19 Nov 2008 11:37:45 +0000 (11:37 +0000)]
Prevent memory leaks in error paths by deferring
allocation until we have checked for errors. Also, fix the host ID
(target #) to be one larger than the max target ID for the host. Also,
reduce the number of outstanding commands per LUN to 1 (although this
might not be needed). Also scst_lcl_ini_driver_template flags cleanup.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Signed-off-by: Vladislav Bolkhovitin <vst@vlnb.net>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@576 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix for memory overwrite-after-free bug in scst_local
vlnb [Wed, 19 Nov 2008 10:55:58 +0000 (10:55 +0000)]
Fix for memory overwrite-after-free bug in scst_local

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@575 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below implements the following modifications for
vlnb [Tue, 18 Nov 2008 18:47:09 +0000 (18:47 +0000)]
The patch below implements the following modifications for
- Adds a description about what the script does.
- Added command-line option -c which allows to specify which directory to use
  as cache for kernel tar balls and patch files.
- More error checking.
- scst_local is now included in all the tests.
- Swapped the order of two test steps, namely compiling the whole tree and
  running sparse. This way the output of the sparse tool is available a lot

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@574 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes two categories of checkpatch
vlnb [Tue, 18 Nov 2008 18:45:13 +0000 (18:45 +0000)]
The patch below fixes two categories of checkpatch
complaints on scst_local, namely "line over 80 columns" and "use tabs to indent
instead of spaces".

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@573 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoLog level for "Warning: expected transfer length X for opcode Y" changed to be disabl...
vlnb [Tue, 18 Nov 2008 18:42:09 +0000 (18:42 +0000)]
Log level for "Warning: expected transfer length X for opcode Y" changed to be disabled by default for release build

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@572 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes sparse warnings about int / unsigned int mismatches in
vlnb [Tue, 18 Nov 2008 18:23:08 +0000 (18:23 +0000)]
The patch below fixes sparse warnings about int / unsigned int mismatches in
the iscsi-scst source code.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@571 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup
vlnb [Thu, 13 Nov 2008 16:14:06 +0000 (16:14 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@570 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes many checkpatch warnings triggered by the iSCSI kernel
vlnb [Wed, 12 Nov 2008 18:49:18 +0000 (18:49 +0000)]
The patch below fixes many checkpatch warnings triggered by the iSCSI kernel
code, mainly about lines that exceeded 80 columns. As you can see in the patch
below most lines that were too long have been split, but some code has also
been moved into helper functions in order to keep the code readable. No
functionality has been changed.

This patch has been verified as follows:
- Reread the patch carefully.
- Verified that the iSCSI target kernel module still loads.
- Verified the output generated by scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
with some modifications

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@569 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoHere is the patch to fix problems with scst_local and 2.6.24 or earlier (tested by...
vlnb [Tue, 11 Nov 2008 12:04:52 +0000 (12:04 +0000)]
Here is the patch to fix problems with scst_local and 2.6.24 or earlier (tested by building under 2.6.24).

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
This line, and those below, will be ignored--

M    trunk/scst_local/scst_local.c

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@568 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded possibility to coexist if both target driver and dev handler need custom memory...
vlnb [Tue, 11 Nov 2008 11:56:18 +0000 (11:56 +0000)]
Added possibility to coexist if both target driver and dev handler need custom memory allocation. Direct consequences:

1. scst_local can work with scst_user's devices

2. scst_user now compatible with iscsi-scst if put_page_callback not applied

+ some cosmetics

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@567 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSmall cleanup of unused code
vlnb [Mon, 10 Nov 2008 17:23:23 +0000 (17:23 +0000)]
Small cleanup of unused code

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@566 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoDepecated scst_cmd_get_tgt_resp_flags() removed
vlnb [Mon, 10 Nov 2008 17:21:09 +0000 (17:21 +0000)]
Depecated scst_cmd_get_tgt_resp_flags() removed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@565 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes warning:
vlnb [Mon, 10 Nov 2008 17:11:48 +0000 (17:11 +0000)]
Fixes warning:

trunk/scst_local/scst_local.c:907: warning: initialization from incompatible pointer type

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@564 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded proposed patch to solve SG IO count limitation issue in pass-through mode....
vlnb [Fri, 7 Nov 2008 18:47:17 +0000 (18:47 +0000)]
Added proposed patch to solve SG IO count limitation issue in pass-through mode. It allows SGV cache do allocation
of pages with order > 0, i.e. more than 1 page per SG entry. Web and doc updated correspondingly.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@563 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake SWP and TAS parameters changable in vdisk handler.
vlnb [Thu, 6 Nov 2008 12:06:58 +0000 (12:06 +0000)]
Make SWP and TAS parameters changable in vdisk handler.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@562 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAttached is a patch that I think makes scst_local properly handle multiple targets...
vlnb [Wed, 5 Nov 2008 18:56:31 +0000 (18:56 +0000)]
Attached is a patch that I think makes scst_local properly handle multiple targets per host.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@561 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup: one more __GFP_NOFAIL removed
vlnb [Sat, 1 Nov 2008 11:45:26 +0000 (11:45 +0000)]
Cleanup: one more __GFP_NOFAIL removed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@560 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSmall optimization
vlnb [Fri, 31 Oct 2008 18:56:01 +0000 (18:56 +0000)]
Small optimization

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@559 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFollow-up improvements to r556
vlnb [Fri, 31 Oct 2008 16:17:08 +0000 (16:17 +0000)]
Follow-up improvements to r556

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@558 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixed incorrect SCST state used on error path
vlnb [Fri, 31 Oct 2008 11:16:47 +0000 (11:16 +0000)]
 - Fixed incorrect SCST state used on error path
 - Small cleanups
 - ToDo entry added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@557 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanup removing usage of in_atomic(). Particularly, now target drivers and dev handl...
vlnb [Fri, 31 Oct 2008 10:49:25 +0000 (10:49 +0000)]
Cleanup removing usage of in_atomic(). Particularly, now target drivers and dev handlers need to explicitly supply preferred execution context in scst_cmd_done() and scst_tgt_cmd_done().

WARNING! This commit changes external SCST interface, so it can break compilation of your out of SCST SVN tree target driver or dev handler. To fix it, simply supply the preferred exection context to scst_cmd_done() and/or scst_tgt_cmd_done().

Thanks to Bart Van Assche <bart.vanassche@gmail.com> for pointing on it.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@556 d57e44dd-8a1f-0410-8b47-8ef2f437770f