mirror/scst/.git
10 years agoUpdated kernel revisions.
bvassche [Fri, 2 Apr 2010 10:41:09 +0000 (10:41 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1578 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Thu, 1 Apr 2010 10:54:46 +0000 (10:54 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1577 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed two more compiler warnings.
bvassche [Thu, 1 Apr 2010 10:53:41 +0000 (10:53 +0000)]
Fixed two more compiler warnings.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1576 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Wed, 31 Mar 2010 18:04:23 +0000 (18:04 +0000)]
Changes:
- Fixed a rare lockup triggered by module removal while I/O was ongoing.
- Made sure that IB cable removal works fine.
- Exported srpt_service_guid via sysfs.
- Made sure that ib_srpt.c compiles fine with #undef CONFIG_SCST_PROC.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1575 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Improve errors reporting
vlnb [Wed, 31 Mar 2010 11:42:15 +0000 (11:42 +0000)]
 - Improve errors reporting

 - Fix minor race for sense buffer allocation

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1574 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix for compilaion issue with kernels between .18 < and .25.
vlnb [Wed, 31 Mar 2010 11:10:08 +0000 (11:10 +0000)]
Fix for compilaion issue with kernels between .18 < and .25.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1573 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed several compiler warnings.
bvassche [Wed, 31 Mar 2010 09:18:28 +0000 (09:18 +0000)]
Fixed several compiler warnings.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1572 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a format specification mismatch.
bvassche [Wed, 31 Mar 2010 06:51:51 +0000 (06:51 +0000)]
Fixed a format specification mismatch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1571 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Some reference leaks fixed
vlnb [Tue, 30 Mar 2010 11:28:20 +0000 (11:28 +0000)]
 - Some reference leaks fixed
 - Updated to compile on pre-2.6.25 kernels
 - Small docs updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1570 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoConverted function, enum and struct documentation to kernel-doc style.
bvassche [Sat, 27 Mar 2010 10:40:13 +0000 (10:40 +0000)]
Converted function, enum and struct documentation to kernel-doc style.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1569 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed several compiler and checkpatch warnings.
bvassche [Sat, 27 Mar 2010 08:46:06 +0000 (08:46 +0000)]
Fixed several compiler and checkpatch warnings.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1568 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed checkpatch complaints about whitespace.
bvassche [Sat, 27 Mar 2010 08:45:18 +0000 (08:45 +0000)]
Fixed checkpatch complaints about whitespace.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1567 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved trailing whitespace.
bvassche [Sat, 27 Mar 2010 08:27:21 +0000 (08:27 +0000)]
Removed trailing whitespace.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1566 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSmall cleanups and improvements
vlnb [Fri, 26 Mar 2010 19:46:41 +0000 (19:46 +0000)]
Small cleanups and improvements

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1565 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoDocument that the io_context patch isn't needed anymore
vlnb [Thu, 25 Mar 2010 19:47:28 +0000 (19:47 +0000)]
Document that the io_context patch isn't needed anymore

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1564 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoGreat threads handling and performance improvements:
vlnb [Thu, 25 Mar 2010 19:43:41 +0000 (19:43 +0000)]
Great threads handling and performance improvements:

 - io_context not needed anymore

 - Now threads pool can be per session

 - Each device now can have own type of threads pool with own threads count

+ docs updates and some cleanups and minor fixes.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1563 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSmall web fixes
vlnb [Tue, 23 Mar 2010 14:08:17 +0000 (14:08 +0000)]
Small web fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1562 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agodos2unix
vlnb [Fri, 19 Mar 2010 11:47:42 +0000 (11:47 +0000)]
dos2unix

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1561 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix minor mistake
vlnb [Fri, 19 Mar 2010 11:44:39 +0000 (11:44 +0000)]
Fix minor mistake

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1560 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAddressing method docs updated
vlnb [Thu, 18 Mar 2010 19:29:31 +0000 (19:29 +0000)]
Addressing method docs updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1559 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoDeeply reworked patch from Mehmet Ali Cer <mehmet.ali.cer@gmail.com> implementing...
vlnb [Thu, 18 Mar 2010 18:17:06 +0000 (18:17 +0000)]
Deeply reworked patch from Mehmet Ali Cer <mehmet.ali.cer@gmail.com> implementing flat LUNs addressing methods required by some operation systems.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1558 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemake CONFIG_SCST_STRICT_SERIALIZING in a more simple and straightforward way using...
vlnb [Thu, 18 Mar 2010 12:05:11 +0000 (12:05 +0000)]
Remake CONFIG_SCST_STRICT_SERIALIZING in a more simple and straightforward way using ORDERED attribute

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1557 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUniform max queue depth handling in iSCSI
vlnb [Thu, 18 Mar 2010 11:44:39 +0000 (11:44 +0000)]
Uniform max queue depth handling in iSCSI

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1556 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix for possible requirsive target_mutex taking
vlnb [Wed, 17 Mar 2010 19:41:16 +0000 (19:41 +0000)]
Fix for possible requirsive target_mutex taking

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1554 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdd new scst_cmd_get_queue_type()/scst_cmd_set_queue_type() accessors and use them...
vlnb [Wed, 17 Mar 2010 19:11:18 +0000 (19:11 +0000)]
Add new scst_cmd_get_queue_type()/scst_cmd_set_queue_type() accessors and use them in target drivers instead of direct access to SCST's cmd->queue_type.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1553 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix copy_to_user()/copy_from_user() wrong reeturn value processing
vlnb [Wed, 17 Mar 2010 18:45:23 +0000 (18:45 +0000)]
Fix copy_to_user()/copy_from_user() wrong reeturn value processing

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1552 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSome speedup for massive targets deletions
vlnb [Wed, 17 Mar 2010 18:05:31 +0000 (18:05 +0000)]
Some speedup for massive targets deletions

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1549 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSet bufflen for not expected transfer len case to max to allow, e.g., to get immediat...
vlnb [Wed, 17 Mar 2010 17:40:17 +0000 (17:40 +0000)]
Set bufflen for not expected transfer len case to max to allow, e.g., to get immediate iSCSI data. Otherwise, the iSCSI target will get a too low buffer error and have to close connection.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1548 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Alexey Obitotskiy <alexeyo1@open-e.com> (with changes) implementing suppor...
vlnb [Wed, 17 Mar 2010 14:03:41 +0000 (14:03 +0000)]
Patch from Alexey Obitotskiy <alexeyo1@open-e.com> (with changes) implementing support limiting number of sessions for a target (MaxSessions)

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1547 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoKey mark for explicit confirmations added
vlnb [Wed, 17 Mar 2010 12:56:35 +0000 (12:56 +0000)]
Key mark for explicit confirmations added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1546 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMinor docs update
vlnb [Wed, 17 Mar 2010 12:48:21 +0000 (12:48 +0000)]
Minor docs update

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1545 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates
vlnb [Tue, 16 Mar 2010 18:38:13 +0000 (18:38 +0000)]
Web updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1544 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoClarified a source code comment.
bvassche [Mon, 15 Mar 2010 19:25:29 +0000 (19:25 +0000)]
Clarified a source code comment.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1543 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - SysfsRules file added
vlnb [Sat, 13 Mar 2010 11:59:24 +0000 (11:59 +0000)]
 - SysfsRules file added
 - Other docs updated
 - ini_group renamed to ini_groups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1542 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSmall docs updates
vlnb [Wed, 10 Mar 2010 17:57:39 +0000 (17:57 +0000)]
Small docs updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1541 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Limit devices names to avoid confusions with truncated names
vlnb [Wed, 10 Mar 2010 12:51:04 +0000 (12:51 +0000)]
 - Limit devices names to avoid confusions with truncated names
 - For sysfs build remove scst_vdisk_ID module parameter and introduce setup_id sysfs attribute with the same goal
 - Minor fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1540 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMake enable_target() interface more clear
vlnb [Wed, 10 Mar 2010 11:56:15 +0000 (11:56 +0000)]
Make enable_target() interface more clear

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1539 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Dev handler sysfs interface changed to match new unified rules
vlnb [Tue, 9 Mar 2010 19:36:48 +0000 (19:36 +0000)]
 - Dev handler sysfs interface changed to match new unified rules
 - Docs updated
 - Other minor fixes, improvements and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1538 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemove accidental double cmnd_exec_logout() call noticed by Alexey Obitotskiy <alexey...
vlnb [Tue, 9 Mar 2010 11:21:27 +0000 (11:21 +0000)]
Remove accidental double cmnd_exec_logout() call noticed by Alexey Obitotskiy <alexeyo1@open-e.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1537 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoThis patch allows for SCST_USER_PARSE to return status and abort commands execution...
vlnb [Tue, 9 Mar 2010 11:13:50 +0000 (11:13 +0000)]
This patch allows for SCST_USER_PARSE to return status and abort commands execution on the parse stage.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1536 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Alexey Obitotskiy <alexeyo1@open-e.com> implementing EUI-64 identifier...
vlnb [Fri, 5 Mar 2010 17:53:27 +0000 (17:53 +0000)]
Patch from Alexey Obitotskiy <alexeyo1@open-e.com> implementing EUI-64 identifier for 0x83 VPD page

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1535 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoForgotted piece of noop -> nop rename
vlnb [Fri, 5 Mar 2010 13:09:30 +0000 (13:09 +0000)]
Forgotted piece of noop -> nop rename

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1534 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoDeeply reworked patch from Alexey Obitotskiy <alexeyo1@open-e.com> implementing suppo...
vlnb [Fri, 5 Mar 2010 12:56:20 +0000 (12:56 +0000)]
Deeply reworked patch from Alexey Obitotskiy <alexeyo1@open-e.com> implementing support for sending NOP-In requests

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1533 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated error messages -- req_lim < 0 is not an internal error but can be caused...
bvassche [Wed, 3 Mar 2010 19:36:05 +0000 (19:36 +0000)]
Updated error messages -- req_lim < 0 is not an internal error but can be caused by a buggy initiator.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1532 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded missing space in an error message.
bvassche [Wed, 3 Mar 2010 19:29:37 +0000 (19:29 +0000)]
Added missing space in an error message.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1531 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoIf a device set read-only in a security group, it should also be reported in MODE...
vlnb [Wed, 3 Mar 2010 10:57:53 +0000 (10:57 +0000)]
If a device set read-only in a security group, it should also be reported in MODE SENSE

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1530 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFollow up to the previous commit
vlnb [Tue, 2 Mar 2010 17:58:44 +0000 (17:58 +0000)]
Follow up to the previous commit

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1529 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Makes initial pass-through devices checks less strict. The main reason for that...
vlnb [Tue, 2 Mar 2010 17:32:23 +0000 (17:32 +0000)]
 - Makes initial pass-through devices checks less strict. The main reason for that is because not all devices comply SCSI requirements too well.
 - Workarounds in vdisk readv/writev limitation to process only limited number of entries per call

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1528 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixes crash on very big buffers allocations reported by Matteo Tescione <matteo@rmnet...
vlnb [Mon, 1 Mar 2010 19:41:14 +0000 (19:41 +0000)]
Fixes crash on very big buffers allocations reported by Matteo Tescione <matteo@rmnet.it> and others

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1527 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agofcst: fix abort handling
jeykholt [Mon, 1 Mar 2010 18:35:36 +0000 (18:35 +0000)]
fcst: fix abort handling

Call scst_tgt_cmd_done() on aborted commands.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1526 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoscripts/run-regression-tests works now for the 2.6.33 kernel too.
bvassche [Mon, 1 Mar 2010 17:32:38 +0000 (17:32 +0000)]
scripts/run-regression-tests works now for the 2.6.33 kernel too.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1525 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdate for 2.6.33
vlnb [Mon, 1 Mar 2010 15:56:31 +0000 (15:56 +0000)]
Update for 2.6.33

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1524 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Alexey Obitotskiy <alexeyo1@open-e.com> with cleanups and fixes implementi...
vlnb [Mon, 1 Mar 2010 13:38:06 +0000 (13:38 +0000)]
Patch from Alexey Obitotskiy <alexeyo1@open-e.com> with cleanups and fixes implementing setting and managing relative target IDs.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1523 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agofcst: set max_hw_pending_time
jeykholt [Thu, 25 Feb 2010 18:23:23 +0000 (18:23 +0000)]
fcst: set max_hw_pending_time

The target template max_hw_pending_time was zero, causing
premature timeouts and a fast retry in scst_hw_pending_work_fn().

Set it to 20 seconds, like qla2x00t does, for now.
It could be the wrong thing for tape, but should be
plenty long enough for disks.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1522 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoA set of startup scripts for Gentoo customized by Scott R. Bowe <scottb@sentania...
vlnb [Thu, 25 Feb 2010 14:14:23 +0000 (14:14 +0000)]
A set of startup scripts for Gentoo customized by Scott R. Bowe <scottb@sentania.net>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1521 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMinor fixes and cleanups
vlnb [Thu, 25 Feb 2010 13:37:56 +0000 (13:37 +0000)]
Minor fixes and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1520 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoProperty svn:ignore set
vlnb [Thu, 25 Feb 2010 11:33:24 +0000 (11:33 +0000)]
Property svn:ignore set

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1519 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved trailing whitespace because checkpatch complained about it.
bvassche [Sun, 21 Feb 2010 19:30:39 +0000 (19:30 +0000)]
Removed trailing whitespace because checkpatch complained about it.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1518 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded fcst code in generate-kernel-patch output.
bvassche [Sun, 21 Feb 2010 09:00:20 +0000 (09:00 +0000)]
Added fcst code in generate-kernel-patch output.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1517 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates and fixes
vlnb [Sat, 20 Feb 2010 20:35:28 +0000 (20:35 +0000)]
Web updates and fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1516 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - New main Makefile target fcst added
vlnb [Sat, 20 Feb 2010 20:08:10 +0000 (20:08 +0000)]
 - New main Makefile target fcst added
 - Preliminary fixes to compile on 2.6.33

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1515 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoThis patch adds a new target module for SCST and libfc
vlnb [Sat, 20 Feb 2010 20:02:02 +0000 (20:02 +0000)]
This patch adds a new target module for SCST and libfc
that accepts FCP requests from libfc HBAs running Fibre Channel
over Ethernet (FCoE) and passes them to SCST.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1514 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykho...
vlnb [Fri, 19 Feb 2010 18:45:53 +0000 (18:45 +0000)]
Fixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykholt@cisco.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1513 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed two WARN_ON() statements.
bvassche [Fri, 19 Feb 2010 12:03:48 +0000 (12:03 +0000)]
Fixed two WARN_ON() statements.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1512 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity...
vlnb [Wed, 17 Feb 2010 19:07:54 +0000 (19:07 +0000)]
Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWorks now when started with a relative path too.
bvassche [Mon, 15 Feb 2010 19:09:48 +0000 (19:09 +0000)]
Works now when started with a relative path too.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1510 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded to repository.
bvassche [Mon, 15 Feb 2010 17:34:22 +0000 (17:34 +0000)]
Added to repository.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1509 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFactored out channel unregistration code into a new function srpt_unregister_channel().
bvassche [Sun, 14 Feb 2010 12:51:14 +0000 (12:51 +0000)]
Factored out channel unregistration code into a new function srpt_unregister_channel().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1508 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a memory leak in an error path.
bvassche [Sun, 14 Feb 2010 12:11:54 +0000 (12:11 +0000)]
Fixed a memory leak in an error path.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1507 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMoved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd().
bvassche [Sun, 14 Feb 2010 12:08:47 +0000 (12:08 +0000)]
Moved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1506 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Sun, 14 Feb 2010 11:36:34 +0000 (11:36 +0000)]
Changes:
- Fixed race condition between SCST session registration and IB channel event
  handler in srpt_add_one(): at least in theory it was possible that
  sdev->scst_tgt was accessed before being initialized properly.
- A kernel WARN_ON() is no longer triggered when a DREQ has been received after
  SCST session deregistration started.
- Made sure that srpt_unmap_sg_to_ib_sge() does not call ib_dma_unmap_sg()
  twice.
- Moved srpt_unmap_sg_to_ib_sge() call out of srpt_reset_ioctx() and
  srpt_abort_scst_cmd() into the callers of these functions.
- Renamed some of the SRPT command states.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1505 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved handling of AESOLNT, CRSOLNT and LOSOLNT flags again.
bvassche [Fri, 12 Feb 2010 19:42:00 +0000 (19:42 +0000)]
Removed handling of AESOLNT, CRSOLNT and LOSOLNT flags again.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1504 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSimplified implementation of the thread=1 mode.
bvassche [Fri, 12 Feb 2010 19:37:43 +0000 (19:37 +0000)]
Simplified implementation of the thread=1 mode.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1503 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated test instructions.
bvassche [Fri, 12 Feb 2010 19:30:08 +0000 (19:30 +0000)]
Updated test instructions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1502 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCompiles again without warnings.
bvassche [Fri, 12 Feb 2010 18:59:15 +0000 (18:59 +0000)]
Compiles again without warnings.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1501 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCommented out required by iSCSI RFC, but not needed for processing, check of LUN...
vlnb [Fri, 12 Feb 2010 13:12:58 +0000 (13:12 +0000)]
Commented out required by iSCSI RFC, but not needed for processing, check of LUN field in Data-Out PDU, because some initiators (Windows, at least) don't care to correctly set it.

Reported and tested by Ladislav PaĊĦek <pasek@valbek.cz>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1500 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoThose files were deleted moving to new pass-through implementation, but should have...
vlnb [Fri, 12 Feb 2010 13:07:23 +0000 (13:07 +0000)]
Those files were deleted moving to new pass-through implementation, but should have been resurrected when that implementation was limited to 2.6.30+ kernels only. Fixing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1499 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade ib_srpt easier to build on a multiboot system where multiple kernels
bvassche [Thu, 11 Feb 2010 19:28:58 +0000 (19:28 +0000)]
Made ib_srpt easier to build on a multiboot system where multiple kernels
have been installed -- one kernel with OFED and one or more kernels without
OFED.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1498 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed two MODULE_PARM_DESC() clauses.
bvassche [Thu, 11 Feb 2010 19:27:49 +0000 (19:27 +0000)]
Fixed two MODULE_PARM_DESC() clauses.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1497 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Christian Motschke <motschke@itso-berlin.de>:
vlnb [Wed, 10 Feb 2010 19:32:31 +0000 (19:32 +0000)]
Patch from Christian Motschke <motschke@itso-berlin.de>:

I had some problems compiling scst due to some bashisms in the Makefiles. As
you will know, Debian uses /bin/dash as default shell and /bin/sh is only a
link to /bin/dash. I can either change the default shell, (or in my opinion
the better solution) use SHELL=/bin/bash in the Makefile.
I have made a patch for the Makefiles in question (I hope, that are all
Makefiles).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1496 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agocmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD
vlnb [Wed, 10 Feb 2010 19:22:39 +0000 (19:22 +0000)]
cmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD

Noticed by Alexey Obitotskiy <alexeyo1@open-e.com>

This line, and those below, will be ignored--

M    trunk/iscsi-scst/usr/iscsid.c

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1495 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 9 Feb 2010 15:46:10 +0000 (15:46 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1494 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agosvn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate...
bvassche [Sun, 7 Feb 2010 09:06:03 +0000 (09:06 +0000)]
svn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate-rx-tx-buffers/scripts

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1493 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates
vlnb [Tue, 2 Feb 2010 17:16:58 +0000 (17:16 +0000)]
Web updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1490 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRepeated performance measurements for r1373 and the code on this branch.
bvassche [Fri, 29 Jan 2010 19:09:06 +0000 (19:09 +0000)]
Repeated performance measurements for r1373 and the code on this branch.
Results: identical throughput for all test cases, except for 128K and 8K
asynchronous writes, where the implementation on the branch performs 19%
and 15% faster than r1373 respectively.

Setup details for the target:
* 2.6.30.7 kernel with SCST patches and with kernel debugging disabled.
* SCST revision compiled in release mode (make debug2release).
* ib_srpt kernel module parameters thread=0.
* 1 GB file residing on a tmpfs filesystem was exported via scst_vdisk.
* Frequency scaling was disabled.
* Runlevel: 3.

Setup details for the initiator:
* vanilla 2.6.27.39 kernel.
* SRP initiator was loaded with parameter srp_sg_tablesize=128
* Frequency scaling was disabled.
* Runlevel: 3.

Results for SCST r1373:

$ ~bart/software/scst/scripts/blockdev-perftest -d -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.223    1.223    1.225  836.768    0.736   13.075    0.595    0.595    0.595 1720.680    0.851   26.886
 33554432    1.210    1.210    1.210  846.088    0.088   26.440    0.606    0.605    0.606 1690.110    1.920   52.816
 16777216    1.185    1.185    1.185  864.121    0.248   54.008    0.622    0.622    0.623 1645.466    1.497  102.842
  8388608    1.135    1.129    1.132  904.632    1.878  113.079    0.649    0.652    0.652 1572.881    3.051  196.610
  4194304    1.040    1.045    1.043  982.054    1.918  245.513    0.696    0.694    0.695 1472.949    1.982  368.237
  2097152    1.098    1.097    1.096  933.543    0.490  466.772    0.767    0.768    0.764 1335.724    2.799  667.862
  1048576    1.265    1.264    1.265  809.638    0.367  809.638    0.901    0.908    0.900 1134.238    4.161 1134.238
   524288    1.501    1.506    1.502  681.378    0.931 1362.756    1.117    1.125    1.124  912.656    2.814 1825.313
   262144    1.668    1.662    1.661  615.442    1.206 2461.770    1.235    1.230    1.234  830.492    1.361 3321.970
   131072    1.860    1.851    1.855  551.951    1.083 4415.610    1.282    1.274    1.276  801.575    2.029 6412.599
    65536    2.236    2.245    2.238  457.248    0.797 7315.963    1.613    1.622    1.608  634.377    2.323 10150.035
    32768    3.065    3.062    3.078  333.698    0.732 10678.340    2.283    2.274    2.273  449.759    0.945 14392.298
    16384    4.706    4.794    4.716  216.114    1.779 13831.324    3.662    3.645    3.645  280.513    0.609 17952.809
     8192    8.097    8.237    8.096  125.752    1.017 16096.212    6.297    6.302    6.289  162.640    0.134 20817.981
     4096   14.674   14.694   14.657   69.780    0.071 17863.608   11.449   11.440   11.408   89.570    0.139 22929.974
$ ~bart/software/scst/scripts/blockdev-perftest -a -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.701    1.705    1.699  601.771    0.822    9.403    1.709    1.728    1.728  594.774    3.119    9.293
 33554432    1.695    1.618    1.603  625.428   15.196   19.545    1.719    1.720    1.723  595.142    0.687   18.598
 16777216    1.600    1.598    1.598  640.423    0.436   40.026    1.741    1.720    1.722  592.707    3.291   37.044
  8388608    1.809    1.807    1.568  595.301   40.790   74.413    1.706    1.705    1.705  600.468    0.156   75.058
  4194304    1.314    1.314    1.551  739.690   56.260  184.922    1.628    1.634    1.629  628.190    0.951  157.048
  2097152    1.040    0.981    1.189  963.138   75.904  481.569    1.407    1.426    1.425  721.444    4.347  360.722
  1048576    1.064    0.995    1.067  983.835   32.288  983.835    1.285    1.277    1.286  798.358    2.347  798.358
   524288    0.984    1.058    0.987 1015.093   33.379 2030.187    1.252    1.254    1.250  817.791    1.280 1635.582
   262144    0.986    0.982    1.153  989.944   71.807 3959.778    1.243    1.249    1.244  822.357    1.723 3289.428
   131072    1.155    1.160    1.160  883.882    1.666 7071.055    1.251    1.252    1.252  818.046    0.179 6544.368
    65536    0.928    0.928    1.166 1028.366  106.412 16453.859    1.262    1.254    1.255  814.735    2.217 13035.757
    32768    1.183    1.084    1.084  918.281   37.291 29385.000    1.260    1.262    1.257  812.726    1.254 26007.237
    16384    0.930    1.178    0.931 1023.755  109.140 65520.309    1.266    1.270    1.269  807.233    1.189 51662.925
     8192    1.203    1.101    1.112  900.865   35.135 115310.778    1.273    1.274    1.272  804.366    0.725 102958.849
     4096    0.999    1.094    1.093  966.038   41.681 247305.603    1.293    1.293    1.293  792.081    0.136 202772.806

Results for the SCST code on this branch:

$ ~bart/software/scst/scripts/blockdev-perftest -d -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.220    1.225    1.220  838.049    1.672   13.095    0.595    0.595    0.596 1720.849    0.929   26.888
 33554432    1.208    1.207    1.210  847.223    0.909   26.476    0.603    0.603    0.604 1697.318    1.800   53.041
 16777216    1.180    1.181    1.179  867.755    0.626   54.235    0.619    0.619    0.619 1654.679    0.375  103.417
  8388608    1.127    1.130    1.128  907.754    1.025  113.469    0.649    0.649    0.650 1577.987    1.350  197.248
  4194304    1.041    1.043    1.084  970.038   17.898  242.509    0.745    0.691    0.691 1446.033   50.051  361.508
  2097152    1.096    1.097    1.097  933.846    0.127  466.923    0.770    0.769    0.768 1331.667    1.308  665.834
  1048576    1.268    1.282    1.269  804.454    3.912  804.454    0.912    0.909    0.910 1125.005    1.691 1125.005
   524288    1.518    1.519    1.518  674.360    0.179 1348.720    1.132    1.133    1.127  905.460    2.061 1810.919
   262144    1.686    1.687    1.685  607.410    0.289 2429.640    1.234    1.233    1.235  829.988    0.750 3319.953
   131072    1.845    1.855    1.849  553.648    1.199 4429.182    1.281    1.271    1.270  803.701    3.236 6429.607
    65536    2.243    2.238    2.250  456.401    0.958 7302.419    1.610    1.609    1.615  635.507    1.152 10168.115
    32768    3.100    3.096    3.101  330.442    0.191 10574.158    2.281    2.273    2.276  449.770    0.680 14392.647
    16384    4.730    4.738    4.781  215.603    1.015 13798.570    3.668    3.658    3.630  280.404    1.249 17945.853
     8192    8.136    8.143    8.125  125.879    0.117 16112.492    6.310    6.288    6.320  162.386    0.343 20785.421
     4096   14.734   14.777   14.729   69.440    0.102 17776.731   11.434   11.434   11.421   89.591    0.051 22935.343
$ ~bart/software/scst/scripts/blockdev-perftest -a -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.621    1.616    1.859  605.258   38.591    9.457    1.733    1.732    1.730  591.217    0.421    9.238
 33554432    1.606    1.849    1.608  609.432   39.346   19.045    1.748    1.727    1.781  584.599    7.431   18.269
 16777216    1.613    1.615    1.838  608.666   36.341   38.042    1.726    1.723    1.732  592.885    1.307   37.055
  8388608    1.806    1.808    1.598  591.362   34.824   73.920    1.713    1.711    1.710  598.426    0.454   74.803
  4194304    1.555    1.332    1.543  696.900   50.708  174.225    1.633    1.685    1.642  619.381    8.436  154.845
  2097152    0.966    0.966    0.957 1063.283    5.105  531.642    1.413    1.409    1.415  724.960    1.347  362.480
  1048576    1.166    0.933    1.173  949.570  104.943  949.570    1.276    1.278    1.280  801.318    0.890  801.318
   524288    0.930    0.930    1.158 1028.986  102.433 2057.971    1.253    1.253    1.255  816.704    0.517 1633.409
   262144    0.993    0.958    1.167  992.704   83.077 3970.817    1.242    1.243    1.244  823.968    0.476 3295.873
   131072    0.998    0.994    0.932 1051.674   33.625 8413.395    1.256    1.251    1.251  817.434    1.742 6539.470
    65536    0.929    1.173    0.931 1025.243  107.612 16403.886    1.250    1.254    1.253  817.667    1.190 13082.667
    32768    0.933    1.185    1.182  942.734  109.764 30167.481    1.266    1.268    1.262  809.419    1.637 25901.411
    16384    1.174    1.006    1.008  968.451   68.247 61980.887    1.262    1.267    1.269  808.751    1.941 51760.085
     8192    1.041    0.990    0.934 1037.960   45.831 132858.894    1.270    1.310    1.274  797.260   10.946 102049.295
     4096    1.287    1.000    1.001  947.597  107.493 242584.705    1.294    1.309    1.287  789.841    5.665 202199.350

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1483 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Fri, 29 Jan 2010 11:54:38 +0000 (11:54 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1482 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agosession_active_commands_attr attribute must have active_commands name.
vlnb [Tue, 26 Jan 2010 13:02:13 +0000 (13:02 +0000)]
session_active_commands_attr attribute must have active_commands name.

Reported by Joe Eykholt <jeykholt@cisco.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1478 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 26 Jan 2010 11:52:01 +0000 (11:52 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1477 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Sat, 23 Jan 2010 08:54:06 +0000 (08:54 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1476 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 19 Jan 2010 11:37:41 +0000 (11:37 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1475 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMoved comma's in table header to the proper place.
bvassche [Sun, 17 Jan 2010 17:36:50 +0000 (17:36 +0000)]
Moved comma's in table header to the proper place.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1474 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Sun, 17 Jan 2010 13:07:46 +0000 (13:07 +0000)]
Changes:
- The entire receive queue can be used again instead of only SRPT_RQ_SIZE - 1
  elements (as in r1470).
- Added initiator-lockup-avoidance code to SRP_TSK_MGMT processing code too.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1473 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated test instructions.
bvassche [Sat, 16 Jan 2010 19:38:08 +0000 (19:38 +0000)]
Updated test instructions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1472 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated copyright statement.
bvassche [Sat, 16 Jan 2010 19:36:29 +0000 (19:36 +0000)]
Updated copyright statement.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1471 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Thu, 14 Jan 2010 20:35:37 +0000 (20:35 +0000)]
Changes:
- Updated copyright statement.
- Micro-optimized the function srpt_req_lim_delta().
- Made sure that SRPT does not cause a lockup in (at least) the Linux SRP
  initiator. See also http://bugzilla.kernel.org/show_bug.cgi?id=14235.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1470 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved a trailing space because checkpatch complained about it.
bvassche [Thu, 14 Jan 2010 13:37:56 +0000 (13:37 +0000)]
Removed a trailing space because checkpatch complained about it.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1469 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoEnabled sparse checking for the 2.6.23.17 kernel.
bvassche [Thu, 14 Jan 2010 13:28:26 +0000 (13:28 +0000)]
Enabled sparse checking for the 2.6.23.17 kernel.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1468 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following...
vlnb [Thu, 14 Jan 2010 13:14:30 +0000 (13:14 +0000)]
Patch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following scenario:

1. Commands start going to the init_cmd_list probably because SCST was suspended
2. A command is now waiting in the init_cmd_list, it was not yet completely initialized (more impotently cmd->dev == NULL)
3. A clear task set for the same lun arrives from a different initiator
4. The command is marked as aborted from other initiator and released from the init list.
5. The command gets to the PRE_XMIT_RESPONSE state, since it was aborted the scst_xmit_process_aborted_cmd is called.
6. At this stage since the command is marked as aborted by other initiator the scst checks for the device TAS flag (cmd->dev->tas) however cmd->dev is NULL and we crash on Null pointer de-referencing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1466 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoImprove handling of aborts of done commands
vlnb [Thu, 14 Jan 2010 12:59:13 +0000 (12:59 +0000)]
Improve handling of aborts of done commands

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1465 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved SRP_CRED_REQ support again.
bvassche [Wed, 13 Jan 2010 20:19:54 +0000 (20:19 +0000)]
Removed SRP_CRED_REQ support again.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1464 d57e44dd-8a1f-0410-8b47-8ef2f437770f