mirror/scst/.git
10 years agoFixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykho...
vlnb [Fri, 19 Feb 2010 18:45:53 +0000 (18:45 +0000)]
Fixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykholt@cisco.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1513 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed two WARN_ON() statements.
bvassche [Fri, 19 Feb 2010 12:03:48 +0000 (12:03 +0000)]
Fixed two WARN_ON() statements.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1512 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity...
vlnb [Wed, 17 Feb 2010 19:07:54 +0000 (19:07 +0000)]
Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWorks now when started with a relative path too.
bvassche [Mon, 15 Feb 2010 19:09:48 +0000 (19:09 +0000)]
Works now when started with a relative path too.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1510 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded to repository.
bvassche [Mon, 15 Feb 2010 17:34:22 +0000 (17:34 +0000)]
Added to repository.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1509 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFactored out channel unregistration code into a new function srpt_unregister_channel().
bvassche [Sun, 14 Feb 2010 12:51:14 +0000 (12:51 +0000)]
Factored out channel unregistration code into a new function srpt_unregister_channel().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1508 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a memory leak in an error path.
bvassche [Sun, 14 Feb 2010 12:11:54 +0000 (12:11 +0000)]
Fixed a memory leak in an error path.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1507 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMoved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd().
bvassche [Sun, 14 Feb 2010 12:08:47 +0000 (12:08 +0000)]
Moved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1506 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Sun, 14 Feb 2010 11:36:34 +0000 (11:36 +0000)]
Changes:
- Fixed race condition between SCST session registration and IB channel event
  handler in srpt_add_one(): at least in theory it was possible that
  sdev->scst_tgt was accessed before being initialized properly.
- A kernel WARN_ON() is no longer triggered when a DREQ has been received after
  SCST session deregistration started.
- Made sure that srpt_unmap_sg_to_ib_sge() does not call ib_dma_unmap_sg()
  twice.
- Moved srpt_unmap_sg_to_ib_sge() call out of srpt_reset_ioctx() and
  srpt_abort_scst_cmd() into the callers of these functions.
- Renamed some of the SRPT command states.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1505 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved handling of AESOLNT, CRSOLNT and LOSOLNT flags again.
bvassche [Fri, 12 Feb 2010 19:42:00 +0000 (19:42 +0000)]
Removed handling of AESOLNT, CRSOLNT and LOSOLNT flags again.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1504 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSimplified implementation of the thread=1 mode.
bvassche [Fri, 12 Feb 2010 19:37:43 +0000 (19:37 +0000)]
Simplified implementation of the thread=1 mode.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1503 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated test instructions.
bvassche [Fri, 12 Feb 2010 19:30:08 +0000 (19:30 +0000)]
Updated test instructions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1502 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCompiles again without warnings.
bvassche [Fri, 12 Feb 2010 18:59:15 +0000 (18:59 +0000)]
Compiles again without warnings.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1501 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCommented out required by iSCSI RFC, but not needed for processing, check of LUN...
vlnb [Fri, 12 Feb 2010 13:12:58 +0000 (13:12 +0000)]
Commented out required by iSCSI RFC, but not needed for processing, check of LUN field in Data-Out PDU, because some initiators (Windows, at least) don't care to correctly set it.

Reported and tested by Ladislav PaĊĦek <pasek@valbek.cz>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1500 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoThose files were deleted moving to new pass-through implementation, but should have...
vlnb [Fri, 12 Feb 2010 13:07:23 +0000 (13:07 +0000)]
Those files were deleted moving to new pass-through implementation, but should have been resurrected when that implementation was limited to 2.6.30+ kernels only. Fixing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1499 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade ib_srpt easier to build on a multiboot system where multiple kernels
bvassche [Thu, 11 Feb 2010 19:28:58 +0000 (19:28 +0000)]
Made ib_srpt easier to build on a multiboot system where multiple kernels
have been installed -- one kernel with OFED and one or more kernels without
OFED.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1498 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed two MODULE_PARM_DESC() clauses.
bvassche [Thu, 11 Feb 2010 19:27:49 +0000 (19:27 +0000)]
Fixed two MODULE_PARM_DESC() clauses.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1497 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Christian Motschke <motschke@itso-berlin.de>:
vlnb [Wed, 10 Feb 2010 19:32:31 +0000 (19:32 +0000)]
Patch from Christian Motschke <motschke@itso-berlin.de>:

I had some problems compiling scst due to some bashisms in the Makefiles. As
you will know, Debian uses /bin/dash as default shell and /bin/sh is only a
link to /bin/dash. I can either change the default shell, (or in my opinion
the better solution) use SHELL=/bin/bash in the Makefile.
I have made a patch for the Makefiles in question (I hope, that are all
Makefiles).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1496 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agocmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD
vlnb [Wed, 10 Feb 2010 19:22:39 +0000 (19:22 +0000)]
cmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD

Noticed by Alexey Obitotskiy <alexeyo1@open-e.com>

This line, and those below, will be ignored--

M    trunk/iscsi-scst/usr/iscsid.c

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1495 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 9 Feb 2010 15:46:10 +0000 (15:46 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1494 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agosvn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate...
bvassche [Sun, 7 Feb 2010 09:06:03 +0000 (09:06 +0000)]
svn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate-rx-tx-buffers/scripts

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1493 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates
vlnb [Tue, 2 Feb 2010 17:16:58 +0000 (17:16 +0000)]
Web updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1490 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRepeated performance measurements for r1373 and the code on this branch.
bvassche [Fri, 29 Jan 2010 19:09:06 +0000 (19:09 +0000)]
Repeated performance measurements for r1373 and the code on this branch.
Results: identical throughput for all test cases, except for 128K and 8K
asynchronous writes, where the implementation on the branch performs 19%
and 15% faster than r1373 respectively.

Setup details for the target:
* 2.6.30.7 kernel with SCST patches and with kernel debugging disabled.
* SCST revision compiled in release mode (make debug2release).
* ib_srpt kernel module parameters thread=0.
* 1 GB file residing on a tmpfs filesystem was exported via scst_vdisk.
* Frequency scaling was disabled.
* Runlevel: 3.

Setup details for the initiator:
* vanilla 2.6.27.39 kernel.
* SRP initiator was loaded with parameter srp_sg_tablesize=128
* Frequency scaling was disabled.
* Runlevel: 3.

Results for SCST r1373:

$ ~bart/software/scst/scripts/blockdev-perftest -d -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.223    1.223    1.225  836.768    0.736   13.075    0.595    0.595    0.595 1720.680    0.851   26.886
 33554432    1.210    1.210    1.210  846.088    0.088   26.440    0.606    0.605    0.606 1690.110    1.920   52.816
 16777216    1.185    1.185    1.185  864.121    0.248   54.008    0.622    0.622    0.623 1645.466    1.497  102.842
  8388608    1.135    1.129    1.132  904.632    1.878  113.079    0.649    0.652    0.652 1572.881    3.051  196.610
  4194304    1.040    1.045    1.043  982.054    1.918  245.513    0.696    0.694    0.695 1472.949    1.982  368.237
  2097152    1.098    1.097    1.096  933.543    0.490  466.772    0.767    0.768    0.764 1335.724    2.799  667.862
  1048576    1.265    1.264    1.265  809.638    0.367  809.638    0.901    0.908    0.900 1134.238    4.161 1134.238
   524288    1.501    1.506    1.502  681.378    0.931 1362.756    1.117    1.125    1.124  912.656    2.814 1825.313
   262144    1.668    1.662    1.661  615.442    1.206 2461.770    1.235    1.230    1.234  830.492    1.361 3321.970
   131072    1.860    1.851    1.855  551.951    1.083 4415.610    1.282    1.274    1.276  801.575    2.029 6412.599
    65536    2.236    2.245    2.238  457.248    0.797 7315.963    1.613    1.622    1.608  634.377    2.323 10150.035
    32768    3.065    3.062    3.078  333.698    0.732 10678.340    2.283    2.274    2.273  449.759    0.945 14392.298
    16384    4.706    4.794    4.716  216.114    1.779 13831.324    3.662    3.645    3.645  280.513    0.609 17952.809
     8192    8.097    8.237    8.096  125.752    1.017 16096.212    6.297    6.302    6.289  162.640    0.134 20817.981
     4096   14.674   14.694   14.657   69.780    0.071 17863.608   11.449   11.440   11.408   89.570    0.139 22929.974
$ ~bart/software/scst/scripts/blockdev-perftest -a -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.701    1.705    1.699  601.771    0.822    9.403    1.709    1.728    1.728  594.774    3.119    9.293
 33554432    1.695    1.618    1.603  625.428   15.196   19.545    1.719    1.720    1.723  595.142    0.687   18.598
 16777216    1.600    1.598    1.598  640.423    0.436   40.026    1.741    1.720    1.722  592.707    3.291   37.044
  8388608    1.809    1.807    1.568  595.301   40.790   74.413    1.706    1.705    1.705  600.468    0.156   75.058
  4194304    1.314    1.314    1.551  739.690   56.260  184.922    1.628    1.634    1.629  628.190    0.951  157.048
  2097152    1.040    0.981    1.189  963.138   75.904  481.569    1.407    1.426    1.425  721.444    4.347  360.722
  1048576    1.064    0.995    1.067  983.835   32.288  983.835    1.285    1.277    1.286  798.358    2.347  798.358
   524288    0.984    1.058    0.987 1015.093   33.379 2030.187    1.252    1.254    1.250  817.791    1.280 1635.582
   262144    0.986    0.982    1.153  989.944   71.807 3959.778    1.243    1.249    1.244  822.357    1.723 3289.428
   131072    1.155    1.160    1.160  883.882    1.666 7071.055    1.251    1.252    1.252  818.046    0.179 6544.368
    65536    0.928    0.928    1.166 1028.366  106.412 16453.859    1.262    1.254    1.255  814.735    2.217 13035.757
    32768    1.183    1.084    1.084  918.281   37.291 29385.000    1.260    1.262    1.257  812.726    1.254 26007.237
    16384    0.930    1.178    0.931 1023.755  109.140 65520.309    1.266    1.270    1.269  807.233    1.189 51662.925
     8192    1.203    1.101    1.112  900.865   35.135 115310.778    1.273    1.274    1.272  804.366    0.725 102958.849
     4096    0.999    1.094    1.093  966.038   41.681 247305.603    1.293    1.293    1.293  792.081    0.136 202772.806

Results for the SCST code on this branch:

$ ~bart/software/scst/scripts/blockdev-perftest -d -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.220    1.225    1.220  838.049    1.672   13.095    0.595    0.595    0.596 1720.849    0.929   26.888
 33554432    1.208    1.207    1.210  847.223    0.909   26.476    0.603    0.603    0.604 1697.318    1.800   53.041
 16777216    1.180    1.181    1.179  867.755    0.626   54.235    0.619    0.619    0.619 1654.679    0.375  103.417
  8388608    1.127    1.130    1.128  907.754    1.025  113.469    0.649    0.649    0.650 1577.987    1.350  197.248
  4194304    1.041    1.043    1.084  970.038   17.898  242.509    0.745    0.691    0.691 1446.033   50.051  361.508
  2097152    1.096    1.097    1.097  933.846    0.127  466.923    0.770    0.769    0.768 1331.667    1.308  665.834
  1048576    1.268    1.282    1.269  804.454    3.912  804.454    0.912    0.909    0.910 1125.005    1.691 1125.005
   524288    1.518    1.519    1.518  674.360    0.179 1348.720    1.132    1.133    1.127  905.460    2.061 1810.919
   262144    1.686    1.687    1.685  607.410    0.289 2429.640    1.234    1.233    1.235  829.988    0.750 3319.953
   131072    1.845    1.855    1.849  553.648    1.199 4429.182    1.281    1.271    1.270  803.701    3.236 6429.607
    65536    2.243    2.238    2.250  456.401    0.958 7302.419    1.610    1.609    1.615  635.507    1.152 10168.115
    32768    3.100    3.096    3.101  330.442    0.191 10574.158    2.281    2.273    2.276  449.770    0.680 14392.647
    16384    4.730    4.738    4.781  215.603    1.015 13798.570    3.668    3.658    3.630  280.404    1.249 17945.853
     8192    8.136    8.143    8.125  125.879    0.117 16112.492    6.310    6.288    6.320  162.386    0.343 20785.421
     4096   14.734   14.777   14.729   69.440    0.102 17776.731   11.434   11.434   11.421   89.591    0.051 22935.343
$ ~bart/software/scst/scripts/blockdev-perftest -a -s 30 -m 12 /dev/sdb
blocksize        W        W        W   W(avg,   W(std,        W        R        R        R   R(avg,   R(std,        R
  (bytes)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)      (s)      (s)      (s)    MB/s)    MB/s)   (IOPS)
 67108864    1.621    1.616    1.859  605.258   38.591    9.457    1.733    1.732    1.730  591.217    0.421    9.238
 33554432    1.606    1.849    1.608  609.432   39.346   19.045    1.748    1.727    1.781  584.599    7.431   18.269
 16777216    1.613    1.615    1.838  608.666   36.341   38.042    1.726    1.723    1.732  592.885    1.307   37.055
  8388608    1.806    1.808    1.598  591.362   34.824   73.920    1.713    1.711    1.710  598.426    0.454   74.803
  4194304    1.555    1.332    1.543  696.900   50.708  174.225    1.633    1.685    1.642  619.381    8.436  154.845
  2097152    0.966    0.966    0.957 1063.283    5.105  531.642    1.413    1.409    1.415  724.960    1.347  362.480
  1048576    1.166    0.933    1.173  949.570  104.943  949.570    1.276    1.278    1.280  801.318    0.890  801.318
   524288    0.930    0.930    1.158 1028.986  102.433 2057.971    1.253    1.253    1.255  816.704    0.517 1633.409
   262144    0.993    0.958    1.167  992.704   83.077 3970.817    1.242    1.243    1.244  823.968    0.476 3295.873
   131072    0.998    0.994    0.932 1051.674   33.625 8413.395    1.256    1.251    1.251  817.434    1.742 6539.470
    65536    0.929    1.173    0.931 1025.243  107.612 16403.886    1.250    1.254    1.253  817.667    1.190 13082.667
    32768    0.933    1.185    1.182  942.734  109.764 30167.481    1.266    1.268    1.262  809.419    1.637 25901.411
    16384    1.174    1.006    1.008  968.451   68.247 61980.887    1.262    1.267    1.269  808.751    1.941 51760.085
     8192    1.041    0.990    0.934 1037.960   45.831 132858.894    1.270    1.310    1.274  797.260   10.946 102049.295
     4096    1.287    1.000    1.001  947.597  107.493 242584.705    1.294    1.309    1.287  789.841    5.665 202199.350

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1483 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Fri, 29 Jan 2010 11:54:38 +0000 (11:54 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1482 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agosession_active_commands_attr attribute must have active_commands name.
vlnb [Tue, 26 Jan 2010 13:02:13 +0000 (13:02 +0000)]
session_active_commands_attr attribute must have active_commands name.

Reported by Joe Eykholt <jeykholt@cisco.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1478 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 26 Jan 2010 11:52:01 +0000 (11:52 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1477 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Sat, 23 Jan 2010 08:54:06 +0000 (08:54 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1476 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Tue, 19 Jan 2010 11:37:41 +0000 (11:37 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1475 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMoved comma's in table header to the proper place.
bvassche [Sun, 17 Jan 2010 17:36:50 +0000 (17:36 +0000)]
Moved comma's in table header to the proper place.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1474 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Sun, 17 Jan 2010 13:07:46 +0000 (13:07 +0000)]
Changes:
- The entire receive queue can be used again instead of only SRPT_RQ_SIZE - 1
  elements (as in r1470).
- Added initiator-lockup-avoidance code to SRP_TSK_MGMT processing code too.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1473 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated test instructions.
bvassche [Sat, 16 Jan 2010 19:38:08 +0000 (19:38 +0000)]
Updated test instructions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1472 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated copyright statement.
bvassche [Sat, 16 Jan 2010 19:36:29 +0000 (19:36 +0000)]
Updated copyright statement.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1471 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Thu, 14 Jan 2010 20:35:37 +0000 (20:35 +0000)]
Changes:
- Updated copyright statement.
- Micro-optimized the function srpt_req_lim_delta().
- Made sure that SRPT does not cause a lockup in (at least) the Linux SRP
  initiator. See also http://bugzilla.kernel.org/show_bug.cgi?id=14235.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1470 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved a trailing space because checkpatch complained about it.
bvassche [Thu, 14 Jan 2010 13:37:56 +0000 (13:37 +0000)]
Removed a trailing space because checkpatch complained about it.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1469 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoEnabled sparse checking for the 2.6.23.17 kernel.
bvassche [Thu, 14 Jan 2010 13:28:26 +0000 (13:28 +0000)]
Enabled sparse checking for the 2.6.23.17 kernel.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1468 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following...
vlnb [Thu, 14 Jan 2010 13:14:30 +0000 (13:14 +0000)]
Patch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following scenario:

1. Commands start going to the init_cmd_list probably because SCST was suspended
2. A command is now waiting in the init_cmd_list, it was not yet completely initialized (more impotently cmd->dev == NULL)
3. A clear task set for the same lun arrives from a different initiator
4. The command is marked as aborted from other initiator and released from the init list.
5. The command gets to the PRE_XMIT_RESPONSE state, since it was aborted the scst_xmit_process_aborted_cmd is called.
6. At this stage since the command is marked as aborted by other initiator the scst checks for the device TAS flag (cmd->dev->tas) however cmd->dev is NULL and we crash on Null pointer de-referencing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1466 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoImprove handling of aborts of done commands
vlnb [Thu, 14 Jan 2010 12:59:13 +0000 (12:59 +0000)]
Improve handling of aborts of done commands

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1465 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved SRP_CRED_REQ support again.
bvassche [Wed, 13 Jan 2010 20:19:54 +0000 (20:19 +0000)]
Removed SRP_CRED_REQ support again.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1464 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following category of checkpatch errors:
bvassche [Wed, 13 Jan 2010 19:33:21 +0000 (19:33 +0000)]
Fixed the following category of checkpatch errors:
   3 ERROR: code indent should use tabs where possible

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1463 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed processing of REQUEST SENSE and INQUIRY commands for not existing LUNs
vlnb [Wed, 13 Jan 2010 18:10:10 +0000 (18:10 +0000)]
Fixed processing of REQUEST SENSE and INQUIRY commands for not existing LUNs

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1462 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRegular reservations cleanup
vlnb [Wed, 13 Jan 2010 14:03:55 +0000 (14:03 +0000)]
Regular reservations cleanup

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1461 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a compiler warning about a format specification mismatch.
bvassche [Wed, 13 Jan 2010 13:21:08 +0000 (13:21 +0000)]
Fixed a compiler warning about a format specification mismatch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1460 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that the EXTRACHECKS_BUG_ON() macro does not trigger a compiler
bvassche [Wed, 13 Jan 2010 13:20:00 +0000 (13:20 +0000)]
Made sure that the EXTRACHECKS_BUG_ON() macro does not trigger a compiler
warning about an empty controlled statement in a release or perf build.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1459 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that none of the EXTRACHECKS_BUG_ON(), EXTRACHECKS_WARN_ON()
bvassche [Wed, 13 Jan 2010 13:13:03 +0000 (13:13 +0000)]
Made sure that none of the EXTRACHECKS_BUG_ON(), EXTRACHECKS_WARN_ON()
or EXTRACHECKS_WARN_ON_ONCE() macros trigger a compiler warning about an
empty controlled statement in a release or perf build.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1458 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following checkpatch complaint:
bvassche [Wed, 13 Jan 2010 08:21:39 +0000 (08:21 +0000)]
Fixed the following checkpatch complaint:
   1 WARNING: braces {} are not necessary for single statement blocks

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1457 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoDocs about QLA FW version updated
vlnb [Tue, 12 Jan 2010 20:10:56 +0000 (20:10 +0000)]
Docs about QLA FW version updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1456 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCustom commands parsing cleanups
vlnb [Tue, 12 Jan 2010 19:05:27 +0000 (19:05 +0000)]
Custom commands parsing cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1455 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoLink to PRs patch to test updated.
vlnb [Tue, 12 Jan 2010 15:05:25 +0000 (15:05 +0000)]
Link to PRs patch to test updated.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1454 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing broken link to the...
vlnb [Tue, 12 Jan 2010 14:53:33 +0000 (14:53 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing broken link to the Marvell logo after Marvell redesigned their site.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1453 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Logging cleanups. Particularly, TRACE_MGMT_MINOR level was removed
vlnb [Tue, 12 Jan 2010 13:29:01 +0000 (13:29 +0000)]
 - Logging cleanups. Particularly, TRACE_MGMT_MINOR level was removed
 - Docs updates
 - Other minor fixes and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1452 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a race condition (use-after-free) that could trigger a kernel bug report during...
bvassche [Tue, 12 Jan 2010 08:52:08 +0000 (08:52 +0000)]
Fixed a race condition (use-after-free) that could trigger a kernel bug report during module unloading.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1451 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb update
vlnb [Mon, 11 Jan 2010 19:44:15 +0000 (19:44 +0000)]
Web update

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1450 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago - Improved handling of commands with TASK ABORTED status
vlnb [Mon, 11 Jan 2010 19:41:23 +0000 (19:41 +0000)]
 - Improved handling of commands with TASK ABORTED status

 - Minor cleanup

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1449 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoLet's experimantally disable SCST_MAX_DEV_COMMANDS and cmd->dev_cmd_count functionali...
vlnb [Mon, 11 Jan 2010 19:27:07 +0000 (19:27 +0000)]
Let's experimantally disable SCST_MAX_DEV_COMMANDS and cmd->dev_cmd_count functionality and see if users will complain about it. If not, we will remove it.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1448 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWhen converting the SCST source code into a series of upstream patches, SCST
vlnb [Mon, 11 Jan 2010 19:16:38 +0000 (19:16 +0000)]
When converting the SCST source code into a series of upstream patches, SCST
is built via the kbuild infastructure. In kernel version 2.6.24 (commit
f77bf01425b11947eeb3b5b54685212c302741b8) the kbuild variable ccflags-y has
been introduced and the use of EXTRA_CFLAGS in kbuild makefiles has been
deprecated. The patch below converts SCST's in-tree makefiles such that these
use ccflags-y instead of EXTRA_CFLAGS when generating kernel patches for
kernel 2.6.24 or later.

Additionally, this patch removes the "default n" from the file
scst/kernel/in-tree/Kconfig.scst since this statement is superfluous.

The patch below has been tested by verifying the output of the following
command:
for ((v=23;v<=32;v++)); do rm -rf re* && scripts/run-regression-tests 2.6.$v; done

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1447 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that if a work completion reports an error status that
bvassche [Mon, 11 Jan 2010 19:00:03 +0000 (19:00 +0000)]
Made sure that if a work completion reports an error status that
completion queue processing is not aborted but that the remaining
completion queue entries are processed.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1446 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoConverted a WARN_ON() into a PRINT_ERROR() statement.
bvassche [Mon, 11 Jan 2010 18:41:55 +0000 (18:41 +0000)]
Converted a WARN_ON() into a PRINT_ERROR() statement.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1445 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoClose IB channel after session unregistration instead of before in order
bvassche [Mon, 11 Jan 2010 11:30:08 +0000 (11:30 +0000)]
Close IB channel after session unregistration instead of before in order
to prevent the following errors to occur:
ib_srpt: srpt_completion:1737:***ERROR***: failed sending response status= 4
ib_srpt: srpt_completion:1737:***ERROR***: failed sending response status= 5

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1444 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that the pre-cflags patches are uniform to the other in-tree kernel
bvassche [Sun, 10 Jan 2010 13:16:28 +0000 (13:16 +0000)]
Made sure that the pre-cflags patches are uniform to the other in-tree kernel
patches, i.e. that -p1 has to be used to apply these patches.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1443 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBackported some 2.6.32 IB bug fixes to the 2.6.30 kernel.
bvassche [Sun, 10 Jan 2010 13:14:28 +0000 (13:14 +0000)]
Backported some 2.6.32 IB bug fixes to the 2.6.30 kernel.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1442 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following race conditions:
bvassche [Sat, 9 Jan 2010 20:14:13 +0000 (20:14 +0000)]
Fixed the following race conditions:
- With thread=1, the kernel thread was stopped before all I/O was stopped.
  This could result in IB completions for responses sent to the initiator
  not being processed, scst_tgt_cmd_done() not being called for certain
  SCST commands and hence this race could cause "rmmod ib_srpt" to hang.
- ib_unregister_event_handler() was called after cancel_work_sync(). This
  could cause srpt_event_handler() to queue new work, work that could be
  executed after the data it operates on had been deallocated.
Change: simplified module unloading by calling ib_destroy_cm_id(sdev->cm_id)
  before calling scst_unregister(). This made the variable "cleaning_up"
  superfluous.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1441 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following category of checkpatch complaints:
bvassche [Sat, 9 Jan 2010 15:01:59 +0000 (15:01 +0000)]
Fixed the following category of checkpatch complaints:
   2 ERROR: code indent should use tabs where possible

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1440 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCommands can be aborted by other transports, so cmnd_rx_continue() should check scst_...
vlnb [Fri, 8 Jan 2010 16:19:31 +0000 (16:19 +0000)]
Commands can be aborted by other transports, so cmnd_rx_continue() should check scst_cmd_aborted().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1439 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMark "completed" should be cleared from being retried commands.
vlnb [Fri, 8 Jan 2010 16:14:49 +0000 (16:14 +0000)]
Mark "completed" should be cleared from being retried commands.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1438 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Alexey Obitotskiy <alexeyo1@open-e.com> with 2 fixes and cleanups implemen...
vlnb [Fri, 8 Jan 2010 16:11:13 +0000 (16:11 +0000)]
Patch from Alexey Obitotskiy <alexeyo1@open-e.com> with 2 fixes and cleanups implementing initiator-oriented access control in sysfs interface.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1437 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates
vlnb [Fri, 8 Jan 2010 16:06:21 +0000 (16:06 +0000)]
Web updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1436 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel revisions.
bvassche [Thu, 7 Jan 2010 12:41:46 +0000 (12:41 +0000)]
Updated kernel revisions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1435 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved some TRACE_ENTRY() / TRACE_EXIT() statements.
bvassche [Wed, 6 Jan 2010 20:47:08 +0000 (20:47 +0000)]
Removed some TRACE_ENTRY() / TRACE_EXIT() statements.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1434 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed checkpatch complaints about whitespace (use tabs instead of spaces /
bvassche [Wed, 6 Jan 2010 20:22:15 +0000 (20:22 +0000)]
Fixed checkpatch complaints about whitespace (use tabs instead of spaces /
trailing whitespace) and the sparse complaint about using '0' as a pointer.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1433 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Wed, 6 Jan 2010 20:11:24 +0000 (20:11 +0000)]
Changes:
- srpt_release_channel_by_cmid(): the sdev->spinlock and scst_mgmt_lock are
  no longer locked nested.
- srpt_find_channel(): does now return NULL when the channel is not found
  (which never happens).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1432 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoA huge chunk of related to each other changes, which had to be tested together.
vlnb [Wed, 6 Jan 2010 13:02:22 +0000 (13:02 +0000)]
A huge chunk of related to each other changes, which had to be tested together.

iSCSI-SCST: A huge improvements in errors recovery and iSCSI RFC complaince as well as performance. Also:

 - Fixes and improvements for MaxOutstandingR2T>1

 - Flow control tracing added.

 - Cleanups

SCST core:

 - Now for scst_cmd_init_stage1_done() commands preprocessing_done() is always called before xmit_response(), even in case of abort or error.

 - Fixed recently introduced bug, which can lead to sending responses for aborted commands after reply on the corresponding TM command already sent.

 - Flow control tracing added.

 - Now it is possible to call functions setting commands execution status (e.g., scst_set_cmd_error_status()) several times for the same command. Only the first call will be completed, other calls - ignored.

 - All commands are counted and shown in proc/sysfs now. Before only active, i.e. not yet executed commands, were counted and shown there.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1431 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded more debugging code.
bvassche [Mon, 4 Jan 2010 20:56:00 +0000 (20:56 +0000)]
Added more debugging code.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1430 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Mon, 4 Jan 2010 20:26:19 +0000 (20:26 +0000)]
Changes:
- Removed references to SCST core internal state names.
- Does no longer accept new connections while unloading.
- Module unloading should now really no longer cause a hang.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1429 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMerged two lines.
bvassche [Mon, 4 Jan 2010 20:13:04 +0000 (20:13 +0000)]
Merged two lines.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1428 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoDo not try to include files marked for deletion.
bvassche [Mon, 4 Jan 2010 20:05:53 +0000 (20:05 +0000)]
Do not try to include files marked for deletion.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1427 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed typos.
bvassche [Sun, 3 Jan 2010 08:34:21 +0000 (08:34 +0000)]
Fixed typos.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1426 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed sporadic lockup triggered by removing the ib_srpt kernel module.
bvassche [Sat, 2 Jan 2010 13:56:12 +0000 (13:56 +0000)]
Fixed sporadic lockup triggered by removing the ib_srpt kernel module.
The following complaint was logged by the kernel when this happened:

INFO: task rmmod:26637 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
rmmod         D 00000000ffffffff     0 26637  26629
 ffff88009ce9dbd8 0000000000000046 ffff88009ce9dbf8 ffffffff8052466e
 0000000000000000 0000000000000001 0000000000000001 0000000000000001
 ffff88003c24d070 00000000001d17c0 000000000000c8a0 ffff88003c24d078
Call Trace:
 [<ffffffff8052466e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff80522408>] schedule+0x18/0x40
 [<ffffffff805227a5>] schedule_timeout+0x165/0x1a0
 [<ffffffff80525320>] ? _spin_unlock_irq+0x30/0x60
 [<ffffffff8023f4d9>] ? sub_preempt_count+0xa9/0xe0
 [<ffffffff80521756>] wait_for_common+0x116/0x1a0
 [<ffffffff80248850>] ? default_wake_function+0x0/0x20
 [<ffffffff8052189d>] wait_for_completion+0x1d/0x20
 [<ffffffffa06983e1>] scst_unregister_session+0x101/0x240 [scst]
 [<ffffffffa070f52f>] srpt_release+0xef/0x1e0 [ib_srpt]
 [<ffffffff805252d5>] ? _spin_unlock_irqrestore+0x65/0x80
 [<ffffffffa0693f60>] scst_unregister+0x70/0x380 [scst]
 [<ffffffff805252b2>] ? _spin_unlock_irqrestore+0x42/0x80
 [<ffffffffa0711982>] srpt_remove_one+0xa2/0x190 [ib_srpt]
 [<ffffffffa03b3105>] ib_unregister_client+0x65/0x120 [ib_core]
 [<ffffffff8027a02d>] ? trace_hardirqs_on+0xd/0x10
 [<ffffffffa0715114>] srpt_cleanup_module+0x70/0xd4 [ib_srpt]
 [<ffffffff80284f87>] sys_delete_module+0x1a7/0x270
 [<ffffffff8020cc6d>] ? retint_swapgs+0xe/0x13
 [<ffffffff80279e79>] ? trace_hardirqs_on_caller+0x29/0x1d0
 [<ffffffff8052466e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff8020c21b>] system_call_fastpath+0x16/0x1b
INFO: lockdep is turned off.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1425 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Sat, 2 Jan 2010 12:27:32 +0000 (12:27 +0000)]
Changes:
- Decreased number of target-to-initiator request send buffers from two
  to one such that a clear error message can be printed when the SRP
  initiator did not respond to the SRP_CRED_REQ information unit.
- Bug fix: don't modify ch->last_response_req_lim when sending an SRP
  information unit that contains the REQUEST LIMIT DELTA field failed.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1424 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges related to credit-based SRP buffer management:
bvassche [Fri, 1 Jan 2010 17:48:07 +0000 (17:48 +0000)]
Changes related to credit-based SRP buffer management:
- Bug fix: don't set the REQUEST LIMIT DELTA field to SRPT_RQ_SIZE when
  sending the first reponse to the initiator but to the proper value
  (a small integer).
- An SRP_CRED_REQ information unit is now sent to the initiator if the
  number of I/O contexts available for receiving dropped below two I/O
  contexts (see also the SRP standard for more information). This change
  is required to fix the SRP initiator lockup that happens when the
  initiator sends requests faster than the target can process them. In
  order to fix the lockup, it is  also necessary to implement SRP_CRED_REQ
  support in the SRP initiator in the vanilla Linux kernel and in OFED.
  Neither kernel version 2.6.32 nor OFED 1.5 nor any previous
  version of these components supports SRP_CRED_REQ information units.
  See also http://bugzilla.kernel.org/show_bug.cgi?id=14235 for more
  information about the initiator lockup.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1423 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded and commented out the following statement:
bvassche [Fri, 1 Jan 2010 17:06:38 +0000 (17:06 +0000)]
Added and commented out the following statement:
EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1422 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoThe patch below fixes the following two issues in the iscsi-scst-howto.txt
vlnb [Mon, 28 Dec 2009 19:58:39 +0000 (19:58 +0000)]
The patch below fixes the following two issues in the iscsi-scst-howto.txt
document:
* For some Linux distro's the command iscsi-iname is installed in /usr/sbin
  and for others in /sbin.
* The scst and scst_vdisk modules must be loaded before the sample scstadmin
  commands work.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1421 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCompilation of the SCST's sysfs code triggers a section mismatch because the
vlnb [Mon, 28 Dec 2009 19:55:45 +0000 (19:55 +0000)]
Compilation of the SCST's sysfs code triggers a section mismatch because the
function scst_sysfs_cleanup() is declared as an exit-only function while it is
also called from init_scst(). The patch below fixes this section mismatch.

This patch has been tested by verifying that the following command does not
report any section mismatches:

make CONFIG_DEBUG_SECTION_MISMATCH=y scst iscsi-scst srpt

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1420 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoChanges:
bvassche [Mon, 28 Dec 2009 19:31:51 +0000 (19:31 +0000)]
Changes:
- Convert sense data to/from fixed format / descriptor format before
  sending back a response.
- Print an error message to the kernel log when an unsupported IB event
  has been received.
- Return the SCSI status BUSY instead of CHECK CONDITION when allocating
  an SCST command failed (until r1409, the SCSI status in the SRP_RSP
  information unit was set to TASK SET FULL in this case).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1419 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFollow-up for r1415: compiles again without warnings on both 32-bit
bvassche [Sat, 26 Dec 2009 18:57:17 +0000 (18:57 +0000)]
Follow-up for r1415: compiles again without warnings on both 32-bit
and 64-bit systems.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1418 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated to do list.
bvassche [Sat, 26 Dec 2009 09:23:39 +0000 (09:23 +0000)]
Updated to do list.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1417 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBehavior changes:
bvassche [Fri, 25 Dec 2009 15:26:42 +0000 (15:26 +0000)]
Behavior changes:
- Fixed: the SCSOLNT and UCSOLNT bits were ignored in received SRP requests,
  and the SOLNT bit was not set in responses when required. This is required
  by the SRP protocol specification.
- Fixed: SRP_RSP messages must be limited to the MAXIMUM TARGET TO INITIATOR
  IU LENGTH  field indicated in the SRP_LOGIN_RSP response instead of the
  maximum message size supported by SRPT. This is also required by the SRP
  protocol specification.
- Fixed: the STATUS field of response messages with status GOOD and that
  contain sense data is no longer modified into CHECK CONDITION.
Internal changes (refactoring):
- Replaced the SCSI sense data handling data structures and code in SRPT by
  those of the SCST core.
- Moved the code for building an error response from srpt_handle_cmd() and
  srpt_handle_tsk_mgmt() to srpt_handle_new_iu().
- Removed the ioctx::data_len member.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1416 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a recently introduced format specification mismatch.
bvassche [Fri, 25 Dec 2009 09:10:10 +0000 (09:10 +0000)]
Fixed a recently introduced format specification mismatch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1415 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMove all the code from scst_cdbprobe.h to scst_lib.c where it should really belong.
vlnb [Thu, 24 Dec 2009 19:46:20 +0000 (19:46 +0000)]
Move all the code from scst_cdbprobe.h to scst_lib.c where it should really belong.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1414 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates.
vlnb [Thu, 24 Dec 2009 13:54:49 +0000 (13:54 +0000)]
Web updates.

Tooltips code and usage provided by Greg V Zemskov <mne@greg.su> and Kirill Malkin <kirill.malkin@reldata.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1412 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Die if /proc/scsi_tgt/version doesn't exist.
mgandalf [Wed, 23 Dec 2009 19:55:07 +0000 (19:55 +0000)]
- Die if /proc/scsi_tgt/version doesn't exist.
- Replace croak() with die() in the module.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1411 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel versions 2.6.27.41, 2.6.31.8 and 2.6.32.1 to 2.6.27.42, 2.6.31.9 and...
bvassche [Sat, 19 Dec 2009 10:46:17 +0000 (10:46 +0000)]
Updated kernel versions 2.6.27.41, 2.6.31.8 and 2.6.32.1 to 2.6.27.42, 2.6.31.9 and 2.6.32.2 respectively.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1410 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that all log lines generated by the ib_srpt kernel module
bvassche [Fri, 18 Dec 2009 19:11:24 +0000 (19:11 +0000)]
Made sure that all log lines generated by the ib_srpt kernel module
have an "ib_srpt: " prefix. Thanks to Stanley Sufficool for the patch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1409 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBetter handling of devices, which don't support MODE SENSE control mode page
vlnb [Fri, 18 Dec 2009 17:21:27 +0000 (17:21 +0000)]
Better handling of devices, which don't support MODE SENSE control mode page

Tested-By: Dietmar Maurer <dietmar@proxmox.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1408 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that checkpatch doesn't complain about missing whitespace around
bvassche [Fri, 18 Dec 2009 17:16:03 +0000 (17:16 +0000)]
Made sure that checkpatch doesn't complain about missing whitespace around
the minus character in the following expression:
    tgt_dev->curr_sn = (typeof(tgt_dev->curr_sn)) -300

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1407 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSmall cleanup: there's no need to have SN's long + test on SNs overflow added
vlnb [Thu, 17 Dec 2009 12:57:24 +0000 (12:57 +0000)]
Small cleanup: there's no need to have SN's long + test on SNs overflow added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1406 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following category of complaints reported by the 2.6.32 checkpatch:
bvassche [Wed, 16 Dec 2009 20:01:08 +0000 (20:01 +0000)]
Fixed the following category of complaints reported by the 2.6.32 checkpatch:
  11 ERROR: that open brace { should be on the previous line

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1405 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded kernel version 2.6.32.1.
bvassche [Wed, 16 Dec 2009 19:51:11 +0000 (19:51 +0000)]
Added kernel version 2.6.32.1.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1404 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded to repository.
bvassche [Wed, 16 Dec 2009 19:49:19 +0000 (19:49 +0000)]
Added to repository.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1403 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed kernel version numbers.
bvassche [Wed, 16 Dec 2009 19:49:00 +0000 (19:49 +0000)]
Fixed kernel version numbers.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1402 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix incorrect initialization of scst_mgmt_cmd_stub structure
vlnb [Wed, 16 Dec 2009 19:24:42 +0000 (19:24 +0000)]
Fix incorrect initialization of scst_mgmt_cmd_stub structure

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1400 d57e44dd-8a1f-0410-8b47-8ef2f437770f