vlnb [Thu, 22 Oct 2009 15:40:42 +0000 (15:40 +0000)]
Let's don't check if data should be copied between dev handler's and target driver's buffers on the fast path and make it a duty of a target driver who might need it.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1244
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 15:19:11 +0000 (15:19 +0000)]
- Use vfs_readv/vfs_writev instead of direct calls to VFS functions
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1243
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 15:17:38 +0000 (15:17 +0000)]
Set max_cmd_len correcty.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1242
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:58:55 +0000 (12:58 +0000)]
Use of strict_strtoul() instead of simple_strtoul() as suggested by checkpatch. Other uses of simple_strtoul() are OK and can't be converted
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1241
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:49:18 +0000 (12:49 +0000)]
Doc about additional 2.6.26.x commits updated.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1240
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:39:36 +0000 (12:39 +0000)]
From
ac2ef12020817c8e8edb7b4fe57f053c62cc833e Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Thu, 14 Aug 2008 09:39:35 -0700
Subject: qla2xxx: Set an rport's dev_loss_tmo value in a consistent manner.
[ Upstream commit
85821c906cf3563a00a3d98fa380a2581a7a5ff1 ]
As there's no point in adding a fixed-fudge value (originally 5
seconds), honor the user settings only. We also remove the
driver's dead-callback get_rport_dev_loss_tmo function
(qla2x00_get_rport_loss_tmo()).
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Submitted by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1239
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:33:45 +0000 (12:33 +0000)]
Fix incorrect WARN_ON()
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1238
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:32:40 +0000 (12:32 +0000)]
Fix compilation with enabled procfs on kernels <2.6.26. Sysfs from now will be supported only on kernels >=2.6.26.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1237
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 22 Oct 2009 12:06:07 +0000 (12:06 +0000)]
Experimental optimization. Suppose that if sock_recvmsg() returned less data than requested, then next time it will return -EAGAIN, so there's no point to call it again.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1236
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 21 Oct 2009 20:03:39 +0000 (20:03 +0000)]
Only extract the kernel tree when it's needed, i.e. for the 2.6.26.* kernels.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1235
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 21 Oct 2009 19:45:35 +0000 (19:45 +0000)]
Added support for continued lines.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1234
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 21 Oct 2009 19:43:48 +0000 (19:43 +0000)]
Temporarily disabled release build testing.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1233
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 21 Oct 2009 17:41:26 +0000 (17:41 +0000)]
LUNs replace implemented
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1232
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 21 Oct 2009 17:14:27 +0000 (17:14 +0000)]
"Commands" attribute added for scst_user
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1231
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 21 Oct 2009 16:51:48 +0000 (16:51 +0000)]
qla2x00_schedule_rport_del() must used _irq[save,restore] spinlocks, because it can be called on the IRQ.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1230
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 21 Oct 2009 16:49:52 +0000 (16:49 +0000)]
Merge ... the sysfs branch. To enable the sysfs interface you should run "make disable_proc". To switch back on the procfs interface you should run "make disable_proc".
The sysfs intarface is mostly finished. Only initiators-oriented access control not implemented and not all target drivers are updated. Only qla2x00t has been fully updated.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1229
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 20 Oct 2009 18:40:06 +0000 (18:40 +0000)]
Fix for inconsistency in compile time warning about patch io_context for 2.6.26 kernel, noticed by Mark Buechler <mark.buechler@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1228
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 15 Oct 2009 15:56:57 +0000 (15:56 +0000)]
- Fix for a possible DoS, when misbehavine scst_user's handler hangs several memory allocations (= count of iSCSI read threads) and by so prevents other sessions from being served correctly. Spotted by Erez Zilber <erezzi.list@gmail.com>
- iSCSI read state machine cleanups
- Fix a race when just freed iSCSI session accessed, because the corresponding SCST session is still being unregistered.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1224
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 15 Oct 2009 07:48:39 +0000 (07:48 +0000)]
Fixed typo.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1220
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 15 Oct 2009 07:15:56 +0000 (07:15 +0000)]
Run a full check not only on the first specified kernel version but also on kernel version 2.6.26.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1219
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 15 Oct 2009 07:14:54 +0000 (07:14 +0000)]
Added variable generating_upstream_patch_defined. When set to 1, this
variable tells the script specialize-patch to treat the preprocessor
symbol GENERATING_UPSTREAM_PATCH as defined.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1218
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 15 Oct 2009 07:12:09 +0000 (07:12 +0000)]
Added command-line option -u to scripts/generate-kernel-patch, which has
the following effect:
- Exclude the put_page_callback patch.
- Enable #define GENERATING_UPSTREAM_PATCH.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1217
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 15 Oct 2009 07:09:40 +0000 (07:09 +0000)]
Made sure that the qla2x00t patches are only included in the output of
scripts/generate-kernel-patch for kernel version 2.6.26. As a result,
during the nightly build the qla2x00t code will only be checked with
checkpatch and sparse for the 2.6.26 kernel.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1216
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 14 Oct 2009 17:10:46 +0000 (17:10 +0000)]
Made sure that patch generation also works for other kernel versions than 2.6.26.8.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1215
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 14 Oct 2009 16:30:44 +0000 (16:30 +0000)]
From
20246fe8e4ea34f2ab556b7c50037b976051cab7 Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Tue, 21 Oct 2008 20:25:04 +0200
Subject: SCSI: qla2xxx: Skip FDMI registration on ISP21xx/22xx parts.
commit
031e134e5f95233d80fb1b62fdaf5e1be587597c upstream
Firmware does not have the facilities to issue management server
IOCBs.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Ferenc Wagner <wferi@niif.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Submitted by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1214
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 14 Oct 2009 16:29:08 +0000 (16:29 +0000)]
From
61c8bd1d3a9e7e57843d98d9b133fec77ecf4e1b Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Mon, 29 Sep 2008 15:15:04 +0000
Subject: SCSI: qla2xxx: Defer enablement of RISC interrupts until ISP initialization completes.
commit
048feec5548c0582ee96148c61b87cccbcb5f9be upstream
Josip Rodin noted
(http://article.gmane.org/gmane.linux.ports.sparc/10152) the
driver oopsing during registration of an rport to the
FC-transport layer with a backtrace indicating a dereferencing of
an shost->shost_data equal to NULL. David Miller identified a
small window in driver logic where this could happen:
> Look at how the driver registers the IRQ handler before the host has
> been registered with the SCSI layer.
>
> That leads to a window of time where the shost hasn't been setup
> fully, yet ISRs can come in and trigger DPC thread events, such as
> loop resyncs, which expect the transport area to be setup.
>
> But it won't be setup, because scsi_add_host() hasn't finished yet.
>
> Note that in Josip's crash log, we don't even see the
>
> qla_printk(KERN_INFO, ha, "\n"
> " QLogic Fibre Channel HBA Driver: %s\n"
> " QLogic %s - %s\n"
> " ISP%04X: %s @ %s hdma%c, host#=%ld, fw=%s\n",
> ...
>
> message yet.
>
> Which means that the crash occurs between qla2x00_request_irqs()
> and printing that message.
Close this window by enabling RISC interrupts after the host has
been registered with the SCSI midlayer.
Reported-by: Josip Rodin <joy@entuzijast.net>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Submitted by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1213
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 14 Oct 2009 16:25:36 +0000 (16:25 +0000)]
From
1e42c5591e3a65ef36ea90c4461c09e78280417d Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Wed, 14 Oct 2009 08:51:21 +0200
Subject: [PATCH] qla2xxx: Add dev_loss_tmo_callbk/terminate_rport_io callback support.
[ Upstream commit
5f3a9a207f1fccde476dd31b4c63ead2967d934f ]
Signed-off-by: Seokmann Ju <seokmann.ju@qlogic.com>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Submitted by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1212
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 14 Oct 2009 16:20:19 +0000 (16:20 +0000)]
- Add raw accumulated times in the latency statistics output
- Minor cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1211
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 14 Oct 2009 14:21:19 +0000 (14:21 +0000)]
Apply the 2.6.31 kmemcheck patch not only to current but also to future 2.6.31.* kernels since the change is small that the submitted patch will be integrated.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1210
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 14 Oct 2009 07:07:53 +0000 (07:07 +0000)]
Applied fix for sparse warning to 2.6.31.4 too.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1209
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 13 Oct 2009 19:52:46 +0000 (19:52 +0000)]
Updated kernel versions 2.6.27.36 and 2.6.31.3 to 2.6.27.37 and 2.6.31.4 respectively.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1208
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 13 Oct 2009 16:01:33 +0000 (16:01 +0000)]
Fix for problem with 2.6.31 kernel, where blk_rq_append_bio() was un-exported. So, from now scst_exec_req_fifo is again required for pass-through handlers.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1207
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 12 Oct 2009 17:40:55 +0000 (17:40 +0000)]
Updated Subversion ignore list.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1205
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 12 Oct 2009 17:40:24 +0000 (17:40 +0000)]
Made sure all per-hunk state variables are initialized properly.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1204
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 12 Oct 2009 17:17:03 +0000 (17:17 +0000)]
Reverted r1199: this revision was an attempt to eliminate the differences
in patch order between the systems on which this script is run. Since the
applied changes did not have any effect, I'm reverting this commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1203
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 12 Oct 2009 11:47:44 +0000 (11:47 +0000)]
Don't call target drivers on_free_cmd() for internal commands
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1201
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 12 Oct 2009 11:44:51 +0000 (11:44 +0000)]
Web fixes and updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1200
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 16:18:21 +0000 (16:18 +0000)]
Sort patch names alphabetically.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1199
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 15:54:04 +0000 (15:54 +0000)]
Reworked qla2x00t patch generation process:
- Moved qla2x00t patch generation code from qla2x00t/Makefile to
qla2x00t/extract-qla2xxx-orig and qla2x00t/generate-in-tree-patches.
Restored qla2x00t/Makefile to r1104.
- scripts/run-regression-tests now passes the full kernel version (including
patch level) to scripts/generate-kernel-patch.
- scripts/generate-kernel-patch can now generate patches for the files
in drivers/scsi/qla2xxx for any kernel version instead of only 2.6.26.8.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1198
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 11:42:34 +0000 (11:42 +0000)]
Added a reference to the submitted kernel patch.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1197
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 09:49:41 +0000 (09:49 +0000)]
Reduced disk space needed for nightly build.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1196
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 09:48:36 +0000 (09:48 +0000)]
Added command-line option -k, which makes run-regression-tests consume
less disk space when running the regression test for multiple kernel
versions.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1195
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 11 Oct 2009 09:22:50 +0000 (09:22 +0000)]
Updated kernel version 2.6.30.2 to 2.6.30.3.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1194
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 10 Oct 2009 18:04:02 +0000 (18:04 +0000)]
Added a kernel patch for a 2.6.31 regression.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1193
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 10 Oct 2009 17:55:37 +0000 (17:55 +0000)]
Made sure that ls does not print an error message when no matches are
found for the specified file pattern.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1192
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 10 Oct 2009 14:55:18 +0000 (14:55 +0000)]
Inhibit building the qla2x00t targets in parallel because this produces incorrect results.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1191
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 9 Oct 2009 07:11:34 +0000 (07:11 +0000)]
Applied property changes necessary to make the changes in r1189 work.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1190
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 8 Oct 2009 16:53:17 +0000 (16:53 +0000)]
The current status of the QLogic target driver in the SCST project is as
follows:
- Building the QLogic target driver is possible by following the instructions
in qla2x00t/qla2x00-target/README.
- Some but not all of the qla2x00-target code is included in the output of
scripts/generate-kernel-patch. This is unfortunate because it is the output
of this script that is posted to the LKML each time SCST is submitted for
review.
- Most of the qla2x00-target code is checked during the nightly build by
checkpatch. None of the qla2x00-target code is checked during the nightly
build by sparse.
The patch below makes sure that all of the qla2x00-target code is included in
the generate-kernel-patch output and also that all of the qla2x00-target code
is checked during the nightly build by both checkpatch and sparse. This has
been realized by including the diff of the linux-2.6.26.8/drivers/scsi/qla2xxx
source files and the source files in qla2x00t/*[ch] as individual patches under
qla2x00t/in-tree-patches. These patches are generated from downloaded
linux-2.6.26.8 sources and the sources in the SCST SVN repository.
The next step is to fix the checkpatch and sparse warnings triggered by the
qla2x00-target code and to port the latest qla2xxx patches to the SCST
qla2x00t implementation.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1189
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 8 Oct 2009 16:24:47 +0000 (16:24 +0000)]
Fix for 2 typos noticed by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1188
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 8 Oct 2009 13:44:55 +0000 (13:44 +0000)]
Docs and web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1187
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 8 Oct 2009 13:01:45 +0000 (13:01 +0000)]
Web updates and fixes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1186
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 6 Oct 2009 19:00:25 +0000 (19:00 +0000)]
A better fix for incorrect size of port_data_t and mb[8] for MBC_PORT_NODE_NAME_LIST problem.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1185
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 6 Oct 2009 17:43:55 +0000 (17:43 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1184
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 6 Oct 2009 14:32:17 +0000 (14:32 +0000)]
Some cleanups with a micro performance improvement as a nice side effect.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1182
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 5 Oct 2009 19:49:39 +0000 (19:49 +0000)]
Updated kernel versions 2.6.27.35, 2.6.30.8 and 2.6.31.1 to 2.6.27.36,
2.6.30.9 and 2.6.31.2 respectively.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1181
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 5 Oct 2009 19:00:27 +0000 (19:00 +0000)]
Patch from Richard Sharpe <realrichardsharpe@gmail.com> fixing incorrect SCST include path
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1180
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 5 Oct 2009 18:38:15 +0000 (18:38 +0000)]
Fixes for issues reported by Gal Rosen <galr@storwize.com>:
1. Incorrect task management response delivery (with patch)
2. Possible use of non-initialized variable
3. Incorrect size of port_data_t and mb[8] for MBC_PORT_NODE_NAME_LIST
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1179
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 4 Oct 2009 08:31:04 +0000 (08:31 +0000)]
Compiles again on RHEL 5 / CentOS 5 with CONFIG_SCST_DEBUG enabled.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1176
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 4 Oct 2009 07:22:43 +0000 (07:22 +0000)]
Applies again properly to 2.6.26 kernel.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1175
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 14:53:32 +0000 (14:53 +0000)]
Fixed the following checkpatch complaints:
- WARNING: labels should not be indented
- WARNING: braces {} are not necessary for single statement blocks
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1174
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 13:24:21 +0000 (13:24 +0000)]
Fixed the following checkpatch complaint:
ERROR: open brace '{' following struct go on the same line.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1173
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 13:16:03 +0000 (13:16 +0000)]
Fixed the following checkpatch complaint:
ERROR: return is not a function, parentheses are not required
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1172
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 13:12:18 +0000 (13:12 +0000)]
Fixed the following checkpatch complaints:
- ERROR: space required before the open parenthesis '('
- ERROR: "(foo*)" should be "(foo *)"
- ERROR: "foo * bar" should be "foo *bar"
- ERROR: code indent should use tabs where possible
Verified that the output of svn diff -x -w is empty for this commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1171
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:54:02 +0000 (12:54 +0000)]
Fixed two occurrences of the following checkpatch complaint: ERROR: do not initialise externals to 0 or NULL.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1170
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:47:24 +0000 (12:47 +0000)]
Fixed checkpatch complaints about the positioning of braces:
- ERROR: else should follow close brace '}'
- ERROR: open brace '{' following struct go on the same line
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1169
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:39:24 +0000 (12:39 +0000)]
More fixes for checkpatch complaints about whitespace:
- 2 ERROR: code indent should use tabs where possible
- 2 ERROR: trailing whitespace
Verified that the output of svn diff -x -w is empty for this commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1168
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:29:05 +0000 (12:29 +0000)]
Fixed the following checkpatch complaint:
ERROR: do not use assignment in if condition
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1167
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:25:13 +0000 (12:25 +0000)]
Removed trailing whitespace. Verified that the output of
svn diff -x -w is empty for this commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1166
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 12:15:33 +0000 (12:15 +0000)]
Removed trailing whitespace from the source lines that are different
from the qla2xxx driver source code in the 2.6.26 kernel. Verified
that the output of svn diff -x -w is empty for this commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1165
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 3 Oct 2009 06:59:51 +0000 (06:59 +0000)]
Fixed the following checkpatch warning by removing a blank line:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1164
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 2 Oct 2009 12:36:41 +0000 (12:36 +0000)]
Possible NULL pointer dereference in vdisk_fsync() noticed by Andrzej Hajderek <andrzej@hajderek.pl> fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1162
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 1 Oct 2009 11:01:11 +0000 (11:01 +0000)]
Forgotten copyrights updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1160
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 30 Sep 2009 18:35:24 +0000 (18:35 +0000)]
- New scst_user IOCTL SCST_USER_PREALLOC_BUFFER added
- New scst_user option sgv_disable_clustered_pool added
- fileio_tgt updated to use those new facilities
- Scst_user docs updated
- sgv_pool_get() and sgv_pool_put() made exported
- AENs sense buffer override fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1159
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 30 Sep 2009 18:24:18 +0000 (18:24 +0000)]
Logging improved
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1158
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 29 Sep 2009 20:35:22 +0000 (20:35 +0000)]
Extended latency statistics
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1157
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 29 Sep 2009 20:30:17 +0000 (20:30 +0000)]
Patch from Smadar Gonen <smadar.gn@gmail.com> implementing extended latency statistics.
Intermediate commit, don't use it!
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1156
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Mon, 28 Sep 2009 13:38:31 +0000 (13:38 +0000)]
- By default, don't issue a LIP after a group assignment change.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1155
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 15:51:58 +0000 (15:51 +0000)]
Added more error injection code.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1154
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 11:45:59 +0000 (11:45 +0000)]
Added to repository.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1152
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 11:39:58 +0000 (11:39 +0000)]
Added kernel version 2.6.31.1.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1151
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 08:54:42 +0000 (08:54 +0000)]
Fixed the following checkpatch complaints:
- ERROR: open brace '{' following struct go on the same line
- ERROR: return is not a function, parentheses are not required
- ERROR: that open brace { should be on the previous line
- WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
- WARNING: braces {} are not necessary for single statement blocks
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1150
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 08:39:18 +0000 (08:39 +0000)]
Converted GNU-style to C99-style initializer list because checkpatch
does not recognize the former and complains about it.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1149
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 26 Sep 2009 08:37:27 +0000 (08:37 +0000)]
Fixed checkpatch complaints about whitespace.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1148
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 25 Sep 2009 19:39:25 +0000 (19:39 +0000)]
Not completed documenting how to workaround Windows READ CAPACITY(16) bug completed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1147
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 25 Sep 2009 18:57:10 +0000 (18:57 +0000)]
- Sense handling cleanup
- How to workaround Windows READ CAPACITY(16) bug documented
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1146
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 25 Sep 2009 18:31:33 +0000 (18:31 +0000)]
Update for 2.6.31
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1145
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 25 Sep 2009 18:20:13 +0000 (18:20 +0000)]
- Fixes wrong DMA data direction
- Micro performance improvement
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1144
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Fri, 25 Sep 2009 14:11:43 +0000 (14:11 +0000)]
- Only retry creating a temp group name the max possible names
to prevent an infinite loop. Since we're using rand() here,
it's possible we could exit the loop with no unique name.
However, this is pretty unlikely considering thousands
if temp group names would have to already exist.
- Fail out if we can't come up with a temp group name and just
use the original specified.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1143
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Fri, 25 Sep 2009 14:00:08 +0000 (14:00 +0000)]
- Print a friendly warning if -issuelip (or it's config option) is used
and the target drives lacks support for it.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1142
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Fri, 25 Sep 2009 13:56:06 +0000 (13:56 +0000)]
- Regenerate temp group name should the current one already exist.
- Include temp group renames in the change count.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1141
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 25 Sep 2009 08:00:00 +0000 (08:00 +0000)]
Fixed a typo in the documentation: replaced ipsrpdm by ibsrpdm.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1140
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 24 Sep 2009 18:42:22 +0000 (18:42 +0000)]
Only report that a command already got aborted when SCSI management
debugging has been enabled.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1139
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 24 Sep 2009 18:33:07 +0000 (18:33 +0000)]
Updated kernel versions 2.6.27.34 and 2.6.30.7 to 2.6.27.35 and 2.6.30.8 respectively.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1138
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 23 Sep 2009 19:14:02 +0000 (19:14 +0000)]
Spell fixes, including "restransmitting" noticed by Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1137
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 18:45:53 +0000 (18:45 +0000)]
- Update example scst.conf file to reflect the new [OPTIONS] section.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1136
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 18:05:47 +0000 (18:05 +0000)]
- Minor cleanup to new -issuelip functionality.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1135
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 17:44:53 +0000 (17:44 +0000)]
Changes for 1.0.10
- Added new [OPTIONS] section to config file.
- Added new ISSUE_LIP option for fc targets to issue a LIP after group
assignment changes.
- Added new KEEP_CONFIG option to keep all options when overwriting a
configuration file with -writeconfig.
- General cleanup.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1134
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 15:39:08 +0000 (15:39 +0000)]
- If target-oriented access control mode is used, Default_ groups will first be created
as temporary groups and later renamed.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1133
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 15:00:29 +0000 (15:00 +0000)]
- Added items to the ToDo list.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1132
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 23 Sep 2009 14:58:19 +0000 (14:58 +0000)]
- Replace a device on a given LUN when applying the configuration instead of removing
the old device and assigning the new one.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1131
d57e44dd-8a1f-0410-8b47-
8ef2f437770f