13 years agoCheck for sparse before starting the regression tests.
bvassche [Sat, 4 Apr 2009 18:03:43 +0000 (18:03 +0000)]
Check for sparse before starting the regression tests.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@749 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChanged usage slightly: kernel versions are now accepted without the switch -k.
bvassche [Sat, 4 Apr 2009 15:14:21 +0000 (15:14 +0000)]
Changed usage slightly: kernel versions are now accepted without the switch -k.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@748 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChanges:
bvassche [Sat, 4 Apr 2009 09:12:20 +0000 (09:12 +0000)]
- Added command-line options -a, -d, -n and -s.
- If the syntax of the command-line options is incorrect, a usage text
  is displayed.
- Bug fix: log2_io_size is now honored even if the target device is larger
  than the specified size.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@747 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBidirectional data transfers added
vlnb [Fri, 3 Apr 2009 17:49:26 +0000 (17:49 +0000)]
Bidirectional data transfers added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@744 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix for circular locking dependency between target_mutex and scst_mutex spotted by...
vlnb [Fri, 3 Apr 2009 17:38:20 +0000 (17:38 +0000)]
Fix for circular locking dependency between target_mutex and scst_mutex spotted by lockdep

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@743 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoInitial 8Gb support, not tested very well yet.
zorko [Fri, 3 Apr 2009 06:35:36 +0000 (06:35 +0000)]
Initial 8Gb support, not tested very well yet.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@742 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake it compile on CentOS, or so Vlad asserts.
zorko [Fri, 3 Apr 2009 00:44:57 +0000 (00:44 +0000)]
Make it compile on CentOS, or so Vlad asserts.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@740 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes failure of enabling target mode, if do it too fast. Based on work by sdrb ...
vlnb [Thu, 2 Apr 2009 19:27:39 +0000 (19:27 +0000)]
Fixes failure of enabling target mode, if do it too fast. Based on work by sdrb <sdrb@onet.eu>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@739 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Smadar Gonen <smadar.gn@gmail.com> fixing compilation on CentOS 5.2
vlnb [Thu, 2 Apr 2009 18:24:18 +0000 (18:24 +0000)]
Patch from Smadar Gonen <smadar.gn@gmail.com> fixing compilation on CentOS 5.2

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@737 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoDocs and logging updates
vlnb [Thu, 2 Apr 2009 18:20:15 +0000 (18:20 +0000)]
Docs and logging updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@736 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Frank Zago fixing scstadmin typos
vlnb [Thu, 2 Apr 2009 18:18:00 +0000 (18:18 +0000)]
Patch from Frank Zago fixing scstadmin typos

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@735 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Frank Zago fixing compilation on 2.6.23 kernel
vlnb [Thu, 2 Apr 2009 18:16:11 +0000 (18:16 +0000)]
Patch from Frank Zago fixing compilation on 2.6.23 kernel

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@734 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix of leftover from previous debug sessions
vlnb [Wed, 1 Apr 2009 12:15:27 +0000 (12:15 +0000)]
Fix of leftover from previous debug sessions

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@733 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with 1.0.1.x r731:
vlnb [Wed, 1 Apr 2009 12:12:41 +0000 (12:12 +0000)]
Merge with 1.0.1.x r731:

Docs updated. Changes in iscsi-scst/doc/iscsi-scst-howto.txt made by Bart Van Assche

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@732 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoVersion number increased
vlnb [Wed, 1 Apr 2009 11:09:44 +0000 (11:09 +0000)]
Version number increased

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@729 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded to repository.
bvassche [Sun, 29 Mar 2009 08:50:52 +0000 (08:50 +0000)]
Added to repository.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@728 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor WEB updates
vlnb [Fri, 27 Mar 2009 20:41:42 +0000 (20:41 +0000)]
Minor WEB updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@727 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChangeLog and ToDo files updated
vlnb [Fri, 27 Mar 2009 19:50:23 +0000 (19:50 +0000)]
ChangeLog and ToDo files updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@725 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Minor fixes in error recovery paths
vlnb [Fri, 27 Mar 2009 12:14:41 +0000 (12:14 +0000)]
 - Minor fixes in error recovery paths
 - Minor cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@724 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below adds a comment about why it is safe to use in_atomic() in
vlnb [Thu, 26 Mar 2009 19:01:28 +0000 (19:01 +0000)]
The patch below adds a comment about why it is safe to use in_atomic() in
scst_cmd_atomic() -- the 2.6.29 checkpatch script issues a warning about it.
At the same time, the scst_cmd_atomic() comment has been converted to
kernel-doc style. See also Documentation/kernel-doc-nano-HOWTO.txt for more

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@723 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSync with the latest IET (r207-211):
vlnb [Thu, 26 Mar 2009 18:38:05 +0000 (18:38 +0000)]
Sync with the latest IET (r207-211):

 - Fix CHAP account handling bugs
 - Fix bugs in multi PDU handling code

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@722 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixed crash introduced by r710 reported by andy yan <andyysj@gmail.com>
vlnb [Thu, 26 Mar 2009 18:25:00 +0000 (18:25 +0000)]
 - Fixed crash introduced by r710 reported by andy yan <andyysj@gmail.com>
 - Improve logging on write access on read-only devices
 - Make the same initiator coming through different sessions use shared IO context
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@721 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Ruben Laban <r.laban@ism.nl>:
vlnb [Wed, 25 Mar 2009 19:42:03 +0000 (19:42 +0000)]
Patch from Ruben Laban <r.laban@ism.nl>:

While writing DKMS support for the SCST and iSCST-SCST kernel modules, I ran
into a (common) problem with regard to out-of-tree build detection. A common
method to detect out-of-tree building is by using the KERNELRELEASE variable.
The usage of this variable poses a problem when using DKMS. DKMS itself uses
the KERNELRELEASE variable to specify the kernel for which the driver to
build. A suggested alternative would to use the PATCHLEVEL variable as part
of the detection mechanism instead. I attached a patch reflecting this
suggested change.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@720 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Ruben Laban <r.laban@ism.nl>:
vlnb [Wed, 25 Mar 2009 19:33:10 +0000 (19:33 +0000)]
Patch from Ruben Laban <r.laban@ism.nl>:

I replaced all occurences of DISTDIR with DESTDIR and also introduced SBINDIR (and friends) to some other Makefiles.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@719 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes deadlock on iSCSI session freeing. Reported by andy yan <andyysj@gmail.com>
vlnb [Wed, 25 Mar 2009 13:03:29 +0000 (13:03 +0000)]
Fixes deadlock on iSCSI session freeing. Reported by andy yan <andyysj@gmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@718 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below adds support for the 2.6.29 kernel and also fixes the
vlnb [Wed, 25 Mar 2009 12:55:27 +0000 (12:55 +0000)]
The patch below adds support for the 2.6.29 kernel and also fixes the
checkpatch issues reported by the checkpatch script included with the 2.6.29
kernel and that were not yet reported by the 2.6.28 checkpatch script
(trailing statements should be on the next line / struct should normally be
The patch below has been tested as follows:
- Reran scripts/run-regression-tests -k -k -k -k -k -k 2.6.29 and verified the output.
- Rebuilt, installed and loaded scst, iscsi-scst and srpt as follows:
make -s clean && make -s -C scst install && make -s -C iscsi-scst install && make -s -C srpt install && cd scstadmin && make -s && make -s install && modprobe scst_vdisk && modprobe iscsi-scst && dmesg

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
with minor cleanups and corrections in put_page_callback-2.6.29.patch

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@717 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Added command-line option -d, which allows to specify a directory for
bvassche [Tue, 24 Mar 2009 19:08:29 +0000 (19:08 +0000)]
- Added command-line option -d, which allows to specify a directory for
  temporary regression test files.
- Added workaround for the problem that the branch profiling code in the
  2.6.29 kernel triggers a huge number of sparse warnings.
- Made sure that all tests print some output, even if successful.
- Improved summarizing of sparse warnings.
- Command-line option -j now works.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@716 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixes broken build if io_context patch not applied
vlnb [Tue, 24 Mar 2009 10:43:55 +0000 (10:43 +0000)]
 - Fixes broken build if io_context patch not applied
 - #warning's cleanup

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@715 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Added command-line option -j (number of jobs that make should run
bvassche [Mon, 23 Mar 2009 19:58:18 +0000 (19:58 +0000)]
- Added command-line option -j (number of jobs that make should run
- scripts/generate-kernel-patch is now only run once instead of three
  times per kernel version.
- Context imbalance warnings are no longer filtered from the output of

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@714 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFinished renaming of export_alloc_io_context patch into io_context performed in revis...
bvassche [Mon, 23 Mar 2009 19:44:42 +0000 (19:44 +0000)]
Finished renaming of export_alloc_io_context patch into io_context performed in revision r710.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@713 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following recently introduced checkpatch complaints:
vlnb [Mon, 23 Mar 2009 19:32:32 +0000 (19:32 +0000)]
The patch below fixes the following recently introduced checkpatch complaints:
* use tabs not spaces

and the following recently introduced sparse warnings:

* drivers/scst/scst_lib.c:437:6: warning: symbol 'scst_queue_report_luns_changed_UA' was not declared. Should it be static?
* drivers/scst/scst_lib.c:3909:21: warning: symbol 'tm_dbg_tgt_dev' was not declared. Should it be static?
* drivers/scst/iscsi-scst/session.c:170:9: warning: cast to non-scalar
* drivers/scst/iscsi-scst/session.c:180:24: warning: cast to non-scalar
The patch below has been verified by reviewing it carefully and by verifying the output of the following command: scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@712 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUnsupported patch from Krzysztof Błaszkowski <kb@sysmikro.com.pl>:
vlnb [Mon, 23 Mar 2009 19:25:38 +0000 (19:25 +0000)]
Unsupported patch from Krzysztof Błaszkowski <kb@sysmikro.com.pl>:

I prepared it for kernel which is used by openSuSE11.1-0 but it can
also be applied to (with some offset/fuzz) which is going to
be deployed in SLE11.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@711 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Make dynamic io_context assignment complete. Old export_alloc_io_context patch...
vlnb [Mon, 23 Mar 2009 19:19:56 +0000 (19:19 +0000)]
 - Make dynamic io_context assignment complete. Old export_alloc_io_context patch should be reverted and new io_context patch applied instead.
 - Make BLOCKIO io_contex be per-(device,session)
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@710 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChanges:
bvassche [Sat, 21 Mar 2009 10:21:26 +0000 (10:21 +0000)]
- Added command-line option -f, which enables a full check. Changed
  behavior when -f has not been specified to running checkpatch, sparse
  and headers_check only. This makes the script complete a lot faster.
- A summary of the errors and warnings reported by checkpatch, sparse
  and make headers_check is now printed.
- Made the functions kernel_version and patchlevel more robust.
- The function duplicate_source_tree now only copies the files
  administered by Subversion. Other files, e.g. .o files, are skipped.
- Moved the make flag -j3 from individual make commands to a single
  assignment to the variable MAKEFLAGS, such that the make flags are
  easier to modify.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@709 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes possible oopses on scst_cmd dereference.
vlnb [Fri, 20 Mar 2009 18:40:55 +0000 (18:40 +0000)]
Fixes possible oopses on scst_cmd dereference.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@708 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following recently introduced checkpatch complaints:
vlnb [Fri, 20 Mar 2009 12:36:01 +0000 (12:36 +0000)]
The patch below fixes the following recently introduced checkpatch complaints:
* use tabs not spaces
* Macros with complex values should be enclosed in parenthesis.
* printk() should include KERN_ facility level.
The patch below has been verified by reviewing it carefully and by verifying the output of the following command: scripts/run-regression-tests -k

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@707 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixing NULL pointer dereferences accessing dev->d_sense
vlnb [Fri, 20 Mar 2009 12:29:20 +0000 (12:29 +0000)]
Fixing NULL pointer dereferences accessing dev->d_sense

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@706 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSupport for descriptor sense format added
vlnb [Fri, 20 Mar 2009 12:07:48 +0000 (12:07 +0000)]
Support for descriptor sense format added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@705 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Ruben Laban <r.laban@ism.nl> to make the Makefiles more packager friendly...
vlnb [Thu, 19 Mar 2009 14:20:07 +0000 (14:20 +0000)]
Patch from Ruben Laban <r.laban@ism.nl> to make the Makefiles more packager friendly with some modifications.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@704 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRemove sg_init_one() definition, because it was added in the kernel prior 2.6.16.
vlnb [Thu, 19 Mar 2009 14:00:15 +0000 (14:00 +0000)]
Remove sg_init_one() definition, because it was added in the kernel prior 2.6.16.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@703 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSupport for variable lenght CDB added
vlnb [Wed, 18 Mar 2009 19:36:01 +0000 (19:36 +0000)]
Support for variable lenght CDB added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@702 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBetter version of r696
vlnb [Tue, 17 Mar 2009 18:47:05 +0000 (18:47 +0000)]
Better version of r696

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@701 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - scst_user docs updated
vlnb [Tue, 17 Mar 2009 18:07:36 +0000 (18:07 +0000)]
 - scst_user docs updated

 - Added notification about device change in fileio_tgt

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@700 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Support for SCSI AENs added
vlnb [Tue, 17 Mar 2009 18:05:19 +0000 (18:05 +0000)]
 - Support for SCSI AENs added

 - Now sense data are sent without additional memory allocation and copy

 - Sending and receiving padding bytes reimplemented

 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@699 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixed problems in reading iscsi-scst.conf
vlnb [Tue, 17 Mar 2009 18:00:26 +0000 (18:00 +0000)]
 - Fixed problems in reading iscsi-scst.conf
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@698 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Support for Async. Event Notifications added
vlnb [Tue, 17 Mar 2009 17:56:28 +0000 (17:56 +0000)]
 - Support for Async. Event Notifications added

 - Implemented "plug-and-play" notifications about new devices in security groups and changed size of a device both through AENs and Unit Attentions

 - New command SCST_USER_DEVICE_CAPACITY_CHANGED added to scst_user interface to notify SCST core that the corresponding device has changed its capacity

 - New command "resync_size" added to scst_vdisk proc interface to tell scst_vdisk to reread size of the corresponding device.

 - Docs update

 - Minor fixes and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@697 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoIncrease size of struct scst_dev_type.name to match scst_user's requirements
vlnb [Mon, 16 Mar 2009 18:46:17 +0000 (18:46 +0000)]
Increase size of struct scst_dev_type.name to match scst_user's requirements

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@696 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoHeavily modified patch from Gennadiy Nerubayev <parakie@gmail.com>.
vlnb [Mon, 9 Mar 2009 20:05:15 +0000 (20:05 +0000)]
Heavily modified patch from Gennadiy Nerubayev <parakie@gmail.com>.

Adds a pattern matching for initiator names to SCST access control.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@695 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd handling of non-NONE data transfer direction commands with 0 buffer length in...
vlnb [Mon, 9 Mar 2009 19:24:32 +0000 (19:24 +0000)]
Add handling of non-NONE data transfer direction commands with 0 buffer length in scst_user module.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@694 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes in debug/release/perf switching patches
vlnb [Fri, 6 Mar 2009 19:06:32 +0000 (19:06 +0000)]
Fixes in debug/release/perf switching patches

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@693 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSession and connection reinstation fixes for cases when they are shutting down and...
vlnb [Fri, 6 Mar 2009 19:04:48 +0000 (19:04 +0000)]
Session and connection reinstation fixes for cases when they are shutting down and request for reinstation comes.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@692 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Now only sent for execution commands are counted to wait for in TM commands
vlnb [Fri, 6 Mar 2009 19:01:16 +0000 (19:01 +0000)]
 - Now only sent for execution commands are counted to wait for in TM commands
 - TM debug fixes and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@691 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoForgotten chunk in previous commit
vlnb [Fri, 6 Mar 2009 10:26:39 +0000 (10:26 +0000)]
Forgotten chunk in previous commit

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@690 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUse inline numbers for masks rather than assume peace
zorko [Wed, 4 Mar 2009 18:38:48 +0000 (18:38 +0000)]
Use inline numbers for masks rather than assume peace
and goodwill and basic sensible cooperation.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@689 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFexes for processing internal REQUEST SENSE with scst_user handler
vlnb [Wed, 4 Mar 2009 18:33:50 +0000 (18:33 +0000)]
Fexes for processing internal REQUEST SENSE with scst_user handler

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@688 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Connection reinstatement fixes
vlnb [Wed, 4 Mar 2009 18:31:35 +0000 (18:31 +0000)]
 - Connection reinstatement fixes
 - Minor cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@687 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes possible crash on BUG_ON (or memory leak without it), if REQUEST SENSE was...
vlnb [Tue, 3 Mar 2009 18:17:36 +0000 (18:17 +0000)]
Fixes possible crash on BUG_ON (or memory leak without it), if REQUEST SENSE was issued on a command, in which empty sense was returned.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@686 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixed a major IET-derived iSCSI RFC violation: sessions and connections were not...
vlnb [Tue, 3 Mar 2009 18:13:23 +0000 (18:13 +0000)]
 - Fixed a major IET-derived iSCSI RFC violation: sessions and connections were not working
 - A lot of cleanups and minor fixes, mostly IET-derived

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@685 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Cleanups
vlnb [Tue, 3 Mar 2009 18:02:25 +0000 (18:02 +0000)]
 - Cleanups
 - scst_set_initial_UA() added. It sets initial Unit Attention for session, replacing default scst_sense_reset_UA
 - task_mgmt_affected_cmds_done() callback added in struct scst_tgt_template. It's informs target driver that a received task management fun
ction has been completed.
 - Now devices blocked only in reset TM commands. ABORTs, etc. now done without devices blocking
 - scst_unregister_session_ex() removed, since there are no users of it

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@684 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBufflen can be changed after scst_get_cdb_info(), so for bufflen = 0 data_direction...
vlnb [Tue, 3 Mar 2009 17:04:12 +0000 (17:04 +0000)]
Bufflen can be changed after scst_get_cdb_info(), so for bufflen = 0 data_direction should be changed to SCST_DATA_NONE not in scst_get_cdb_info(), but in the end of parsing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@683 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanups
vlnb [Tue, 3 Mar 2009 17:00:53 +0000 (17:00 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@682 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Gal Rosen <galr@storwize.com>:
vlnb [Thu, 26 Feb 2009 20:02:43 +0000 (20:02 +0000)]
Patch from Gal Rosen <galr@storwize.com>:

There are 16 characters of the port_name + 7 characters of ":" + "\0" of
sprintf = total 24 bytes.
wwn_str has only 16 bytes.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@681 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPut some limit checking on dma segments so that
zorko [Mon, 23 Feb 2009 23:18:25 +0000 (23:18 +0000)]
Put some limit checking on dma segments so that
we don't, somehow, inadvertantly overrun the total
number of queue entries for a command + continuation

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@680 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMajor rewrite of DMA mapping code to reduce code duplication
zorko [Mon, 23 Feb 2009 00:13:25 +0000 (00:13 +0000)]
Major rewrite of DMA mapping code to reduce code duplication
and to allow some debug and enhancements that will be easier

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@679 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix for bug reported by Gennadiy Nerubayev <parakie@gmail.com>. In some cases, e...
vlnb [Fri, 20 Feb 2009 18:04:11 +0000 (18:04 +0000)]
Fix for bug reported by Gennadiy Nerubayev <parakie@gmail.com>. In some cases, e.g. with DRBD, bio->bi_end_io() can be called with IRQs disable which isn't appropriate for direct processing in SCST core. Switch to one of internal SCST threads in such cases.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@678 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Krzysztof Blaszkowski with some cleanups:
vlnb [Thu, 19 Feb 2009 19:06:13 +0000 (19:06 +0000)]
Patch from Krzysztof Blaszkowski with some cleanups:

I realized yesterday that the fix missed one rare case
still. if the hiwmk_check() returned with error and no_fail override was set
then the counter would still cross 0 on free.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@677 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Krzysztof Blaszkowski:
vlnb [Wed, 18 Feb 2009 19:17:29 +0000 (19:17 +0000)]
Patch from Krzysztof Blaszkowski:

i noticed this issue running simple iscsi connection test to a few targets.
without included patch the active_pages_total counter wraps around 0 thus it
breaks logic for releasing memory on "hi watermark" just like it is depicted

Inactive/active pages                      18/-25
Hi/lo watermarks [pages]                   119808/0
Hi watermark releases/failures             4/0

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@676 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Docs updates
vlnb [Wed, 18 Feb 2009 18:52:35 +0000 (18:52 +0000)]
 - Docs updates
 - Minor cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@675 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes negotiation breakage, introduced by r667
vlnb [Mon, 16 Feb 2009 18:46:00 +0000 (18:46 +0000)]
Fixes negotiation breakage, introduced by r667

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@674 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix patching that I broke.
zorko [Fri, 13 Feb 2009 18:02:48 +0000 (18:02 +0000)]
Fix patching that I broke.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@673 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge in work from Feral into this branch. The
zorko [Wed, 11 Feb 2009 18:55:43 +0000 (18:55 +0000)]
Merge in work from Feral into this branch. The
recovery from not being able to push a ctio
fix is in. Various task management fixes are
also in. Other work in progress.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@672 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBroaden tags target.
zorko [Wed, 11 Feb 2009 18:54:17 +0000 (18:54 +0000)]
Broaden tags target.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@671 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRe-order Makefile install and uninstall a bit. Specifically
mgandalf [Wed, 11 Feb 2009 16:16:53 +0000 (16:16 +0000)]
Re-order Makefile install and uninstall a bit. Specifically
for the install so lsb commands come last should lsb not exist
on the system, at least the rest of install works.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@670 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd lsb support for init.d scripts. Patch from Bart Van Assche.
mgandalf [Wed, 11 Feb 2009 16:09:45 +0000 (16:09 +0000)]
Add lsb support for init.d scripts. Patch from Bart Van Assche.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@669 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes checkpatch errors notices by Bart Van Assche <bart.vanassche@gmail.com>
vlnb [Mon, 9 Feb 2009 20:08:14 +0000 (20:08 +0000)]
Fixes checkpatch errors notices by Bart Van Assche <bart.vanassche@gmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@668 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Iscsi-scst-adm fixes. It should be fully functional now.
vlnb [Fri, 6 Feb 2009 19:52:34 +0000 (19:52 +0000)]
 - Iscsi-scst-adm fixes. It should be fully functional now.
 - Other iSCSI-SCST user space fixes, improvements and cleanups.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@667 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanups
vlnb [Fri, 6 Feb 2009 19:46:57 +0000 (19:46 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@666 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago2 missed functions added to scst_user interface:
vlnb [Thu, 5 Feb 2009 18:30:50 +0000 (18:30 +0000)]
2 missed functions added to scst_user interface:

 - SCST_USER_UNREGISTER_DEVICE - to unregister device, flush mem reuse (SGV) cache and send UCMD_STATE_ON_CACHE_FREEING notifications for all freed buffers to the user space handler. Simple device close doesn't allow that, so all the cached buffers might look as "leaked" from the user space handler POV.

 - SCST_USER_FLUSH_CACHE - to flush mem reuse (SGV) cache and send UCMD_STATE_ON_CACHE_FREEING notifications for all freed buffers to the user space handler

+ some cosmetics

Docs update is coming

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@665 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fix typo in scst_rx_mgmt_fn_tag() call for task abort
vlnb [Thu, 5 Feb 2009 18:23:28 +0000 (18:23 +0000)]
 - Fix typo in scst_rx_mgmt_fn_tag() call for task abort
 - Cosmetics

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@664 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoClustering of scst_user pages added
vlnb [Thu, 5 Feb 2009 18:07:51 +0000 (18:07 +0000)]
Clustering of scst_user pages added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@663 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoA bunch of pending fixes/cleanups:
vlnb [Wed, 4 Feb 2009 18:45:32 +0000 (18:45 +0000)]
A bunch of pending fixes/cleanups:

 - Docs about limitation of having initiator and target on the same host updated + cleanups
 - Minor local thread storage improvements
 - TRACE_MGMT_MINOR excluded from the default set of trace flags to not confuse people
 - Dedicated kmem_cache for blockio created

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@662 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRemove some misleading and dead files.
zorko [Tue, 3 Feb 2009 06:32:12 +0000 (06:32 +0000)]
Remove some misleading and dead files.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@661 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUpdate some firmware sets.
zorko [Tue, 3 Feb 2009 06:31:27 +0000 (06:31 +0000)]
Update some firmware sets.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@660 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoIn the header file scst.h scst_cmd::sg_cnt and tgt_sg_cnt::sg_cnt are declared
vlnb [Mon, 2 Feb 2009 16:25:47 +0000 (16:25 +0000)]
In the header file scst.h scst_cmd::sg_cnt and tgt_sg_cnt::sg_cnt are declared
as signed integers, while some inline functions in the same header file treat
these as unsigned integers. The patch below converts all uses to signed

The patch below has been verified by checking the output files generated by
the following command:
  scripts/run-regression-tests -k -k -k -k -k

Note: I do not expect that this patch changes the behavior of SCST in any way.
This patch is not a bug fix -- all it does is cleaning up an inconsistency.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@659 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below implements the following changes for the iSCSI-SCST HOWTO
vlnb [Mon, 2 Feb 2009 15:49:39 +0000 (15:49 +0000)]
The patch below implements the following changes for the iSCSI-SCST HOWTO
- Added RHEL / CentOS to the list of officially supported kernels.
- Mentioned that regenerating the initial RAM disk is an explicit step on many
- Replaced shell instructions for generating /etc/scst.conf by a sequence of
  scstadmin commands.
- Added note about insserv.

Also it adds small HOWTO how to recompile RHEL/CentOS kernel in README_RHEL.

Also it implements some docs cleanups.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@658 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below adds the following two RHEL 5 / CentOS 5 patches to the SCST
vlnb [Mon, 2 Feb 2009 11:36:53 +0000 (11:36 +0000)]
The patch below adds the following two RHEL 5 / CentOS 5 patches to the SCST
source tree:
- Support for zero-copy TCP transfer completion.
- An implementation of scsi_execute_async_fifo().
Except for the hunk headers, these patches are identical to similarly named
patches already present in the SCST source tree.

Additionally, implementations of seq_list_start() and seq_list_next() are
provided for those kernel versions that do not define these functions.

The patch below has been tested by verifying that iSCSI data transfer still
works OK on CentOS 5.2 (x86_64).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@657 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below is a minor correction for the 2.6.27 in-tree kernel patches
vlnb [Mon, 2 Feb 2009 11:29:14 +0000 (11:29 +0000)]
The patch below is a minor correction for the 2.6.27 in-tree kernel patches
I submitted about three months ago: the patch headers now refer to the 2.6.27
kernel as they should instead of the 2.6.26 kernel. At least one user has been
confused by this. The patch below does not change any behavior of SCST.
The patch has been tested by verifying that the output of the following
command remained the same as before the modifications:
scripts/run-regression-tests -k 2.6.27

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@656 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Removed artificial limitation on sg_tablesize. It isn't needed, because the regula...
vlnb [Mon, 2 Feb 2009 11:16:38 +0000 (11:16 +0000)]
 - Removed artificial limitation on sg_tablesize. It isn't needed, because the regular iSCSI negotiated MaxRecvDataSegmentLength-related facilities do all the job pretty well.
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@655 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFinal merge with IET (r201-204):
vlnb [Fri, 30 Jan 2009 17:47:31 +0000 (17:47 +0000)]
Final merge with IET (r201-204):

 - 2.6.25 introduced netlink_socket_release(), to be used to clean up netlink sockets correctly (taking care of namespaces).

 - New more scalable proc seq_file implementation

+ minor signess cleanups

+ version updated

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@654 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r196:
vlnb [Fri, 30 Jan 2009 16:49:01 +0000 (16:49 +0000)]
Merge with IET r196:

 - Allow removal of kernel target objects if the user space object does not exist

Based on a patch by Lars Ellenberg.

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@653 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r195:
vlnb [Fri, 30 Jan 2009 16:41:22 +0000 (16:41 +0000)]
Merge with IET r195:

From: Lars Ellenberg <lars.ellenberg@linbit.com>

Ignore SIGPIPE in ietd

Otherwise we would die in some later write() during the event_loop
instead of getting EPIPE!

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@652 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge of IET r194:
vlnb [Fri, 30 Jan 2009 16:36:39 +0000 (16:36 +0000)]
Merge of IET r194:

 - Add support for Reject PDUs and make use of them in appropriate places.

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@651 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r192-193:
vlnb [Fri, 30 Jan 2009 16:25:52 +0000 (16:25 +0000)]
Merge with IET r192-193:

 - Introduce min*/max*() and more list_* macros

 - Multipart PDU support for discovery sessions

The conn's response buffer is now replaced with a list of buffers and
all users are updated accordingly. Discovery sessions can make use of
this mechanism, if the list of targets + addresses does not fit into a
single text PDU, the initiator may now retrieve subsequent parts.

This also fixes the data segment handling for discovery sessions.

Based on a patch originally provided by Shreyansh Jain <shrey.linux@gmail.com>

Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@650 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r170-191:
vlnb [Thu, 29 Jan 2009 19:10:10 +0000 (19:10 +0000)]
Merge with IET r170-191:

 - Update MaxConnections documentation
 - Remove isns config description from man page
 - Check return values of chdir(), ftruncate() and write(), because recent versions of the glibc insist on the return value being checked by
introducing __attribute__((warn_unused_result)) to these functions.
 - Fix snprintf use in isns.c
 - Take \0-termination into account when passing strings to isns_tlv_set() to solve incompatibility with MS iSNS 3.0 as IQN length is multiple of 4
 - Fix list corruption if SCST target registration fails
 - Register the target port actually used instead of the default iSCSI port.
 - Remove unused connection->pad
 - Refactor cmnd_execute()
 - Version changed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@649 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fix for iSCSI RFC violation: TARGET COLD RESET must close all connections/sessions...
vlnb [Thu, 29 Jan 2009 18:25:45 +0000 (18:25 +0000)]
 - Fix for iSCSI RFC violation: TARGET COLD RESET must close all connections/sessions, not only the current one
 - Cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@648 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r169:
vlnb [Thu, 29 Jan 2009 12:19:22 +0000 (12:19 +0000)]
Merge with IET r169:

From:  Shreyansh Jain <shrey.linux at gmail.com>
Subject: [Patch 1/1] Segfault in ietd buffer overrun in dump_line

Fix a buffer overrun problem in __dump_line function in log.c file.
It also removes a stray 'return' call in log_pdu function which was
restricting a PDU dump call to complete log_pdu operation.

Also, in log_pdu function, the first check for log_level against
passed parameter for log was incorrect and would have forced a return
even when the caller has set the logging level to acceptable level.

Signed-off-by: Shreyansh Jain <shrey.linux at gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@647 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMerge with IET r160-168: add iscsi-scst-adm support to display list of CHAP accounts...
vlnb [Thu, 29 Jan 2009 12:12:42 +0000 (12:12 +0000)]
Merge ... IET r160-168: add iscsi-scst-adm support to display list of CHAP accounts and their data

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@646 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake USN related stuff completed. Unfortunately, it can break existing cluster setups...
vlnb [Wed, 28 Jan 2009 18:44:59 +0000 (18:44 +0000)]
Make USN related stuff completed. Unfortunately, it can break existing cluster setups, but it's better to make it now, then later.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@645 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSync with IET revisions 156-159: fix for compilation on glibc 2.8
vlnb [Tue, 27 Jan 2009 18:50:33 +0000 (18:50 +0000)]
Sync with IET revisions 156-159: fix for compilation on glibc 2.8

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@644 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Add autogenerated USN
vlnb [Tue, 27 Jan 2009 18:09:24 +0000 (18:09 +0000)]
 - Add autogenerated USN
 - Sync fileio_tgt with scst_vdisk

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@643 d57e44dd-8a1f-0410-8b47-8ef2f437770f