mirror/scst/.git
10 years agoChanges:
bvassche [Mon, 28 Dec 2009 19:31:51 +0000 (19:31 +0000)]
Changes:
- Convert sense data to/from fixed format / descriptor format before
  sending back a response.
- Print an error message to the kernel log when an unsupported IB event
  has been received.
- Return the SCSI status BUSY instead of CHECK CONDITION when allocating
  an SCST command failed (until r1409, the SCSI status in the SRP_RSP
  information unit was set to TASK SET FULL in this case).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1419 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFollow-up for r1415: compiles again without warnings on both 32-bit
bvassche [Sat, 26 Dec 2009 18:57:17 +0000 (18:57 +0000)]
Follow-up for r1415: compiles again without warnings on both 32-bit
and 64-bit systems.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1418 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated to do list.
bvassche [Sat, 26 Dec 2009 09:23:39 +0000 (09:23 +0000)]
Updated to do list.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1417 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBehavior changes:
bvassche [Fri, 25 Dec 2009 15:26:42 +0000 (15:26 +0000)]
Behavior changes:
- Fixed: the SCSOLNT and UCSOLNT bits were ignored in received SRP requests,
  and the SOLNT bit was not set in responses when required. This is required
  by the SRP protocol specification.
- Fixed: SRP_RSP messages must be limited to the MAXIMUM TARGET TO INITIATOR
  IU LENGTH  field indicated in the SRP_LOGIN_RSP response instead of the
  maximum message size supported by SRPT. This is also required by the SRP
  protocol specification.
- Fixed: the STATUS field of response messages with status GOOD and that
  contain sense data is no longer modified into CHECK CONDITION.
Internal changes (refactoring):
- Replaced the SCSI sense data handling data structures and code in SRPT by
  those of the SCST core.
- Moved the code for building an error response from srpt_handle_cmd() and
  srpt_handle_tsk_mgmt() to srpt_handle_new_iu().
- Removed the ioctx::data_len member.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1416 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed a recently introduced format specification mismatch.
bvassche [Fri, 25 Dec 2009 09:10:10 +0000 (09:10 +0000)]
Fixed a recently introduced format specification mismatch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1415 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMove all the code from scst_cdbprobe.h to scst_lib.c where it should really belong.
vlnb [Thu, 24 Dec 2009 19:46:20 +0000 (19:46 +0000)]
Move all the code from scst_cdbprobe.h to scst_lib.c where it should really belong.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1414 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates.
vlnb [Thu, 24 Dec 2009 13:54:49 +0000 (13:54 +0000)]
Web updates.

Tooltips code and usage provided by Greg V Zemskov <mne@greg.su> and Kirill Malkin <kirill.malkin@reldata.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1412 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Die if /proc/scsi_tgt/version doesn't exist.
mgandalf [Wed, 23 Dec 2009 19:55:07 +0000 (19:55 +0000)]
- Die if /proc/scsi_tgt/version doesn't exist.
- Replace croak() with die() in the module.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1411 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel versions 2.6.27.41, 2.6.31.8 and 2.6.32.1 to 2.6.27.42, 2.6.31.9 and...
bvassche [Sat, 19 Dec 2009 10:46:17 +0000 (10:46 +0000)]
Updated kernel versions 2.6.27.41, 2.6.31.8 and 2.6.32.1 to 2.6.27.42, 2.6.31.9 and 2.6.32.2 respectively.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1410 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that all log lines generated by the ib_srpt kernel module
bvassche [Fri, 18 Dec 2009 19:11:24 +0000 (19:11 +0000)]
Made sure that all log lines generated by the ib_srpt kernel module
have an "ib_srpt: " prefix. Thanks to Stanley Sufficool for the patch.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1409 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBetter handling of devices, which don't support MODE SENSE control mode page
vlnb [Fri, 18 Dec 2009 17:21:27 +0000 (17:21 +0000)]
Better handling of devices, which don't support MODE SENSE control mode page

Tested-By: Dietmar Maurer <dietmar@proxmox.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1408 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoMade sure that checkpatch doesn't complain about missing whitespace around
bvassche [Fri, 18 Dec 2009 17:16:03 +0000 (17:16 +0000)]
Made sure that checkpatch doesn't complain about missing whitespace around
the minus character in the following expression:
    tgt_dev->curr_sn = (typeof(tgt_dev->curr_sn)) -300

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1407 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSmall cleanup: there's no need to have SN's long + test on SNs overflow added
vlnb [Thu, 17 Dec 2009 12:57:24 +0000 (12:57 +0000)]
Small cleanup: there's no need to have SN's long + test on SNs overflow added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1406 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed the following category of complaints reported by the 2.6.32 checkpatch:
bvassche [Wed, 16 Dec 2009 20:01:08 +0000 (20:01 +0000)]
Fixed the following category of complaints reported by the 2.6.32 checkpatch:
  11 ERROR: that open brace { should be on the previous line

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1405 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded kernel version 2.6.32.1.
bvassche [Wed, 16 Dec 2009 19:51:11 +0000 (19:51 +0000)]
Added kernel version 2.6.32.1.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1404 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded to repository.
bvassche [Wed, 16 Dec 2009 19:49:19 +0000 (19:49 +0000)]
Added to repository.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1403 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed kernel version numbers.
bvassche [Wed, 16 Dec 2009 19:49:00 +0000 (19:49 +0000)]
Fixed kernel version numbers.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1402 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix incorrect initialization of scst_mgmt_cmd_stub structure
vlnb [Wed, 16 Dec 2009 19:24:42 +0000 (19:24 +0000)]
Fix incorrect initialization of scst_mgmt_cmd_stub structure

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1400 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdate for 2.6.32 + fix context of vdisk_t10_dev_id_rwlock
vlnb [Wed, 16 Dec 2009 19:21:41 +0000 (19:21 +0000)]
Update for 2.6.32 + fix context of vdisk_t10_dev_id_rwlock

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1399 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFixed incorrect "set_t10_dev_id " token size caused by rename of set_t10_device_id...
vlnb [Wed, 16 Dec 2009 11:48:29 +0000 (11:48 +0000)]
Fixed incorrect "set_t10_dev_id " token size caused by rename of set_t10_device_id to set_t10_dev_id.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1398 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com> adding missed links in 2...
vlnb [Wed, 16 Dec 2009 11:38:54 +0000 (11:38 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com> adding missed links in 2 pages

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1397 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFix spelling typos.
vlnb [Wed, 16 Dec 2009 11:35:12 +0000 (11:35 +0000)]
Fix spelling typos.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
with additional spelling fixes noticed by frank zago <fzago@systemfabricworks.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1396 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Added -noprompt option. Use with care!
mgandalf [Tue, 15 Dec 2009 20:01:01 +0000 (20:01 +0000)]
- Added -noprompt option. Use with care!
- Added support for T10 device ID. Applied modified patch by witoldk1@open-e.com.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1395 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Witold Kowolik <witold.kowolik@open-e.com> ranaming SCSI ID to T10 device...
vlnb [Tue, 15 Dec 2009 19:32:20 +0000 (19:32 +0000)]
Patch from Witold Kowolik <witold.kowolik@open-e.com> ranaming SCSI ID to T10 device ID + small fix to handle spaces in t10dev_id with small changes. Particularly, I renamed everywhere t10_device_id in t10_dev_id.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1394 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Smadar Gonen <smadar.gn@gmail.com> with minor changes fixing race in task...
vlnb [Tue, 15 Dec 2009 18:32:13 +0000 (18:32 +0000)]
Patch from Smadar Gonen <smadar.gn@gmail.com> with minor changes fixing race in task managmement code if several TM functions affect the same command on different stages of processing.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1392 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel version 2.6.31.7 to 2.6.31.8.
bvassche [Mon, 14 Dec 2009 19:14:23 +0000 (19:14 +0000)]
Updated kernel version 2.6.31.7 to 2.6.31.8.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1391 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSpelling fix.
bvassche [Sun, 13 Dec 2009 18:02:39 +0000 (18:02 +0000)]
Spelling fix.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1390 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated SRPT documentation.
bvassche [Sun, 13 Dec 2009 18:01:14 +0000 (18:01 +0000)]
Updated SRPT documentation.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1389 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBug fix: SRQ availability counter is no longer decremented when ib_post_send() fails.
bvassche [Sun, 13 Dec 2009 17:59:44 +0000 (17:59 +0000)]
Bug fix: SRQ availability counter is no longer decremented when ib_post_send() fails.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1388 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAdded an additional consistency check: an error message is now printed if
bvassche [Sun, 13 Dec 2009 13:00:39 +0000 (13:00 +0000)]
Added an additional consistency check: an error message is now printed if
the kernel-ib-devel RPM has been installed but not the kernel-ib RPM.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1387 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWhitespace-only change: fixed a checkpatch complaint.
bvassche [Wed, 9 Dec 2009 12:03:35 +0000 (12:03 +0000)]
Whitespace-only change: fixed a checkpatch complaint.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1386 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel version 2.6.27.40 to 2.6.27.41.
bvassche [Wed, 9 Dec 2009 11:38:11 +0000 (11:38 +0000)]
Updated kernel version 2.6.27.40 to 2.6.27.41.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1385 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated kernel versions 2.6.27.39 and 2.6.31.6 to 2.6.27.40 and 2.6.31.7 respectively.
bvassche [Tue, 8 Dec 2009 20:47:50 +0000 (20:47 +0000)]
Updated kernel versions 2.6.27.39 and 2.6.31.6 to 2.6.27.40 and 2.6.31.7 respectively.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1384 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdate: the __same_type() macro has been introduced in kernel version 2.6.31, not...
bvassche [Mon, 7 Dec 2009 08:51:58 +0000 (08:51 +0000)]
Update: the __same_type() macro has been introduced in kernel version 2.6.31, not in 2.6.30.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1383 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Fixed a checkpatch complaint.
bvassche [Mon, 7 Dec 2009 08:07:58 +0000 (08:07 +0000)]
- Fixed a checkpatch complaint.
- Made sure that the SRPT source code compiles again on systems with a 2.6.29
  or older kernel.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1382 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFMR only applies to the SRP initiator, not to the SRP target.
bvassche [Mon, 7 Dec 2009 07:21:39 +0000 (07:21 +0000)]
FMR only applies to the SRP initiator, not to the SRP target.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1381 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Simplified error handling in srpt_get_desc_tbl(): incorrect indirect
bvassche [Sun, 6 Dec 2009 19:00:25 +0000 (19:00 +0000)]
- Simplified error handling in srpt_get_desc_tbl(): incorrect indirect
  descriptors are now reported by returning -EINVAL instead of setting the
  third argument to true. Removed the third argument of this function.
- Added support for SRP_CMD requests with non-zero ADDITIONAL CDB LENGTH.
  Note: support for these requests has not yet been tested -- I do not know
  of any SRP initiator that generates such requests.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1380 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated SRPT documentation.
bvassche [Sun, 6 Dec 2009 12:44:47 +0000 (12:44 +0000)]
Updated SRPT documentation.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1379 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoUpdated to do list.
bvassche [Sun, 6 Dec 2009 12:37:21 +0000 (12:37 +0000)]
Updated to do list.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1378 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Moved two constants from ib_srpt.c to ib_srpt.h.
bvassche [Sat, 5 Dec 2009 10:10:53 +0000 (10:10 +0000)]
- Moved two constants from ib_srpt.c to ib_srpt.h.
- Changed default value of srp_max_message_size from 4096 to 2116. This
  size corresponds to the size of an SRP_CMD request message containing
  an indirect buffer list with 128 elements.
- A warning is now printed when an SRP_CMD request is received containing
  more than one CDB -- this kind of messages is not yet supported.
- Switched back from multiple ib_dma_sync_single_for_cpu() calls to a
  single call because the latter results in better performance.
- An error message is now printed if a corrupt SRP_CMD request has been
  received. Before these were ignored silently.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1377 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Added new vdisk_blockio and vdisk_nullio introduced by the sysfs changes.
mgandalf [Fri, 4 Dec 2009 19:08:32 +0000 (19:08 +0000)]
- Added new vdisk_blockio and vdisk_nullio introduced by the sysfs changes.
  Change by witoldk1@open-e.com.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1376 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoValidator fix
vlnb [Thu, 3 Dec 2009 18:57:58 +0000 (18:57 +0000)]
Validator fix

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1375 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoWeb updates
vlnb [Thu, 3 Dec 2009 18:43:13 +0000 (18:43 +0000)]
Web updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1374 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoSome locking cleanups
vlnb [Mon, 30 Nov 2009 19:17:59 +0000 (19:17 +0000)]
Some locking cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1373 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoShould have been included in the previous commit (r1371).
bvassche [Mon, 30 Nov 2009 10:59:40 +0000 (10:59 +0000)]
Should have been included in the previous commit (r1371).

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1372 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoAvoid dangling pointer dereferences by resetting ioctx->scmnd in srpt_on_free_cmd().
bvassche [Mon, 30 Nov 2009 09:51:17 +0000 (09:51 +0000)]
Avoid dangling pointer dereferences by resetting ioctx->scmnd in srpt_on_free_cmd().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1371 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoCleanup:
bvassche [Sat, 28 Nov 2009 18:40:15 +0000 (18:40 +0000)]
Cleanup:
- Removed a spinlock that became superfluous.
- Fixed checkpatch and sparse complaints.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1370 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years ago- Split srpt_find_channel into two functions: srpt_find_channel() and
bvassche [Sat, 28 Nov 2009 17:20:22 +0000 (17:20 +0000)]
- Split srpt_find_channel into two functions: srpt_find_channel() and
  srpt_release_channel_by_cmid().
- Removed tracing statements from srpt_unmap_sg_to_ib_sge() because this
  function is now invoked while performing I/O.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1369 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBug fixes (some introduced in the previous revision, some long-standing):
bvassche [Sat, 28 Nov 2009 16:36:53 +0000 (16:36 +0000)]
Bug fixes (some introduced in the previous revision, some long-standing):
- Fixed system lockup triggered by "rmmod ib_srpt" while the SRP was writing
  data. This lockup occurred because srpt_reset_ioctx() was not resetting
  the pointers to the memory it freed, which indirectly triggered a kernel
  oops in the IB interrupt handler.
- Fixed BUG() during "rmmod ib_srpt" triggered by calling scst_rx_cmd()
  after scst_unregister_session(). This has been fixed by making sure that
  the channel state is set to RDMA_CHANNEL_DISCONNECTING before calling
  scst_unregister_session().
Performance improvements:
- Simplified cmd_wait_list manipulation code.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1368 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoBug fixes:
bvassche [Sat, 28 Nov 2009 14:03:55 +0000 (14:03 +0000)]
Bug fixes:
- Fixed races on srpt_ioctx::state manipulation by declaring this variable
  atomic.
- Fixed races on srpt_rdma_ch::state manipulation by declaring this variable
  atomic.
- Fixed bug in srpt_abort_scst_cmd(): SRPT_STATE_DATA_IN was not yet handled.
- Fixed races on srpt_rdma_ch::cm_id destruction. Clearly documented which
  object owns the cm_id at which time.
Performance improvements:
- Eliminated the list of active commands (active_scmnd_list) because this
  list was a duplicated of a list already kept by the SCST core.
- Switched to double-checked locking in srpt_handle_new_iu(). This saves one
  spin_lock_irqsave() and one spin_unlock_irqrestore() call in the common
  case (that is, a live channel).
- Eliminated RDMA channel state tests in SCST command handling callback
  functions -- removed the function srpt_abort_if_disconnecting().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1367 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoRemoved trailing whitespace.
bvassche [Sat, 28 Nov 2009 08:24:10 +0000 (08:24 +0000)]
Removed trailing whitespace.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1366 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoPatch from Witold Kowolik <witoldk1@open-e.com> implementing manual setting of SCSI...
vlnb [Fri, 27 Nov 2009 18:52:23 +0000 (18:52 +0000)]
Patch from Witold Kowolik <witoldk1@open-e.com> implementing manual setting of SCSI ID on vdisk devices (with some changes)

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1365 d57e44dd-8a1f-0410-8b47-8ef2f437770f

10 years agoFollowup for r1361
vlnb [Fri, 27 Nov 2009 18:22:45 +0000 (18:22 +0000)]
Followup for r1361

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1364 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoChanges:
bvassche [Fri, 27 Nov 2009 17:52:47 +0000 (17:52 +0000)]
Changes:
- The message that sense data is truncated is now generated via the
  PRINT_WARNING() macro instead of TRACE_DBG().
- Cleaned up code for sense data truncation.
- Compiles again on RHEL and CentOS systems.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1363 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoLog sense data truncation when debugging is enabled.
bvassche [Fri, 27 Nov 2009 12:10:59 +0000 (12:10 +0000)]
Log sense data truncation when debugging is enabled.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1362 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoDevice sysfs locking reconsidered to remove recently introduced deadlock possibility.
vlnb [Thu, 26 Nov 2009 18:39:13 +0000 (18:39 +0000)]
Device sysfs locking reconsidered to remove recently introduced deadlock possibility.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1361 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoImprove fairness between connections.
vlnb [Tue, 24 Nov 2009 19:50:11 +0000 (19:50 +0000)]
Improve fairness between connections.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1360 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoLogos rearranged
vlnb [Tue, 24 Nov 2009 11:52:54 +0000 (11:52 +0000)]
Logos rearranged

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1359 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFix for warning: 'res' may be used uninitialized in this function
vlnb [Mon, 23 Nov 2009 18:43:03 +0000 (18:43 +0000)]
Fix for warning: 'res' may be used uninitialized in this function

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1358 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago - Patch from Daniel Fernandes <dfernandes1978@hotmail.com> adding validator logos
vlnb [Mon, 23 Nov 2009 16:38:44 +0000 (16:38 +0000)]
 - Patch from Daniel Fernandes <dfernandes1978@hotmail.com> adding validator logos
 - QStar Technologies added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1357 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago - Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing bug in URL reporte...
vlnb [Mon, 23 Nov 2009 12:06:23 +0000 (12:06 +0000)]
 - Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing bug in URL reported by validator
 - Soul company name fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1356 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com>:
vlnb [Mon, 23 Nov 2009 11:44:55 +0000 (11:44 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com>:

 - Fixes Some code error in comparison.html
 - Add class tab to Orange.css
 - Add tab class in code inside Contributing.html

+ Beijing Soul Technology Co., Ltd. added on the users page

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1355 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoWhitespace-only change.
bvassche [Mon, 23 Nov 2009 08:40:51 +0000 (08:40 +0000)]
Whitespace-only change.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1354 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago- Added counter that keeps track of the number of work requests posted on
bvassche [Sun, 22 Nov 2009 18:42:35 +0000 (18:42 +0000)]
- Added counter that keeps track of the number of work requests posted on
  the per-channel queue pair. This counter is used to prevent that
  ib_post_send() triggers a queue overflow.
- Fixed error handling in srpt_xfer_data(): srpt_unmap_sg_to_ib_sge() is now
  called before returning an error code.
- Simplified implementation of the sysfs attribute login_info.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1353 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agogcc 4.4.1 (as included in openSUSE 11.2) complains about the user-space iSCSI code...
vlnb [Fri, 20 Nov 2009 19:53:12 +0000 (19:53 +0000)]
gcc 4.4.1 (as included in openSUSE 11.2) complains about the user-space iSCSI code because it breaks strict-aliasing rules. The reported warnings should be addressed because not doing so can result in the compiler generating incorrect code. The patch below fixes these compiler warnings.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1352 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing a bit incorrect layou...
vlnb [Fri, 20 Nov 2009 11:28:37 +0000 (11:28 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing a bit incorrect layout on the users page

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1351 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoOrdered reads groupped under single config symbol.
vlnb [Thu, 19 Nov 2009 11:57:57 +0000 (11:57 +0000)]
Ordered reads groupped under single config symbol.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1350 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFix bug preventing pass-through dev handlers be loaded if SCSI_EXEC_REQ_FIFO_DEFINED...
vlnb [Thu, 19 Nov 2009 10:22:25 +0000 (10:22 +0000)]
Fix bug preventing pass-through dev handlers be loaded if SCSI_EXEC_REQ_FIFO_DEFINED not defined.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1349 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoMinor web updates and fixes
vlnb [Wed, 18 Nov 2009 13:57:58 +0000 (13:57 +0000)]
Minor web updates and fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1348 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoRemoved trailing whitespace.
bvassche [Wed, 18 Nov 2009 07:52:12 +0000 (07:52 +0000)]
Removed trailing whitespace.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1347 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoUpdated to do list once more.
bvassche [Wed, 18 Nov 2009 07:22:30 +0000 (07:22 +0000)]
Updated to do list once more.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1346 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoUpdated to do list.
bvassche [Tue, 17 Nov 2009 20:03:35 +0000 (20:03 +0000)]
Updated to do list.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1345 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoAdded more comments.
bvassche [Tue, 17 Nov 2009 18:01:16 +0000 (18:01 +0000)]
Added more comments.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1344 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoRemoved a BUILD_BUG_ON() statement that was too restrictive.
bvassche [Tue, 17 Nov 2009 18:00:23 +0000 (18:00 +0000)]
Removed a BUILD_BUG_ON() statement that was too restrictive.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1343 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFix for recently introduced incorrectly set expected data direction
vlnb [Tue, 17 Nov 2009 13:53:03 +0000 (13:53 +0000)]
Fix for recently introduced incorrectly set expected data direction

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1342 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoMinor compiler and checkpatch fixes
vlnb [Tue, 17 Nov 2009 12:59:49 +0000 (12:59 +0000)]
Minor compiler and checkpatch fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1341 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoWeb fixes from Daniel Fernandes <dfernandes1978@hotmail.com>
vlnb [Tue, 17 Nov 2009 12:10:10 +0000 (12:10 +0000)]
Web fixes from Daniel Fernandes <dfernandes1978@hotmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1340 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com>:
vlnb [Mon, 16 Nov 2009 18:19:46 +0000 (18:19 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com>:

 - Fixes wrong writing in using CompanySubTitles Class
 - Fixes lost link for SCST Local in Pages scst_admin.html and handler_fileio_tgt.html
 - Fixes Users.html page in Subtitles( I increase a little page space, and reduce a little font size)

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1339 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago - Fix for memory allocation for scst_user and locally handled commands
vlnb [Mon, 16 Nov 2009 18:05:10 +0000 (18:05 +0000)]
 - Fix for memory allocation for scst_user and locally handled commands
 - Execution context cleanups and fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1338 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoUsers page made logs based
vlnb [Mon, 16 Nov 2009 17:22:27 +0000 (17:22 +0000)]
Users page made logs based

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1337 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoSince the expression "sizeof(*sense) + sizeof(*sense) % 4" did not make
bvassche [Sun, 15 Nov 2009 13:14:40 +0000 (13:14 +0000)]
Since the expression "sizeof(*sense) + sizeof(*sense) % 4" did not make
sense, replaced this expression by "sizeof(*sense)" and a BUILD_BUG_ON()
statement that verifies that sizeof(*sense) is a multiple of four. Should
the first expression have been "roundup(sizeof(*sense), 4)" ?

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1336 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago- Small performance improvement: ib_dma_sync_for_device() and
bvassche [Sun, 15 Nov 2009 13:11:46 +0000 (13:11 +0000)]
- Small performance improvement: ib_dma_sync_for_device() and
  ib_dma_sync_for_cpu() calls do now only synchronize the data areas used.
- Removed per-command mutex again because it's not a full solution with
  regard to avoiding races between module unloading / IB error handling and
  SCST's command handling.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1335 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFixed a (false positive) compiler warning.
bvassche [Sat, 14 Nov 2009 19:30:27 +0000 (19:30 +0000)]
Fixed a (false positive) compiler warning.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1334 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoUpdated test instructions.
bvassche [Wed, 11 Nov 2009 18:56:05 +0000 (18:56 +0000)]
Updated test instructions.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1333 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago- Fixed races between command abortion code and regular command processing
bvassche [Wed, 11 Nov 2009 18:44:05 +0000 (18:44 +0000)]
- Fixed races between command abortion code and regular command processing
  code.
- Fixed the bug that new commands could be queued for a channel that was
  being closed.
- Bug fix: ib_dma_unmap_sg() is now called by srpt_xmit_response() when
  aborting commands.
- Changed default value of the kernel module parameter 'thread' from zero
  to one because using thread=0 can cause the Linux and the OFED SRP
  initiator to lock up -- see also
  http://bugzilla.kernel.org/show_bug.cgi?id=14235 and
  https://bugs.openfabrics.org/show_bug.cgi?id=1745.
- Made disconnect logging more detailed -- added cm_id in output.
- Changed argument type of second argument of srpt_release_channel() from
  int to bool.
- Eliminated srpt_abort_scst_cmd's 'tell_initiator' argument because this
  argument always has the same value (i.e. true).
- Simplified abortion of commands in state SRPT_STATE_NEW. Simplified
  implementation of srpt_on_free_cmd().

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1332 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoUpdated kernel versions 2.6.27.38 and 2.6.31.5 to 2.6.28.39 and 2.6.31.6 respectively.
bvassche [Tue, 10 Nov 2009 11:59:00 +0000 (11:59 +0000)]
Updated kernel versions 2.6.27.38 and 2.6.31.5 to 2.6.28.39 and 2.6.31.6 respectively.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1331 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoWeb fixes from Daniel Fernandes <dfernandes1978@hotmail.com>
vlnb [Mon, 9 Nov 2009 20:05:52 +0000 (20:05 +0000)]
Web fixes from Daniel Fernandes <dfernandes1978@hotmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1330 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoBIDI fixes
vlnb [Mon, 9 Nov 2009 13:53:57 +0000 (13:53 +0000)]
BIDI fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1329 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years ago- Changed default maximum control message size from 996 to 4096 bytes.
bvassche [Sat, 7 Nov 2009 11:56:51 +0000 (11:56 +0000)]
- Changed default maximum control message size from 996 to 4096 bytes.
  As a result, the maximum number of sg list elements that an initiator
  can pass in one message increased from 58 to 251.
- Added kernel module parameter srp_max_message_size, which allows to
  specify the maximum size of SRP control messages.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1328 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFixed a sparse error that was introduced in r1324.
bvassche [Sat, 7 Nov 2009 10:15:23 +0000 (10:15 +0000)]
Fixed a sparse error that was introduced in r1324.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1327 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoFix for user space part of the iSCSI target, which refused connections in the procfs...
vlnb [Fri, 6 Nov 2009 19:28:27 +0000 (19:28 +0000)]
Fix for user space part of the iSCSI target, which refused connections in the procfs mode.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1326 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoLogging cleanup
vlnb [Fri, 6 Nov 2009 19:05:09 +0000 (19:05 +0000)]
Logging cleanup

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1325 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoiSCSI target sysfs "enabled" attribute implemented
vlnb [Fri, 6 Nov 2009 18:41:37 +0000 (18:41 +0000)]
iSCSI target sysfs "enabled" attribute implemented

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1324 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agokobject tricky lifetime races fixed
vlnb [Fri, 6 Nov 2009 18:39:52 +0000 (18:39 +0000)]
kobject tricky lifetime races fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1323 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing more Validator errors.
vlnb [Fri, 6 Nov 2009 18:32:39 +0000 (18:32 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing more Validator errors.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1322 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoAdded command-line option -w.
bvassche [Fri, 6 Nov 2009 13:17:14 +0000 (13:17 +0000)]
Added command-line option -w.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1321 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoData Domain added
vlnb [Fri, 6 Nov 2009 11:55:00 +0000 (11:55 +0000)]
Data Domain added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1320 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPatch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing issues discovered...
vlnb [Thu, 5 Nov 2009 14:34:38 +0000 (14:34 +0000)]
Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing issues discovered by validator.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1319 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoSVN access changed to trunk/
vlnb [Wed, 4 Nov 2009 19:44:50 +0000 (19:44 +0000)]
SVN access changed to trunk/

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1318 d57e44dd-8a1f-0410-8b47-8ef2f437770f

11 years agoPranah Storage Technologies added
vlnb [Wed, 4 Nov 2009 19:29:11 +0000 (19:29 +0000)]
Pranah Storage Technologies added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1317 d57e44dd-8a1f-0410-8b47-8ef2f437770f