bvassche [Mon, 8 Dec 2008 12:58:09 +0000 (12:58 +0000)]
Cleanup.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@610
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 16:28:05 +0000 (16:28 +0000)]
Made "make htmldocs" the last step.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@609
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 16:27:19 +0000 (16:27 +0000)]
Option -p now generates three extra patches: scst_debug.diff, scst_sgv.diff and scst_user.diff.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@608
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 14:04:29 +0000 (14:04 +0000)]
Fixed typo.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@607
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 13:39:16 +0000 (13:39 +0000)]
Added 'make htmldocs'. Changed default kernel version from 2.6.27.7 into 2.6.27.8.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@606
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 13:37:43 +0000 (13:37 +0000)]
Modified the way in which the dummy mpt patch is suppressed, such that the run-regression-tests script works again.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@605
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:56:43 +0000 (13:56 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@604
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:54:00 +0000 (13:54 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@603
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:48:10 +0000 (13:48 +0000)]
Various changes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@602
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 4 Dec 2008 21:29:24 +0000 (21:29 +0000)]
Fixed a sparse warning.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@601
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 4 Dec 2008 21:21:05 +0000 (21:21 +0000)]
- Removed command-line option -l -- scst_local is now unconditionally
included in the generated patch output.
- Added command-line option -p <patchdir>, which allows to generate a
set of patches instead of one big patch.
- New feature: by setting the environment variable SIGNED_OFF_BY, the
Signed-off-by line is filled in.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@600
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 19:31:46 +0000 (19:31 +0000)]
It was brocken. Fixed.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@599
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 19:13:02 +0000 (19:13 +0000)]
Added README for scst_local
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@598
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 18:20:22 +0000 (18:20 +0000)]
Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@597
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 18:00:51 +0000 (18:00 +0000)]
Until now I had been using the latest git version of sparse (August 26, 2008).
Apparently not all messages reported by this version are correct. So I switched
back to the last released sparse version (0.4.1). The patch below fixes all
errors and warnings reported by sparse 0.4.1 on the SCST source code.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@596
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 3 Dec 2008 18:29:50 +0000 (18:29 +0000)]
Added 'make headers_check', 'make checkstack' and 'make namespacecheck'.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@595
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 3 Dec 2008 18:01:42 +0000 (18:01 +0000)]
Make soft IRQ context default
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@594
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 3 Dec 2008 11:59:41 +0000 (11:59 +0000)]
Cleanups after "make namespacecheck"
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@593
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 1 Dec 2008 18:36:54 +0000 (18:36 +0000)]
- Patch from Richard Sharpe <realrichardsharpe@gmail.com> to fix an unterminated macro call and add a semicolon to please
the compiler in an ifdef block.
- Memory leak fixed on error path in scst_local
- Docs cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@592
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
richardsharpe [Mon, 1 Dec 2008 00:55:56 +0000 (00:55 +0000)]
Some minor fixups to the doc to make it more correct.
My previous commit was tested against 2.6.24 and 2.6.26.5 prior to the commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@591
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
richardsharpe [Mon, 1 Dec 2008 00:42:02 +0000 (00:42 +0000)]
Fix a problem on kernels older than 2.6.25 where the symbol SCSI_MAX_SG_SEGMENTS
is not available. Define it if it is not already defined.
Also fix a few minor English issues.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@590
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 29 Nov 2008 17:00:15 +0000 (17:00 +0000)]
Small docs update
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@589
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 17:19:29 +0000 (17:19 +0000)]
alloc_io_context renamed to export_alloc_io_context
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@588
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 17:15:17 +0000 (17:15 +0000)]
- Performance increase
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@587
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 16:11:51 +0000 (16:11 +0000)]
Signed/unsigned cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@586
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 26 Nov 2008 19:03:41 +0000 (19:03 +0000)]
Fixing compilation warning when compiling the code with -Wcast-qual.
The casting from (const uint8_t *) to (uint8_t *) is not really necessary.
Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@585
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 26 Nov 2008 19:00:23 +0000 (19:00 +0000)]
There are two remaining printk() statements on which checkpatch warns that the
KERN_ facility level is missing. Algthough these warnings are false positives,
I have developed a patch to suppress these warnings.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@584
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 25 Nov 2008 16:44:24 +0000 (16:44 +0000)]
- Now task_mgmt_fn() callback called for TARGET RESET and NEXUS LOSS only once for tgt_dev, which belongs to the session, from which the corresponding request came
- Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@583
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 21 Nov 2008 12:12:53 +0000 (12:12 +0000)]
Checkpatch warnings fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@582
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 21 Nov 2008 10:18:28 +0000 (10:18 +0000)]
Forgotten in r578 initiator version increase
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@581
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 21 Nov 2008 10:16:34 +0000 (10:16 +0000)]
DRIVER_ATTR add_host made static
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@580
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 21 Nov 2008 10:15:03 +0000 (10:15 +0000)]
The patch below fixes the sparse warnings on passing a __user pointer where a
kernel pointer is expected and vice versa. Additionally, there are a few fixes
for checkpatch warnings on trailing whitespace and lines that were over 80
columns.
This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.6.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@579
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 20 Nov 2008 18:58:53 +0000 (18:58 +0000)]
Update to initiator driver from 2.6.27
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@578
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 20 Nov 2008 17:05:08 +0000 (17:05 +0000)]
- SGV cache related parameters moved from scst.h to scst_sgv.h
- Minor updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@577
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 19 Nov 2008 11:37:45 +0000 (11:37 +0000)]
Prevent memory leaks in error paths by deferring
allocation until we have checked for errors. Also, fix the host ID
(target #) to be one larger than the max target ID for the host. Also,
reduce the number of outstanding commands per LUN to 1 (although this
might not be needed). Also scst_lcl_ini_driver_template flags cleanup.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Signed-off-by: Vladislav Bolkhovitin <vst@vlnb.net>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@576
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 19 Nov 2008 10:55:58 +0000 (10:55 +0000)]
Fix for memory overwrite-after-free bug in scst_local
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@575
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 18 Nov 2008 18:47:09 +0000 (18:47 +0000)]
The patch below implements the following modifications for
scripts/run-regression-tests:
- Adds a description about what the script does.
- Added command-line option -c which allows to specify which directory to use
as cache for kernel tar balls and patch files.
- More error checking.
- scst_local is now included in all the tests.
- Swapped the order of two test steps, namely compiling the whole tree and
running sparse. This way the output of the sparse tool is available a lot
sooner.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@574
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 18 Nov 2008 18:45:13 +0000 (18:45 +0000)]
The patch below fixes two categories of checkpatch
complaints on scst_local, namely "line over 80 columns" and "use tabs to indent
instead of spaces".
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@573
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 18 Nov 2008 18:42:09 +0000 (18:42 +0000)]
Log level for "Warning: expected transfer length X for opcode Y" changed to be disabled by default for release build
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@572
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 18 Nov 2008 18:23:08 +0000 (18:23 +0000)]
The patch below fixes sparse warnings about int / unsigned int mismatches in
the iscsi-scst source code.
This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.6.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@571
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 13 Nov 2008 16:14:06 +0000 (16:14 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@570
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 12 Nov 2008 18:49:18 +0000 (18:49 +0000)]
The patch below fixes many checkpatch warnings triggered by the iSCSI kernel
code, mainly about lines that exceeded 80 columns. As you can see in the patch
below most lines that were too long have been split, but some code has also
been moved into helper functions in order to keep the code readable. No
functionality has been changed.
This patch has been verified as follows:
- Reread the patch carefully.
- Verified that the iSCSI target kernel module still loads.
- Verified the output generated by scripts/run-regression-tests -k 2.6.27.5.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
with some modifications
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@569
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 11 Nov 2008 12:04:52 +0000 (12:04 +0000)]
Here is the patch to fix problems with scst_local and 2.6.24 or earlier (tested by building under 2.6.24).
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
This line, and those below, will be ignored--
M trunk/scst_local/scst_local.c
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@568
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 11 Nov 2008 11:56:18 +0000 (11:56 +0000)]
Added possibility to coexist if both target driver and dev handler need custom memory allocation. Direct consequences:
1. scst_local can work with scst_user's devices
2. scst_user now compatible with iscsi-scst if put_page_callback not applied
+ some cosmetics
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@567
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 10 Nov 2008 17:23:23 +0000 (17:23 +0000)]
Small cleanup of unused code
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@566
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 10 Nov 2008 17:21:09 +0000 (17:21 +0000)]
Depecated scst_cmd_get_tgt_resp_flags() removed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@565
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 10 Nov 2008 17:11:48 +0000 (17:11 +0000)]
Fixes warning:
trunk/scst_local/scst_local.c:907: warning: initialization from incompatible pointer type
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@564
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 7 Nov 2008 18:47:17 +0000 (18:47 +0000)]
Added proposed patch to solve SG IO count limitation issue in pass-through mode. It allows SGV cache do allocation
of pages with order > 0, i.e. more than 1 page per SG entry. Web and doc updated correspondingly.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@563
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 6 Nov 2008 12:06:58 +0000 (12:06 +0000)]
Make SWP and TAS parameters changable in vdisk handler.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@562
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 5 Nov 2008 18:56:31 +0000 (18:56 +0000)]
Attached is a patch that I think makes scst_local properly handle multiple targets per host.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@561
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 1 Nov 2008 11:45:26 +0000 (11:45 +0000)]
Cleanup: one more __GFP_NOFAIL removed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@560
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 31 Oct 2008 18:56:01 +0000 (18:56 +0000)]
Small optimization
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@559
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 31 Oct 2008 16:17:08 +0000 (16:17 +0000)]
Follow-up improvements to r556
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@558
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 31 Oct 2008 11:16:47 +0000 (11:16 +0000)]
- Fixed incorrect SCST state used on error path
- Small cleanups
- ToDo entry added
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@557
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 31 Oct 2008 10:49:25 +0000 (10:49 +0000)]
Cleanup removing usage of in_atomic(). Particularly, now target drivers and dev handlers need to explicitly supply preferred execution context in scst_cmd_done() and scst_tgt_cmd_done().
WARNING! This commit changes external SCST interface, so it can break compilation of your out of SCST SVN tree target driver or dev handler. To fix it, simply supply the preferred exection context to scst_cmd_done() and/or scst_tgt_cmd_done().
Thanks to Bart Van Assche <bart.vanassche@gmail.com> for pointing on it.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@556
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 20:17:42 +0000 (20:17 +0000)]
The patch below fixes the following:
* Lots of checkpatch warnings about lines over 80 characters.
* Checkpatch errors about code indent should use tabs where possible (same issues as reported by Dotan Barak).
* One checkpatch warning about braces {} are not necessary for single statement blocks.
* Sparse warnings about missing declarations.
* Sparse warnings about using 0 instead of NULL.
This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.3.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
With changes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@555
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 19:11:04 +0000 (19:11 +0000)]
The patch below fixes the checkpatch warnings for source files in the
directory scst/include about lines that exceed 80 columns.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@554
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 18:59:23 +0000 (18:59 +0000)]
The patch below fixes a few more warnings about lines that exceed 80 columns.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@553
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 12:43:20 +0000 (12:43 +0000)]
The patch below adds the first version of a script that runs regression tests
to the SCST source tree. All tests are run in an automated fashion, but result
interpretation is not yet completely automated.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@552
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 12:34:48 +0000 (12:34 +0000)]
The patch below makes the srpt driver compile against the 2.6.27 kernel
headers.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Acked-by: Vu Pham <vu@mellanox.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@551
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 30 Oct 2008 12:22:48 +0000 (12:22 +0000)]
Fixes wrong sess_count decrement on session registration failure
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@549
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Oct 2008 20:43:38 +0000 (20:43 +0000)]
The iscsi-scst kernel module does not get compiled even with CONFIG_SCST_ISCSI
set to m or y. The patch below fixes this.
This patch has been verified by rerunning scripts/run-regression-tests -k 2.6.27.3
and by verifying that the kernel build produced a iscsi-scst.ko kernel module.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@548
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Oct 2008 20:41:29 +0000 (20:41 +0000)]
By testing kernel patch generation for the mpt driver I found out that the
Kconfig and Makefile were read from the wrong directory. The patch below fixes
this.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@547
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Oct 2008 20:38:49 +0000 (20:38 +0000)]
Release/debug/perf patches updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@546
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Oct 2008 20:30:47 +0000 (20:30 +0000)]
Small improvement
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@545
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Oct 2008 20:19:07 +0000 (20:19 +0000)]
Fixed accidentally enabled superfluous warnings.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@544
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 25 Oct 2008 18:49:47 +0000 (18:49 +0000)]
Release/debug/perf patches updated + cosmetics in scst/src/dev_handlers/Makefile
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@543
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 25 Oct 2008 17:31:10 +0000 (17:31 +0000)]
-Wno-missing-field-initializers added. Small cleanup.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@542
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 25 Oct 2008 17:14:08 +0000 (17:14 +0000)]
Fixes 2 incorrectly used variables
Signed off by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@541
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 24 Oct 2008 15:04:20 +0000 (15:04 +0000)]
A typo fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@540
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 24 Oct 2008 12:14:11 +0000 (12:14 +0000)]
The patch below fixes the sparse warnings in ib_srpt.c about missing
declarations by inserting the keyword static where appropriate.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@539
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 24 Oct 2008 12:11:17 +0000 (12:11 +0000)]
The patch below fixes more checkpatch warnings about lines that are over
eighty columns, and more sparse warnings about missing declarations by
inserting the keyword static where appropriate. A sparse warning about a
shadowed variable (ucmd) is also fixed.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@538
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 24 Oct 2008 11:52:12 +0000 (11:52 +0000)]
- Minor context cleanup
- Minor doc update
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@537
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 24 Oct 2008 11:50:36 +0000 (11:50 +0000)]
Web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@536
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Fri, 24 Oct 2008 00:19:11 +0000 (00:19 +0000)]
Fix missing removal of DECLARE_MUTEX_UNLOCKED noticed by Shai.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@535
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 23 Oct 2008 12:06:39 +0000 (12:06 +0000)]
Fixes problems spotted by lockdep
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@534
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 23 Oct 2008 12:03:22 +0000 (12:03 +0000)]
Replace SCSI_TRY_RESET_BUS by SCSI_TRY_RESET_TARGET, which is more appropriate for TARGET RESET TM
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@533
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Wed, 22 Oct 2008 21:45:16 +0000 (21:45 +0000)]
Get rid of obsolete DECLARE_MUTEX_LOCKED usage.
Call device_create with extra driver data argument (NULL)
on 2.6.27 and later.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@532
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 22 Oct 2008 18:45:05 +0000 (18:45 +0000)]
Patch from Bart Van Assche <bart.vanassche@gmail.com> with some minor changes/additions:
The patch below fixes the checkpatch warnings about lines that are over eighty
columns, and the sparse warnings about missing declarations by inserting the
keyword static where appropriate.
This patch has been tested by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Also extracheck in_interrupt() was added in scst_cmd_atomic()
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@531
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 22 Oct 2008 17:47:28 +0000 (17:47 +0000)]
The patch below implements the following changes:
- Add a dummy Signed-off-by line to the generated patch, such that checkpatch
doesn't complain that it's missing.
- Sort the names of source files (through ls) before using these, such that
the generated patch is the same during each run.
- Fixed a bug in #elif handling (this bug is not triggered by the current SCST
code).
This patch has been tested by comparing the output of the old and the new
generate-kernel-patch script.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@530
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 21 Oct 2008 11:51:52 +0000 (11:51 +0000)]
The first approximation to update to 2.6.27 + minor fixes, particularly remove of unused variable and add full path to depmod in Makefiles. Partially done by Bart Van Assche <bart.vanassche@gmail.com>.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@529
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 21 Oct 2008 10:23:42 +0000 (10:23 +0000)]
The patch below implements the following changes:
- Converted tabs to spaces in the help text.
- Removed command-line option '-s' -- the srpt driver is now always included.
- Recognizes now both kernel versions with three components (x.y.z) and kernel
versions with four components (x.y.z.p).
- Empty files for Kconfig and Makefile are added for those components that are
not included in the kernel patch, such that make allyesconfig
/ make allmodconfig keeps working.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@528
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 21 Oct 2008 10:19:05 +0000 (10:19 +0000)]
Property svn:ignore set
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@527
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 16 Oct 2008 19:23:22 +0000 (19:23 +0000)]
scst_local module added.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@526
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 16 Oct 2008 17:46:37 +0000 (17:46 +0000)]
The patch below implements the following changes, because an
upcoming checkpatch version will complain about these:
* Make sure that a single tab is used for indenting instead of four spaces.
* Removed spaces from around the colon used for specifying field widths.
* Remove trailing whitespace in .txt files.
This patch has been tested by verifying that:
- the output of svn diff -x -w is empty, i.e. that the patch only affects
whitespace.
- the SCST out-of-tree source code still compiles fine against the 2.6.25 kernel
(make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@525
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 16 Oct 2008 17:42:54 +0000 (17:42 +0000)]
Compiler warning fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@524
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 16 Oct 2008 17:34:33 +0000 (17:34 +0000)]
A major cleanup of sending commands for execution code path fixing found problems in it: handling double UA and internal REQUEST SENSE + possible wrong context assignment. Plus several other minor cleanups and fixes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@523
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 10 Oct 2008 10:00:08 +0000 (10:00 +0000)]
Allows enabling target mode support without SCST enabled. Otherwise it is impossible to use the target driver with out of tree SCST.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@522
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 9 Oct 2008 17:58:04 +0000 (17:58 +0000)]
Unused files removed as requested by Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@521
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 8 Oct 2008 17:59:11 +0000 (17:59 +0000)]
Fixes SAM violation, noticed by Sudhakar <ssudhakarp@gmail.com>. Plus, Windows requires it to automatically support LUNs >8, see support.microsoft.com/kb/310072/en-us
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@520
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 8 Oct 2008 17:36:08 +0000 (17:36 +0000)]
Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@519
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 8 Oct 2008 13:44:27 +0000 (13:44 +0000)]
Until now the kernel config option to enable the SRP target was called
CONFIG_INFINIBAND_SRPT. This is a reminiscent from the time when the SRPT code
resided in the directory drivers/infiniband/ulp/srpt. Since this code has been moved
into the directory drivers/scst/srpt, the path below renames this config option
into CONFIG_SCST_SRPT. The other changes present in this patch are:
- Removed srpt/src/Makefile.infiniband.Linux-2.6.2[45].patch since these files are obsolete.
- Rewrote Kconfig help text slightly.
The patch below has been tested by verifying that the 2.6.26.5 kernel + SCST
patch still compiles cleanly with CONFIG_SCST_SRPT=m.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@518
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 7 Oct 2008 14:56:42 +0000 (14:56 +0000)]
Web fixes and updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@517
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 7 Oct 2008 08:57:46 +0000 (08:57 +0000)]
The patch below enables compilation of the SRPT driver with the 2.6.26.x kernel.
This patch has been tested by verifying that:
- the patched Linux 2.6.25.17 and 2.6.26.5 kernel trees still compile when
CONFIG_INFINIBAND_SRPT=m is present in .config (verified that
make -k modules only complains about a missing qla2xxx-target directory).
- the SCST out-of-tree source code still compiles fine against the 2.6.25 kernel
(make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
- checkpatch output is identical for the output of scripts/generate-kernel-patch 2.6.25
and scripts/generate-kernel-patch 2.6.26.
Based on patch from Vu Pham <vu@mellanox.com>
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@516
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:24:49 +0000 (17:24 +0000)]
The patch below fixes the following class of checkpatch warnings:
WARNING: externs should be avoided in .c files
This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@515
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:22:17 +0000 (17:22 +0000)]
The patch below fixes the following class of checkpatch warnings:
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@514
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:19:48 +0000 (17:19 +0000)]
The patch below fixes the following checkpatch error:
ERROR: return is not a function, parentheses are not required
This patch has been tested by verifying that the newly generated patch still
applies without warnings to the 2.6.25.17 kernel and that the patched kernel
still compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@513
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:18:04 +0000 (17:18 +0000)]
The patch below fixes the following classes of checkpatch errors:
* ERROR: return is not a function, parentheses are not required
* ERROR: that open brace { should be on the previous line
This patch has been tested by verifying that the newly generated patch still
applies without warnings to the 2.6.25.17 kernel and that the patched kernel
still compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@512
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:15:08 +0000 (17:15 +0000)]
As known the script generate-kernel-patch generates a patch for the specified
vanilla Linux kernel version. When I submitted this script for inclusion in the
SCST Subversion repository the SRPT target driver was excluded by default
because of checkpatch errors triggered by the SRPT source code. These errors
have been fixed considerable time ago. Hence the patch below makes inclusion
of the SRPT driver the default.
This patch has been tested by verifying that the generated patch still applies
cleanly to the 2.6.25.17 kernel, and that the patched kernel still compiles cleanly.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@511
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 6 Oct 2008 17:13:11 +0000 (17:13 +0000)]
The patch below fixes the following two checkpatch warnings:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#290: FILE: net/core/utils.c:316:
+EXPORT_SYMBOL(net_get_page_callback);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#291: FILE: net/core/utils.c:317:
+EXPORT_SYMBOL(net_put_page_callback);
This patch has been tested by verifying that the generated patch still applies
without warnings to the 2.6.25.17 kernel and that the patched kernel still
compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@510
d57e44dd-8a1f-0410-8b47-
8ef2f437770f