vlnb [Tue, 3 Mar 2009 17:04:12 +0000 (17:04 +0000)]
Bufflen can be changed after scst_get_cdb_info(), so for bufflen = 0 data_direction should be changed to SCST_DATA_NONE not in scst_get_cdb_info(), but in the end of parsing.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@683
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 3 Mar 2009 17:00:53 +0000 (17:00 +0000)]
Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@682
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 26 Feb 2009 20:02:43 +0000 (20:02 +0000)]
Patch from Gal Rosen <galr@storwize.com>:
There are 16 characters of the port_name + 7 characters of ":" + "\0" of
sprintf = total 24 bytes.
wwn_str has only 16 bytes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@681
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Mon, 23 Feb 2009 23:18:25 +0000 (23:18 +0000)]
Put some limit checking on dma segments so that
we don't, somehow, inadvertantly overrun the total
number of queue entries for a command + continuation
segments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@680
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Mon, 23 Feb 2009 00:13:25 +0000 (00:13 +0000)]
Major rewrite of DMA mapping code to reduce code duplication
and to allow some debug and enhancements that will be easier
soon.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@679
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 20 Feb 2009 18:04:11 +0000 (18:04 +0000)]
Fix for bug reported by Gennadiy Nerubayev <parakie@gmail.com>. In some cases, e.g. with DRBD, bio->bi_end_io() can be called with IRQs disable which isn't appropriate for direct processing in SCST core. Switch to one of internal SCST threads in such cases.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@678
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 19 Feb 2009 19:06:13 +0000 (19:06 +0000)]
Patch from Krzysztof Blaszkowski with some cleanups:
I realized yesterday that the fix missed one rare case
still. if the hiwmk_check() returned with error and no_fail override was set
then the counter would still cross 0 on free.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@677
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 18 Feb 2009 19:17:29 +0000 (19:17 +0000)]
Patch from Krzysztof Blaszkowski:
i noticed this issue running simple iscsi connection test to a few targets.
without included patch the active_pages_total counter wraps around 0 thus it
breaks logic for releasing memory on "hi watermark" just like it is depicted
in:
Inactive/active pages 18/-25
Hi/lo watermarks [pages] 119808/0
Hi watermark releases/failures 4/0
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@676
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 18 Feb 2009 18:52:35 +0000 (18:52 +0000)]
- Docs updates
- Minor cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@675
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 16 Feb 2009 18:46:00 +0000 (18:46 +0000)]
Fixes negotiation breakage, introduced by r667
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@674
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Fri, 13 Feb 2009 18:02:48 +0000 (18:02 +0000)]
Fix patching that I broke.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@673
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Wed, 11 Feb 2009 18:55:43 +0000 (18:55 +0000)]
Merge in work from Feral into this branch. The
recovery from not being able to push a ctio
fix is in. Various task management fixes are
also in. Other work in progress.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@672
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Wed, 11 Feb 2009 18:54:17 +0000 (18:54 +0000)]
Broaden tags target.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@671
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 11 Feb 2009 16:16:53 +0000 (16:16 +0000)]
Re-order Makefile install and uninstall a bit. Specifically
for the install so lsb commands come last should lsb not exist
on the system, at least the rest of install works.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@670
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Wed, 11 Feb 2009 16:09:45 +0000 (16:09 +0000)]
Add lsb support for init.d scripts. Patch from Bart Van Assche.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@669
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 9 Feb 2009 20:08:14 +0000 (20:08 +0000)]
Fixes checkpatch errors notices by Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@668
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 6 Feb 2009 19:52:34 +0000 (19:52 +0000)]
- Iscsi-scst-adm fixes. It should be fully functional now.
- Other iSCSI-SCST user space fixes, improvements and cleanups.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@667
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 6 Feb 2009 19:46:57 +0000 (19:46 +0000)]
Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@666
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 5 Feb 2009 18:30:50 +0000 (18:30 +0000)]
2 missed functions added to scst_user interface:
- SCST_USER_UNREGISTER_DEVICE - to unregister device, flush mem reuse (SGV) cache and send UCMD_STATE_ON_CACHE_FREEING notifications for all freed buffers to the user space handler. Simple device close doesn't allow that, so all the cached buffers might look as "leaked" from the user space handler POV.
- SCST_USER_FLUSH_CACHE - to flush mem reuse (SGV) cache and send UCMD_STATE_ON_CACHE_FREEING notifications for all freed buffers to the user space handler
+ some cosmetics
Docs update is coming
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@665
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 5 Feb 2009 18:23:28 +0000 (18:23 +0000)]
- Fix typo in scst_rx_mgmt_fn_tag() call for task abort
- Cosmetics
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@664
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 5 Feb 2009 18:07:51 +0000 (18:07 +0000)]
Clustering of scst_user pages added
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@663
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 4 Feb 2009 18:45:32 +0000 (18:45 +0000)]
A bunch of pending fixes/cleanups:
- Docs about limitation of having initiator and target on the same host updated + cleanups
- Minor local thread storage improvements
- TRACE_MGMT_MINOR excluded from the default set of trace flags to not confuse people
- Dedicated kmem_cache for blockio created
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@662
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Tue, 3 Feb 2009 06:32:12 +0000 (06:32 +0000)]
Remove some misleading and dead files.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@661
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Tue, 3 Feb 2009 06:31:27 +0000 (06:31 +0000)]
Update some firmware sets.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@660
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 2 Feb 2009 16:25:47 +0000 (16:25 +0000)]
In the header file scst.h scst_cmd::sg_cnt and tgt_sg_cnt::sg_cnt are declared
as signed integers, while some inline functions in the same header file treat
these as unsigned integers. The patch below converts all uses to signed
integer.
The patch below has been verified by checking the output files generated by
the following command:
scripts/run-regression-tests -k 2.6.24.7 -k 2.6.25.20 -k 2.6.26.8 -k 2.6.27.13 -k 2.6.28.2
Note: I do not expect that this patch changes the behavior of SCST in any way.
This patch is not a bug fix -- all it does is cleaning up an inconsistency.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@659
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 2 Feb 2009 15:49:39 +0000 (15:49 +0000)]
The patch below implements the following changes for the iSCSI-SCST HOWTO
document:
- Added RHEL / CentOS to the list of officially supported kernels.
- Mentioned that regenerating the initial RAM disk is an explicit step on many
distro's.
- Replaced shell instructions for generating /etc/scst.conf by a sequence of
scstadmin commands.
- Added note about insserv.
Also it adds small HOWTO how to recompile RHEL/CentOS kernel in README_RHEL.
Also it implements some docs cleanups.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@658
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 2 Feb 2009 11:36:53 +0000 (11:36 +0000)]
The patch below adds the following two RHEL 5 / CentOS 5 patches to the SCST
source tree:
- Support for zero-copy TCP transfer completion.
- An implementation of scsi_execute_async_fifo().
Except for the hunk headers, these patches are identical to similarly named
patches already present in the SCST source tree.
Additionally, implementations of seq_list_start() and seq_list_next() are
provided for those kernel versions that do not define these functions.
The patch below has been tested by verifying that iSCSI data transfer still
works OK on CentOS 5.2 (x86_64).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@657
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 2 Feb 2009 11:29:14 +0000 (11:29 +0000)]
The patch below is a minor correction for the 2.6.27 in-tree kernel patches
I submitted about three months ago: the patch headers now refer to the 2.6.27
kernel as they should instead of the 2.6.26 kernel. At least one user has been
confused by this. The patch below does not change any behavior of SCST.
The patch has been tested by verifying that the output of the following
command remained the same as before the modifications:
scripts/run-regression-tests -k 2.6.27
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@656
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 2 Feb 2009 11:16:38 +0000 (11:16 +0000)]
- Removed artificial limitation on sg_tablesize. It isn't needed, because the regular iSCSI negotiated MaxRecvDataSegmentLength-related facilities do all the job pretty well.
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@655
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 30 Jan 2009 17:47:31 +0000 (17:47 +0000)]
Final merge with IET (r201-204):
- 2.6.25 introduced netlink_socket_release(), to be used to clean up netlink sockets correctly (taking care of namespaces).
- New more scalable proc seq_file implementation
+ minor signess cleanups
+ version updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@654
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 30 Jan 2009 16:49:01 +0000 (16:49 +0000)]
Merge with IET r196:
- Allow removal of kernel target objects if the user space object does not exist
Based on a patch by Lars Ellenberg.
Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@653
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 30 Jan 2009 16:41:22 +0000 (16:41 +0000)]
Merge with IET r195:
From: Lars Ellenberg <lars.ellenberg@linbit.com>
Ignore SIGPIPE in ietd
Otherwise we would die in some later write() during the event_loop
instead of getting EPIPE!
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@652
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 30 Jan 2009 16:36:39 +0000 (16:36 +0000)]
Merge of IET r194:
- Add support for Reject PDUs and make use of them in appropriate places.
Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@651
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 30 Jan 2009 16:25:52 +0000 (16:25 +0000)]
Merge with IET r192-193:
- Introduce min*/max*() and more list_* macros
- Multipart PDU support for discovery sessions
The conn's response buffer is now replaced with a list of buffers and
all users are updated accordingly. Discovery sessions can make use of
this mechanism, if the list of targets + addresses does not fit into a
single text PDU, the initiator may now retrieve subsequent parts.
This also fixes the data segment handling for discovery sessions.
Based on a patch originally provided by Shreyansh Jain <shrey.linux@gmail.com>
Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@650
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 29 Jan 2009 19:10:10 +0000 (19:10 +0000)]
Merge with IET r170-191:
- Update MaxConnections documentation
- Remove isns config description from man page
- Check return values of chdir(), ftruncate() and write(), because recent versions of the glibc insist on the return value being checked by
introducing __attribute__((warn_unused_result)) to these functions.
- Fix snprintf use in isns.c
- Take \0-termination into account when passing strings to isns_tlv_set() to solve incompatibility with MS iSNS 3.0 as IQN length is multiple of 4
- Fix list corruption if SCST target registration fails
- Register the target port actually used instead of the default iSCSI port.
- Remove unused connection->pad
- Refactor cmnd_execute()
- Version changed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@649
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 29 Jan 2009 18:25:45 +0000 (18:25 +0000)]
- Fix for iSCSI RFC violation: TARGET COLD RESET must close all connections/sessions, not only the current one
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@648
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 29 Jan 2009 12:19:22 +0000 (12:19 +0000)]
Merge with IET r169:
From: Shreyansh Jain <shrey.linux at gmail.com>
Subject: [Patch 1/1] Segfault in ietd buffer overrun in dump_line
Fix a buffer overrun problem in __dump_line function in log.c file.
It also removes a stray 'return' call in log_pdu function which was
restricting a PDU dump call to complete log_pdu operation.
Also, in log_pdu function, the first check for log_level against
passed parameter for log was incorrect and would have forced a return
even when the caller has set the logging level to acceptable level.
Signed-off-by: Shreyansh Jain <shrey.linux at gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@647
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 29 Jan 2009 12:12:42 +0000 (12:12 +0000)]
Merge ... IET r160-168: add iscsi-scst-adm support to display list of CHAP accounts and their data
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@646
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 28 Jan 2009 18:44:59 +0000 (18:44 +0000)]
Make USN related stuff completed. Unfortunately, it can break existing cluster setups, but it's better to make it now, then later.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@645
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 27 Jan 2009 18:50:33 +0000 (18:50 +0000)]
Sync with IET revisions 156-159: fix for compilation on glibc 2.8
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@644
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 27 Jan 2009 18:09:24 +0000 (18:09 +0000)]
- Add autogenerated USN
- Sync fileio_tgt with scst_vdisk
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@643
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 26 Jan 2009 18:08:07 +0000 (18:08 +0000)]
- Fixed race in scst_user, which can lead to usage of already freed command. A misbehaving user space handler can make ucmd to get dead
immediately after the lock is released and we should catch it.
- Text in README about barriers usage updated
- Minor cleanup with aim to have more robust code
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@642
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 26 Jan 2009 17:32:50 +0000 (17:32 +0000)]
The patch below fixes most checkpatch and sparse issues that are reported by
the most recent versions (checkpatch 2.6.28 / latest sparse git version) and
that were not reported by previous versions (checkpatch 2.6.27 / sparse 0.4.1).
The patch below fixes the following issues:
* Removed trailing space in iscsi-scst/README_in-tree.
* Fixed sparse complaints about functions that were not declared static.
* Fixed sparse complaints about casts between address spaces: such casts are
now either fixed or explicit (via the __force keyword).
The patch below has been verified by checking the output produced by:
scripts/run-regression-tests -k 2.6.28.1
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@641
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 26 Jan 2009 17:23:46 +0000 (17:23 +0000)]
Recently (Subversion revision 633) code was added to scst_vdisk.c that
performs a.o. 64-bit division. While gcc supports 64-bit divisions on 32-bit
CPU's, gcc generates a function call for these 64-bit divisions (see also
http://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html for the
entire list). Unfortunately there is no implementation available for these
functions in the Linux kernel. Which means that loading kernel modules
that contain 64-bit divisions on a 32-bit system will fail and that insmod/
modprobe will complain about undefined references to e.g. __umoddi3. AFAIK the
proper approach in the Linux kernel is to use the do_div() macro for
performing 64-bit divisions. This macro is defined in <asm/div64.h>. The patch
below converts the call to div_s64_rem() by a call to do_div().
The patch below has been verified as follows:
- Reran scripts/run-regression-tests -k 2.6.24.7 -k 2.6.25.20 -k 2.6.26.8 -k 2.6.27.12 -k 2.6.28.1
on a 64-bit system and verified that the output of the re*/sparse* files did
not contain any compilation errors.
- Verified that the patched SCST source compiles fine on CentOS 5.2, 32-bit.
- Verified that the scst_vdisk module loads correctly on CentOS 5.2, 32-bit.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@640
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 26 Jan 2009 12:57:22 +0000 (12:57 +0000)]
Fixes wrong usage of the last parameter of module_param_named()
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@639
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 23 Jan 2009 19:51:54 +0000 (19:51 +0000)]
Modified patch from Bart Van Assche <bart.vanassche@gmail.com>
It, hopefully, fixes compilation problems on CentOS 5.2 as well as on vanilla kernels <2.6.28
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@638
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 19 Jan 2009 19:07:42 +0000 (19:07 +0000)]
- Fixed bug in evaluation of expressions containing '&&' or '||'.
- Added support for evaluating #ifdef and #ifndef.
- Added support for substituting the macro's RHEL_MAJOR, RHEL_MINOR and RHEL_RELEASE_CODE.
- Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@637
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 17 Jan 2009 10:34:48 +0000 (10:34 +0000)]
Bumped default kernel version to 2.6.28.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@636
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 16 Jan 2009 20:56:06 +0000 (20:56 +0000)]
A bunch of minor fixes/improvements, cleanups and updates:
- In scst_local new experimental compile-time option to force direct processing added
- Attempt in SCST structures to separate read-mostly from read-write data to decrease cache ping-pong between CPUs
- In scst_vdisk new module parameter num_threads added to specify a number of threads for each vdisk/vcdrom. Default is 5.
- Debug logging for failed digests in iSCSI-SCST improved
- Docs updates/cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@635
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 15 Jan 2009 18:50:43 +0000 (18:50 +0000)]
- Minor optimization
- New member target_name added to struct scst_user_sess
- Docs updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@634
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 15 Jan 2009 16:14:57 +0000 (16:14 +0000)]
Minor fixes for better Windows compatibility
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@633
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 12 Jan 2009 18:55:08 +0000 (18:55 +0000)]
- Update for 2.6.28
- Small doc update in flow control area
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@632
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 10 Jan 2009 17:21:57 +0000 (17:21 +0000)]
Removed trailing whitespace. While the checkpatch script included with the 2.6.27 kernel did not complain on trailing whitespace in documentation and kbuild files, the checkpatch script included with the 2.6.28 kernel does.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@631
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sun, 4 Jan 2009 17:53:57 +0000 (17:53 +0000)]
Minor performance improvement
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@630
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sun, 4 Jan 2009 16:14:33 +0000 (16:14 +0000)]
- Minor improvements
- Incorrect BUG_ON removed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@629
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sun, 4 Jan 2009 16:12:56 +0000 (16:12 +0000)]
Minor fixes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@628
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 30 Dec 2008 10:37:07 +0000 (10:37 +0000)]
Fixed problem with KERN_CONT absent in some vendor kernels
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@627
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 26 Dec 2008 17:49:27 +0000 (17:49 +0000)]
READ POSITION command's constants cleanup, since LONG_BIT conflicts with constant defined in /usr/include/bits/xopen_lim.h
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@626
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 26 Dec 2008 17:42:21 +0000 (17:42 +0000)]
Obsolete TODO removed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@625
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 26 Dec 2008 17:40:30 +0000 (17:40 +0000)]
Access control docs updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@624
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Thu, 18 Dec 2008 17:30:37 +0000 (17:30 +0000)]
- Fixed a removeDevice() case when using -ForceConfig. Spotted by Ondrej Palkovsky.
- SCST.pm: Cosmetic changes to error messages - include the handler name.
- SCST.pm: Quote handlers, handler IOs, devices, users and groups in error messages.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@623
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 18 Dec 2008 16:50:43 +0000 (16:50 +0000)]
Set memory limits according to LOWMEM, not TOTALMEM
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@622
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 18 Dec 2008 16:41:26 +0000 (16:41 +0000)]
Cleanup: dev_serialized deleted, because it dublicates dev_double_ua_possible
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@621
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Thu, 18 Dec 2008 16:11:32 +0000 (16:11 +0000)]
- Cosmetic fixes by Witold Kowolik and increment version.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@620
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Thu, 18 Dec 2008 16:05:55 +0000 (16:05 +0000)]
- Fixed enabling/disabling targets. Spotted by Witold Kowolik.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@619
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Thu, 18 Dec 2008 16:00:34 +0000 (16:00 +0000)]
- Fix a check in SCST::removeUser(), spotted by Witold Kowolik.
- Changed a few returns to 1 instead of $TRUE since really they're
int returns and not boolean.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@618
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 11 Dec 2008 14:30:40 +0000 (14:30 +0000)]
.26 changed to .27 to stop confusing too observant people :)
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@617
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 10 Dec 2008 15:55:16 +0000 (15:55 +0000)]
Checkpatch fix
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@616
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 10 Dec 2008 12:05:17 +0000 (12:05 +0000)]
Trailing whitespace fixed
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@615
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 10 Dec 2008 10:55:01 +0000 (10:55 +0000)]
- Memory barriers cleanup. Comments for them improved
- Small docs update
- srpt/README_in-tree added
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@614
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Tue, 9 Dec 2008 18:57:32 +0000 (18:57 +0000)]
- Added patch my Witold Kowolik to allow enable/disable of qla_isp cards.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@613
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
mgandalf [Tue, 9 Dec 2008 18:28:29 +0000 (18:28 +0000)]
- Applied patch from Witold Kowolik with modifications,
simplifies/fixes option parsing.
- Added new REMOVABLE option.
- Allow options to be specified in lowercase.
- Misc. fixes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@612
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 9 Dec 2008 07:50:44 +0000 (07:50 +0000)]
Split generated patch files further:
- Left out iscsi_scst_itf_ver.h since it is a generated file.
- README.qla2x00t has been put in a separate patch, qla2x00t-doc.diff.
- scst_proc.diff has been scst_core.diff.
- scst_vdisk.diff has been split from scst_dev_handlers.diff.
- scst_dev_handlers.diff has been renamed into scst_passthrough.diff.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@611
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 8 Dec 2008 12:58:09 +0000 (12:58 +0000)]
Cleanup.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@610
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 16:28:05 +0000 (16:28 +0000)]
Made "make htmldocs" the last step.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@609
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 16:27:19 +0000 (16:27 +0000)]
Option -p now generates three extra patches: scst_debug.diff, scst_sgv.diff and scst_user.diff.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@608
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 14:04:29 +0000 (14:04 +0000)]
Fixed typo.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@607
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 13:39:16 +0000 (13:39 +0000)]
Added 'make htmldocs'. Changed default kernel version from 2.6.27.7 into 2.6.27.8.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@606
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 6 Dec 2008 13:37:43 +0000 (13:37 +0000)]
Modified the way in which the dummy mpt patch is suppressed, such that the run-regression-tests script works again.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@605
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:56:43 +0000 (13:56 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@604
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:54:00 +0000 (13:54 +0000)]
Cleanup
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@603
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 5 Dec 2008 13:48:10 +0000 (13:48 +0000)]
Various changes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@602
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 4 Dec 2008 21:29:24 +0000 (21:29 +0000)]
Fixed a sparse warning.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@601
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 4 Dec 2008 21:21:05 +0000 (21:21 +0000)]
- Removed command-line option -l -- scst_local is now unconditionally
included in the generated patch output.
- Added command-line option -p <patchdir>, which allows to generate a
set of patches instead of one big patch.
- New feature: by setting the environment variable SIGNED_OFF_BY, the
Signed-off-by line is filled in.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@600
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 19:31:46 +0000 (19:31 +0000)]
It was brocken. Fixed.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@599
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 19:13:02 +0000 (19:13 +0000)]
Added README for scst_local
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@598
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 18:20:22 +0000 (18:20 +0000)]
Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@597
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 4 Dec 2008 18:00:51 +0000 (18:00 +0000)]
Until now I had been using the latest git version of sparse (August 26, 2008).
Apparently not all messages reported by this version are correct. So I switched
back to the last released sparse version (0.4.1). The patch below fixes all
errors and warnings reported by sparse 0.4.1 on the SCST source code.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@596
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 3 Dec 2008 18:29:50 +0000 (18:29 +0000)]
Added 'make headers_check', 'make checkstack' and 'make namespacecheck'.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@595
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 3 Dec 2008 18:01:42 +0000 (18:01 +0000)]
Make soft IRQ context default
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@594
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 3 Dec 2008 11:59:41 +0000 (11:59 +0000)]
Cleanups after "make namespacecheck"
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@593
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 1 Dec 2008 18:36:54 +0000 (18:36 +0000)]
- Patch from Richard Sharpe <realrichardsharpe@gmail.com> to fix an unterminated macro call and add a semicolon to please
the compiler in an ifdef block.
- Memory leak fixed on error path in scst_local
- Docs cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@592
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
richardsharpe [Mon, 1 Dec 2008 00:55:56 +0000 (00:55 +0000)]
Some minor fixups to the doc to make it more correct.
My previous commit was tested against 2.6.24 and 2.6.26.5 prior to the commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@591
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
richardsharpe [Mon, 1 Dec 2008 00:42:02 +0000 (00:42 +0000)]
Fix a problem on kernels older than 2.6.25 where the symbol SCSI_MAX_SG_SEGMENTS
is not available. Define it if it is not already defined.
Also fix a few minor English issues.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@590
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Sat, 29 Nov 2008 17:00:15 +0000 (17:00 +0000)]
Small docs update
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@589
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 17:19:29 +0000 (17:19 +0000)]
alloc_io_context renamed to export_alloc_io_context
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@588
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 17:15:17 +0000 (17:15 +0000)]
- Performance increase
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@587
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 28 Nov 2008 16:11:51 +0000 (16:11 +0000)]
Signed/unsigned cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@586
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 26 Nov 2008 19:03:41 +0000 (19:03 +0000)]
Fixing compilation warning when compiling the code with -Wcast-qual.
The casting from (const uint8_t *) to (uint8_t *) is not really necessary.
Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@585
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 26 Nov 2008 19:00:23 +0000 (19:00 +0000)]
There are two remaining printk() statements on which checkpatch warns that the
KERN_ facility level is missing. Algthough these warnings are false positives,
I have developed a patch to suppress these warnings.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@584
d57e44dd-8a1f-0410-8b47-
8ef2f437770f