13 years agoAllows enabling target mode support without SCST enabled. Otherwise it is impossible...
vlnb [Fri, 10 Oct 2008 10:00:08 +0000 (10:00 +0000)]
Allows enabling target mode support without SCST enabled. Otherwise it is impossible to use the target driver with out of tree SCST.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@522 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUnused files removed as requested by Bart Van Assche <bart.vanassche@gmail.com>
vlnb [Thu, 9 Oct 2008 17:58:04 +0000 (17:58 +0000)]
Unused files removed as requested by Bart Van Assche <bart.vanassche@gmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@521 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes SAM violation, noticed by Sudhakar <ssudhakarp@gmail.com>. Plus, Windows requir...
vlnb [Wed, 8 Oct 2008 17:59:11 +0000 (17:59 +0000)]
Fixes SAM violation, noticed by Sudhakar <ssudhakarp@gmail.com>. Plus, Windows requires it to automatically support LUNs >8, see support.microsoft.com/kb/310072/en-us

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@520 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCleanups
vlnb [Wed, 8 Oct 2008 17:36:08 +0000 (17:36 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@519 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUntil now the kernel config option to enable the SRP target was called
vlnb [Wed, 8 Oct 2008 13:44:27 +0000 (13:44 +0000)]
Until now the kernel config option to enable the SRP target was called
CONFIG_INFINIBAND_SRPT. This is a reminiscent from the time when the SRPT code
resided in the directory drivers/infiniband/ulp/srpt. Since this code has been moved
into the directory drivers/scst/srpt, the path below renames this config option
into CONFIG_SCST_SRPT. The other changes present in this patch are:
- Removed srpt/src/Makefile.infiniband.Linux-2.6.2[45].patch since these files are obsolete.
- Rewrote Kconfig help text slightly.

The patch below has been tested by verifying that the kernel + SCST
patch still compiles cleanly with CONFIG_SCST_SRPT=m.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@518 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoWeb fixes and updates
vlnb [Tue, 7 Oct 2008 14:56:42 +0000 (14:56 +0000)]
Web fixes and updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@517 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below enables compilation of the SRPT driver with the 2.6.26.x kernel.
vlnb [Tue, 7 Oct 2008 08:57:46 +0000 (08:57 +0000)]
The patch below enables compilation of the SRPT driver with the 2.6.26.x kernel.

This patch has been tested by verifying that:
- the patched Linux and kernel trees still compile when
  CONFIG_INFINIBAND_SRPT=m is present in .config (verified that
  make -k modules only complains about a missing qla2xxx-target directory).
- the SCST out-of-tree source code still compiles fine against the 2.6.25 kernel
  (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
- checkpatch output is identical for the output of scripts/generate-kernel-patch 2.6.25
  and scripts/generate-kernel-patch 2.6.26.

Based on patch from Vu Pham <vu@mellanox.com>

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@516 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following class of checkpatch warnings:
vlnb [Mon, 6 Oct 2008 17:24:49 +0000 (17:24 +0000)]
The patch below fixes the following class of checkpatch warnings:
WARNING: externs should be avoided in .c files

This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@515 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following class of checkpatch warnings:
vlnb [Mon, 6 Oct 2008 17:22:17 +0000 (17:22 +0000)]
The patch below fixes the following class of checkpatch warnings:
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu

This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@514 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following checkpatch error:
vlnb [Mon, 6 Oct 2008 17:19:48 +0000 (17:19 +0000)]
The patch below fixes the following checkpatch error:
ERROR: return is not a function, parentheses are not required

This patch has been tested by verifying that the newly generated patch still
applies without warnings to the kernel and that the patched kernel
still compiles.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@513 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following classes of checkpatch errors:
vlnb [Mon, 6 Oct 2008 17:18:04 +0000 (17:18 +0000)]
The patch below fixes the following classes of checkpatch errors:
* ERROR: return is not a function, parentheses are not required
* ERROR: that open brace { should be on the previous line

This patch has been tested by verifying that the newly generated patch still
applies without warnings to the kernel and that the patched kernel
still compiles.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@512 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAs known the script generate-kernel-patch generates a patch for the specified
vlnb [Mon, 6 Oct 2008 17:15:08 +0000 (17:15 +0000)]
As known the script generate-kernel-patch generates a patch for the specified
vanilla Linux kernel version. When I submitted this script for inclusion in the
SCST Subversion repository the SRPT target driver was excluded by default
because of checkpatch errors triggered by the SRPT source code. These errors
have been fixed considerable time ago. Hence the patch below makes inclusion
of the SRPT driver the default.

This patch has been tested by verifying that the generated patch still applies
cleanly to the kernel, and that the patched kernel still compiles cleanly.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@511 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below fixes the following two checkpatch warnings:
vlnb [Mon, 6 Oct 2008 17:13:11 +0000 (17:13 +0000)]
The patch below fixes the following two checkpatch warnings:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#290: FILE: net/core/utils.c:316:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#291: FILE: net/core/utils.c:317:

This patch has been tested by verifying that the generated patch still applies
without warnings to the kernel and that the patched kernel still

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@510 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoWeb updates. Particularly, "Contributing" page was added
vlnb [Fri, 3 Oct 2008 18:09:00 +0000 (18:09 +0000)]
Web updates. Particularly, "Contributing" page was added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@509 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor fixes and changes
vlnb [Thu, 2 Oct 2008 10:46:47 +0000 (10:46 +0000)]
Minor fixes and changes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@508 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoVERIFY commands that comes with BYTCHK unset (i.e. no data to write)
vlnb [Tue, 30 Sep 2008 18:15:06 +0000 (18:15 +0000)]
VERIFY commands that comes with BYTCHK unset (i.e. no data to write)
shouldn't fail

Signed-off-by: Gal Rosen <galr@storwize.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@506 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSponsorship related updates
vlnb [Tue, 30 Sep 2008 17:29:31 +0000 (17:29 +0000)]
Sponsorship related updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@505 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAs pointed out by Arne Redlich, size of dummy_data is too small as well as some check...
vlnb [Mon, 29 Sep 2008 16:58:36 +0000 (16:58 +0000)]
As pointed out by Arne Redlich, size of dummy_data is too small as well as some checks in noop_out_start() are not needed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@503 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes possible oops in double reset UAs handling
vlnb [Fri, 26 Sep 2008 16:03:50 +0000 (16:03 +0000)]
Fixes possible oops in double reset UAs handling

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@500 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoHandling of double reset UAs made more reliable
vlnb [Fri, 26 Sep 2008 16:01:53 +0000 (16:01 +0000)]
Handling of double reset UAs made more reliable

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@499 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes broken NOP-Out with payload handling + minor fixed. Both problems derived from...
vlnb [Fri, 26 Sep 2008 15:59:47 +0000 (15:59 +0000)]
Fixes broken NOP-Out with payload handling + minor fixed. Both problems derived from IET.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@498 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor changes
vlnb [Thu, 25 Sep 2008 09:21:44 +0000 (09:21 +0000)]
Minor changes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@497 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoBelatedly put in a patch to avoid an OOPS that Stanley had
zorko [Wed, 24 Sep 2008 01:09:27 +0000 (01:09 +0000)]
Belatedly put in a patch to avoid an OOPS that Stanley had
sent me but I hadn't integrated. Bad me.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@496 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd more startup delay for 24XX cards when execing f/w (temp soln)
zorko [Fri, 12 Sep 2008 22:30:21 +0000 (22:30 +0000)]
Add more startup delay for 24XX cards when execing f/w (temp soln)
Add support for up through 2.6.25 (might even be good for 2.6.26)
Remove HBAAPI support. This never has worked well and I doubt anyone will miss it.
Remove files not pertinent SCST build.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@493 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Gal Rosen <galr@storwize.com>:
vlnb [Thu, 28 Aug 2008 15:48:35 +0000 (15:48 +0000)]
Patch from Gal Rosen <galr@storwize.com>:

Mailbox is 16 bits, and the shift should be of 2 bytes (16 bits) not 2 bits, and 1 byte not 1 bit

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@492 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoForgotten to be changed during 1.0.0 release externally seen SCST revision
vlnb [Wed, 20 Aug 2008 15:33:18 +0000 (15:33 +0000)]
Forgotten to be changed during 1.0.0 release externally seen SCST revision

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@490 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMake qlaispd sleep interruptible so as to now
zorko [Sat, 16 Aug 2008 17:05:07 +0000 (17:05 +0000)]
Make qlaispd sleep interruptible so as to now
skew process statistics.

Submitted by: Stanislaw Gruszka

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@489 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed the following sparse warnings:
zorko [Thu, 14 Aug 2008 22:42:58 +0000 (22:42 +0000)]
Fixed the following sparse warnings:

warning: Using plain integer as NULL pointer
warning: obsolete struct initializer, use C99 syntax
warning: symbol 'hba_api_ioctl_operations' was not declared. Should it be static?

Submitted-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@488 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoReturn value of the script depend on the return value of the
vlnb [Wed, 13 Aug 2008 18:09:23 +0000 (18:09 +0000)]
Return value of the script depend on the return value of the
last executed function.

In some functions (for example: start) the return value of the
last executable is being returned but not being checked anywhere.
If this last operaion fails, the return value shouldn't be 0.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@487 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPolishing for in-tree
vlnb [Fri, 1 Aug 2008 17:59:05 +0000 (17:59 +0000)]
Polishing for in-tree

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@486 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCheckpath and compiler fixes
vlnb [Fri, 1 Aug 2008 17:03:24 +0000 (17:03 +0000)]
Checkpath and compiler fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@485 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Compiler made to show more warnings
vlnb [Thu, 31 Jul 2008 10:01:45 +0000 (10:01 +0000)]
 - Compiler made to show more warnings
 - New warnings fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@484 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCompilation if target mode disabled fixed
vlnb [Tue, 29 Jul 2008 17:19:58 +0000 (17:19 +0000)]
Compilation if target mode disabled fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@483 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoLocking documented
vlnb [Tue, 29 Jul 2008 17:18:08 +0000 (17:18 +0000)]
Locking documented

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@482 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAll empty lines due
vlnb [Mon, 28 Jul 2008 18:19:34 +0000 (18:19 +0000)]
All empty lines due
to code commented out because inside #if LINUX_VERSION_CODE ... /
#endif is now really removed.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@481 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed minor iSCSI standard violation
vlnb [Mon, 28 Jul 2008 11:08:32 +0000 (11:08 +0000)]
Fixed minor iSCSI standard violation

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@480 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSCST_HIGHMEM removed as not needed
vlnb [Fri, 25 Jul 2008 16:46:27 +0000 (16:46 +0000)]
SCST_HIGHMEM removed as not needed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@479 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUpdated corespondingly to the latest changes in the driver (kernels <2.6.26 not suppo...
vlnb [Fri, 25 Jul 2008 10:57:42 +0000 (10:57 +0000)]
Updated corespondingly to the latest changes in the driver (kernels <2.6.26 not supported anymore)

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@478 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded qla2x00t HOWTO written by Amit Mehta. Web pages updated correspondingly.
vlnb [Thu, 24 Jul 2008 16:23:44 +0000 (16:23 +0000)]
Added qla2x00t HOWTO written by Amit Mehta. Web pages updated correspondingly.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@477 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor the kernel patch preparations fixes
vlnb [Thu, 24 Jul 2008 10:38:51 +0000 (10:38 +0000)]
Minor the kernel patch preparations fixes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@476 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Update for 2.6.26
vlnb [Thu, 24 Jul 2008 09:22:55 +0000 (09:22 +0000)]
 - Update for 2.6.26
 - Zero-copy feature, introduced by put_page_callback patch, made kernel compile time configurable via CONFIG_TCP_ZERO_COPY_TRANSFER_COMPLETION_NOTIFICATION option. If you upgrade from earlier versions, see the corresponding "[CAUTION]" e-mail in scst-devel mailing list about possible compatibility problems.
 - SRP target temporary removed from "all" and "install" the main Makefile targets, since it isn't compiled on 2.6.26
 - Minor fixes and cleanups

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@475 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix for long standing protection problem in the initiator driver
vlnb [Thu, 24 Jul 2008 09:04:05 +0000 (09:04 +0000)]
Fix for long standing protection problem in the initiator driver

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@474 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUpdate of the initiator driver to one from kernel 2.6.26. Sorry, the prior kernels...
vlnb [Wed, 23 Jul 2008 17:41:22 +0000 (17:41 +0000)]
Update of the initiator driver to one from kernel 2.6.26. Sorry, the prior kernels not supported anymore, but backport patches are welcome.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@473 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor changes and docs updates
vlnb [Tue, 22 Jul 2008 15:32:42 +0000 (15:32 +0000)]
Minor changes and docs updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@471 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes crash on module unload found by Gal Rosen
vlnb [Mon, 21 Jul 2008 17:01:12 +0000 (17:01 +0000)]
Fixes crash on module unload found by Gal Rosen

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@470 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - QLA: minor cleanups
vlnb [Fri, 18 Jul 2008 17:02:13 +0000 (17:02 +0000)]
 - QLA: minor cleanups
 - SCST_USER: microoptimization

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@469 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSRPT 1.0.0 tag added
vlnb [Fri, 18 Jul 2008 11:08:44 +0000 (11:08 +0000)]
SRPT 1.0.0 tag added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@468 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoTypo fixed
vlnb [Fri, 18 Jul 2008 10:35:56 +0000 (10:35 +0000)]
Typo fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@466 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoUse gfp_t instead of int to hold GFP_* masks.
vlnb [Thu, 17 Jul 2008 18:23:32 +0000 (18:23 +0000)]
Use gfp_t instead of int to hold GFP_* masks.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@465 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor scstadmin-related improvements
vlnb [Thu, 17 Jul 2008 17:56:57 +0000 (17:56 +0000)]
Minor scstadmin-related improvements

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@464 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix the following sparse warnings in several locations:
vlnb [Tue, 15 Jul 2008 18:00:19 +0000 (18:00 +0000)]
Fix the following sparse warnings in several locations:

/scst/trunk/scst/src/dev_handlers/scst_dev_handler.h:54:40: warning:
incorrect type in argument 2 (different address spaces)
expected char const *buf
/scst/trunk/scst/src/dev_handlers/scst_dev_handler.h:54:40:    got
char const [noderef] <asn:1>*buf

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@463 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix the following sparse warnings in several locations:
vlnb [Tue, 15 Jul 2008 17:55:02 +0000 (17:55 +0000)]
Fix the following sparse warnings in several locations:

 warning: incorrect type in argument 2 (different address spaces)
    expected void const [noderef] <asn:1>*from
    got void *<noident>
 warning: symbol '__dev_user_get_next_cmd' was not declared. Should it
be static?

One more optional fix (that i didn't do) is instead of casting
arg in the ioctl() function before every call to function
is to do the casting only once to a temporary variable and
send this variable to every function.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@462 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix the following sparse warnings in several locations:
vlnb [Tue, 15 Jul 2008 17:52:16 +0000 (17:52 +0000)]
Fix the following sparse warnings in several locations:

warning: incorrect type in argument 2 (different address spaces)
    expected void const [noderef] <asn:1>*from
    got void *<noident>

One more optional fix (that i didn't do) is instead of casting
arg in the ioctl() function before every call to function
is to do the casting only once to a temporary variable and
send this variable to every function.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@461 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Added init enable instructions to "make install" and README file.
mgandalf [Mon, 14 Jul 2008 20:00:18 +0000 (20:00 +0000)]
- Added init enable instructions to "make install" and README file.
- Changed VERSION on top-level Makefile to MODULE_VERSION to be more clear.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@460 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoRemoved duplicate SCST.pm module file.
mgandalf [Mon, 14 Jul 2008 19:44:04 +0000 (19:44 +0000)]
Removed duplicate SCST.pm module file.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@459 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoSRPT release related updates
vlnb [Mon, 14 Jul 2008 17:20:46 +0000 (17:20 +0000)]
SRPT release related updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@458 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agosrpt: converting makefile back to compile in scst tree
huongvp [Fri, 11 Jul 2008 16:32:48 +0000 (16:32 +0000)]
srpt: converting makefile back to compile in scst tree

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@457 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChange the 0 integer to NULL to fix the following sparse warning
vlnb [Thu, 10 Jul 2008 11:08:07 +0000 (11:08 +0000)]
Change the 0 integer to NULL to fix the following sparse warning
(in locations that i miss in the previous patch):

warning: Using plain integer as NULL pointer
warning: Using plain integer as NULL pointer

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@456 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChange the 0 integer to NULL to fix the following sparse warning:
vlnb [Thu, 10 Jul 2008 11:06:20 +0000 (11:06 +0000)]
Change the 0 integer to NULL to fix the following sparse warning:

warning: Using plain integer as NULL pointer

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@455 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixed not clearly applied xxx2yyy
vlnb [Thu, 10 Jul 2008 11:05:16 +0000 (11:05 +0000)]
Fixed not clearly applied xxx2yyy

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@454 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoApparently the SCST code with debugging and/or tracing enabled compiles fine as
vlnb [Thu, 10 Jul 2008 10:49:06 +0000 (10:49 +0000)]
Apparently the SCST code with debugging and/or tracing enabled compiles fine as
an external module. When applying the SCST kernel patch to the mainstream
kernel tree with debugging and/or tracing enabled however, the resulting code
triggers a compiler error. This is because the symbols DEBUG and TRACING
conflict with symbols with the same named defined in unrelated kernel headers.
The patch below resolves these conflicts by renaming the following preprocessor
  into macro undefined / macro defined.
- In qla_isp/linux/isp_scst.c, renamed DEBUG into DEBUG_ISP_SCST.
- In qla_isp/..., renamed SCSI_TARGET in SCST_SCSI_TARGET.
- In qla_isp/..., renamed SCSI_TARGET_DEV in SCST_SCSI_TARGET_DEV.
Additionally, all CONFIG_SCSI_TARGET* macro's are renamed into CONFIG_SCST* in
order to avoid confusion between the STGT CONFIG-symbols and the SCST CONFIG-

The following additional options are now configurable through Kconfig:

The patch below has been verified as follows:
- Verified that the following command does not print any new warning messages:
  make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s
- Verified as follows that the internal SCST patches still apply cleanly:
  for p in *patch; do patch -p0 --dry-run -f -s <$p; done
- Checked that the patch generated by generate-kernel-patch still applies
  cleanly to the kernel, and that the patched kernel tree still
  compiles, installs and boots fine, that the iscsi-scst, ib_srpt,
  scst_disk and scst_vdisk modules still load, and that iSCSI communication
  still works fine. All SCST kernel configuration options that could be
  enabled have been enabled during this test.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@453 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoLet svn ignore symbolic links created when driver is built.
swgruszka [Thu, 10 Jul 2008 07:05:47 +0000 (07:05 +0000)]
Let svn ignore symbolic links created when driver is built.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@452 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd KVER make parameter and remove Module{,s}.symvers on clean.
swgruszka [Thu, 10 Jul 2008 06:44:28 +0000 (06:44 +0000)]
Add KVER make parameter and remove Module{,s}.symvers on clean.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@451 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agosrpt:
huongvp [Thu, 10 Jul 2008 00:04:49 +0000 (00:04 +0000)]
 - changing Makefile to compile srpt out-of scst tree and in release mode
 - fixing checkpath warnings for kernel inclusion

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@450 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe LSI SCST driver does not forward ABORT TASK SET task management messages to SCST...
vlnb [Wed, 9 Jul 2008 17:38:34 +0000 (17:38 +0000)]
The LSI SCST driver does not forward ABORT TASK SET task management messages to SCST.  This patch fixes that.

Signed-off-by: Erik Habbinga <erikhabbinga@inphase-tech.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@449 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd the "static" qualifier to function that isn't being declared
vlnb [Wed, 9 Jul 2008 17:35:11 +0000 (17:35 +0000)]
Add the "static" qualifier to function that isn't being declared
(in h file) or exported to fix the following sparse warning:

/scst/trunk/iscsi-scst/kernel/iscsi.c:166:6: warning: symbol
'cmnd_free' was not declared. Should it be static?

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@448 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago- Added a proper Makefile.PL to SCST::SCST so now we have a also a
mgandalf [Wed, 9 Jul 2008 17:32:42 +0000 (17:32 +0000)]
- Added a proper Makefile.PL to SCST::SCST so now we have a also a
  proper man page.
- Renamed Changes to ChangeLog
- Updated README to include instructions for installing the perl module.
- Renamed SCST perl module directory tp scst-0.7.4

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@447 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoChange the name of local variable to prevent the following compilation warning:
vlnb [Wed, 9 Jul 2008 17:32:16 +0000 (17:32 +0000)]
Change the name of local variable to prevent the following compilation warning:
/scst/trunk/iscsi-scst/kernel/iscsi.c:190:30: warning: symbol 'req'
shadows an earlier one
/scst/trunk/iscsi-scst/kernel/iscsi.c:182:29: originally declared here

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@446 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below implements the following changes:
vlnb [Wed, 9 Jul 2008 17:28:36 +0000 (17:28 +0000)]
The patch below implements the following changes:
- The script specialize-patch now acts as if #define INSIDE_KERNEL_TREE 1
  is effective.
- The script generate-kernel-patch now renames sBUG_ON() into BUG_ON()
  and sBUG() into BUG(). The same script removes the definitions of the
  sBUG_ON(), sBUG() and WARN_ON_ONCE() macro's from the header file
  scst_debug.h. The last macro is only removed for kernel versions later than

This patch has been tested as follows:
- Compared the output of the command "scripts/generate-kernel-patch 2.6.25"
  before and after the changes.
- Verified the newly generated patch with checkpatch. Checkpatch statistics
  are now as follows:
    521 WARNING: line over 80 characters
     12 WARNING: consider using strict_strtoul in preference to simple_strtoul
     10 WARNING: printk() should include KERN_ facility level
      3 WARNING: CVS style keyword markers, these will _not_ be updated
      2 WARNING: do not add new typedefs
      1 WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
- Verified that the generated kernel patch still applies cleanly to the kernel and that this kernel still compiles, installs and boots fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@445 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoThe patch below contains the following changes:
vlnb [Wed, 9 Jul 2008 17:19:24 +0000 (17:19 +0000)]
The patch below contains the following changes:
- Substituted lun_t by uint64_t and removed typedef lun_t.
- Fixed the following class of checkpatch errors (two instances):
    ERROR: space required before the open parenthesis '('

This patch has been verified as follows:
- Checked that the following command still works and did not produce any
  new compiler warnings:
    make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s
- Checked that the patch generated by generate-kernel-patch still applies
  cleanly to the kernel, and that the patched kernel tree still
  compiles, installs and boots fine, and that the iscsi-scst, ib_srpt,
  scst_disk and scst_vdisk modules still load.
- Verified that checkpatch does not report any new warnings or errors.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@444 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Forgotten piece of changes for returning to the release mode
vlnb [Wed, 9 Jul 2008 16:58:56 +0000 (16:58 +0000)]
 - Forgotten piece of changes for returning to the release mode
 - QLA_ISP targets in the main Makefile temporary disabled, since they don't support building with specified kernel version

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@443 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Version changed to 1.0.1
vlnb [Wed, 9 Jul 2008 16:44:01 +0000 (16:44 +0000)]
 - Version changed to 1.0.1
 - Switched back to the debug mode

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@442 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoTag 1.0.0 added
vlnb [Wed, 9 Jul 2008 09:46:36 +0000 (09:46 +0000)]
Tag 1.0.0 added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@440 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCosmetics
vlnb [Wed, 9 Jul 2008 09:14:21 +0000 (09:14 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@439 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCosmetics
vlnb [Wed, 9 Jul 2008 07:00:50 +0000 (07:00 +0000)]

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@438 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Known issues added
vlnb [Wed, 9 Jul 2008 06:53:41 +0000 (06:53 +0000)]
 - Known issues added
 - Cosmetics

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@437 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPending changes to match the 1.0.0 released packeges
vlnb [Tue, 8 Jul 2008 19:21:22 +0000 (19:21 +0000)]
Pending changes to match the 1.0.0 released packeges

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@436 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoWEB updates for release 1.0.0
vlnb [Tue, 8 Jul 2008 16:41:52 +0000 (16:41 +0000)]
WEB updates for release 1.0.0

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@435 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd release2debug and debug2release Makefile targets for qla_isp.
swgruszka [Tue, 8 Jul 2008 07:59:42 +0000 (07:59 +0000)]
Add release2debug and debug2release Makefile targets for qla_isp.
Leave qla_isp in release 'state' as other stuff.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@434 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Version changed to 1.0.0
vlnb [Mon, 7 Jul 2008 18:00:32 +0000 (18:00 +0000)]
 - Version changed to 1.0.0
 - Build configuration changed to "Release"
 - iscsi-scst-howto.txt added
 - ChangeLog's updated
 - Minor docs changes
 - scstadm_install and scstadm_uninstall main Makefile targets added

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@433 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Comment about 2008 Linux Storage & Filesystem Workshop added
vlnb [Mon, 7 Jul 2008 17:54:49 +0000 (17:54 +0000)]
 - Comment about 2008 Linux Storage & Filesystem Workshop added
 - scst_user_spec.txt removed, it was committed here by mistake
 - Minor changes

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@432 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Install/uninstall added
vlnb [Mon, 7 Jul 2008 17:51:53 +0000 (17:51 +0000)]
 - Install/uninstall added
 - Version fixed

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@431 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd uninstall makefile target.
swgruszka [Sun, 6 Jul 2008 10:45:25 +0000 (10:45 +0000)]
Add uninstall makefile target.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@430 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoCopy Modules.symvers stuff from qla2x00t makefiles to avoid undefined symbols warrning.
swgruszka [Sat, 5 Jul 2008 20:19:11 +0000 (20:19 +0000)]
Copy Modules.symvers stuff from qla2x00t makefiles to avoid undefined symbols warrning.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@429 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd warrning qla_isp do not support > 2.6.24
swgruszka [Sat, 5 Jul 2008 19:11:16 +0000 (19:11 +0000)]
Add warrning qla_isp do not support > 2.6.24

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@428 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdd "extraclean" entry to the qla_isp Makefiles.
vlnb [Fri, 4 Jul 2008 17:53:30 +0000 (17:53 +0000)]
Add "extraclean" entry to the qla_isp Makefiles.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@427 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded qla_isp support to the general Makefile.
vlnb [Wed, 2 Jul 2008 17:43:20 +0000 (17:43 +0000)]
Added qla_isp support to the general Makefile.

The following operations (parametgers to the make) are now supported:
qla_isp, qla_isp_clean, qla_isp_extraclean,
qla_isp_install, qla_isp_uninstall.

But at the moment qla_isp doesn't support all of the needed operations: uninstall and extraclean are not supported in its Makefile.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@426 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFixes few harmless issues:
vlnb [Mon, 30 Jun 2008 09:50:27 +0000 (09:50 +0000)]
Fixes few harmless issues:
 1. The #define on line 228 of iscsi-scst/usr/isns.c triggers a compiler
warning on ppc.
 2. make iscsi && sudo make iscsi_install triggers the following error
message ( kernel, ppc), but doesn't break installation:
install: cannot stat `usr/iscsi-scst-adm': No such file or directory
 3. Unneeded "unlikely" removed

Issues 1 and 2 reported by Bart Van Assche <bart.vanassche@gmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@425 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor updates
vlnb [Mon, 30 Jun 2008 09:38:39 +0000 (09:38 +0000)]
Minor updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@424 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - A complete fix for the problem when a command comes with zero transfer length...
vlnb [Thu, 26 Jun 2008 16:39:05 +0000 (16:39 +0000)]
 - A complete fix for the problem when a command comes with zero transfer length and READ or WRITE data transfer direction
 - Version changed to 1.0.0-rc2

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@423 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoMinor cleanups and docs updates
vlnb [Thu, 26 Jun 2008 16:35:10 +0000 (16:35 +0000)]
Minor cleanups and docs updates

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@422 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoNew web look
vlnb [Thu, 26 Jun 2008 11:52:09 +0000 (11:52 +0000)]
New web look

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@421 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixes incorrect allocation length 0 by scst_user module
vlnb [Mon, 23 Jun 2008 16:32:51 +0000 (16:32 +0000)]
 - Fixes incorrect allocation length 0 by scst_user module
 - Fixes missed case of "allocation length 0 for READ6/WRITE6 means 256".

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@420 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoReplace memory allocation from kzalloc to kmalloc because
vlnb [Thu, 19 Jun 2008 17:54:25 +0000 (17:54 +0000)]
Replace memory allocation from kzalloc to kmalloc because
this memory buffer will be zeroed later on in the code.

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@419 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoFix compilation warning in kernels higher than 2.6.16
vlnb [Thu, 19 Jun 2008 17:52:18 +0000 (17:52 +0000)]
Fix compilation warning in kernels higher than 2.6.16
(the prototype of the function strncasecmp was changed in 2.6.16).

Signed-off-by: Dotan Barak <dotanba@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@418 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years ago - Fixes not cleanly applies xxx2yyy patches
vlnb [Thu, 19 Jun 2008 17:48:08 +0000 (17:48 +0000)]
 - Fixes not cleanly applies xxx2yyy patches
 - Updated to IET r155
 - Compilation fixes
 - Typos fixes, including patch from Dotan Barak <dotanba@gmail.com>

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@417 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded error message for a kernel bug, which doesn't allow for poll() to work with...
vlnb [Wed, 18 Jun 2008 09:54:38 +0000 (09:54 +0000)]
Added error message for a kernel bug, which doesn't allow for poll() to work with >256 file descriptors and prevents iscsi-scstd to start.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@416 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Bart Van Assche <bart.vanassche@gmail.com>:
vlnb [Fri, 13 Jun 2008 17:31:29 +0000 (17:31 +0000)]
Patch from Bart Van Assche <bart.vanassche@gmail.com>:

The patch below fixes the following class of checkpatch warnings:
- WARNING: braces {} are not necessary for single statement blocks

How this patch has been verified:
- Checked that make -s clean && make -s scst iscsi-scst still works.
- Verified that checkpatch does no longer complain about the placement of

The patch below only changes comments, so it should be safe to include it in
the 1.0.0 release.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@415 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoAdded option mapping NV -> NV_CACHE.
mgandalf [Fri, 13 Jun 2008 13:38:46 +0000 (13:38 +0000)]
Added option mapping NV -> NV_CACHE.

git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@414 d57e44dd-8a1f-0410-8b47-8ef2f437770f

13 years agoPatch from Bart Van Assche <bart.vanassche@gmail.com>:
vlnb [Fri, 13 Jun 2008 11:08:23 +0000 (11:08 +0000)]
Patch from Bart Van Assche <bart.vanassche@gmail.com>:

The script scripts/specialize-patch'>scripts/specialize-patch is an awk script. Currently it specifies /usr/bin/awk as its interpreter although it doesn't use the standard AWK syntax but the extended GNU AWK syntax. The patch below changes the interpreter name such that the script also works on systems where /usr/bin/awk is not GNU AWK (e.g. Ubuntu 8.04). Note: GNU AWK is not installed by default on all Linux systems. E.g. on Debian systems it's in the gawk package.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@413 d57e44dd-8a1f-0410-8b47-8ef2f437770f