bvassche [Thu, 10 Sep 2009 18:26:06 +0000 (18:26 +0000)]
Made sure that there is only a single blank line before scsi_end_async() in the output of scripts/generate-kernel-patch.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1088
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 9 Sep 2009 18:30:50 +0000 (18:30 +0000)]
Replaced kernel versions 2.6.27.31 and 2.6.30.5 by 2.6.27.32 and 2.6.30.6 respectively.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1085
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 8 Sep 2009 11:31:48 +0000 (11:31 +0000)]
Maintainer's address added
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1083
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Tue, 8 Sep 2009 01:45:52 +0000 (01:45 +0000)]
Don't try and stop a kernel thread that hasn't started- this will fix some
reported oopses.
Fix residual setting for 21XX/22XX/23XX cards. Oops.
Return at least *some* kind of WWN. Apparently there are still enough
cards floating around that have scrambled NVRAM that this is a problem-
at least for me.
More meaningless format changes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1082
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Tue, 8 Sep 2009 01:40:39 +0000 (01:40 +0000)]
If we're running newer than 3.0.16 firmware and are in target mode, tell
the firmware to not automatically issue a PRLI after a PLOGI. This should
solve the problem of being in N-port topology where we have to issue a PLOGI
which by default is followed by a PRLI, which makes us an illegal target.
This is not the most ideal fix in that it breaks the initiator side of
initiator/target mode for any local topology disks.
Various other meaningless formattting changes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1081
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Tue, 8 Sep 2009 01:36:17 +0000 (01:36 +0000)]
Remove obsolete documentation.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1080
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 7 Sep 2009 12:09:16 +0000 (12:09 +0000)]
The patch below fixes occurrences of the following recently introduced
checkpatch warning: "do not use assignment in if condition".
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
with some fixes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1079
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 7 Sep 2009 12:02:47 +0000 (12:02 +0000)]
Microcleanup to combine the vars alltogether
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1078
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 6 Sep 2009 12:02:49 +0000 (12:02 +0000)]
Do not only remove references of SCSI_EXEC_REQ_FIFO_DEFINED / SCST_IO_CONTEXT
but also their definition.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1077
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 6 Sep 2009 11:09:21 +0000 (11:09 +0000)]
Refinements / bug fixes of the changes introduced in the previous commit:
- Only replace sBUG/sBUG_ON by BUG/BUG_ON when this macro is being used, not
in its definition.
- Fixed bugs in algorithm for preserving the original code during a sparse run.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1076
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 4 Sep 2009 15:49:41 +0000 (15:49 +0000)]
Bump up SCSI version to SCSI-3
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1075
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 3 Sep 2009 18:31:22 +0000 (18:31 +0000)]
Whitespace-only changes. Fixed the following categories of checkpatch
complaints:
- code indent should use tabs where possible.
- trailing whitespace.
- else should follow close brace '}'.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1074
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 3 Sep 2009 16:52:34 +0000 (16:52 +0000)]
Fix for a problem found by Saar David <liorg@ged-I.com>: the missed << 24 added.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1073
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 3 Sep 2009 12:09:33 +0000 (12:09 +0000)]
The patch below fixes the spelling of a few function names. This patch has
been tested by running the following command and verifying its output:
scripts/run-regression-tests 2.6.30.4
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1071
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 3 Sep 2009 11:53:48 +0000 (11:53 +0000)]
- Some docs and web updates with minor fixes.
- Default number of IO threads for vdisks on systems with context-RA increased, because context-RA handles multitreaded sequential IO much better.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1070
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 2 Sep 2009 16:43:54 +0000 (16:43 +0000)]
Updated SRPT to do list.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1069
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 2 Sep 2009 16:42:26 +0000 (16:42 +0000)]
Modified scripts invoked during a regression test run such that the line numbers printed by sparse match those of the SCST source files present in the Subversion repository.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1068
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 2 Sep 2009 16:38:27 +0000 (16:38 +0000)]
Updated Subversion ignore list.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1067
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 2 Sep 2009 09:59:37 +0000 (09:59 +0000)]
Trace_level cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1065
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 2 Sep 2009 09:58:31 +0000 (09:58 +0000)]
Minor SGV docs improvements
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1064
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 2 Sep 2009 09:57:23 +0000 (09:57 +0000)]
Web fixes and new images from Daniel Fernandes <dfernandes1978@hotmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1063
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
zorko [Sun, 23 Aug 2009 04:10:13 +0000 (04:10 +0000)]
Update copyright date on LICENSE.
Update README to note that multi-id firmware needs to be used for NPIV.
Add a FIRMWARE readme that was supposed to go in back last June.
M qla_isp/LICENSE
M qla_isp/README.scst
A qla_isp/FIRMWARE.readme
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1062
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 17 Aug 2009 16:01:06 +0000 (16:01 +0000)]
Updated kernel version 2.6.27.30 to 2.6.27.31.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1061
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 17 Aug 2009 10:43:28 +0000 (10:43 +0000)]
Updated kernel versions: 2.6.30.4 to 2.6.30.5 and 2.6.27.29 to 2.6.27.30.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1060
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 16 Aug 2009 13:27:01 +0000 (13:27 +0000)]
Refinements for SRPT command processing state management.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1059
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 16 Aug 2009 12:18:52 +0000 (12:18 +0000)]
Fixed bug introduced in the previous revision of the specialize-patch
script: empty lines after #if ... #else ... #endif blocks were deleted.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1058
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
swgruszka [Sat, 15 Aug 2009 14:10:08 +0000 (14:10 +0000)]
Update firmware to that we have in Feral cvs repository.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1057
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 15 Aug 2009 13:54:36 +0000 (13:54 +0000)]
Minor documentation updates.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1056
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 15 Aug 2009 13:48:12 +0000 (13:48 +0000)]
- Changed the identification string displayed by the ibsrpdm tool from
"Mellanox OFED SRP target" to "SCST SRP target" to reflect that this
version of the SRP target is distributed through the SCST project.
- Added kernel parameter use_port_guid_in_session_name that allows to
use the original session naming scheme of the SRP target. This should
make it again possible to connect to a multiport SRP target by masking
out redundant paths on the target.
- Made sure that whenever a login is rejected that a kernel message is
generated (printk()) such that this information ends up in
/var/log/messages.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1055
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 15 Aug 2009 13:33:24 +0000 (13:33 +0000)]
Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1054
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 14 Aug 2009 19:34:55 +0000 (19:34 +0000)]
Whether or not SCSI_EXEC_REQ_FIFO_DEFINED and SCST_IO_CONTEXT are defined
does now depend on their definition in the per kernel-version patches.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1053
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 14 Aug 2009 19:19:04 +0000 (19:19 +0000)]
Chenge logs and TAGS updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1051
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 14 Aug 2009 19:16:53 +0000 (19:16 +0000)]
1.0.1.1 web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1049
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 14 Aug 2009 18:53:10 +0000 (18:53 +0000)]
Rearranged preprocessor statements containing version checks such that these
are now processed correctly by scripts/specialize-patch.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1048
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 14 Aug 2009 18:26:58 +0000 (18:26 +0000)]
- The expression "defined(SCST_IO_CONTEXT)" is now replaced by "1".
- The following two lines and the first blank line below are now removed:
+#define SCSI_EXEC_REQ_FIFO_DEFINED
+#define SCST_IO_CONTEXT
- Hunks that do no longer contain any modifications because of the
previous steps are now removed from the output because patch otherwise
complains.
- Added support for evaluating expressions containing the arithmetic
operators *, /, +, -.
- Removed support for partial evaluation of expressions because it is too
tricky to get this right due to operator precedence.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1047
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 13 Aug 2009 19:05:31 +0000 (19:05 +0000)]
Changed terminology in comments and one printk() message such that it
matches the terminology used in the SRP spec.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1046
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 13 Aug 2009 18:29:59 +0000 (18:29 +0000)]
- Remove the line "+#define SCSI_EXEC_REQ_FIFO_DEFINED" from the generated
patch.
- Substitute "defined(SCSI_EXEC_REQ_FIFO_DEFINED)" by "1" in preprocessor
statements.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1045
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 13 Aug 2009 17:34:32 +0000 (17:34 +0000)]
The patch below fixes several recently introduced sparse warnings and
errors. The patch below has been tested by verifying the output of the following commands:
scripts/run-regression-tests 2.6.29
scripts/run-regression-tests 2.6.30.4
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Committed with some minor changes/additions.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1044
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 13 Aug 2009 12:06:04 +0000 (12:06 +0000)]
Whitespace-only change -- fixed the following checkpatch error:
ERROR: space required after that ',' (ctx:VxV).
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1043
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 13 Aug 2009 09:33:28 +0000 (09:33 +0000)]
Fixed typo.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1042
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 12 Aug 2009 18:01:19 +0000 (18:01 +0000)]
Joined a few preprocessor statements on a single line that were split
over multiple lines such that scripts/generate-kernel-patch and
scripts/run-regression-tests can process these.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1041
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 12 Aug 2009 17:13:26 +0000 (17:13 +0000)]
New implementation of the pass-through commands execution. Changes:
- scsi_execute_async() renamed to scst_scsi_exec_async() and from now will stay in scst_lib.c
- In scst_scsi_exec_async() support for long CDBs and bidirectional commands added
- Patches scst_exec_req_fifo were removed for kernels between 2.6.26 and 2.6.29, because they are not needed anymore. Pass-through will work on those kernels without them
- Monor bug fixes and cleanups
- Docs updated
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1040
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 11 Aug 2009 19:58:48 +0000 (19:58 +0000)]
Removed the one_guid_per_ioc kernel parameter again because it did not
solve the connectivity problem between WinOF and an SRP target
equipped with multiple IB ports.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1039
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 11 Aug 2009 19:24:30 +0000 (19:24 +0000)]
Added a note about the size of struct ib_qp_attr.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1038
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 10 Aug 2009 16:59:16 +0000 (16:59 +0000)]
- Added "replace" command to replace one LUN by another and generate INQUIRY DATA HAS CHANGED Unit Attention
- Sending INQUIRY DATA HAS CHANGED Unit Attention through AENs added
- Minor fixes and cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1036
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 10 Aug 2009 15:44:22 +0000 (15:44 +0000)]
Should have been included in the previous commit (r1034).
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1035
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 10 Aug 2009 15:28:03 +0000 (15:28 +0000)]
- Implemented kernel module parameter one_guid_per_ioc. Setting this
parameter to true should make it possible to connect from a WinOF
initiator to an SRP target when there is more than one IB path
between initiator and target.
- Renamed mellanox_ioc_guid into global_ioc_guid.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1034
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 10 Aug 2009 12:39:13 +0000 (12:39 +0000)]
Whitespace-only change: fixed a checkpatch complaint about trailing whitespace.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1033
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 10 Aug 2009 12:32:06 +0000 (12:32 +0000)]
Whitespace-only changes: fixed checkpatch complaints reported against a 2.6.27 kernel.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1032
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 10 Aug 2009 12:27:29 +0000 (12:27 +0000)]
- Adds generation of INQUERY DATA HAS CHANGED UA for changed devices during automatic sessions reassignment
- Requeue global UAs on delivery failure added
- Minor fixes and cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1031
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 10 Aug 2009 09:57:30 +0000 (09:57 +0000)]
- Added consistency checking for the SRPT command state management
introduced in r1026.
- Removed WARN_ON() statements that could trigger a warning when nothing
was wrong because these were reading uninitialized memory. These statements
were introduced in r1026. The call stack of the warning logged in the
kernel log is as follows:
<IRQ> [<
ffffffffa057f578>] ? srpt_handle_new_iu+0x818/0xaf0 [ib_srpt]
[<
ffffffff80243f18>] warn_slowpath_common+0x78/0xd0
[<
ffffffff80243f7f>] warn_slowpath_null+0xf/0x20
[<
ffffffffa057f578>] srpt_handle_new_iu+0x818/0xaf0 [ib_srpt]
[<
ffffffffa057f9ab>] srpt_completion+0x15b/0x230 [ib_srpt]
[<
ffffffffa04351f2>] mlx4_ib_cq_comp+0x12/0x20 [mlx4_ib]
[<
ffffffffa01eb1aa>] mlx4_cq_completion+0x3a/0x80 [mlx4_core]
[<
ffffffffa01ec475>] mlx4_eq_int+0x2a5/0x2e0 [mlx4_core]
[<
ffffffffa01ec59a>] mlx4_msi_x_interrupt+0x6a/0x90 [mlx4_core]
[<
ffffffff8027c0aa>] handle_IRQ_event+0x3a/0xf0
[<
ffffffff8027dee1>] handle_edge_irq+0xc1/0x160
[<
ffffffff8020ec3f>] handle_irq+0x1f/0x30
[<
ffffffff8020e37a>] do_IRQ+0x6a/0xf0
[<
ffffffff8020c7d3>] ret_from_intr+0x0/0xa
<EOI> [<
ffffffffa0012e52>] ? acpi_idle_enter_simple+0x159/0x187 [processor]
[<
ffffffffa0012e48>] ? acpi_idle_enter_simple+0x14f/0x187 [processor]
[<
ffffffff804323e5>] ? cpuidle_idle_call+0xa5/0x100
[<
ffffffff8020b0a2>] ? cpu_idle+0x62/0xd0
[<
ffffffff804be614>] ? rest_init+0x84/0x90
[<
ffffffff8067ecc5>] ? start_kernel+0x35a/0x415
[<
ffffffff8067e289>] ? x86_64_start_reservations+0x99/0xb9
[<
ffffffff8067e389>] ? x86_64_start_kernel+0xe0/0xf2
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1030
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 8 Aug 2009 15:02:19 +0000 (15:02 +0000)]
- Fixed memory leak in srpt_handle_tsk_mgmt() error path.
- Modified srpt_build_cmd_rsp() and srpt_build_tskmgmt_rsp() such that
these two functions now return the number of bytes of the response PDU
built.
- Converted a printk() statement to TRACE_DBG().
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1029
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 8 Aug 2009 14:59:28 +0000 (14:59 +0000)]
Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1028
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
swgruszka [Sat, 8 Aug 2009 13:50:16 +0000 (13:50 +0000)]
Update README.scst a bit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1027
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 8 Aug 2009 11:52:46 +0000 (11:52 +0000)]
Implemented SRPT command state management. The SRPT target code does no
longer rely on the struct scst_cmd state managed by the SCST core.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1026
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 7 Aug 2009 14:17:40 +0000 (14:17 +0000)]
Updated Subversion ignore list.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1025
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 7 Aug 2009 14:14:19 +0000 (14:14 +0000)]
Updated SRPT documentation.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1024
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 6 Aug 2009 17:18:28 +0000 (17:18 +0000)]
Patch from Bart Van Assche <bart.vanassche@gmail.com>:
Since SCST r979 the SRP target source code does no longer compile on RHEL /
CentOS systems where OFED has been installed. This is because OFED has its
own backported versions of the 2.6.20+ workqueue API and already includes a
definition of cancel_delayed_work_sync(). The patch below makes sure that on
RHEL 5 / CentOS 5 systems with OFED 1.4 installed the SCST definition of
cancel_delayed_work_sync() does not conflict with the OFED definition of
the same function.
The patch below has been tested by verifying that the SRPT source code
compiles and runs fine on CentOS 5.3 + OFED 1.4.1 and also on a system with
a vanilla 2.6.30.4 kernel.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1023
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 6 Aug 2009 16:28:23 +0000 (16:28 +0000)]
- Atomic move of a security name from one security group to another implemented
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1020
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 6 Aug 2009 13:42:28 +0000 (13:42 +0000)]
Fixed the following checkpatch complaint: return is not a function,
parentheses are not required.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1019
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 6 Aug 2009 11:49:05 +0000 (11:49 +0000)]
Web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1018
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Thu, 6 Aug 2009 11:47:18 +0000 (11:47 +0000)]
Automatic sessions reassignment implemented
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1017
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 6 Aug 2009 10:05:10 +0000 (10:05 +0000)]
Fixed data races on manipulation of the srpt_devices list by eliminating
this list. Only the number of IB devices is relevant for the SRPT
implementation. Introduced a new counter that tracks the number of IB
devices.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1016
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 6 Aug 2009 09:12:37 +0000 (09:12 +0000)]
- Refactoring: split srpt_ch_qp_rtr_rts() into two functions, namely
srpt_ch_qp_rtr() and srpt_ch_qp_rts().
- Replaced dynamic memory allocation (kmalloc()/kfree()) in the aforementioned
two functions by stack allocation.
- Compiles again on pre-2.6.22 kernels (RHEL / CentOS systems).
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1015
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 5 Aug 2009 19:48:16 +0000 (19:48 +0000)]
- Fixed race conditions related to channel state manipulation.
- Inlined srpt_disconnect_channel().
- Modified error handling coding style in srpt_cm_req_recv() to the usual
kernel coding style: upon error, jump to the error handling code.
- Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1014
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 5 Aug 2009 09:50:11 +0000 (09:50 +0000)]
Minor docs update
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1013
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 4 Aug 2009 18:45:46 +0000 (18:45 +0000)]
- Bug fix: if processing of any of the SRP task management functions by
the SCST core fails (abort task, LUN reset, ...), an SRP_RSP PDU is
now sent back to the initiator.
- Added more debug tracing statements.
- Improved readability of some parts of the source code.
- Added more comments.
- Partially reverted one hunk of r1003: while casting an unsigned 64-bit
value to the type u64 and printing such values via %llx works fine on
x86 systems, the same code triggers a compiler warning on PowerPC
systems. So while r1003 changed some (unsigned long long) casts to (u64)
casts, this revision changes these back to (unsigned long long) casts.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1012
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 4 Aug 2009 17:50:43 +0000 (17:50 +0000)]
Web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1011
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 4 Aug 2009 17:17:16 +0000 (17:17 +0000)]
A minor SAM violation fixed.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1010
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 4 Aug 2009 16:59:09 +0000 (16:59 +0000)]
Minor typo noticed by Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1009
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 4 Aug 2009 11:59:15 +0000 (11:59 +0000)]
Patch from Smadar Gonen <smadar.gn@gmail.com>:
The following fixes were made:
- Use monotonic clock as time source instead of a real-time clock so change of system time will not affect calculation.
- Init scst_time to 0 + minor display fix.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1007
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 4 Aug 2009 11:10:18 +0000 (11:10 +0000)]
Web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1006
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 3 Aug 2009 16:00:36 +0000 (16:00 +0000)]
Fixed race conditions on RDMA channel manipulations found via source reading:
- Added a second argument to srpt_find_channel() that specified whether or not
the channel should be removed from the channel list if found.
- Moved list_del() statement from the body of the srpt_release_channel()
function to its callers.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1005
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Mon, 3 Aug 2009 15:06:00 +0000 (15:06 +0000)]
Multiple cosmetic source code changes.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1004
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 2 Aug 2009 18:57:48 +0000 (18:57 +0000)]
- Enabled the LUN reset task management function.
- Changed return type of srpt_release_channel() from int to void
because the return value did depend in a trivial way on the function
arguments. Changed the return type of srpt_find_and_release_channel()
and several of its callers also from int to void. Instead
srpt_cm_handler() now directly sets its own return value.
- Converted a list_for_each_entry_safe() into a list_for_each_entry() loop
because no elements are added or deleted in the loop body.
- Converted debug-printk() statements into TRACE_DBG().
- Changed indentation of one statement from 12 to 16 (was not reported by
checkpatch).
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1003
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 2 Aug 2009 18:45:40 +0000 (18:45 +0000)]
Added even more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1002
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sun, 2 Aug 2009 18:04:21 +0000 (18:04 +0000)]
Added command-line option -f, which allows to skip the test whether there is still data present.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1001
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 1 Aug 2009 06:50:36 +0000 (06:50 +0000)]
Whitespace-only change: fixed a checkpatch complaint.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@1000
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Sat, 1 Aug 2009 06:03:55 +0000 (06:03 +0000)]
Only call scst_tgt_cmd_done() if scst_rx_data() has not been called.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@999
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 31 Jul 2009 11:40:10 +0000 (11:40 +0000)]
Fixed the issue that 'rmmod ib_srpt' with ongoing SRP I/O could trigger
a deadlock.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@998
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 31 Jul 2009 11:33:26 +0000 (11:33 +0000)]
Whitespace-only changes: fixed checkpatch complaints introduced in the previous commit.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@997
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 31 Jul 2009 11:27:54 +0000 (11:27 +0000)]
Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@996
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Fri, 31 Jul 2009 10:52:40 +0000 (10:52 +0000)]
Patch from Smadar Gonen <smadar.gn@gmail.com> fixing some minor corner cases
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@994
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Fri, 31 Jul 2009 06:21:31 +0000 (06:21 +0000)]
Upgraded kernel versions 2.6.27.28 and 2.6.30.3 to 2.6.27.29 and 2.6.30.4 respectively.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@993
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 30 Jul 2009 12:48:06 +0000 (12:48 +0000)]
- Fixed a buffer overrun: a service entry name occupying 35 bytes was
written into a buffer with a size of 32 bytes. Enlarged the buffer
to 36 bytes.
- Converted sprintf() calls to snprintf() calls.
- Added more TRACE_ENTRY() / TRACE_EXIT() statements.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@992
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 30 Jul 2009 08:32:23 +0000 (08:32 +0000)]
Moved /sys/class/infiniband_srpt/trace_level to
/proc/scsi_tgt/ib_srpt/trace_level such that the behavior of the
ib_srpt target is consistent with that of other SCST drivers.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@991
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Thu, 30 Jul 2009 06:38:15 +0000 (06:38 +0000)]
Compiles again with tracing disabled.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@990
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 29 Jul 2009 18:14:41 +0000 (18:14 +0000)]
Should have been included in the previous commit (r988).
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@989
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 29 Jul 2009 16:57:00 +0000 (16:57 +0000)]
- Fixed a race condition found via source reading: srpt_remove_one() did not
wait until srpt_refresh_port_work() finished. This race condition could be
triggered during module removal.
- Added a kernel module parameter called "trace_flag" that allows to set the
trace flags for the ib_srpt module before module initialization starts.
- Added sysfs variable /sys/class/infiniband_srpt/trace_level that allows to
display and to modify the enabled trace flags in a human-readable form.
- Added several TRACE_ENTRY() / TRACE_EXIT() statements.
- Added more comments.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@988
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Wed, 29 Jul 2009 15:46:46 +0000 (15:46 +0000)]
Whitespace-only changes: removed trailing whitespace because checkpatch complained about it.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@987
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Wed, 29 Jul 2009 12:49:17 +0000 (12:49 +0000)]
- Possibility to operate with single size entries as well as control of the reclamation time added to the SGV caache
- Fileio_tgt updated to be able to use those neww facilities
- Docs updated. Particulary, a new dociment describing the SGV cache added
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@986
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Jul 2009 11:01:22 +0000 (11:01 +0000)]
Web updates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@985
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Tue, 28 Jul 2009 09:29:12 +0000 (09:29 +0000)]
Patch from Gal Rosen <galr@storwize.com>:
I suggest the attached patch for the issue of disabling target mode
while I/O.
Fix BUG in qla target. Set ha->tgt to NULL in wrong place (when
disabling target mode). This cause to unfinished commands, and the echo
command to disabling the target mode to stuck. scst_tgt_cmd_done never
called because the ha->tgt was set to NULL before it should be. ha->tgt
already set to NULL in q2t_target_release after all task managements
finished and all commands were cleaned, so the fix just remove the set
from q2t_host_action.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@984
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
bvassche [Tue, 28 Jul 2009 07:35:38 +0000 (07:35 +0000)]
Whitespace-only change: fixed a recently introduced checkpatch error
about trailing whitespace.
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@983
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 17:52:19 +0000 (17:52 +0000)]
The most recent version of the sparse static source code checking tool does
now report functions that are called with a lock held but that are missing
__acquires() and __releases() annotations. The patch below adds such
annotations and makes the following sparse warnings disappear:
drivers/scst/iscsi-scst/iscsi.c:2861:9: warning: context imbalance in 'iscsi_check_send_delayed_tm_resp' - unexpected unlock
drivers/scst/iscsi-scst/nthread.c:1614:17: warning: context imbalance in 'scst_do_job_wr' - unexpected unlock
drivers/scst/iscsi-scst/iscsi.c:2861:9: warning: context imbalance in 'iscsi_check_send_delayed_tm_resp' - unexpected unlock
drivers/scst/iscsi-scst/nthread.c:1614:17: warning: context imbalance in 'scst_do_job_wr' - unexpected unlock
drivers/scst/scst_local/scst_local.c:554:30: warning: context imbalance in 'scst_local_queuecommand' - unexpected unlock
The patch below has been tested by comparing the output of
"scripts/run-regression-tests 2.6.30.3" before and after the patch was applied.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@982
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 17:49:19 +0000 (17:49 +0000)]
Minor web fixes
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@981
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 17:33:48 +0000 (17:33 +0000)]
- Implemented abort on timeout of stuck in the firmware commands
- Minor cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@980
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 16:59:49 +0000 (16:59 +0000)]
- Implemented abort on timeout of stuck in tgt hardware commands
- Cleanups
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@979
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 16:19:10 +0000 (16:19 +0000)]
Fix double free
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@977
d57e44dd-8a1f-0410-8b47-
8ef2f437770f
vlnb [Mon, 27 Jul 2009 11:39:05 +0000 (11:39 +0000)]
WEB upates
git-svn-id: https://scst.svn.sourceforge.net/svnroot/scst/trunk@976
d57e44dd-8a1f-0410-8b47-
8ef2f437770f